upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-03-22 02:21:12 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 8
81941 commits 775 branches 1188 tags 6.5 GiB
Commit graph

996 commits

Author SHA1 Message Date
Ferdinand Thiessen
66eb021ece
refactor: remove duplicated types and add return types 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-07-23 15:59:26 +02:00
Ferdinand Thiessen
a18e61a1e5
feat(files_sharing): add config option for extending link-share permissions 
This allows the admin to control the behavior whether link shares with
READ permissions should be extended to also gain SHARE permissions,
allowing users (public share receivers) to add the share to their cloud.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-07-17 16:59:36 +02:00
Robin Appelman
aa15f9d16d
chore: run rector 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-07-01 22:45:52 +02:00
Ferdinand Thiessen
5981b7eb51
chore: apply new CSFixer rules 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

# Conflicts:
#	apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
 2025-07-01 16:26:50 +02:00
skjnldsv
9806a9830c feat(files_sharing): allow viewing files with download disabled 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2025-06-26 11:47:53 +02:00
Côme Chilliet
12524d93f4
Merge pull request #53417 from nextcloud/fix/fix-32bits-phpunit 
fix(tests): Fix 32bits PHPUnit tests
 2025-06-19 10:38:32 +02:00
skjnldsv
bf3ce79abd feat(files_sharing): show Account menu on public pages 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2025-06-11 16:43:53 +02:00
Côme Chilliet
b1f6283f6e
fix(tests): Fix files_sharing tests conflicting with other tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-06-10 15:38:43 +02:00
Misha M.-Kupriyanov
4f3de46c08 test: files_sharing add test for LoadAdditionalListener 
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
 2025-06-10 10:01:18 +02:00
Ferdinand Thiessen
495c364268
chore: use consistent casing for header names (required by openAPI) 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-06-09 19:24:26 +02:00
Ferdinand Thiessen
9d8c2cd096
test(files_sharing): split testCanAccessShare into separate tests and fix for PHPUnit 10 
- split the test into individual test cases
- fix invalid call to `onConsecutiveCalls` (it was called more than
  defined values and is deprecated in v10 anyways).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-06-02 13:20:53 +02:00
Ferdinand Thiessen
3a99b88917
test(files_sharing): adjust mocks of Talk classes 
Classes need to exist to be mocked (reflection), thus unknown classes
only can be mocked as `stdClass`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-05-31 22:39:37 +02:00
Ferdinand Thiessen
7115658327
test(files_sharing): adjust tests for PHPUnit v10 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-05-31 22:22:52 +02:00
Ferdinand Thiessen
60ccc85e76
fix(files_sharing): show note, label and list of uploaded files on file drop 
This was missing from the Vue migration of the public share view:
- Show the note as the description of the file drop
- Show the label as the heading of the file drop if available
- Show list of uploaded files for verification

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-05-26 15:11:36 +02:00
Louis
a48bc55e2a
Merge pull request #52810 from nextcloud/artonge/feat/do_not_require_samesite_strict_cookie_on_public.php 2025-05-22 10:30:16 +02:00
Louis Chemineau
ec1db0c32a
fix: Replace the deprecated direct download link with the public DAV endpoint 
Follow-up of #48098

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-05-21 16:01:54 +02:00
Marcel Müller
612a1560b1 fix(tests): Register mount in loginHelper as well 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
 2025-05-19 08:56:13 +02:00
Ferdinand Thiessen
4a9dc6c64d
refactor: move tag handling from files handler to files_sharing 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-05-16 13:09:03 +02:00
Côme Chilliet
2cd491f491
Merge pull request #48560 from nextcloud/fix/migrate-encryption-away-from-hooks 
feat(encryption): Migrate from hooks to events
 2025-05-14 19:25:51 +02:00
Côme Chilliet
43418eea5f fix(tests): Set encryption configuration even earlier so that all users are created with private key 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-05-13 23:37:52 +02:00
Côme Chilliet
367c877b7a fix(tests): Avoid user login before a private key is setup 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-05-13 23:37:52 +02:00
John Molakvoæ (skjnldsv)
cd6a53ea4d fix(files_sharing): add mime fallback to public preview too 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2025-05-13 18:28:54 +02:00
skjnldsv
bcc8de0c9d fix(files_sharing): bring back owner and ownerDisplayName initial state 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2025-04-29 21:25:47 +02:00
Côme Chilliet
0cf4f3cc71
fix: Replace all usages of OC_User backend method calls by IUserManager 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-04-10 11:29:21 +02:00
Robin Appelman
bcbf0e76a7
fix: more optimized caching for share target verification 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-04-08 16:42:01 +02:00
Joas Schilling
5a167fdfd8
fix(phpunit10): Migrate away from PHPUnit at() calls 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-03-27 23:23:56 +01:00
Ferdinand Thiessen
00d08a4f69
fix(lookup-server): disable lookup server for non-global scale setups 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-03-11 14:26:47 +01:00
Ferdinand Thiessen
34251c4375
fix(lookup-server): do not query data by default 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-03-11 14:26:47 +01:00
Côme Chilliet
34139987d6 fix: Replace OC_App calls by IAppManager 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-02-24 17:48:34 +01:00
Ferdinand Thiessen
c19ce403f3
fix(files_sharing): block downloading if needed 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-18 11:58:12 +01:00
Côme Chilliet
64863c9d46
chore: Apply new rector configuration to apps folder 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-02-13 11:46:42 +01:00
Côme Chilliet
ed5b7ae161
chore: re-apply current rector configuration to apps folder 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-02-13 11:45:33 +01:00
Robin Appelman
65a10f281d
test: add test for shared storage root being changed after watcher 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-02-06 19:41:44 +01:00
Ferdinand Thiessen
73dc0f0f19
fix(sharing): Ensure download restrictions are not dropped 
When a user receives a share with share-permissions but also with
download restrictions (hide download or the modern download permission attribute),
then re-shares of that share must always also include those restrictions.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-04 15:39:14 +01:00
Ferdinand Thiessen
253f4345f1
fix(files_sharing): Respect permissions passed when creating link shares 
Given:
User creates a link or email share with permissions=4 (create only = file drop).

Problem:
Currently the permissions are automatically extended to permissions = 5
(READ + CREATE). Work around was to create the share and directly update
it.

Solution:
Respect what the user is requesting, create a file drop share.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-28 16:40:50 +01:00
Christopher Ng
42d997bcd7 test: Update tests 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2025-01-15 15:50:43 -08:00
skjnldsv
5c359e424f feat(federatedfilesharing): auto-accept shares from trusted servers 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2025-01-09 12:54:51 +01:00
Robin Appelman
e59ebafc87 test: add test for permissions of copied share 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-12-04 19:19:08 +01:00
Benjamin Gaussorgues
5581f0c7bf
chore: remove legacy action to test remote endpoint 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-11-29 11:14:37 +01:00
Côme Chilliet
ae7f9cb3c1
Merge pull request #43025 from nextcloud/bugfix/error-on-reshare-after-transfer-ownership 
fix: update re-share if shared-by user has been revoked
 2024-11-25 18:20:29 +01:00
provokateurin
beea8854ca
feat(files_sharing): Allow users with share permission to manage shares on IShareOwnerlessMount 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-11-25 10:27:31 +01:00
Luka Trovic
2ca51919db fix(sharing): add command to fix broken shares after ownership transferring 
Signed-off-by: Luka Trovic <luka@nextcloud.com>
 2024-11-18 21:24:23 +01:00
skjnldsv
4d9d617c84 feat(files_sharing): use share node or label as page title 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-11-08 14:20:58 +01:00
Ferdinand Thiessen
c84c256261
fix: Adjust preview for view-only shares 
Previously there was a different behavior for public shares (link-shares) and internal shares,
if the user disabled the view permission.
The legacy UI for public shares simply "disabled" the context menu and hided all download actions.
With Nextcloud 31 all share types use the consistent permissions attributes,
which simplifies code, but caused a regression: Images can no longer been viewed.

Because on 30 and before the attribute was not set, previews for view-only files
were still allowed. Now with 31 we need a new way to allow "viewing" shares.

So this is allowing previews for those files, but only for internal usage.
This is done by settin a special header, which only works with custom requests,
and not by opening the URL directly.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-28 15:52:27 +01:00
provokateurin
aacb3ddc1e
fix(files_sharing): Cleanup error messages 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-28 09:07:41 +01:00
provokateurin
381077028a
refactor(apps): Use constructor property promotion when possible 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-21 12:37:59 +02:00
dependabot[bot]
bb598c8451
chore(deps): Bump nextcloud/coding-standard in /vendor-bin/cs-fixer 
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 1.3.1 to 1.3.2.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v1.3.1...v1.3.2)

---
updated-dependencies:
- dependency-name: nextcloud/coding-standard
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-19 07:57:35 +02:00
Côme Chilliet
1580c8612b
chore(apps): Apply new rector configuration to autouse classes 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-10-15 10:40:25 +02:00
provokateurin
1642a34e8a
refactor(files_sharing): Add Storage parameter strong types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-07 15:00:07 +02:00
Robin Appelman
f8a59b56b4
test: fix share storage move test with object store 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-09-27 14:45:43 +02:00