upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-14 19:20:35 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 7
67023 commits 1033 branches 1221 tags 8.4 GiB
Commit graph

156 commits

Author SHA1 Message Date
Glandos
b6c65fee2a php-cs-fix 
Signed-off-by: Glandos <bugs-github@antipoul.fr>
 2023-04-17 16:29:13 +02:00
Glandos
9b4d5146d5 List preview directory only once 
getCachedPreview used to call `getFile`, and this calls `getDirectoryListing` (or underlying function that list directory) to find the file. This was done for every preview spec.
Now, this is done only once at the beginning of the loop, and the array is just iterated when needed to find the correct entry.

Signed-off-by: Glandos <bugs-github@antipoul.fr>
 2023-04-17 16:29:13 +02:00
Simon L
b39329c21c imaginary - fix autorotate and improve the logic 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2023-03-09 00:11:37 +01:00
Glandos
3bea7af7b7
fix indent 2 
Signed-off-by: Glandos <bugs-github@antipoul.fr>
 2023-02-16 10:10:12 +01:00
Glandos
59e7ed1fad
fix indent 
Signed-off-by: Glandos <bugs-github@antipoul.fr>
 2023-02-15 23:40:16 +01:00
Glandos
528e66859b
Use proc_open to avoid spawning a shell 
The use of `exec` will spawn a shell, using `/bin/sh` on POSIX platforms. But in restricted environment, such as AppArmor, this means giving execution to `/bin/sh`, which renders the execution restriction quite useless.
Using an array with `proc_open` reduces this, and paved the way for file streaming instead of temporary file.

Signed-off-by: Glandos <bugs-github@antipoul.fr>
 2023-02-15 23:37:13 +01:00
Robin Appelman
382432d4e1
cache formats supported by imagick 
turns out this can be quite slow

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-02-13 14:57:06 +01:00
Simon L
112d516f27 imaginary - allow to generate heif, pdf and svg thumbnails 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2023-02-08 00:25:18 +01:00
Simon L
9a64d95676 imaginary - add tiff to supported formats 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2023-01-25 11:53:16 +01:00
Côme Chilliet
f5c361cf44
composer run cs:fix 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-20 11:45:08 +01:00
Daniel Kesselberg
71a6030706
docs: add description how BackgroundCleanupJob.getNewPreviewLocations works 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2023-01-03 16:03:02 +01:00
Côme Chilliet
a372564850
Fix psalm spotted errors with new requirements 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-02 15:02:28 +01:00
Varun Patil
7004c1e9f8 preview: fix HEIC orientation 
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
 2022-12-08 23:14:13 -08:00
Côme Chilliet
a0f6a6545b
Use TimedJob from OCP instead of OC 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-12-05 10:13:34 +01:00
Varun Patil
b91d6c22cf preview: respect quality in Imaginary 
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
 2022-12-03 07:13:49 -08:00
Richard Steinmetz
98e55ea4f0
Fix distorted previews when using imaginary 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2022-11-11 14:21:05 +01:00
szaimen
f9e9cd270d
Limit-number-of-concurrent-preview-generations 
Signed-off-by: Bowen Ding <dbw9580@live.com>
Signed-off-by: szaimen <szaimen@e.mail.de>
 2022-11-05 16:03:01 +08:00
Julius Härtl
07e94eca6f
Emit typed event when preview is requested 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-10-27 14:31:33 +02:00
Julius Härtl
4baf960c21
Save getting the parent node when generating the preview 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-08-24 22:20:32 +02:00
Christopher Ng
57c66bf7cb Use Image class from public API 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2022-06-02 00:37:36 +00:00
John Molakvoæ
87ce03db1a
Merge pull request #32410 from nextcloud/bugfix/noid/imaginary-exception 2022-05-20 08:14:17 +02:00
Carl Schwan
a5a4e0df1c Fix crop condition 
Make sure that when fetching the image from the cache we don't
accidentally fetch the cropped image just because it also start with
256-256

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-19 17:25:32 +02:00
Julius Härtl
3742b7392d Add explicit return if getSmallImagePreview fails 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-05-19 17:01:01 +02:00
Carl Schwan
05bf8b4445 Fix cropped image generated when not asked 
The $crop parameter was not propagated to the imaginary pipeline and
instead it used the smartcrop algorithm always

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-17 10:19:54 +02:00
John Molakvoæ
0863a3d423
Merge pull request #32315 from nextcloud/fix/noid/preview-duplicate-folder-creation 2022-05-10 10:11:24 +02:00
Richard Steinmetz
982c846b11
Fix preview generator trying to recreate an existing folder 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2022-05-09 17:30:07 +02:00
Alexander F
00505c9a51 Set loglevel for IMagick Thumbnail error to info 
Issue #32263

Signed-off-by: Alexander Fleischer <Alexander.Fleischer@tu-ilmenau.de>
 2022-05-09 17:09:40 +02:00
Côme Chilliet
069477e608
Migrate more classes of lib/private to LoggerInterface 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-04-26 16:52:52 +02:00
John Molakvoæ
3d1f22f6d8
Generate small preview straight away if Imaginary is enabled 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2022-04-06 18:55:48 +02:00
Carl Schwan
b5c9189cfa Fix imaginary with rotated exif images 
Now do the operation in two steps:

1. Rotate the image according the exif data
2. Do the actual operation

This should only have a performance impact on image with exif rotation
data to do the rotation. For all the other images the autorotate steps
should be almost instant.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-04-04 16:38:38 +02:00
Carl Schwan
34988cff19
Merge pull request #24166 from nextcloud/imaginary-prototype 
Send images to Imaginary docker to generate previews
 2022-03-18 12:32:56 +01:00
Vincent Petry
9b6a1cc8ae
Send images to imaginary docker to generate previews 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Co-Authored-by: Vincent Petry <vincent@nextcloud.com>
 2022-03-17 08:24:07 +01:00
Côme Chilliet
13c11208d4
Ignore errors when searching for bundled preview 
When an odt file is xml and not zip, it would throw a ValueError.
It will now just ignore this file and return null for the preview.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-02-28 15:43:07 +01:00
Côme Chilliet
0daec4b27e
Fix tmp file cleaning for bundled previews 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-02-24 14:55:57 +01:00
Côme Chilliet
d43dbfa0f2
Fix typing in OC\Preview\Movie 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-02-24 14:55:48 +01:00
Côme Chilliet
ebe731f014
Fix typing in OC\Preview 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-02-24 14:42:55 +01:00
UmbrellaCodr
a0d7e27789
reduce 'Movie preview generation failed Output' log errors 
for movies under 5 seconds

Signed-off-by: UmbrellaCodr <umbrella@biohazard.cc>

Update lib/private/Preview/Movie.php

Co-authored-by: Simon L. <szaimen@e.mail.de>
 2022-02-03 17:52:37 -08:00
Carl Schwan
6312c0df69
Check style update 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-01-13 00:19:07 +01:00
Julius Härtl
6f986519fe
Merge pull request #28610 from nextcloud/enh/preview-cleanup-query 2021-12-28 13:20:02 +01:00
Côme Chilliet
3631789651
Fix resource usages in OC_Image 
This makes sure using resource or GdImage (PHP>=8) behaves the same.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-10-28 17:48:43 +02:00
J0WI
047cab8dd2 Use findBinaryPath for previews 
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
 2021-10-23 23:15:42 +02:00
Vincent Petry
24e0255378
Fall back to full file for video previews 
If the first 5 MB are not enough to grab a useful frame for the
thumbnail preview, fall back to reading the full file.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-09-18 10:53:00 +02:00
Julius Härtl
0670118470
Use storage filter when fetching previews to cleanup 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-08-26 22:03:05 +02:00
John Molakvoæ (skjnldsv)
40c10ab145
Properly log errors in Movie previews generation 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-08-19 09:47:12 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-06-04 22:02:41 +02:00
J0WI
74a7c2eefc Use correct getSystemValue type 
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
 2021-04-12 22:54:50 +02:00
dependabot-preview[bot]
eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0 
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-02-18 13:31:24 +01:00
Roeland Jago Douma
4d7c4b3d2f Markdown: remove redundant int cast 
For #25641

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-02-15 10:29:54 +01:00
Roeland Jago Douma
cc554890c1 Fix WebP availability check 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-02-11 11:31:38 +01:00
John Molakvoæ (skjnldsv)
d47b84be67
Add SGI and TGA preview support 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-01-22 10:42:51 +01:00