Joas Schilling
a0cb795f04
Merge pull request #48162 from nextcloud/bugfix/noid/array-keys
...
fix(autocomplete): Move known array keys to psalm docs
2024-09-19 10:25:06 +02:00
Nextcloud bot
9c0c2859d3
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-19 00:20:42 +00:00
Ferdinand Thiessen
5cce140701
chore: Remove deprecated ILogger logging functions
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 00:37:06 +02:00
Ferdinand Thiessen
f1dfd6ba71
refactor(OC_Template): Remove deprecated ILogger
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 00:35:21 +02:00
Ferdinand Thiessen
74923d174b
refactor(OC_Files): Remove deprecated ILogger
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 00:35:21 +02:00
Ferdinand Thiessen
8b79283c6b
refactor(OC_Util): Remove deprecated ILogger
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 00:35:21 +02:00
Ferdinand Thiessen
0d31976690
refactor(OC_Hook): Remove deprecated ILogger
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 00:35:21 +02:00
Ferdinand Thiessen
69abd8851b
refactor(OC_App): Remove ILogger usage
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 00:35:21 +02:00
Ferdinand Thiessen
7ae62cfe47
refactor(ProviderFactory): Remove usage of ILogger and use non-deprecated stuff
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 00:35:20 +02:00
Ferdinand Thiessen
44c7248749
refactor(Collaboration): Use non-deprecated methods
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 00:35:20 +02:00
Ferdinand Thiessen
fe05882628
chore!: Remove OC\AppFramework\Logger
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 00:32:25 +02:00
John Molakvoæ
df2711d23e
Merge pull request #48163 from nextcloud/feat/nfo
...
feat: add nfo file support
2024-09-19 00:22:16 +02:00
Joas Schilling
342927b140
Merge pull request #48182 from nextcloud/oracle-share-reminder
...
fix: fix share reminder job for oracle
2024-09-18 20:24:07 +02:00
Robin Appelman
b45f2420fe
fix: fix share reminder job for oracle
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-18 19:24:44 +02:00
Côme Chilliet
989d708bd8
Merge pull request #48137 from nextcloud/enh/add-rich-object-formatter
...
feat: Add OCP interface to format richtext into string
2024-09-18 18:59:56 +02:00
Robin Appelman
3c0c81bb94
fix: ensure parent folder exists when writing a file to object storage
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-18 14:11:27 +02:00
Robin Appelman
75cf17e4c4
fix: verify that parent exists in cache when inserting
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-18 14:11:27 +02:00
Robin Appelman
e0fb25f846
fix: fix object store id for test object store
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-18 13:54:55 +02:00
Robin Appelman
60f6347c97
fix: cleanup objectstore file_put_content
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-18 13:54:55 +02:00
Robin Appelman
3e94ee391f
fix: create intermediate directories for objectstore moveFromStorage
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-18 13:54:55 +02:00
Robin Appelman
879fcc4253
fix: get source file before moving the cache item in objectstore moveFromStorage
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-18 13:54:55 +02:00
John Molakvoæ (skjnldsv)
397910cd1d
feat: add nfo file support
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-09-18 11:51:10 +02:00
Joas Schilling
0af0bf3d42
fix(autocomplete): Move known array keys to psalm docs
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-18 11:40:45 +02:00
Nextcloud bot
13fce9fb9d
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-18 09:28:00 +00:00
Nextcloud bot
29a03ff8fe
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-18 00:22:04 +00:00
John Molakvoæ
6bcab26174
Merge pull request #44013 from nextcloud/fieat/profile-pronounces
...
feat: add pronouns to account profile
2024-09-18 01:25:07 +02:00
John Molakvoæ (skjnldsv)
b24e02e5df
fix(core): profile design and pronouns support
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-09-18 00:15:19 +02:00
John Molakvoæ
eb374a74c7
Merge pull request #45020 from Noodlesalat/fix-lastlogin-update-token-login
2024-09-17 23:54:37 +02:00
John Molakvoæ (skjnldsv)
26abc86eca
feat: add profile pronouns
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-09-17 22:20:36 +02:00
provokateurin
c2fb7a72da
fix(psalm): Fix @throws annotations
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-17 17:18:30 +02:00
Stephan Orbaugh
f25acfb799
Merge pull request #47986 from cfiehe/fix_move_on_same_bucket
...
perf(ObjectStoreStorage): Improve (slow) move on same object bucket
2024-09-17 16:35:19 +02:00
Ferdinand Thiessen
f5b73d2c77
fix: Remove legacy settings forms
...
`OC_App::getForms` was always returning an empty array,
because there were no setter for `adminForms` or `personalForms` anymore.
So removed all that legacy settings forms logic.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-17 14:54:39 +02:00
Côme Chilliet
117c7ee654
fix: Fix Event and Notification creation with the new required parameter
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-17 14:37:55 +02:00
John Molakvoæ
fe9981fad7
Merge pull request #48129 from nextcloud/feat/zst
2024-09-17 14:31:06 +02:00
Côme Chilliet
295eee6712
fix: Add missing alias for IRichTextFormatter
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-17 14:23:44 +02:00
John Molakvoæ (skjnldsv)
67fb4da40f
chore: update RepairMimeTypes migration
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-09-17 14:14:01 +02:00
Côme Chilliet
70a886ce83
feat: Add OCP interface to format richtext into string
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-17 13:57:33 +02:00
Kate
4e64a6eb48
Merge pull request #48080 from nextcloud/fix/storage/method-docs-inheritance
2024-09-17 11:16:20 +02:00
John Molakvoæ
57a5baa88f
Merge pull request #48094 from nextcloud/fix/storage/get-owner-false
2024-09-17 10:44:31 +02:00
John Molakvoæ
6f78730573
Merge pull request #48114 from nextcloud/fix/AppStore--remove-unneeded-warning
2024-09-17 10:26:31 +02:00
provokateurin
d2d1e3284d
fix(Storage): Fix method docs inheritance
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-17 10:20:38 +02:00
provokateurin
dc13f9cc1e
fix(Files): Handle getOwner() returning false
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-17 10:10:50 +02:00
provokateurin
8ca6fcace7
fix(Storage): Document getOwner() can return false
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-17 10:10:50 +02:00
Côme Chilliet
c256518ab3
Merge pull request #48110 from nextcloud/chore/remove-deprecated-aliases
...
chore: Remove deprecated aliases from dependency injection
2024-09-17 09:39:27 +02:00
Ferdinand Thiessen
c2443ad1f2
chore: Replace DI alias with real class
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-17 02:27:31 +02:00
Nextcloud bot
d76d971e55
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-17 00:20:40 +00:00
Grigorii K. Shartsev
70ed4aec39
fix(appstoreFetcher): get app list from custom app store
...
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-09-17 01:29:25 +02:00
Grigorii K. Shartsev
ce679c3da4
fix(appstoreFetcher): remove unneeded warning
...
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-09-17 01:24:49 +02:00
Côme Chilliet
0759b481e6
chore: Remove deprecated aliases from dependency injection
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 21:11:09 +02:00
Côme Chilliet
b9fb1db0f8
Merge pull request #48009 from nextcloud/fix/remove-references-to-deprected-storage-interface
...
fix: Remove OCP\Files\Storage interface deprecated since version 9
2024-09-16 20:50:38 +02:00
Côme Chilliet
03b969fb95
chore: Improve typing and phpdoc comments
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 20:29:48 +02:00
Robin Appelman
ede0c26b78
Merge pull request #46480 from nextcloud/fix/mailer-binaryfinder-fallback
...
fix(Mailer): Fix sendmail binary fallback
2024-09-16 18:18:14 +02:00
Côme Chilliet
e7ac9bb2d8
chore: Check storage is an instance of the correct class instead of psalm-suppress
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 18:11:39 +02:00
Côme Chilliet
ed0ac284e3
chore: Remove deprecated Storage::search method instead of moving it to IStorage
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 18:11:38 +02:00
Côme Chilliet
5d01e0a73c
chore: psalm-suppress legacy code weirdness
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 18:11:38 +02:00
Côme Chilliet
492e6997d8
chore: Fix psalm issues, put back private versions of getter in private Storage interface
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 18:11:38 +02:00
Côme Chilliet
f80eda4398
chore: fix autoloaders
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 18:11:38 +02:00
Côme Chilliet
22822d5e9b
fix: Fix other uses of removed Storage interface
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 18:11:36 +02:00
Côme Chilliet
801733e523
fix: Remove OCP\Files\Storage interface deprecated since version 9
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 18:10:48 +02:00
John Molakvoæ
dde0b48c93
Merge pull request #46218 from nextcloud/artonge/fix/hash_return_type
2024-09-16 17:15:18 +02:00
Robin Appelman
d9c5512878
Merge pull request #46140 from nextcloud/fix-nc-env-inclusion
...
fix(config): Add missing handling for `envCache` in `getKeys()`
2024-09-16 16:55:13 +02:00
John Molakvoæ
6eefcdba0c
Merge pull request #47316 from Farcry69/fix/metadata-refresh-crash
2024-09-16 15:59:26 +02:00
Josh
87aa1267a8
fix(Mailer): Fix sendmail binary fallback
...
feat: add debug logging to sendmail binary finder
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-09-16 15:20:29 +02:00
Robin Appelman
13088b745a
Merge branch 'master' into fix-nc-env-inclusion
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-16 15:13:29 +02:00
Christoph Fiehe
9597072ada
perf(ObjectStoreStorage): Improve (slow) move on same object bucket
...
This commit fixes the issue #47856 . When you upload a file into a group folder and when you use a single S3 bucket as primary storage, the final move operation hangs for a long time. In the background, Nextcloud initiates a copy-delete sequence from the bucket into the bucket, with causes a lot unnecessary overhead. Nextcloud thinks that the file must be imported to another storage and does not recognize that everything is done on the same object bucket. In that case, the import step can be completely skipped, which saves time, network bandwidth and reduces the load on the object storage.
The behavior improves a lot with https://github.com/nextcloud/server/pull/46013 . However, there are still some put messages that are being sent to the object storage when you use an object storage as primary storage and upload files into a group folder.
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>
2024-09-16 15:11:09 +02:00
John Molakvoæ
9acaf0788f
chore: improve hash_file php usage in Local Storage
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-09-16 15:07:21 +02:00
Louis Chemineau
6674f790a9
fix(files): Ensure that the hash method does not return null
...
To match beececf660/lib/private/Files/View.php (L1050)
- Fix https://github.com/nextcloud/server/issues/44110
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-16 15:07:21 +02:00
Ferdinand Thiessen
7fbd518452
feat: Make CheckServerResponseTrait public and provide as OCP\SetupCheck\CheckServerResponseTrait
...
This trait is used by other apps for creating setup checks,
so we should provide it instead apps using private API.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-16 14:58:21 +02:00
John Molakvoæ
ff0cab5956
Merge pull request #47852 from nextcloud/sharding-code-fixes
2024-09-16 11:39:58 +02:00
Joas Schilling
c228c62088
Merge pull request #48063 from nextcloud/bugfix/noid/fix-otf-loading
...
fix(a11y): Add OTF font loading check
2024-09-16 11:25:47 +02:00
Joas Schilling
932d488b9f
Merge pull request #47948 from nextcloud/fix/issue-34720
...
fix(collaboration): Reduce timeouts to 3s for link reference connects
2024-09-16 11:25:32 +02:00
Kate
8a32881633
Merge pull request #48008 from nextcloud/fix/entity/strict-types
2024-09-16 11:08:35 +02:00
Christoph Wurst
0a7b4b597e
Merge pull request #48042 from nextcloud/refactor/elvis
...
refactor: Use the elvis operator + fix: Handle null checks with the ?? operator
2024-09-16 10:04:37 +02:00
Joas Schilling
c7c031dbd2
fix(a11y): Add OTF font loading check
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-16 09:59:21 +02:00
Nextcloud bot
d6a59be1c0
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-16 00:20:11 +00:00
Anna
6892500405
Merge pull request #48046 from nextcloud/refactor/self-class-reference
...
refactor: Replace __CLASS__ with ::class references
2024-09-15 23:01:22 +02:00
Christoph Wurst
c57e684e7b
fix: Handle null checks with the ?? operator
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-09-15 21:50:11 +02:00
Anna
4281ce6fa1
Merge pull request #48010 from nextcloud/feat/switch-from-settype-to-casts
...
feat(db): switch from settype to casts
2024-09-15 21:49:04 +02:00
Christoph Wurst
1ee833efab
refactor: Replace __CLASS__ with ::class references
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-09-15 21:40:55 +02:00
Christoph Wurst
614f9ec0a2
refactor: Use the elvis operator
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-09-15 21:01:34 +02:00
Christoph Wurst
903484a884
refactor: migrate dirname to __DIR__ constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-09-15 20:55:23 +02:00
Anna Larch
6c36c54dc6
feat(db): switch from settype to casts
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-15 19:26:58 +02:00
Kate
3fe3f8d1f6
Merge pull request #48016 from nextcloud/fix/s3configtrait/proxy-false
2024-09-15 19:16:04 +02:00
Kate
101891280b
Merge pull request #48013 from nextcloud/fix/baseresponse/xml-element-value-string-cast
2024-09-15 19:15:46 +02:00
Kate
77de180faa
Merge pull request #48014 from nextcloud/fix/tags/boolean-user-has-tags
2024-09-15 17:48:27 +02:00
Kate
a643cb22b2
Merge pull request #48017 from nextcloud/fix/comment/children-count-integer
2024-09-15 17:48:11 +02:00
provokateurin
9a63494fe4
fix(Comment): Initialize childrenCount as integer
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-15 15:44:37 +02:00
provokateurin
7c1c02d6a5
fix(S3ConfigTrait): Allow proxy field to take false
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-15 15:41:58 +02:00
provokateurin
5bbe535c27
fix(Storage\Local): Do not call getSourcePath() on SplFileInfo
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-15 15:39:09 +02:00
provokateurin
3d9b49815b
fix(BaseResponse): Cast XML element values to string
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-15 15:37:27 +02:00
provokateurin
9b82bfd3c3
fix(Tags): Return boolean for userHasTags()
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-15 15:33:46 +02:00
provokateurin
247b1dd70e
fix(Entity): Fix magic setter call for custom strong typed setters
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-15 15:14:54 +02:00
Côme Chilliet
6c46c43429
Merge pull request #47971 from nextcloud/fix/do-not-try-to-change-response-code-too-late
...
fix: Do not try to set HTTP response code on already closed connection
2024-09-14 21:18:47 +02:00
Ferdinand Thiessen
81df2d2c12
feat(PsrLoggerAdapter): Allow to use Psr\Log\LogLevel for log method
...
There is the `Psr\Log\LogLevel` class defining loglevel constants,
to be fully compatible we should at least support those logging levels.
Moreover this is the last part that was still required from `ILogger` interface,
as we did not have alternatives for the loglevel constants.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-14 17:35:11 +02:00
Côme Chilliet
e54eef5ae3
fix: Do not try to set HTTP response code on already closed connection
...
This avoids a PHP warning in the logs about trying to set the response
code while the output already started. It’s useless to try to print an
error page anyway in this situation because the connection was closed
already.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-14 14:20:49 +02:00
Nextcloud bot
26aa322e44
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-14 00:21:21 +00:00
provokateurin
714671a8a6
fix(files): Adjust Cache::searchQuery() parameter name to match interface
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-13 18:13:44 +02:00
Côme Chilliet
bcb4e781a4
Merge pull request #47927 from nextcloud/fix/migrate-away-from-oc_app
...
Migrate away from OC_App to IAppManager
2024-09-13 17:44:38 +02:00
Josh
d165405d5b
fix(collaboration): Reduce timeouts to 3s for link reference connects
...
Fixes rest of #34720
https://github.com/nextcloud/server/issues/34720#issuecomment-1286609205
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-09-13 10:41:28 -04:00
Côme Chilliet
dfa994ef28
Merge pull request #47865 from nextcloud/admin_audit/enh/move-to-event-listeners-v2
...
Move admin_audit to proper event listeners v2
2024-09-13 16:21:44 +02:00
Côme Chilliet
d76745553c
fix: Fix phpdoc wording
...
Co-authored-by: Anna <anna@nextcloud.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2024-09-13 16:01:55 +02:00
Ferdinand Thiessen
a90f0a6b36
Merge pull request #47883 from nextcloud/fix/setup-checks
...
fix(setup-checks): Ensure URL with webroot works
2024-09-13 13:42:41 +02:00
Joas Schilling
df155fa3df
Merge pull request #47933 from nextcloud/bugfix/noid/throw-precondition-failure-when-not-matching
...
fix(config): Throw PreconditionException always when it didn't match
2024-09-13 13:39:21 +02:00
Ferdinand Thiessen
9e979d42b4
fix(setup-checks): Ensure URL with webroot works
...
We basically mock the way `URLGenerator::getAbsoluteURL` works,
so we must make sure that the URL might already contain the webroot.
Because `baseURL` and `cliURL` also contain the webroot we need to remove
the webroot from the URL first.
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-13 13:06:24 +02:00
Git'Fellow
413ba1a718
Merge pull request #47854 from nextcloud/validAppsFromAppStore
...
fix(appstore): Ensure returned apps from AppStore are valid
2024-09-13 10:55:33 +02:00
Côme Chilliet
76f2bc0bfc
fix: Replace OC_App::getAllApps with a method in AppManager
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-13 10:08:44 +02:00
Côme Chilliet
7ed583cb8e
chore: Migrate cleanAppId and getAppPath calls to IAppManager from OC_App
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-13 10:08:43 +02:00
Git'Fellow
dccfb6d68a
fix: check if key is set
...
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-09-13 09:49:09 +02:00
Joas Schilling
dcd97e1234
fix(config): Throw PreconditionException always when it didn't match
...
Previously even when the precondition did not match, the call "passed"
when the after value was the expected one. This however can lead to
race conditions, duplicate code excutions and other things.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-13 09:20:08 +02:00
Nextcloud bot
c9e4598360
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-13 00:20:46 +00:00
Côme Chilliet
b6c286640f
Merge pull request #47685 from nextcloud/fix/move-apihelper-to-oc-namespace
...
fix: Move OC_API into \OC\ApiHelper in standard namespace
2024-09-12 14:34:07 +02:00
Julius Knorr
38e0a89972
fix: Add whiteboard to education and public sector bundle
...
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2024-09-12 09:13:42 +02:00
Ferdinand Thiessen
5fc514877b
Merge pull request #47586 from nextcloud/fix/color
...
fix(theming): Add migration to restore primary color after separating primary and background
2024-09-11 15:10:09 +02:00
Git'Fellow
8585b05357
fix(appstore): Ensure returned apps from AppStore are valid
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: lint
chore: remove space
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: check if response array is null
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
chore: Add log
2024-09-11 11:12:59 +02:00
Nextcloud bot
4bc8ba5b22
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-11 00:21:11 +00:00
Ferdinand Thiessen
027fc052e7
fix: Adjust types of IQueryBuilder to properly allow joining with sub-query
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-10 17:51:27 +02:00
Ferdinand Thiessen
c7d9068be9
chore: Use IAppConfig instead of IConfig->getAppValue
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-10 17:51:26 +02:00
Kate
979cc8712c
Merge pull request #47662 from nextcloud/fix/notification/validate-rich-object-key-value-types
2024-09-10 17:40:46 +02:00
Robin Appelman
a7eaed721c
Merge pull request #47853 from nextcloud/clearify-swift-exception
...
fix: make swift connect exception message more informative
2024-09-10 16:45:19 +02:00
provokateurin
a3da7456a7
fix(Activity): Restrict IEvent rich object parameters type
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-10 16:37:54 +02:00
provokateurin
db68ea9496
fix(SetupCheck): Restrict SetupResult rich object parameters type
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-10 16:37:54 +02:00
provokateurin
f7246a9b7a
fix(INotification): Restrict rich object parameters type
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-10 16:37:42 +02:00
provokateurin
d0a827a684
fix(RichObjectStrings/Validator): Validate key value types of rich object parameters
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-10 16:36:33 +02:00
John Molakvoæ
0858ff7a07
Merge pull request #47834 from nextcloud/retAppsManDis
2024-09-10 16:31:17 +02:00
Côme Chilliet
7d881b1bc3
chore: Add descriptions for new events and fix copyright year
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-10 16:20:30 +02:00
John Molakvoæ
4d3168fb24
fix(appstore): disabled appstore log level bump from debug to info
...
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-09-10 16:00:56 +02:00
Carl Schwan
986a3d45f8
feat(user_ldap): Introduce user id assigned typed events for LDAP usage
...
Based on work from https://github.com/nextcloud/server/pull/32019
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2024-09-10 14:06:11 +02:00
Thomas Citharel
82ba7d763b
chore: Code cleanup in lib/private/Console/Application
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2024-09-10 14:05:59 +02:00
Thomas Citharel
c2150bd079
feat: Add mimetype into BeforePreviewFetchedEvent event
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2024-09-10 14:05:06 +02:00
Richard Steinmetz
12ea0eb24a
Merge pull request #47858 from nextcloud/fix/preview/handle-no-local-file
...
fix(preview): gracefully handle file not being opened in ProviderV2
2024-09-10 13:24:44 +02:00
Julius Knorr
46a4a16eb6
fix: Only write once to template instead of create/copy
...
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2024-09-10 09:43:42 +02:00
Richard Steinmetz
bcf9f91893
fix(preview): gracefully handle file not being opened in ProviderV2
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-09-10 08:49:43 +02:00
Nextcloud bot
a51c200cab
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-10 00:37:30 +00:00
Robin Appelman
508d8e7c01
fix: make swift connect exception message more informative
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-09 17:15:01 +02:00
Robin Appelman
da59fd4389
fix: misc code fixes around db sharding
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-09 16:59:59 +02:00
provokateurin
d5e98cd190
fix(NavigationManager): Skip invalid default navigation entries
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 11:04:36 +02:00
provokateurin
669641142b
fix(TemplateLayout): Use NavigationManager to get default app name
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 11:04:36 +02:00
provokateurin
01ec6762a2
fix(URLGenerator): Use NavigationManager to generate default page URL
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 11:04:36 +02:00
provokateurin
70ed08daf1
refactor(AppManager): Deprecated default apps handling
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 11:04:36 +02:00
provokateurin
b0baaaed9d
feat(NavigationManager): Add default entries handling
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 11:04:36 +02:00
Côme Chilliet
90a948506b
chore: Make parameter name more explicit
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-09 10:46:29 +02:00
Côme Chilliet
42c5a60c29
fix: Force 503 HTTP status code for maintenance mode on v1
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-09 10:46:29 +02:00
Côme Chilliet
76d1b11bc9
chore: Deleted now unused classes from \OC\OCS
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-09 10:46:29 +02:00
Côme Chilliet
e184784f86
fix: Remove duplicated code in \OC\OCS\ApiHelper, use Response classes instead
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-09 10:46:29 +02:00
Côme Chilliet
4c9104ef08
fix: Move ApiHelper to \OC\OCS next to related classes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-09 10:46:29 +02:00
Côme Chilliet
37569466de
fix: A bit of code cleanup in OC\AppFramework\OCS\ApiHelper
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-09 10:46:29 +02:00
Côme Chilliet
ea32d17d88
fix: Move OC_API into \OC\ApiHelper in standard namespace
...
It’s only used by ocs/v1.php
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-09 10:46:29 +02:00
provokateurin
70fa51f042
fix(files): Never return a null ETag in DAV
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 10:30:33 +02:00
Git'Fellow
2ac8d9a3db
fix(appstore): return if appstore is manually disabled
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: camel case
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: log a debug log
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: typing
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: typo
fix: typing
2024-09-09 09:56:22 +02:00
Nextcloud bot
a2cfcf3ca7
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-09 00:23:27 +00:00
Nextcloud bot
926bd29617
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-08 00:36:35 +00:00
Ferdinand Thiessen
1c52bd7704
Merge pull request #47808 from nextcloud/rakekniven-patch-2
...
chore(i18n): Spelling of ID
2024-09-07 14:06:12 +02:00
Nextcloud bot
7a6191ebb9
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-07 00:36:58 +00:00
Fabian Dreßler
1d6cce8a25
fix: update last_login timestamp for token based-logins
...
fixes #31075 and maybe #32953
Signed-off-by: Fabian Dreßler <nudelsalat@clouz.de>
2024-09-06 14:11:41 -04:00
rakekniven
b8774816f6
chore(i18n): Spelling of ID
...
Reported at Transifex
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2024-09-06 19:21:07 +02:00
Anupam Kumar
31a983ac69
chore: update autoloader
...
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
2024-09-06 18:02:15 +05:30
Anupam Kumar
bb94b17959
fix(TaskProcessing): increase error_message column length
...
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
2024-09-06 18:01:56 +05:30
Git'Fellow
a36738dbfc
chore(storage): refactor some code portions
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
chore: revert portion
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-09-06 12:44:48 +02:00
Ferdinand Thiessen
ba73beaac1
Merge pull request #47784 from nextcloud/fix/file-info
...
fix(FileInfo): correctly implement `\ArrayAccess::offsetGet`
2024-09-06 12:18:30 +02:00
Ferdinand Thiessen
141fed839a
Merge pull request #47756 from nextcloud/fixingPathShareCheck
...
fix(files): Check if target path is a descendant of the shared folder
2024-09-06 03:58:24 +02:00
Ferdinand Thiessen
a96406086c
fix(FileInfo): correctly implement \ArrayAccess::offsetGet
...
We are targetting PHP 8.1+, since PHP 8.0 `offsetGet` has the `mixed` types for `offset` and return value.
So this adds the types to correctly implement the interface.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:58:00 +02:00
Nextcloud bot
e4fa996701
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-06 00:25:10 +00:00
Git'Fellow
0308001118
fix(files): Check if the target path is a descendant of the shared folder path
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: tests
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: fix tests
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: add tests
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: tests
2024-09-05 23:54:01 +02:00
Anna Larch
8af7ecb257
chore: adjust code to adhere to coding standard
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-05 21:23:38 +02:00
Stephan Orbaugh
c2f87fbd39
Merge pull request #47761 from nextcloud/fix/missing-footer
...
fix: Fix missing footer on public pages
2024-09-05 18:02:25 +02:00
Louis Chemineau
dbf56b6c11
fix: Migrate existing bg jobs to use sha256
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-05 15:36:51 +02:00
Louis Chemineau
843a47f12c
fix: Use sha256 to hash arguments of background jobs
...
This is to prevent collision as we are sometime hashing user input, yet using that hash to target the background job in the database.
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-05 15:36:51 +02:00
Andy Scherzinger
332b3efdf0
Merge pull request #47754 from nextcloud/fix/noid/cache-appstore-on-dev-instances
...
fix(appstore): Cache apps.json also on dev instances
2024-09-05 09:17:40 +02:00
Nextcloud bot
8cded1e320
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-05 00:23:50 +00:00
Christopher Ng
4fed8ed891
fix: Fix missing footer on public pages
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-09-04 16:41:13 -07:00
Marcel Müller
b2c2c93a03
fix(appstore): Cache apps.json also on dev instances
...
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2024-09-04 21:56:58 +02:00
Kate
09fef8f0ec
Merge pull request #47417 from nextcloud/fix/files/create-mountpoint-parents
2024-09-04 20:00:24 +02:00
John Molakvoæ
99b225f06b
Merge pull request #40164 from nextcloud/exceptionsTranslateShare
2024-09-04 09:50:49 +02:00
John Molakvoæ
8f825cbd16
Merge pull request #47155 from nextcloud/executeStatementOnDelete
2024-09-04 09:35:16 +02:00
Julius Härtl
3ca7480829
fix: Do not throw if appstore is unavailable during upgrade
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-09-04 09:31:13 +02:00
John Molakvoæ
7efd244956
Merge pull request #47675 from nextcloud/adapterQueryOpti
2024-09-04 09:15:52 +02:00
John Molakvoæ
f4aa2644ee
fix: adjust sharing controller exceptions case
...
Co-authored-by: F. E Noel Nfebe <fenn25.fn@gmail.com>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-09-04 09:03:45 +02:00
Git'Fellow
f250643e7a
fix(l10n): Translate all share exceptions
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Fix drone
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Fix tests
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-09-04 09:03:45 +02:00
Nextcloud bot
94d259e750
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-04 00:21:54 +00:00
Andy Scherzinger
a538ff60b3
Merge pull request #47679 from nextcloud/chore/typo-docs
...
chore(IGetRealUIDBackend): Fix typo in doc block
2024-09-03 17:56:38 +02:00
John Molakvoæ
f9fcc5b170
Merge pull request #47412 from Luka-sama/feat/shares-reminder
2024-09-03 17:24:02 +02:00
Stefan Cherniakov
457eaee2b3
fix(files_sharing): Add missing check for null & use bool instead of int for reminder_sent field
...
Signed-off-by: Stefan Cherniakov <luka-sama@pm.me>
2024-09-03 17:23:31 +02:00
Ferdinand Thiessen
61d687631b
chore(ExternalShareMenuAction): Remove unused legacy properties
...
Keep them in the constructor to not break the API,
but they are not used anymore.
This way of adding a share was deprecated in Nextcloud 12 (2016!),
in favor of the federated share API, in Nextcloud 28 this way to create a share was removed.
So we can cleanup as all it takes now to create a federeated share is the share token + federated user ID.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-03 16:07:50 +02:00
Ferdinand Thiessen
4d2556d4cf
refactor(IMenuAction): Make public menu actions use the new Vue UI
...
This removes custom rendering code an replaces it with the declarative menu actions.
Also adjust the template to allow the Vue UI to mount.
Custom entries still are possible.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-03 16:07:49 +02:00
Stefan Cherniakov
d633b9bce6
fix(files_sharing): Make share reminders more stable & fix issues
...
Signed-off-by: Stefan Cherniakov <luka-sama@pm.me>
2024-09-03 13:37:17 +02:00
Stefan Cherniakov
5e4a166365
feat(files_sharing): reminder for link shares with expiration date
...
Signed-off-by: Stefan Cherniakov <luka-sama@pm.me>
2024-09-03 13:37:17 +02:00
John Molakvoæ
b7bd5b0012
Merge pull request #47650 from nextcloud/chore/cleanup-middleware
2024-09-03 09:21:43 +02:00
Kate
02a6f12bf9
Merge pull request #47676 from nextcloud/fix/ocp/image-interface
2024-09-02 16:11:26 +02:00
Ferdinand Thiessen
cbeca43ee8
Merge pull request #47678 from nextcloud/chore/add-typings
...
chore(IConfig): Adjust type of `getUsersForUserValue`
2024-09-02 15:33:58 +02:00
provokateurin
031166c177
fix(OCP): Fix Image interface
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-02 14:57:17 +02:00
Julien Veyssier
873c42b0f1
Merge pull request #47627 from nextcloud/fix/noid/link-ref-provider-size-check
...
[LinkReferenceProvider] Better size check
2024-09-02 12:33:21 +02:00
Ferdinand Thiessen
2bf3280dcc
chore(IGetRealUIDBackend): Fix typo in doc block
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-02 12:30:01 +02:00
Ferdinand Thiessen
bdce5921f6
chore(IConfig): getUsersForUserValue is returning a list
...
It is returning a list of strings so adjust the return typing
to reflect this (`list<string>` instead of `array`).
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-02 12:27:06 +02:00
Julius Härtl
7f0d0cf03c
Merge pull request #47640 from nextcloud/fix/migrator-replica
...
fix: Run migration sql as statement so that the primary db node is used
2024-09-02 10:46:24 +02:00
Git'Fellow
8e6e7976d2
fix: psalm
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-09-02 10:19:25 +02:00
Git'Fellow
388f2973b9
fix: psalm
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-09-02 10:08:08 +02:00
Git'Fellow
dfcf3132dd
chore(db): Make the query more simpler to read
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-09-02 09:57:48 +02:00
Nextcloud bot
3973a8f722
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-02 00:21:05 +00:00
Nextcloud bot
8367c72f88
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-01 00:20:51 +00:00
Nextcloud bot
09411a1e9d
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-08-31 00:26:10 +00:00