upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-15 22:11:17 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 25
77659 commits 882 branches 1195 tags 7.2 GiB
Commit graph

1669 commits

Author SHA1 Message Date
Julius Knorr
46a4a16eb6
fix: Only write once to template instead of create/copy 
Signed-off-by: Julius Knorr <jus@bitgrid.net>
 2024-09-10 09:43:42 +02:00
Robin Appelman
508d8e7c01
fix: make swift connect exception message more informative 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-09-09 17:15:01 +02:00
Robin Appelman
da59fd4389
fix: misc code fixes around db sharding 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-09-09 16:59:59 +02:00
provokateurin
70fa51f042
fix(files): Never return a null ETag in DAV 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-09 10:30:33 +02:00
Git'Fellow
a36738dbfc chore(storage): refactor some code portions 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

chore: revert portion

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2024-09-06 12:44:48 +02:00
Ferdinand Thiessen
ba73beaac1
Merge pull request #47784 from nextcloud/fix/file-info 
fix(FileInfo): correctly implement `\ArrayAccess::offsetGet`
 2024-09-06 12:18:30 +02:00
Ferdinand Thiessen
a96406086c fix(FileInfo): correctly implement \ArrayAccess::offsetGet 
We are targetting PHP 8.1+, since PHP 8.0 `offsetGet` has the `mixed` types for `offset` and return value.
So this adds the types to correctly implement the interface.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-06 03:58:00 +02:00
Git'Fellow
0308001118 fix(files): Check if the target path is a descendant of the shared folder path 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: fix tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: add tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: tests
 2024-09-05 23:54:01 +02:00
Anna Larch
8af7ecb257 chore: adjust code to adhere to coding standard 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2024-09-05 21:23:38 +02:00
Kate
09fef8f0ec
Merge pull request #47417 from nextcloud/fix/files/create-mountpoint-parents 2024-09-04 20:00:24 +02:00
Andy Scherzinger
bfb5835750
Merge pull request #47546 from nextcloud/fix/files-view-error-messages 
fix: Adjust filename validation messages
 2024-08-29 23:28:50 +02:00
Julius Härtl
61108882b9
fix: Do not fail to get internal path on NonExistingFile/NonExistingFolder 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-08-29 12:43:44 +02:00
Ferdinand Thiessen
17f011f7c5 fix: Also validate parent path in verifyPath 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-08-28 17:22:20 +02:00
Ferdinand Thiessen
08836696e2 fix: Allow read-only filename validation to allow reading files 
Needed to read files with the "Windows compatibility" feature.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-08-28 17:22:20 +02:00
Ferdinand Thiessen
030c209d22 fix: Renaming does not need update but delete permissions 
Renaming is basically copy + delete (a move), so no need to update permissions.
Especially if the node is in a invalid directory the node should be moveable but not editable.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-08-28 17:22:20 +02:00
Louis Chemineau
2574cbfa61
chore: Apply php:cs recommendations 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-08-28 10:44:18 +02:00
Robin Appelman
390f6a78b4
fix: hint storage id in more places 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-08-28 10:21:19 +02:00
Robin Appelman
62f8b6517f
feat: implement distributing partitioned queries over multiple shards 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-08-28 10:21:19 +02:00
Ferdinand Thiessen
81c6c24cd5
fix: Adjust filename validation messages 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-08-27 23:12:24 +02:00
Julius Härtl
6d2253e692
Merge pull request #46013 from nextcloud/obj-store-move-from-storage-preserve-fileid 
fix: write object to the correct urn when moving from another storage to object store
 2024-08-26 13:47:27 +02:00
Daniel Kesselberg
af6de04e9e
style: update codestyle for coding-standard 1.2.3 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2024-08-25 19:34:58 +02:00
Robin Appelman
bd740ac0b0
fix: write object to the correct urn when moving from another storage to object store 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-08-23 15:22:16 +02:00
provokateurin
ebfbe99652
fix(files): Create non-existent parents of mountpoints 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-08-22 12:04:31 +02:00
Ferdinand Thiessen
b9cc7bcec7
fix: FilenameValidator::isForbidden should only check forbidden files 
And not forbidden basenames as this is used for different purposes.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-08-21 04:16:14 +02:00
Robin Appelman
3756152cb1
fix: use mountpoint from storage to find the encryption keys 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-08-20 13:32:03 +02:00
Robin Appelman
1071201052
feat: store the mountpoint of storages in the mount options 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-08-20 13:31:35 +02:00
John Molakvoæ
d35c4eb911
Merge branch 'master' into jr-readdir-false-false 
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
 2024-08-16 10:53:50 +02:00
Andy Scherzinger
609fa7d5db
Merge pull request #47044 from nextcloud/fix/accept-several-mounts-in-encryption 
fix(encryption): Fix mountpoint check to accept if several are found
 2024-08-07 20:58:19 +02:00
Côme Chilliet
277c2cf5d1
fix(encryption): Fix mountpoint check to accept if several are found 
There is no strong requirement to have only one mount for a given
 storage id. Also the error in this case would be misleading.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-08-05 17:34:25 +02:00
Robin Appelman
eb4fb994cf
fix: ensure array returned from getMountsForFileId is continious 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-08-02 17:22:33 +02:00
Christopher Ng
572361f498 fix(files): Fix incorrect keys by reindexing 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2024-08-01 09:14:44 -07:00
Ferdinand Thiessen
21f558b12b
Merge pull request #46379 from nextcloud/fix/folder-search-owner 
fix: `OCP\Files\Node\Folder::search` was not setting the owner
 2024-07-30 13:04:15 +02:00
withbest
dd08f93202 chore: fix some comments 
Signed-off-by: withbest <seekseat@outlook.com>
 2024-07-29 14:43:27 +08:00
Dennis Verspuij
181aecad4c fix: Release directory iterator and thereby its potential directory lock prior to deleting a directory, to avoid e.g. "Text file busy" error with VirtualBox shared folder storage 
Signed-off-by: Dennis Verspuij <6680484+dennisverspuij@users.noreply.github.com>
 2024-07-27 16:37:16 +02:00
Andy Scherzinger
4f2a29adf9
Merge pull request #46672 from nextcloud/fix/preview-invalid-id 
Avoid using partial file info as valid one
 2024-07-25 19:37:30 +02:00
Elizabeth Danzberger
efe03ee690
feat: Add support for filling fields to backend components 
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
 2024-07-25 11:11:40 +02:00
Elizabeth Danzberger
05ed5aa230
fix: Emit new BeforeGetTemplates event 
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
 2024-07-25 11:11:38 +02:00
Julius Härtl
2b0bc8b310 fix: Do not return partial file info if we have a cache entry 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-07-22 22:32:34 +02:00
Ferdinand Thiessen
12796c3ae7
fix: FileInfo from View should have the correct name of a mountpoint 
If a mountpoint is returned from a `View` the name must match the view scoped name
and not the global name.
For example group folders have a name like `1` or `2` (the ID),
but the name of the FileInfo returned fro mthe View should be the mount point name,
like `First groupfolder` or similar.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-07-22 22:01:12 +02:00
Ferdinand Thiessen
9716b0d735 refactor: Migrate some legacy and core functions to IFilenameValidator 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-07-19 19:41:46 +02:00
Robin Appelman
c5b687271b
fix: make batch propagator work with sharding restrictions 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-07-17 19:16:07 +02:00
Robin Appelman
0931492ff0
fix: make usermountcache compatible with sharding 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-07-17 19:16:05 +02:00
Robin Appelman
ad88fd07e3
fix: make joining on tags in search queries work with sharding 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-07-17 15:46:39 +02:00
Robin Appelman
80f8c7949e
fix: always set storage id in Cache::get 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-07-17 15:46:31 +02:00
Robin Appelman
5ff7bde3fb
fix: add set storage id for more cache queries 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-07-17 15:46:21 +02:00
Ferdinand Thiessen
69341e4306
refactor: Migrate filename validation logic from Storage to FilenameValidator 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-07-16 12:49:09 +02:00
Ferdinand Thiessen
bdbeabafa7
feat: Add forbidden_filename_basenames config option 
This allows to configure forbidden filenames (the full filename like `.htaccess`)
and also forbidden basenames like `com0` where `com0`, `com0.txt` and `com0.tar.gz` will match.
We need this as only using basenames was too restrictive and will cause problems on some systems when updating.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-07-15 19:39:18 +02:00
Robin Appelman
c82d382a20 feat: add base class for extending the query builder 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-07-12 17:01:39 +02:00
Ferdinand Thiessen
cf935e33ae
fix: OCP\Files\Node\Folder::search was not setting the owner 
The owner was not set on the file info causing e.g. webdav searches to never return the known owner.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-07-11 15:46:44 +02:00
Ferdinand Thiessen
46f1efac41
feat: Add IFilenameValidator to have one consistent place for filename validation 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-07-09 15:04:34 +02:00
Git'Fellow
c84e76a749 fix(s3): Don't wait indefinitely for S3 to return 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: lint

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: use AwsException

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Throw on connection failure

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Wrap all in try catch block

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: use RequestTimeout error message

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

log: use OCP Server class

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Handle connect timeout only

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Handle errors more generically

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2024-07-05 16:24:32 +02:00
Robin Appelman
ffced73a71 fix: also use optimized getFirstNodeyIdInPath for Folder::getFirstNodeById 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-06-20 18:51:27 +02:00
Ferdinand Thiessen
ae1f5cc56d
fix(S3): Adjust usage of guzzle promise 
`Promise\promise_for` was deprecated and is now removed and replaced with the static API (`Create::promiseFor`).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-06-16 15:54:44 +02:00
Robin Appelman
3a60e40a81
Merge pull request #45172 from nextcloud/test-scanner-no-transactions 
feat: add option to disable scanner transactions
 2024-06-13 14:01:34 +02:00
Robin Appelman
082c6c6e1d
fix: get child ids for folder in a separate query during move 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-06-13 10:38:57 +02:00
Josh
63886147ba fix(ObjectStore): handle empty S3 hostname 
Fixes #45637

The support for s3-accelerate added in #44496 introduced a regression in AWS S3 environments when `hostname` is blank (which is a valid configuration w/ AWS since the hostname gets auto-generated).

Signed-off-by: Josh <josh.t.richards@gmail.com>
 2024-06-12 15:43:20 -04:00
Louis Chemineau
a93d3a5a10 fix(files): Use isRetryable to catch retryable exceptions 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-06-11 15:15:14 +02:00
Ferdinand Thiessen
48e6240502
Merge pull request #45413 from nextcloud/createIfNotExists 
fix(files): Try to create dir only if it not exists
 2024-05-30 19:45:23 +02:00
Git'Fellow
77979b1475 Try create folder first and check if it exists after 
Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2024-05-30 14:27:44 +02:00
Git'Fellow
5c4e4c5590 fix(files): Try to create dir only if it not exists 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2024-05-30 14:27:44 +02:00
John Molakvoæ
91227c908b
Merge branch 'master' into refactor/OC-Server-getHTTPClientService 
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
 2024-05-30 14:21:45 +02:00
Robin Appelman
d87c23242b
Merge pull request #45014 from nextcloud/forbid-moving-subfolder 
fix: forbid moving a folder into a subfolder of itself
 2024-05-27 14:29:34 +02:00
Andy Scherzinger
dae7c159f7
chore: Add SPDX header 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2024-05-24 13:11:22 +02:00
Robin Appelman
66d36bffa6
fix: forbid moving a folder into a subfolder of itself 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-05-17 17:45:44 +02:00
Marcel Klehr
843bb62d6d fix: LazyRoot missing method 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2024-05-14 11:38:39 +02:00
Marcel Klehr
00894e2420 feat: first pass at TaskProcessing API 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2024-05-14 11:38:39 +02:00
Julius Härtl
c4e32d33e0
Merge pull request #44953 from nextcloud/perf/44951/lock-provider 
perf(ILockManager): Allow registering a lock provider lazy
 2024-05-13 14:21:28 +02:00
Côme Chilliet
2d40dae4af
Merge pull request #45233 from nextcloud/fix/touch-propagate-size 
fix: Avoid updating size when calling touch on a file
 2024-05-13 11:48:06 +02:00
Côme Chilliet
e68544d9f4
Merge pull request #43794 from nextcloud/fix/files/scanner-metadata-diff 
fix(files): handle multidimensional arrays in scanner
 2024-05-13 11:05:40 +02:00
Josh
3c3e45f0ad fix(Files): Change how scanner diffs for changed metadata 
Fixes #43408 

Signed-off-by: Josh <josh.t.richards@gmail.com>
 2024-05-08 08:36:42 -04:00
Julius Härtl
24e0d5023c
fix: Avoid updating size when calling touch on a file 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-05-08 11:50:20 +02:00
Christoph Wurst
6258823aba
Merge pull request #45058 from nextcloud/perf/db/sort-before-chunking 
perf(db): Sort data for IN before chunking
 2024-05-07 12:11:32 +02:00
Robin Appelman
f5219a19b2
feat: add option to disable scanner transactions 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-05-03 16:40:15 +02:00
Robin Appelman
8d870a32c2
fix: fix FileAccess::getByFileId(InStorage) 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-05-01 18:00:20 +02:00
Julius Härtl
ff3fc85d10 perf(ILockManager): Allow registering a lock provider lazy 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-04-30 22:28:06 +02:00
Côme Chilliet
ece3588252
fix: Improve typing of mimetype aliases 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-30 09:24:00 +02:00
Côme Chilliet
672923f0a6
fix: Fix newly spotted psalm issues, add exhaustive typed magic properties for LDAP classes 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-30 09:23:58 +02:00
Julius Härtl
2c059dd606
Merge pull request #44952 from nextcloud/perf/44951/template-creator 
perf(templates): Emit RegisterTemplateCreatorEvent to register template creators more lazy
 2024-04-29 08:27:07 +02:00
Christoph Wurst
f3d6309e36
perf(db): Sort data for IN before chunking 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2024-04-26 15:38:29 +02:00
Robin Appelman
40d9a3fcab
feat: add option to enable s3 acceleration 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-04-26 14:40:24 +02:00
Joas Schilling
cdb40a3110
fix(openstack): Fix psalm issue with updated openstack version 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-04-24 07:01:57 +02:00
Joas Schilling
7cfe36e49b
fix(storage): Fix DAV storage as false is never returned 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-04-22 21:06:00 +02:00
Julius Härtl
f9e235f7f1 perf(templates): Emit RegisterTemplateCreatorEvent to register template creators more lazy 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-04-22 15:23:55 +02:00
Joas Schilling
5fffbcfe86
Merge pull request #44889 from nextcloud/bugfix/noid/skip-cross-storage-move-with-ac 
fix(files): Also skip cross storage move with access control
 2024-04-18 10:48:03 +02:00
Joas Schilling
64d32abb48
fix(CI): Suppress psalm UndefinedClass 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-04-18 09:24:11 +02:00
Maxence Lange
b4004a2582
Merge pull request #43574 from nextcloud/enh/noid/lazyappconfig-migrate-metadata 
enh(metadata): migrate metadata to lazy appconfig
 2024-04-17 16:20:33 -01:00
Joas Schilling
050408c9de
fix(files): Also skip cross storage move with access control 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-04-17 16:29:07 +02:00
Julius Härtl
e0fcf6b700
Merge pull request #44294 from nextcloud/fix/storage-mount-owner 
fix: Pass the mountpoint target user to storages without owner
 2024-04-09 13:18:13 +02:00
Julius Härtl
4910e7e231
fix: Pass the mountpoint target user to storages without owner 
Storages that do not have a dedicated owner (e.g. groupfolders, external
storages) currently always assume the current session user as the owner.
This leads to several issues when there is no user session but a node is
obtained through a user folder.

In order to have the correct user available we need to pass the user
that is used to setup a mountpoint along to the storage layer as we
generally assume that an owner is available for those.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-04-09 09:04:24 +01:00
Robin Appelman
d31ed8dbca
fix: use proper jailed patch in watcher 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-04-08 18:37:05 +02:00
Côme Chilliet
47b765552f fix: Remove incorrect default null value 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-02 14:16:21 +02:00
Côme Chilliet
ec5133b739 fix: Apply new coding standard to all files 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-02 14:16:21 +02:00
Louis Chemineau
751795999a
feat(files)): Add retry logic to cover deadlock situations when moving many files 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-03-28 09:05:47 +01:00
Ferdinand Thiessen
7880086de8
fix(S3): Adjust typing for 32bit compatibility 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-03-26 13:07:53 +01:00
Robin Appelman
1d9354a81e
feat: add interface for lower level filecache acess without having to do direct db queries 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-03-25 16:48:41 +01:00
John Molakvoæ
fb97d551a1
Merge pull request #44357 from nextcloud/wrapper-instanceof-resiliant 2024-03-22 20:43:34 +01:00
Ferdinand Thiessen
32dee2f84a
feat(ObjectStore): Make S3 MultipartUpload concurrency configurable 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-03-21 16:25:49 +01:00
Ferdinand Thiessen
69c5e8ebde
fix(ObjectStore): Use common S3 trait so config and connection trait members are in sync 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-03-21 16:25:42 +01:00
Robin Appelman
d5fa2ec7c3
fix: log error when default getWrapperStorage would return null 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-03-20 14:26:01 +01:00
Robin Appelman
afb589a69b
fix: ensure nested mount points are handled in the correct order 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-03-18 18:13:31 +01:00