upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-22 06:37:56 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 54
77659 commits 876 branches 1195 tags 8.3 GiB
Commit graph

951 commits

Author SHA1 Message Date
Julius Härtl
f3ae617bde
test(files_sharing): Test if recent files result use actual share target name 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-10-18 14:31:27 +02:00
Joas Schilling
500fa5431d
Fix unit tests on PHP 8.3 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-10-16 10:17:22 +02:00
Joas Schilling
cd659b7119
Fix unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-10-12 11:36:35 +02:00
Hamid Dehnavi
d64bbc8bd3 Convert isset ternary to null coalescing operator 
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
 2023-09-28 12:18:41 +03:30
Maxence Lange
8b9e7e235d ocm controller 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2023-09-20 08:23:45 -01:00
Robin Appelman
5685d68bd3
add more checks to ensure mounts aren't empty 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-12 16:50:24 +02:00
Robin Appelman
64f62f7cfd
Merge pull request #39863 from nextcloud/sharing-mask-wrapper 
move share permission logic to storage wrapper
 2023-09-04 14:05:14 +02:00
John Molakvoæ (skjnldsv)
f828dce597
Fix sharing creation insert and get 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2023-09-02 10:25:24 +02:00
Joas Schilling
26c734abe4
fix(tests): Specify all positional parameters again to fix tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-08-23 09:08:08 +02:00
Robin Appelman
e73889a240 cleanup di for share permissions wrapper 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-08-16 15:25:05 +02:00
Robin Appelman
a031bc4788 more share permission logic to storage wrapper 
this way we only have to determine the share permissions once

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-08-14 18:17:27 +02:00
Joas Schilling
44b4c16a09
Merge pull request #39605 from nextcloud/bugfix/noid/final-events-cleanup 
fix!: Final round of moving to IEventDispatcher
 2023-08-04 10:39:57 +02:00
Kate
30345f86dc
Merge pull request #39330 from nextcloud/feature/openapi/files_sharing 
files_sharing: Add OpenAPI spec
 2023-08-01 10:04:13 +02:00
jld3103
c6806684d2
files_sharing: Add OpenAPI spec 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-07-31 16:58:49 +02:00
Joas Schilling
cebf93d4d2
fix: Remove legacy dispatcher from share manager 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-07-28 14:11:20 +02:00
Joas Schilling
77bc6c32d8
fix(dispatcher): Move remaining simple cases in apps/ folder to IEventDispatcher 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-07-25 11:19:26 +02:00
John Molakvoæ
f5f142d31b
fix: adjust testing 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2023-07-11 13:52:28 +02:00
Benjamin Gaussorgues
29c1848eda
Migrate files sharing to PSR LoggerInterface 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-07-06 14:08:42 +02:00
Robin Appelman
2ea41dab93
repair -1 folder sizes for object store background scan 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-05-10 19:33:26 +02:00
Michiel de Jong
c0e84cb512 Add SHARE_TYPE_SCIENCEMESH 
Signed-off-by: Michiel de Jong <michiel@unhosted.org>
 2023-03-08 16:46:55 +01:00
Joas Schilling
98ed72b3ed
Revert "fix(performance): Do not set up filesystem on every call" 2023-02-21 07:36:43 +01:00
Julius Härtl
20058eb9de
tests: Fix test isolation on object storage 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-02-17 19:18:38 +01:00
Côme Chilliet
892e6c642a
Skip buggy tests for 32bits CI 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:33 +01:00
Louis Chemineau
4ab3c16403 Pluggable share provider 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2023-02-02 15:41:26 +01:00
Robin Appelman
6fcc1f5684
add test for shared mount conflict resolution 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-01-09 15:30:45 +01:00
Julius Härtl
628b0d8fc4
Merge pull request #35213 from PLUTEX/32611-ocs-api-share-permissions 
Honor permissions of new link share via OCS API
 2022-12-22 15:42:42 +01:00
Jan-Philipp Litza
a7abe2c35a Honor permissions of new link share via OCS API 
The API currently overrides the supplied permissions with "read only"
when a file is shared via link. It allows to update the permissions
later, however.

This keeps the default to "read only" but honors the permissions
supplied by API call if any.

Signed-off-by: Jan-Philipp Litza <jpl@plutex.de>
 2022-12-06 16:00:20 +01:00
Côme Chilliet
578648a062
Adapt tests to new job constructors 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-12-05 10:41:13 +01:00
Côme Chilliet
c79a6b3f62
Fix errors from PHP 8.2 testing 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-11-14 17:08:21 +01:00
Carl Schwan
2f406e5403 More fixes 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-18 14:41:13 +02:00
Carl Schwan
8e3f21d9ed Small progress with fixing unit tests 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-11 14:00:15 +02:00
Carl Schwan
02d55eb90f
Merge pull request #33941 from nextcloud/fix/public-sharing 
Only normalize data in public shares and not crud
 2022-09-15 16:43:01 +02:00
Carl Schwan
7ded5a769b
Only normalize data in public shares and not crud 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-09-08 14:51:28 +02:00
luz paz
9d26671f05 Fix typos in apps/ subdirectory 
Found via `codespell -q 3 -S l10n,./apps/files_external/3rdparty -L adn,ba,boxs,keypair,jus,optionel,ressource,tabel ./apps/`

Signed-off-by: luz paz <luzpaz@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
 2022-09-05 12:59:54 +00:00
Julius Härtl
6ad600ea8a
Fix jsunit tests 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-09-01 14:15:42 +02:00
Robin Appelman
1626a56dda
adjusts tests for CloudIdManager 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-08-31 15:47:00 +02:00
Vincent Petry
696a48ae97
Merge pull request #33430 from nextcloud/fix/remove-broken-resetstorage 
Remove broken function resetStorage from test cases
 2022-08-25 17:05:45 +02:00
Carl Schwan
fa48430feb
Revert "Revert "Remove inefficient fed share scanner"" 
This reverts commit 6667007bf2.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-08-03 15:17:51 +02:00
Côme Chilliet
262f7d92f0
Remove broken function resetStorage from test cases 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-08-02 09:19:09 +02:00
Carl Schwan
7b723813ce
Multiple fixes 
- Fix tests
- Use non deprecated event stuff
- Add a bit of type hinting to the new stuff
- More safe handling of instanceOfStorage (share might not be the first
  wrapper)
- Fix resharing

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-07-31 19:37:59 +02:00
Vincent Petry
03b1791cca
Fix share attribute related tests + code style 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-07-28 16:53:22 +02:00
Vincent Petry
a95c19e14b
Add share attributes + prevent download permission 
Makes it possible to store download permission

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-07-28 16:53:22 +02:00
Vincent Petry
8be9b04981
Remove legacy #dir element in files list 
Removed legacy "#dir" input element in the DOM.

Apps should use OCA.Files.App.currentFileList or
OCA.Sharing.PublicApp.fileList and call getCurrentDirectory() to
retrieve the current directory and changeDirectory() to change it.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-07-27 10:23:44 +02:00
Vincent Petry
ac4e60e6f4
Merge pull request #33361 from nextcloud/techdebt/noid/further-cleanup 
Further markup cleanup
 2022-07-26 22:34:27 +02:00
Vincent Petry
b896cd7f01 Add missing closing spans and avoid empty href 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
 2022-07-26 14:00:12 +00:00
Louis Chemineau
256ed34b7e Skip testMovedIntoShareChangeOwner 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2022-07-26 12:17:46 +00:00
Louis Chemineau
8967602470 Test moving share in and out of another share 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2022-07-26 12:17:46 +00:00
Vincent Petry
bb2557c389
Replace files app ids to classes 
Replaced ids to classes for the following:

- #filestable -> .files-filestable
- #fileList -> .files-fileList
- #controls -> .files-controls
- #emptycontent -> .emptyfilelist.emptycontent

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-07-26 10:19:19 +02:00
Joas Schilling
148498bba5
Merge pull request #32741 from nextcloud/Valdnet-patch-2 
l10n: Delete apostrophe
 2022-06-10 15:54:14 +02:00
Carl Schwan
6667007bf2 Revert "Remove inefficient fed share scanner" 
This reverts commit ce31914314.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-06-10 10:29:42 +02:00
Joas Schilling
50c697dbd4
Fix unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-06-07 20:40:55 +02:00
Côme Chilliet
948f0740ff
Remove at() matcher in files_sharing tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-05-24 15:20:52 +02:00
blizzz
102d119297
Merge pull request #32053 from nextcloud/cache-verify-share-mountpoint 
cache the verification of the share mountpoint
 2022-04-22 14:36:49 +02:00
Carl Schwan
4333c215cb Cache display name 
This should saves some query in the share backend when displaying the
owner and it's not important if the display name is 10 minutes outdated
as it is very rare that this gets changed.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-04-22 10:22:15 +02:00
Robin Appelman
bda8601648
cache the verification of the share mountpoint 
after the initial verification this can only really be invalidated by a system mount (external/group/etc) being created at the share target since any normal file/folder creation will already conflict with the share

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-04-21 18:08:35 +02:00
Cyrille Bollu
c6a5c07041 Adds a "Request password" button to the public share authentication page for shares 
of type TYPE_EMAIL, when the "video verification" checkbox isn't checked. Users accessing
non-anonymous public shares (TYPE_EMAIL shares) can now request a temporary password themselves.

- Creates a migration step for the files_sharing app to add the 'password_expiration_time'
  attribute to the oc_shares table.
- Makes share temporary passwords' expiration time configurable via a system value.
- Adds a system config value to allow permanent share passwords

-Fixes a typo in a comment in apps/files_sharing/src/components/SharingEntryLink.vue

See https://github.com/nextcloud/server/issues/31005

Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
 2022-04-11 21:58:24 +02:00
Vincent Petry
b8b4d247b4
Merge pull request #31194 from nextcloud/feat/allow-to-exclude-groups-from-password-enforcement 
Allow to disable password policy enforcement for selected groups
 2022-04-06 10:13:23 +02:00
Carl Schwan
a29251e02d Allow to disable password policy enforcement for selected groups 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Co-authored-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
 2022-04-05 17:04:17 +00:00
Simon L
1ceb6cdb38
Merge pull request #31684 from nextcloud/user-share-permissions-merge 
take permissions from multiple paths into account for share permissions
 2022-04-05 17:37:46 +02:00
Robin Appelman
11a6887c7d
ensure user folder is created in ApiTest 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-04-04 15:40:31 +02:00
Robin Appelman
278b13155a
take permissions from multiple paths into account for share permissions 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-03-31 16:47:35 +02:00
Louis
47f1ba6ea6
Merge pull request #31240 from nextcloud/Valdnet-patch-3 
l10n: Add a dot
 2022-03-31 14:57:25 +02:00
Valdnet
806a49aba5
Fix test 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-03-31 11:04:47 +02:00
Côme Chilliet
25e7374e80
Fix ILogger instances in application tests for core parameters 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-24 16:21:27 +01:00
Louis Chemineau
85a101987d Add test to spelling unification 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2022-03-21 11:04:04 +01:00
Robin Appelman
d81713e5c1
simplify setup of circular SetupManager<->Manager 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-03-04 16:30:09 +01:00
Robin Appelman
22875bf367
move logic to decide what to setup to setupmanager 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-03-04 16:30:03 +01:00
Robin Appelman
1c468129af
adjust tests to new fs setup 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-03-04 16:29:59 +01:00
Robin Appelman
ad10a33316
make share cache test resilient against skeleton files not being there 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-02-25 15:49:30 +01:00
Louis Chemineau
da435b1e67 Support CRUD share permissions 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2022-02-15 11:54:17 +01:00
szaimen
f0424378f6 Revert "Add non-breaking space in the file size" 
Signed-off-by: szaimen <szaimen@e.mail.de>
 2022-02-10 10:35:19 +01:00
Carl Schwan
46c0ceb59c
Add non-breaking space in the file size 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-01-14 09:19:15 +01:00
Louis Chemineau
14e57bf70a Replace license information to SPDX expression 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2022-01-11 17:26:40 +01:00
Vincent Petry
ce31914314
Remove inefficient fed share scanner 
Remove scanAll which relies on the "shareinfo" endpoint that returns the
full cache tree.
The latter can become big for big shares and result in timeouts.
Furthermode, the full tree would be retrieved again for each and every
detected change which can become expensive quickly.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-01-10 11:33:28 +01:00
Côme Chilliet
37f8f7a5a1
Fix tests on PHP 8.1 for encryption, files_sharing, files_version, 
files_trashbin and theming apps

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-12-16 09:43:29 +01:00
Joas Schilling
d49ad7ea47
Limit more contact searches 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-12-08 18:58:54 +01:00
Joas Schilling
fa036b2001
Move common logic to share manager 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-11-09 10:10:53 +01:00
Robin Appelman
ef93d2ea1c
update tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-10-19 11:31:08 +02:00
John Molakvoæ
90b47ab7f0
Merge pull request #28764 from nextcloud/feat/sharing-link-event 2021-09-10 09:31:18 +02:00
John Molakvoæ
c56c317d82
Emit event on link share action 
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
 2021-09-10 08:36:45 +02:00
Arthur Schiwon
27865d03c0
use specific email getter where necessary 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-09-09 19:23:05 +02:00
Robin Appelman
8597d9c7d4
add event for when a share is mounted 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-08-24 15:26:50 +02:00
Vincent Petry
f6f2f63016
Fix remote share deletion when deleting user 
When deleting a user, we should only delete the direct remote user
shares or the remote group based subshares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-07-27 14:32:51 +02:00
Vincent Petry
dac676c14e
Replace ILogger with LoggerInterface in remote share manager 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Co-authored-by: Carl Schwan <carl@carlschwan.eu>
 2021-07-27 13:04:39 +02:00
Vincent Petry
e67e90afce
Fix remote group share decline+accept code path 
When declining a remote group share through the dialog that appears when
notifications are off, the mount point is now correctly saved when
re-accepting.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-07-27 12:20:03 +02:00
Vincent Petry
e8f4a524a2
Fix external share manager with multiple user groups 
Use query builder with proper matching for finding the group names.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-07-27 12:19:26 +02:00
Vincent Petry
15f41a6b72
Fix remote group share API interactions 
Accepting and declining can now be done repeatedly on both the parent
group share and sub-share with the same effects.

Added unit tests to cover these cases, and also when the same operation
is repeated.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-07-27 12:19:26 +02:00
Vincent Petry
cff8ae7ded
Add logging to external shares manager 
Instead of just returning false, also log the exception to make
debugging database issues easier.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-07-27 12:19:24 +02:00
Vincent Petry
7130a98e47
Fix received federated group shares 
Fix pending shares endpoint to consider user-specific sub-entries
for group shares whenever a share was accepted or declined.

Added unit test for adding remote group shares.

Fixed "removeUserShares" to not send a remote request as we never send
remote requests for group shares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-07-27 12:19:23 +02:00
Julius Härtl
7179002600
Allow to get a local cloud id without going through the contacts manager 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-07-14 16:08:05 +02:00
szaimen
0c27faf711 Update "Sending password by Nextcloud Talk failed" sentence 
Signed-off-by: szaimen <szaimen@e.mail.de>
 2021-07-07 13:39:57 +02:00
Julius Härtl
c0474ba364
Use product name in places where it is appropriate rather than the instance name 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-06-16 11:42:53 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-06-04 22:02:41 +02:00
Thomas Citharel
1c0d975654
Make dav respect disallowing sharing with groups 
Closes #25390

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2021-05-26 11:19:59 +02:00
Morris Jobke
f1dbabd910
Merge pull request #26727 from nextcloud/group-exclude-link-share 
Add option to exclude groups from creating link shares
 2021-05-21 15:35:39 +02:00
Valdnet
602448a05b
l10n: Unify spelling in test 2021-05-20 09:26:38 +02:00
Valdnet
0e39cef0d9
l10n: Unify spelling in test 2021-05-20 09:26:38 +02:00
Robin Appelman
b1dca57a1c
load share settings from the share manager in more places 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-05-12 16:11:28 +02:00
Roeland Jago Douma
701294520a Add bruteforce protection to the shareinfo endpoint 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-05-12 09:34:45 +02:00
rakekniven
48f05158e5
Merge pull request #26784 from nextcloud/Valdnet-patch-8 
l10n: Change to a capital letter
 2021-04-28 10:11:32 +02:00