upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-21 14:23:17 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 15
77659 commits 874 branches 1195 tags 8.3 GiB
Commit graph

1694 commits

Author SHA1 Message Date
provokateurin
01c4fa3ba8
fix(files_sharing): Make share labels nullable 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-08-27 22:28:48 +02:00
Daniel Kesselberg
af6de04e9e
style: update codestyle for coding-standard 1.2.3 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2024-08-25 19:34:58 +02:00
Ferdinand Thiessen
dd58e5290f
feat: Use new password context in sharing API 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-08-22 19:16:55 +02:00
Ferdinand Thiessen
4bbcbc5206
feat: Make ISharedStorage public API and reuse where possible 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-08-12 11:42:10 +02:00
skjnldsv
3cb80626e4 feat(activity): add share link upload notifications 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-08-07 09:49:38 +02:00
Andy Scherzinger
f0b658014a
Merge pull request #47070 from nextcloud/circToTeam 
fix(share): Rename Circle to Team
 2024-08-06 23:25:47 +02:00
skjnldsv
db28aa8cd1 fix(files_sharing): show proper share not found error message 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-08-06 16:25:10 +02:00
Git'Fellow
6002566d92
fix(share): Rename Circle to Team 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2024-08-06 14:48:07 +02:00
Maxence Lange
b6e3009e12
Merge pull request #47043 from nextcloud/fix/noid/ignore-root-on-inherited-shares 
fix(inherited-shares): ignore top root folder
 2024-08-06 11:08:17 -01:00
skjnldsv
712965daa1 fix(files_sharing): filter out invalid shareWith in sharee API 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-08-05 20:36:45 +02:00
Maxence Lange
6c4b0dba77 fix(inherited-shares): ignore top root folder 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-08-05 13:40:53 -01:00
Stephan Orbaugh
5faa903363
Merge pull request #46881 from nextcloud/try-non-recursive-source 
fix: try to find non-recursive share source
 2024-08-01 16:55:59 +02:00
skjnldsv
80231e60aa fix(activity): regroup Files and spltit sharing activity 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-08-01 11:03:24 +02:00
Kate
553224b0a2
Merge pull request #46810 from nextcloud/refactor/files_sharing/security-attributes 2024-08-01 09:55:55 +02:00
Robin Appelman
7343da4a9c
fix: try to find non-recursive share source 
instead of always picking the first one, try to find one that won't blow up

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-07-30 15:32:07 +02:00
Robin Appelman
23cdb539ce fix: fix recursive share check 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-07-30 07:41:26 +02:00
provokateurin
9128a23af1
refactor(files_sharing): Replace security annotations with respective attributes 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-07-27 22:42:51 +02:00
skjnldsv
f28d933acc feat(files_sharing): add public name prompt for files requests 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-18 20:15:39 +02:00
skjnldsv
b80c57dab3 feat(files_sharing): use label as title and file drop destination if available 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-18 19:47:11 +02:00
skjnldsv
43ca07809d fix(files_sharing): file request creation permissions and link copy display 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-18 19:47:11 +02:00
skjnldsv
bb730a1ee3 fix(files_sharing): remove undesirable translations from ShareAPIController 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-16 08:33:53 +02:00
skjnldsv
df42a10e56 chore(files_sharing): lint & refactor fixes 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
9b84831c8d fix(files_sharing): adjust IAttributes API and files_versions 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
967b3848e0 fix(files_sharing): phpunit & openapi fixes 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
bc5839e5b5 chore(files_sharing): cleanup NewFileRequestDialog vue 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
30f9ef414e fix: psalm, cs, autoloader and lint 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
5ce4bb368f chore(files_sharing): refactor share password mail 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
75ca4944c9 feat(files_sharing): allow mixed values in share attributes and allow storing email arrays 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
c253112cf7 chore(files_sharing): refactor mail handling 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
d388370c3b feat(files_sharing): implement IShareProviderWithNotification and refactor sendMailNotification 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
443c48aefb feat(files_sharing): add new file request option 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
fenn-cs
6136112be1 docs(ShareApiController): Correct note about expiry date timezone 
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-07-01 13:53:18 +01:00
Louis Chemineau
f5fd6c8f08
fix(files_sharing): Store the expiration date relative to the server's timezone 
This is needed as we want to store the difference between the server's and the user's timezones.

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-06-26 12:49:42 +02:00
Joas Schilling
8130968a35
feat(notifications): Migrate server INotifiers to new exceptions 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-06-25 11:56:24 +02:00
Andy Scherzinger
1d451d44a2 chore: Add SPDX header 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2024-06-13 14:15:32 +02:00
Ferdinand Thiessen
21a0009553
Merge pull request #44967 from nextcloud/perf/sharing-events 
perf(files_sharing): Move events to listener classes and registration instead of boot
 2024-06-10 11:57:53 +02:00
Andy Scherzinger
1e04619675
chore: Add SPDX header 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2024-06-06 22:53:41 +02:00
fenn-cs
c8a90f04b7 fix(ShareApiClients): Maintain meaning of '' and null for share api clients 
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-05-29 12:36:26 +01:00
fenn-cs
59a5b4e0bd fix(shareManager): Respect empty expireDate in server 
If `expireDate` is an empty string and not `null` then the server should not set a default.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-05-23 14:11:33 +01:00
Julius Härtl
0ca5c7487a
perf(files_sharing): Move events to listener classes and registration instead of boot 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-05-13 14:24:38 +02:00
Robin Appelman
ccd56672e8
refactor: remove non-shallow getSharesInFolder 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-05-01 16:46:06 +02:00
Joas Schilling
490f545006
fix(sharing): Don't change the type of the controller argument 
[EA] New value type (\DateTime) is not matching the resolved parameter type and might introduce types-related false-positives.

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-04-18 14:31:45 +02:00
fenn-cs
ec8a0a6267 fix(shareApiController): avoid duplicated expiryDate operations 
`expireDate` can be set once and used anywhere needed, the current implementation,
duplicates this behavior which leads to `parseDate` receiving an a date object it
parsed and returend earlier in the createShare method.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-04-18 02:01:13 +01:00
fenn-cs
9a0913afdc refactor(shareApiController): use contrusctor property promotion & DI logger 
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-04-18 02:01:08 +01:00
Côme Chilliet
ec5133b739 fix: Apply new coding standard to all files 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-02 14:16:21 +02:00
Robin Appelman
85b5dd0a43
fix: add extra check to ensure wrapped shared storage is set 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-03-20 14:48:55 +01:00
Joas Schilling
6a82042d73
fix(sharing): Align wording for declining a share 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-03-19 11:15:18 +01:00
Ferdinand Thiessen
2be421785f
fix(files_sharing): ShareesAPI - Return empty response when user is not allowed to share 
Resolves: https://github.com/nextcloud/server/issues/20950

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-03-15 15:51:15 +01:00
Robin Appelman
f46209a34e
chore: improve typing for SharedStorage::$storage 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-03-14 11:22:17 +01:00
Robin Appelman
0ace9a4efa
fix: don't return null for SharedStorage::getWrapperStorage with share recursion 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-03-14 11:21:05 +01:00
Robin Appelman
ea8a774a0a fix: add some recrusive detection/prevention 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-03-08 14:20:14 +01:00
Robin Appelman
a598de627c chore: remove long depricated share code 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-03-06 15:24:48 +01:00
Christoph Wurst
5c20f5b9a2
fix(sharing): Avoid (dead)locking during orphan deletion 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2024-03-05 20:19:30 +01:00
Robin Appelman
e7a7b4a401 perf: switch places that always use the first getById result to getFirstNodeById 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-03-04 13:57:31 +01:00
Benjamin Gaussorgues
3f269782aa
Merge pull request #43428 from nextcloud/feat/share-expiration-with-time 2024-02-26 10:07:41 +01:00
John Molakvoæ
0eba9570eb
Merge branch 'master' into share-external-watcher 
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
 2024-02-23 21:51:44 +01:00
John Molakvoæ
d541a7d178
Merge pull request #43605 from nextcloud/orphan-share-daily 2024-02-23 19:43:07 +01:00
Aragon Gouveia
311d1d2306 fix truncated circleId returned from Share API 2024-02-23 14:43:31 +01:00
Benjamin Gaussorgues
01983d50d4
feat(share): save date and time for expiration 
Because of timezones, not saving time can lead to unexpected behaviour
when sharing an item sooner than timezone offset
Example: sharing a file before 9am when in UTC+9

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-02-22 11:26:01 +01:00
Robin Appelman
0b8f0d0a0b
fix: only cleanup orphaned shared daly 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-02-15 17:53:31 +01:00
F. E Noel Nfebe
3fb1674251
Merge pull request #43461 from nextcloud/fix/get-rid-of-getlogger 
chore: Migrate away from OC::$server->getLogger
 2024-02-14 10:47:22 +01:00
Vincent Petry
839ddaa354
feat: rename users to account or person 
Replace translated text in most locations

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2024-02-13 21:06:30 +01:00
Côme Chilliet
c0ce272e9c chore: Migrate away from OC::$server->getLogger 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-02-13 17:32:30 +01:00
Robin Appelman
e50c176428 also improe cache ci for shared cache 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-02-09 14:00:26 +01:00
fenn-cs
d1ec85d1c7 Use @nextcloud/capabilities to obtain share api defaults 
- Remove redundant initial state added
- Call `getCapabilities()` in share config file.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-02-01 17:53:36 +01:00
fenn-cs
d9a2a78392 Consider admin defaults when creating shares 
The current share logic always uses the default `BUNDLED_PERMISSIONS.ALL`
which includes everything.

This commit updates share creation logic to use `defaultPermissions` if set
by admin for the creation of new shares.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-02-01 17:53:36 +01:00
Côme Chilliet
220296b216 fix: Fix template parameter for some listeners 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-01-30 10:57:15 +01:00
Côme Chilliet
8bcc2d352e chore: Fix missing template parameter for IEventListener 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-01-30 10:57:15 +01:00
provokateurin
b64ab5fba8
refactor: Migrate IgnoreOpenAPI attributes to OpenAPI 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-01-18 16:14:17 +01:00
Benjamin Gaussorgues
cc3a2c351a
fix(share): use user timezone to parse share expiration date 
If an user in UTC+1 try to create a share at 00:00, it's day D for him, but
D-1 for the server (UTC).
This fix aims to apply the correct offset

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-01-09 17:28:11 +01:00
John Molakvoæ
82b5a19a35
fix: public dav and files_sharing testing fixes 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2024-01-09 10:56:14 +01:00
John Molakvoæ
7b6a650b6e
feat: public dav endpoint v2 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2024-01-09 10:56:06 +01:00
Joas Schilling
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-11-23 10:36:13 +01:00
Julius Härtl
9677ca062e
fix: Also cleanup orphaned shares user cannot be found anymore 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-11-20 14:26:12 +01:00
Robin Appelman
dec880b285
optimize builtin storage wrappers 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-11-08 15:26:10 +01:00
jld3103
755de1e0b5 refactor: Rename OpenAPI type aliases to their namespaces 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-11-02 11:37:15 +01:00
Robin Appelman
efe68d012c
Merge pull request #39044 from nextcloud/more-empty-mount-checking 
Fix root mounts not being setup in some cases
 2023-10-24 16:54:05 +02:00
Max
be373fca3c
fix(sharing): set name to target name in sharing cache 
Fixes #39879.

Signed-off-by: Max <max@nextcloud.com>
 2023-10-18 14:31:27 +02:00
Joas Schilling
91ebbe8003
fix(federation): Use sharing.federation.allowSelfSignedCertificates config for all OCM requests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-10-11 11:52:10 +02:00
Hamid Dehnavi
d64bbc8bd3 Convert isset ternary to null coalescing operator 
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
 2023-09-28 12:18:41 +03:30
jld3103
c2d45cb172
Add single status code descriptions for OpenAPI 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-09-27 08:05:21 +02:00
Arthur Schiwon
4954c9f4ba
Merge pull request #39574 from nextcloud/fix/noid/ocm-controller 
OCM Services
 2023-09-20 20:16:10 +02:00
John Molakvoæ (skjnldsv)
fac5197486
feat(files): add files_sharing indicator 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2023-09-20 13:58:31 +02:00
Maxence Lange
b5dcd048ae small fixes 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2023-09-20 08:23:45 -01:00
Maxence Lange
c6c06d517c set authType to basic 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2023-09-20 08:23:45 -01:00
Maxence Lange
8b9e7e235d ocm controller 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2023-09-20 08:23:45 -01:00
fenn-cs
766806c35d Enfore allowPublicShares admin setting 
Use the the modern intial-state library to pass data about
`allowPublicUploads` to the sharing frontend.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2023-09-12 20:50:49 +01:00
Robin Appelman
5685d68bd3
add more checks to ensure mounts aren't empty 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-12 16:50:24 +02:00
Robin Appelman
d6eb127f76
improve logic for getting the watcher for a shared external storage 
with the new-ish lazy mount loading the underlying mount might not be loaded yet, so ask the mount cache instead

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-11 15:00:32 +02:00
Joas Schilling
daac5c9a95
fix(cache): Remove displayname cache entry on delete 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-08-28 14:59:54 +02:00
Robin Appelman
d4e67afed7
Merge pull request #39944 from nextcloud/share-cache-share 
pass the share to the cache instead of having to ask the storage
 2023-08-28 13:44:03 +02:00
Joas Schilling
26c734abe4
fix(tests): Specify all positional parameters again to fix tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-08-23 09:08:08 +02:00
Robin Appelman
df71b4d734 pass the share to the cache instead of having to ask the storage 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-08-18 13:38:08 +02:00
Robin Appelman
838929dc83 move "aways loaded" sharing script to event listener 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-08-17 10:57:56 +02:00
Joas Schilling
44b4c16a09
Merge pull request #39605 from nextcloud/bugfix/noid/final-events-cleanup 
fix!: Final round of moving to IEventDispatcher
 2023-08-04 10:39:57 +02:00
Joas Schilling
c3acd03a8e
fix(notifications): Remove share notification when the node is deleted 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-08-03 11:25:26 +02:00
Kate
30345f86dc
Merge pull request #39330 from nextcloud/feature/openapi/files_sharing 
files_sharing: Add OpenAPI spec
 2023-08-01 10:04:13 +02:00
jld3103
c6806684d2
files_sharing: Add OpenAPI spec 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-07-31 16:58:49 +02:00
Joas Schilling
c5dcf3c849
fix!: Remove LegacyBeforeTemplateRenderedListener from files_sharing 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-07-28 14:11:21 +02:00
Joas Schilling
44b810bfbd
feat!: Migrate Sharing events to typed events 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-07-28 14:11:19 +02:00