upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-21 22:27:31 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 40
65968 commits 871 branches 1195 tags 8.3 GiB
Commit graph

183 commits

Author SHA1 Message Date
Vitor Mattos
e55ceb2bb1
Show warning on admin settings page 
Signed-off-by: Vitor Mattos <vitor@php.rio>
 2021-10-23 00:54:50 +02:00
Julien Veyssier
facb50ebcc
fix appstoreenabled check in Fetcher so it's coherent with AppSettingsController 
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
 2021-10-18 12:39:43 +02:00
Christoph Wurst
4b8f8c5203
Deprecate PHP7.3 for Nextcloud 23 
* 7.3 reaches EOL shortly after the release of 23.0.0
* Nextcloud 24 will require PHP7.4

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-10-18 09:15:54 +02:00
Bjoern Schiessle
664bd5802f add 'supported'-label to all supported apps, also if they are not downloaded yet 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2021-10-06 22:17:50 +02:00
Carl Schwan
6958d8005a
Add admin privilege delegation for admin settings 
This makes it possible for selected groups to access some settings
pages.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2021-09-29 21:43:31 +02:00
Stefan
eb46011680 Issue 16719: CheckSetupController.php: now injecting reference to ITempManager, rather than obtaining using it manually 
Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>
 2021-09-17 13:32:42 +02:00
Stefan
8758b36ebb Issue 16719: CheckSetupController.php now checks configured temporary directory for existence and if it's writable 
Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>
 2021-09-17 13:32:42 +02:00
Arthur Schiwon
27865d03c0
use specific email getter where necessary 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-09-09 19:23:05 +02:00
Carl Schwan
07ccccecad
Only recommand for php-sodium on >= PHP 7.4 
This is because php-sodium will solve the missing PASSWORD_ARGON2I
constant problem only on >= php 7.4, previously argon2 wasn't part of
the standard extension and was disabled on Centos/RHEL.

So installing php-sodium on php 7.2 for example wouldn't hide the
message. Tested on Fedora with php 7.4, Centos 7 with php 7.2,
Centos 8 with php 7.2 and openSUSE with php 7.4.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2021-08-06 14:22:09 +02:00
Christoph Wurst
43e41ca532
Merge pull request #28259 from nextcloud/work/carl/sodium-check 
Check that php was compiled with argon2 support or that the php-sodium extensions is installed
 2021-07-30 17:34:10 +02:00
Carl Schwan
8e51a5feda
Check that php was compiled with argon2 support or that the php-sodium 
extensions is installed

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2021-07-30 15:11:55 +02:00
Julien Veyssier
416d10f76c refs #21045 add app config to disable unlimited quota and to set max quota 
avoid unlimited quota as default_quota fallback value if unlimited quota is not allowed
avoid getting/setting/displaying unlimited default quota if not allowed
implement tests for unlimited quota restrictions

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
 2021-07-29 19:31:36 +00:00
Gary Kim
b78f3a57d1
Migrate HintException to OCP 
Signed-off-by: Gary Kim <gary@garykim.dev>
 2021-06-30 15:28:02 -04:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-06-04 22:02:41 +02:00
Valdnet
9c6b01abeb
l10n: Spelling unification 
Spelling unification in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-06-02 17:49:32 +02:00
Arthur Schiwon
847ed37afc
do not use private AccountManager in UsersController 
- extends IAccountProperty for verificationData getters and setters
- implementation thereof ^
- and of course adaption of UsersController

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-05-25 14:35:38 +02:00
Roeland Jago Douma
4a2775a442 Harden apptoken check 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-05-17 16:05:45 +02:00
Joas Schilling
aa651fd629
Merge pull request #26259 from nextcloud/feature/noid/validate-website-to-be-valid 
Validate the website field input to be a valid URL
 2021-04-26 13:56:01 +02:00
Daniel Calviño Sánchez
67dd087ce4 Fix deleting properties of user settings when not given explicitly 
The controller can receive an optional subset of the properties of the
user settings; values not given are set to "null" by default. However,
those null values overwrote the previously existing values, so in
practice any value not given was deleted from the user settings. Now
only non null values overwrite the previous values.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2021-04-23 11:44:41 +02:00
Daniel Calviño Sánchez
ac0c18327e Fix TypeError when "email" is not given in the controller request 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2021-04-23 11:44:41 +02:00
Daniel Calviño Sánchez
a7431817b9 Respect additional user settings not covered by the controller 
"AccountManager::updateUser()" wipes previous user data with whichever
user data is given (except for some adjustments, like resetting the
verified status when needed). As the controller overrode the properties
those properties would lose some of their attributes even if they are
not affected by the changes made by the controller. Now the controller
only modifies the attributes set ("value" and "scope") to prevent that.

Note that with this change the controller no longer removes the
"verified" status, but this is not a problem because, as mentioned,
"AccountManager::updateUser()" resets them when needed (for example,
when the value of the website property changes).

This change is a previous step to fix overwritting properties with null
values, and it will prevent the controller from making unexpected
changes if more attributes are added in the future.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2021-04-23 11:44:41 +02:00
Daniel Calviño Sánchez
8cae515daa Use constants from interface rather than class 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2021-04-23 11:44:40 +02:00
Joas Schilling
d80cc76ee7
Validate the website field input to be a valid URL 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-04-22 16:34:13 +02:00
Roeland Jago Douma
bd2e6309b5
Merge pull request #25605 from nextcloud/trusted-proxy-warning-localhost 
dont show trusted proxy warning when the proxy and remote are both localhost
 2021-04-01 13:27:26 +02:00
Vincent Petry
5d14fd4396
Make extra user profile fields always editable 
The fields for phone number, address, website and twitter are now
editable regardless whether federated sharing and the lookup server
are enabled or not.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-03-26 13:07:08 +01:00
Joas Schilling
61ed57b757
Rename some parameters and methods to make the API more clear 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-10 20:30:29 +01:00
Joas Schilling
07095fd122
Also clear the knownUser when changing via the settings endpoint 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-10 19:37:10 +01:00
Roeland Jago Douma
2afa1c5739
Merge pull request #25862 from nextcloud/techdept/psalm/some_loggers 
Move away some ILoggers
 2021-03-02 15:01:44 +01:00
Roeland Jago Douma
38f761f25f Move away some ILoggers 
Makes psalm happier

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-03-02 10:47:25 +01:00
Roeland Jago Douma
3d0dff0d2b Fix lying docblocks 
* typed the return
* removed unneeded temp variable

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-03-01 16:48:04 +01:00
dependabot-preview[bot]
eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0 
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-02-18 13:31:24 +01:00
Roeland Jago Douma
bd8b1786c5 Some psalm fixes in the settings app 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-02-15 10:00:35 +01:00
Roeland Jago Douma
7d8e9baa77
Revert "use the configured forwarded headers for the setup check" 2021-02-13 18:03:32 +01:00
Robin Appelman
01118a2218
use the configured forwarded headers for the setup check 
instead of always checking against the same header

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-02-12 14:22:27 +01:00
Robin Appelman
cc0cc68c8d
dont show trusted proxy warning when the proxy and remote are both localhost 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-02-12 13:32:51 +01:00
Christoph Wurst
c1d4f8161b
Migrate internal classes to the OCP db col types 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-01-12 14:09:13 +01:00
Roeland Jago Douma
6c8f2dc7bc
Merge pull request #25016 from nextcloud/enh/noid/add-check-for-unsupported-db 
Add setup check to verify that the used DB version is still supported…
 2021-01-11 14:21:42 +01:00
Morris Jobke
24d436cb60
Remove unneeded casts that were found by Psalm 
In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see https://github.com/nextcloud/server/pull/24521)

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2021-01-11 13:14:41 +01:00
Morris Jobke
bffa61fc32
Add setup check to verify that the used DB version is still supported in the next major release 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2021-01-08 13:38:32 +01:00
Christoph Wurst
8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-01-08 11:45:19 +01:00
Christoph Wurst
90d0732828
Fix updating user settings 
The requests dispatched from the personal settings page don't always
send all the possible params but just a subset. Hence requests currently
fail on master e.g. when you update your email. This makes the arguments
optional again.

Regression of da9462b482

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-01-05 12:59:50 +01:00
Christoph Wurst
9ce3ea3368
Update license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-12-30 14:07:05 +01:00
Roeland Jago Douma
adc4f1a811
Merge pull request #22916 from J0WI/unifiy-links-to-php.net 
Unify links to php.net
 2020-12-22 09:53:31 +01:00
Christoph Wurst
d89a75be0b
Update all license headers for Nextcloud 21 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-12-16 18:48:22 +01:00
Julius Härtl
a0444bc69c
Merge pull request #24247 from nextcloud/bugfix/noid/ocm-providerId-string 2020-12-09 17:25:59 +01:00
Julius Härtl
8f6c2ec357
Move columns to bigint 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-08 16:05:53 +01:00
Joas Schilling
f648635758
Make the throwing optional, so background tasks don't break 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-12-07 14:19:38 +01:00
Joas Schilling
46b073d7ce
Add a config for default region of phone numbers 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-12-07 14:19:38 +01:00
Joas Schilling
9e04e6f99a
Also translate the phone number when coming in via the accounts manager API directly 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-12-07 14:19:38 +01:00
Joas Schilling
efe79f2937
Validate and standardize the phone number on saving 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-12-07 14:19:37 +01:00
Joas Schilling
c2913f18d2
Also return the phone number and twitter handle on the API 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-12-07 14:19:37 +01:00
Joas Schilling
da9462b482
Make code strict 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-12-07 14:19:37 +01:00
Morris Jobke
fe79a1ad3e
Harden setup check for TLS version if host is not reachable 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-12-02 13:17:05 +01:00
Joas Schilling
d5df033ede
Create primary keys on all tables and add a command to create the afterwards 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-10 15:36:27 +01:00
Morris Jobke
a223f603f9
Simplify the check if admin can change password based on encryption status 
Found by Psalm:
```
/home/runner/work/server/server/apps/settings/lib/Controller/UsersController.php:324:8:error - RedundantCondition: Type true for $isEncryptionModuleLoaded is never falsy
```

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-11-05 22:20:34 +01:00
Morris Jobke
1c496a5a35
Add a background job that checks for potential user imported SSL certificates and shows a warning in the admin settings 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-11-03 10:06:33 +01:00
nhirokinet
830348dbee
Add SVG support check to setup check 
Signed-off-by: nhirokinet <nhirokinet@nhiroki.net>
 2020-11-02 11:29:08 +01:00
Morris Jobke
b8ed997238
Remove ISection in favor of IIconSection 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-10-28 23:05:00 +01:00
Roeland Jago Douma
28d82394f1
Merge pull request #23720 from nextcloud/lowercase-email 
save email as lower case
 2020-10-27 20:14:43 +01:00
Robin Appelman
cbd6e65678
save email as lower case 
email addresses are case insensitive

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-10-27 14:56:52 +01:00
timm2k
60efad45cf
Update CheckSetupController.php 2020-10-26 09:42:01 +01:00
Roeland Jago Douma
0dbb99a81b
Merge pull request #23161 from nextcloud/enh/noid/setup-checks2 
Remove setup check for php mail
 2020-10-08 22:40:37 +02:00
Christoph Wurst
d9015a8c94
Format code to a single space around binary operators 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-10-05 20:25:24 +02:00
Daniel Kesselberg
9c8e8007f9
Remove setup check for php mail 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-10-03 21:58:55 +02:00
J0WI
68ce17e59b Unify links to php.net 
Update all links to https://www.php.net/

Signed-off-by: J0WI <J0WI@users.noreply.github.com>
 2020-09-17 17:40:04 +02:00
Roeland Jago Douma
05edd1e5d6
Merge pull request #22890 from nextcloud/techdebt/18680/help-static-code-analysis-understand-code 
Help static code analysis to understand code
 2020-09-17 08:51:20 +02:00
Daniel Kesselberg
096fe20611
Help static code analysis to understand code. 
It adds proper type hints to private namespace to allow private namespace methods.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-09-16 16:37:17 +02:00
Morris Jobke
d3680e682a
Remove not needed semicolon and PHPDoc hint 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-09-16 16:18:43 +02:00
Arthur Schiwon
f959828616
emit typed event for user management 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-09-08 22:50:05 +02:00
Christoph Wurst
1f7f93a695
Update license headers for Nextcloud 20 (again) 
There are still lots of outdated headers, so time for another round of
updates.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-09-07 14:37:44 +02:00
Jan C. Borchardt
4c48d6bf18
Add 'Reasons to use Nextcloud in your organization' call to action in settings 
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
 2020-09-07 08:30:01 +02:00
Julius Härtl
7a1748e6f0 Show changelog in apps management 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-09-03 19:16:13 +00:00
Christoph Wurst
2a054e6c04
Update the license headers for Nextcloud 20 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-08-24 14:54:25 +02:00
Joas Schilling
b09620651c
Don't use deprecated getIniWrapper() anymore 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-08-20 16:35:38 +02:00
Morris Jobke
da584462d1
Merge pull request #22018 from nextcloud/bugfix/noid/harden-key-generation 
Harden SSE key generation
 2020-08-19 20:42:34 +02:00
Morris Jobke
603d7dab5e
Add setup check that links to the migration documentation 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-19 15:45:45 +02:00
Julius Härtl
36cfdd320b
Harden key generation 
There might be cases where multiple requests trigger the key generation
at the same time and the instance ends up with a non-fitting
public/private key pair. Therefore the whole key generation should be
locked. Other than that this makes sure that user key generation return
values are properly validated.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-08-14 07:58:40 +02:00
Daniel Kesselberg
89c6a2bc1f
Add setup checks for php default charset and output buffering. 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-07-26 00:54:16 +02:00
Morris Jobke
7e281a07bb
Use IBootstrap for the app federatedfilesharing 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-14 16:34:43 +02:00
Morris Jobke
54d36c047b
Merge pull request #21741 from nextcloud/debt/noid/url-generator-does-not-implement-i-user-session 
Fix type for $urlGenerator
 2020-07-08 09:06:56 +02:00
Daniel Kesselberg
ba0ef74c06
Fix type for $urlGenerator 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-07-08 09:06:29 +02:00
Daniel Kesselberg
87dd760a89
Replace TYPE with TYPES 
As TYPE::* is deprecated.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-06-30 23:46:22 +02:00
Joas Schilling
6e46df26a8
Unify settings middleware with others 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-23 20:18:38 +02:00
Roeland Jago Douma
ce7a15e804
Merge pull request #21274 from nextcloud/bug/21268/paswordless-for-everyone 
Enable passwordless for everyone not only admins.
 2020-06-07 15:04:47 +02:00
Daniel Kesselberg
761a7bf6a2
Enable passwordless for everyone not only admins. 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-06-06 21:34:49 +02:00
Joas Schilling
7dcb1cdb42
Remove controller and routes which have no UI component anyway 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-04 10:41:08 +02:00
Arthur Schiwon
653162a709
use the loginname to verify the old password in user password changes 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-05-26 16:53:25 +02:00
GretaD
fce716b905
Fix languages empty array 
Signed-off-by: GretaD <gretadoci@gmail.com>
 2020-05-08 10:03:58 +02:00
Christoph Wurst
cb057829f7
Update license headers for 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-29 11:57:22 +02:00
Roeland Jago Douma
19171d77e2
Merge pull request #19191 from laurisb/patch-1 
Improve Opcache detection
 2020-04-15 11:03:05 +02:00
Roeland Jago Douma
1cc793888f
Merge pull request #20421 from nextcloud/fix/20393/recommendend_webauthn_mods 
Show setup check for recommended php modules
 2020-04-12 15:56:10 +02:00
Christoph Wurst
a7c8d26d31
Add visibility to all properties and move static keyword 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 16:48:31 +02:00
Christoph Wurst
caff1023ea
Format control structures, classes, methods and function 
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 14:19:56 +02:00
Roeland Jago Douma
75836f004d
Show setup check for recommended php modules 
Fixes #20393

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-04-10 13:25:12 +02:00
Christoph Wurst
14c996d982
Use elseif instead of else if 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 10:35:09 +02:00
Christoph Wurst
afbd9c4e6e
Unify function spacing to PSR2 recommendation 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 13:54:22 +02:00
Christoph Wurst
2a529e453a
Use a blank line after the opening tag 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 11:50:14 +02:00
Christoph Wurst
85e369cddb
Fix multiline comments 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-08 22:24:54 +02:00
Joas Schilling
bc6a5ef5c4
Merge pull request #19890 from nextcloud/enh/comments-reference-id 
Add optional comments reference_id
 2020-04-02 11:34:21 +02:00
Roeland Jago Douma
19ca921676
Merge pull request #20241 from nextcloud/fix/license-headers-19 
Update the license headers for Nextcloud 19
 2020-04-01 12:44:21 +02:00