upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-21 14:23:17 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 15
63063 commits 874 branches 1195 tags 8.3 GiB
Commit graph

4970 commits

Author SHA1 Message Date
Joas Schilling
617528312a
Fix last tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-12-02 10:39:49 +01:00
Joas Schilling
3e20cffc86
More test fixing 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-12-01 22:38:57 +01:00
Joas Schilling
c6ae53096c
More test fixing 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-12-01 22:17:19 +01:00
Joas Schilling
9f00179037
More unit test adjustments 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-12-01 21:40:14 +01:00
Carl Schwan
a8866b0253
Fix tests 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2021-12-01 19:53:24 +01:00
Arthur Schiwon
d384edc9c6
add method to shorten a string to given byte size to Utils 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-11-26 16:21:40 +01:00
Vincent Petry
fd487c1a43
Merge pull request #29432 from nextcloud/fix/support-php-8.1 
Support PHP 8.1 - First batch
 2021-11-23 15:41:20 +01:00
Côme Chilliet
cd72045433
Make mock config return default value to fix warnings 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-11-23 09:29:00 +01:00
Côme Chilliet
25fa0b8acd
Fix TempManager test errors about passing null to is_dir 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-11-23 09:29:00 +01:00
Côme Chilliet
065531570d
Fix Encryption tests on PHP 8.1 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-11-23 09:28:59 +01:00
Côme Chilliet
bb9c099e42
Fix FolderTest calls to Mountpoint constructor with wrong type 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-11-23 09:28:59 +01:00
Côme Chilliet
3a1b3745eb
Fix DateTime constructor calls with null 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-11-23 09:28:58 +01:00
Côme Chilliet
bc3acfc957
Fix test class names 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-11-23 09:28:57 +01:00
Côme Chilliet
66bdda568a
Fix Guzzle function calls 
Since 1.7.0 and 2.0 these functions are turned into static methods.
See https://github.com/guzzle/psr7#upgrading-from-function-api

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-11-23 09:28:57 +01:00
Côme Chilliet
113756db30
Fix ArrayAccess and JsonSerializable return types 
First round of modifications for PHP 8.1

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-11-23 09:28:56 +01:00
Vincent Petry
f01ad7b8d8
Improve normalizer detecting IPv4 inside of IPv6 
The subnet for an IPv4 address inside of IPv6 is now returned in its
IPv4 form.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-11-22 16:46:25 +01:00
Vincent Petry
7e08a4ab15
Fix getting subnet of ipv4 mapped ipv6 addresses 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-11-22 14:10:11 +01:00
Vincent Petry
c42a890126
Merge pull request #29622 from nextcloud/feat/objectstore_multibucket-shift 
Implement multibucket shift for ObjectStore
 2021-11-19 17:26:44 +01:00
Vincent Petry
c92a0e4152
Normalize directory entries in Encoding wrapper 
Directory entry file names are now normalized in getMetaData(),
getDirectoryContents() and opendir().

This makes the scanner work properly as it assumes pre-normalized names.

In case the names were not normalized, the scanner will now skip the
entries and display a warning when applicable.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-11-17 09:43:25 +01:00
Naoto Kobayashi
e9b414fbe3 OC_Util: Add fallbacks to check if current locale is UTF8 
Using escapeshellcmd to get current locale causes error
if the function is disabled.

Add fallbacks to prevent the error.

Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
 2021-11-16 00:40:52 +09:00
Naoto Kobayashi
25f15f86a9 Add check whether escapeshellcmd behaves the same as basename 
Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
 2021-11-15 18:33:50 +09:00
Naoto Kobayashi
455bff5c17 Fix missing setlocale with php 8 
When php version = 8, basename('§') does not bug even if LC_ALL is non-UTF-8 locale.
This cause OC_Util::isSetLocaleWorking() to skip setlocale("C.UTF-8").

Fix it by using escapeshellcmd instead of basename.

Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
 2021-11-14 09:18:59 +09:00
Joas Schilling
265c2c125c
Fix unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-11-12 15:01:56 +01:00
John Molakvoæ
6ab2feaa54
Implement multibucket shift for ObjectStore 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2021-11-11 15:09:28 +01:00
Joas Schilling
3b91e4cc48
Add unit test for share enumeration method 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-11-09 14:42:57 +01:00
Joas Schilling
fa036b2001
Move common logic to share manager 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-11-09 10:10:53 +01:00
Côme Chilliet
58b6f35522
Enable Avatar tests as well for PHP>=8 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-10-28 17:49:32 +02:00
Côme Chilliet
23a4e17bd1
Revert "Do not run image tests on php8" 
This reverts commit d690f90928.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-10-28 17:49:21 +02:00
Joas Schilling
c42f5bc5f6
Add an OCP for trusted domain helper 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-10-28 10:24:16 +02:00
John Molakvoæ
f4e4a85fcf
Merge pull request #27440 from nextcloud/is-file-handle 2021-10-23 11:18:52 +02:00
John Molakvoæ
a06001e085
Merge pull request #29363 from nextcloud/fair-use-push 2021-10-23 10:53:22 +02:00
Joas Schilling
b578a1e8b5
Fair use of push notifications 
We want to keep offering our push notification service for free, but large
users overload our infrastructure. For this reason we have to rate-limit the
use of push notifications. If you need this feature, consider setting up your
own push server or using Nextcloud Enterprise.

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-10-23 00:54:50 +02:00
Arthur Schiwon
e26d6f080b
fix populating account array with missing default values 
- both $userData and $defaultUserData have numeric indices
- each element contains at least the name and other fields
- appending the missing data array is sufficient

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-10-22 23:05:43 +02:00
acsfer
dae769d082
Update Tests 2021-10-22 12:16:11 +02:00
John Molakvoæ
2be0eda47c
Merge pull request #29220 from nextcloud/s3-external-list 2021-10-22 12:06:05 +02:00
John Molakvoæ
c98039c1df
Merge pull request #26725 from nextcloud/fix-federated-scope-not-shown-when-public-addressbook-upload-is-disabled 2021-10-22 11:52:56 +02:00
John Molakvoæ
0a35937662
Merge pull request #26347 from J0WI/clean-path-regex 2021-10-22 11:42:30 +02:00
John Molakvoæ
7e3b6e7088
Merge pull request #29344 from nextcloud/dependabot/composer/doctrine/dbal-3.1.3 2021-10-22 11:35:02 +02:00
Christoph Wurst
7dd7256cfe
Prevent duplicate auth token activity updates 
The auth token activity logic works as follows
* Read auth token
* Compare last activity time stamp to current time
* Update auth token activity if it's older than x seconds

This works fine in isolation but with concurrency that means that
occasionally the same token is read simultaneously by two processes and
both of these processes will trigger an update of the same row.
Affectively the second update doesn't add much value. It might set the
time stamp to the exact same time stamp or one a few seconds later. But
the last activity is no precise science, we don't need this accuracy.

This patch changes the UPDATE query to include the expected value in a
comparison with the current data. This results in an affected row when
the data in the DB still has an old time stamp, but won't affect a row
if the time stamp is (nearly) up to date.

This is a micro optimization and will possibly not show any significant
performance improvement. Yet in setups with a DB cluster it means that
the write node has to send fewer changes to the read nodes due to the
lower number of actual changes.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-10-22 09:32:22 +02:00
Christoph Wurst
130ab63ca1
Bump doctrine/dbal from 3.0.0 to 3.1.3 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-10-22 09:03:45 +02:00
Julien Veyssier
0bef570fe9
Merge pull request #29256 from nextcloud/fix/noid/harmonize-appstoreenabled-check 
Fix appstoreenabled check
 2021-10-21 12:42:14 +02:00
Joas Schilling
f24e8212c3
Fix unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-10-21 09:27:12 +02:00
Joas Schilling
7f1dc52a66
Change origin field to appId 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-10-20 14:47:28 +02:00
John Molakvoæ
5e23800a95
Do not remove current user on findOne 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2021-10-20 11:53:45 +02:00
John Molakvoæ
873e8e219c
Add appName to contactsmenu action API 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2021-10-20 11:53:45 +02:00
Christopher Ng
309354852f Profile backend 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2021-10-19 04:59:35 +00:00
Christopher Ng
7215148a24 Add new account properties 
- New properties
  - Organisation
  - Role
  - Headline
  - Biography
  - Profile Enabled property
- Fix errors with building default account properties
- Fix L10N factory method `getLanguage` not public error
- Update tests

Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2021-10-19 04:44:40 +00:00
Robin Appelman
294b218895
ci 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-10-15 15:35:12 +02:00
John Molakvoæ
f7a4ff4d63
Merge pull request #27217 from nextcloud/techdebt/noid/make-debugging-a-cron-job-easier 2021-10-15 11:09:23 +02:00
John Molakvoæ
b6a3ba136c
Merge pull request #29235 from nextcloud/feat/appstore/enterprise 2021-10-15 11:06:32 +02:00
Christoph Wurst
67baaaaff9
Merge pull request #29231 from nextcloud/fix/calendar-providers-instances 
Build instances of the calendar providers before using them
 2021-10-14 19:29:34 +02:00
Christoph Wurst
c75a12c154
Build instances of the calendar providers before using them 
What we get from the registration context are only the class names. We
still have to load the classes before we can use them.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-10-14 16:06:51 +02:00
John Molakvoæ
1f76423500
Send the subscription key to the appstore requests 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2021-10-14 14:48:45 +02:00
Julius Härtl
acbe4b46c3
Merge pull request #29157 from nextcloud/enh/opendocument 2021-10-14 12:58:34 +02:00
Joas Schilling
9cd9f4b4bc
Move queries to the joblist 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-10-14 09:57:16 +02:00
Joas Schilling
811d0cd1b5
Merge pull request #29135 from nextcloud/feat/appstore-filtering 
Allow to filter apps from the appstore
 2021-10-14 09:50:37 +02:00
Anna Larch
a58d1e6b06
Add Public Calendar Provider 
Signed-off-by: Anna Larch <anna@nextcloud.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-10-14 08:22:24 +02:00
Julius Härtl
2f38781c96
Fix integrity checker tests 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-10-13 18:10:37 +02:00
John Molakvoæ
1a6bac5874
Allow to whitelist apps from the apsptore 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2021-10-13 11:13:33 +02:00
Christoph Wurst
e163d199d8
Merge pull request #29015 from nextcloud/enhancement/l10n-factory-find-generic-language 
Add L10n factory method for generic language heuristics
 2021-10-13 10:58:07 +02:00
Christoph Wurst
5b727fc7da
Add L10n factory method for generic language heuristics 
The existing `findLanguage` method tries its best to find the best
language for the current users. For some tasks we don't want this but
rather determine the most generic language for *another* user, e.g. when
the current user trigger an email notifiaction to someone else. In this
case the current user's language is a bad guess in many multi-language
environments.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-10-13 09:57:21 +02:00
Joas Schilling
3487aeeb1f
Add integration tests for group 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-10-12 14:05:38 +02:00
Daniel
9187e986e1
Merge pull request #28907 from nextcloud/bug/noid/close-stream-local 
explicitly close source stream on local / encryption storage
 2021-10-08 10:02:01 +02:00
Julius Härtl
d68f028251
Merge pull request #27733 from PhrozenByte/enhancement/noid/IURLGenerator-linkToDefaultPageUrl 2021-10-05 13:06:59 +02:00
Carl Schwan
6958d8005a
Add admin privilege delegation for admin settings 
This makes it possible for selected groups to access some settings
pages.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2021-09-29 21:43:31 +02:00
Julius Härtl
9161f6ca4a Remove tests that just prove mocked calls and don't actually validate anything useful 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-09-27 14:24:48 +02:00
Julius Härtl
cab44b6311 Run oci tests against phpunit9/php8 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-09-27 14:24:05 +02:00
Daniel Kesselberg
e60a829b42
explicitly close source stream on local storage 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2021-09-21 17:41:59 +02:00
Daniel Kesselberg
024881dbd3
Add email addresses to contacts menu 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2021-09-15 16:58:44 +02:00
Lukas Reschke
0dcc5c0e9f
Merge pull request #28728 from nextcloud/add-database-backend-limiter 
Add database ratelimiting backend
 2021-09-13 13:07:37 +02:00
Arthur Schiwon
27865d03c0
use specific email getter where necessary 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-09-09 19:23:05 +02:00
Arthur Schiwon
4461b9e870
enable the user to set a primary (notification) email address (backend) 
- specific getters and setters on IUser and implementation
- new notify_email field in provisioning API

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-09-09 19:23:04 +02:00
Arthur Schiwon
a20de15b43
add a job to clean up expired verification tokens 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-09-09 14:03:35 +02:00
Arthur Schiwon
aacaad2a3f
implement verification for additional mails 
- mails added by (sub)admins are automatically verified
- provisioning_api controller as verification endpoint
- IAccountProperty gets a locallyVerified property
- IPropertyCollection gets a method to fetch an IAccountProperty by value
  - an remove equivalent was already present
- AccountManager always initiates mail verification on update if necessary
- add core success template for arbitrary title and message

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-09-09 14:03:35 +02:00
Arthur Schiwon
19cc757531
move verification token logic out of lost password controller 
- to make it reusable
- needed for local email verification

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-09-09 14:03:29 +02:00
Lukas Reschke
6337bb3f59 Adjust tests 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2021-09-06 17:46:02 +02:00
Lukas Reschke
378cc922c4 Adjust logic to store period instead of current timestamp 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2021-09-06 17:31:36 +02:00
Bernd Rederlechner
3866f388b1
Refactor writeObject to only use MultipartUpload when required 
Signed-off-by: Bernd Rederlechner <Bernd.Rederlechner@t-systems.com>

Co-authored-by: Julius Härtl <jus@bitgrid.net>
 2021-08-20 17:02:25 +02:00
Daniel Calviño Sánchez
83b39d6111 Add missing scope to test 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2021-08-18 19:05:33 +02:00
Jonas Meurer
7c76e85dde
Use IURLGenerator function to get value of \OC::$WEBROOT global 
Signed-off-by: Jonas Meurer <jonas@freesources.org>
 2021-08-16 10:56:47 +02:00
acsfer
11169c86f8 Tests update 2021-08-15 12:23:29 +02:00
John Molakvoæ
67e6468b9e
Merge pull request #28220 from nextcloud/get-by-id-multiple-mounts-single-storage 2021-08-09 19:27:23 +02:00
Daniel Rudolf
a1d6189dfa
Fix UrlGeneratorTest 
And again... 😒

Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
 2021-08-05 13:55:35 +02:00
Daniel Rudolf
aa455e71d9
Merge branch 'master' into enhancement/noid/IURLGenerator-linkToDefaultPageUrl 2021-08-04 18:52:55 +02:00
Daniel Rudolf
b768cade2b
Fix UrlGeneratorTest 
Again... 😒

Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
 2021-08-04 18:52:53 +02:00
Julien Veyssier
416d10f76c refs #21045 add app config to disable unlimited quota and to set max quota 
avoid unlimited quota as default_quota fallback value if unlimited quota is not allowed
avoid getting/setting/displaying unlimited default quota if not allowed
implement tests for unlimited quota restrictions

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
 2021-07-29 19:31:36 +00:00
Julius Härtl
db7ffb0bf9
Merge pull request #28175 from nextcloud/jail-search-root 2021-07-29 09:27:53 +02:00
Robin Appelman
5c2e7c7d28
fix Folder->getById() when a single storage is mounted multiple times 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-07-28 17:21:04 +02:00
Robin Appelman
4d5e8bcb99
add test for searching within a "root jail" 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-07-28 17:11:12 +02:00
Julius Härtl
b31c08e536
Merge pull request #28075 from nextcloud/enh/noid/admin_audit-report-full-path 
Admin Audit - Sharing: createShare - report the full path
 2021-07-26 12:35:48 +02:00
Julius Härtl
858d846999
Let memory limit set in tests fit the used amount 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-07-22 17:05:29 +02:00
szaimen
4570bb4f65 Admin Audit - Sharing: createShare - report the full path 
Signed-off-by: szaimen <szaimen@e.mail.de>
 2021-07-22 14:20:05 +00:00
Julius Härtl
7179002600
Allow to get a local cloud id without going through the contacts manager 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-07-14 16:08:05 +02:00
Joas Schilling
11d21e5f5c
Add a unit test to check for casting a IQueryFunction 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-07-07 14:19:24 +02:00
Lukas Reschke
415d704959
Merge pull request #27198 from nextcloud/tests/run-s3-tests 
Run s3 tests again
 2021-07-05 11:52:48 +02:00
Daniel Rudolf
1e5962ae98
Fix UrlGeneratorTest::testGetDefaultPageUrlWithDefaultApps() 
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
 2021-07-01 16:39:26 +02:00
Daniel Rudolf
15a445f743
Move UtilTest::testDefaultApps() to UrlGeneratorTest 
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
 2021-07-01 16:26:55 +02:00
Daniel Rudolf
e16bf707aa
Fix UtilTest::testDefaultApps() 
Oh wow... This definitly was no best practice... 😒

Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
 2021-07-01 16:00:29 +02:00
Gary Kim
b78f3a57d1
Migrate HintException to OCP 
Signed-off-by: Gary Kim <gary@garykim.dev>
 2021-06-30 15:28:02 -04:00
Daniel Rudolf
12059eb65b
Add IUrlGenerator::linkToDefaultPageUrl() 
Replaces the deprecated \OC_Util::getDefaultPageUrl() and makes this API public.

Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
 2021-06-30 16:20:57 +02:00
Julius Härtl
3f44fd00e2
Run s3 tests again 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-06-30 14:30:04 +02:00
Arthur Schiwon
506227b509
adjust internal data handling logic to fix store and load 
- format as stored previously in oc_accounts table is kept

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-06-30 00:48:01 +02:00
Arthur Schiwon
c7bf4295cc
adjust email verification checker 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-06-30 00:47:36 +02:00
Arthur Schiwon
3d6ffd3da2
adjust verification state updater method 
- also fixes scope of internal methods

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-06-30 00:42:42 +02:00
Arthur Schiwon
af3fdbea7b
make AccountManager actually write multi value properties 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-06-30 00:41:12 +02:00
Arthur Schiwon
638c04d6e0
accounts event handler to use eventdispatcher, DI and Accounts API 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-06-30 00:41:11 +02:00
Arthur Schiwon
13818005a3
prov api reports additional emails on getUser 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-06-30 00:41:10 +02:00
Pytal
9ed379da22
Merge pull request #27635 from nextcloud/fix/datetime-constants 
Fix usage of DateTime constants
 2021-06-23 09:56:28 -07:00
Christoph Wurst
6d5cfe0c66
Move DateTime::RFC2822 to DateTimeInterface::2822 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-06-23 15:30:43 +02:00
Christoph Wurst
770881d5d6
Move DateTime::ATOM to DateTimeInterface::ATOM 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-06-23 15:28:07 +02:00
blizzz
ee7a484284
Merge pull request #26346 from J0WI/clean-auth-regex 
Cleaner removePassword regex
 2021-06-23 11:20:19 +02:00
Julius Härtl
a94236483e
Let apps toggle an unread counter on app icons 
Co-authored-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-06-16 17:12:56 +02:00
Robin Appelman
66e10718c6
split of query building bits from searchhelper 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-06-14 16:11:40 +02:00
Robin Appelman
f938daa6e4
update tests and fix some edge cases around new search 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-06-14 16:11:36 +02:00
Robin Appelman
e198dc1b20
rework search api to allow searching on multiple caches at once 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-06-14 16:11:22 +02:00
kesselb
89c534858e
Merge pull request #27414 from francoisfreitag/test-at-2 
Rewrite LegacyHelperTest without $this->at()
 2021-06-08 22:07:16 +02:00
Christoph Wurst
745543d8c0
Merge pull request #27306 from nextcloud/enh/noid/set-local-domain-for-swiftmailer 
Set local domain for swiftmailer
 2021-06-08 15:43:39 +02:00
blizzz
662ab937e0
Merge pull request #27189 from nextcloud/feat/26866/account-collection-properties 
Extend Accounts with multivalue properties (PropertyCollection)
 2021-06-08 14:25:18 +02:00
Arthur Schiwon
ff2382e5a4
CI: more flexible assertions 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-06-07 23:41:04 +02:00
François Freitag
21762a1e94 Rewrite LegacyHelperTest without $this->at() 
The at() matcher has been deprecated. It will be removed in PHPUnit 10.
Please refactor your test to not rely on the order in which methods are
invoked.

Signed-off-by: François Freitag <mail@franek.fr>
 2021-06-07 21:43:30 +02:00
Joas Schilling
181aab416a
Fix warnings about logException 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-06-04 10:57:09 +02:00
Arthur Schiwon
44827e37c0
allow interacting with IAccountPropertyCollections 
- in fact the API could be done in a nicer way and it might be possible to
  work without IAccountPropertyCollection, but only with the
  IAccountProperties.
- To keep it simple at first and not overengineer the blunt attempt is
  followed
- If necessary helpful in the further cause of development adjustements or
  extensions can be done quickly with this base


Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-06-03 20:49:49 +02:00
Arthur Schiwon
0bade27479
add IAccountPropertyCollection with implementation 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-06-03 20:49:49 +02:00
Arthur Schiwon
afea57352b
update unit tests 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-06-03 20:49:49 +02:00
Lukas Reschke
377514aad1 Escape filename in Content-Disposition 
We should escape all occurences of ' and \ in here.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2021-06-02 19:22:17 +02:00
John Molakvoæ
d0cf20cc51
Merge pull request #26792 from nextcloud/user-delete-cleanup-files 
better cleanup of user files on user deletion
 2021-06-02 17:02:00 +02:00
Daniel Kesselberg
747325fc43
Set local domain for swiftmailer transport 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2021-05-31 15:04:00 +02:00
Thomas Citharel
1c0d975654
Make dav respect disallowing sharing with groups 
Closes #25390

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2021-05-26 11:19:59 +02:00
Arthur Schiwon
847ed37afc
do not use private AccountManager in UsersController 
- extends IAccountProperty for verificationData getters and setters
- implementation thereof ^
- and of course adaption of UsersController

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-05-25 14:35:38 +02:00
Morris Jobke
f1dbabd910
Merge pull request #26727 from nextcloud/group-exclude-link-share 
Add option to exclude groups from creating link shares
 2021-05-21 15:35:39 +02:00
Valdnet
1627eb45bb
l10n: Fix test 2021-05-20 09:26:38 +02:00
Julius Härtl
35b910cf8e
Merge pull request #26322 from nextcloud/recent-search 
Use file search for recent files and optimize getting share types
 2021-05-18 09:44:08 +02:00
Roeland Jago Douma
ee3dc57cbd
Merge pull request #26626 from J0WI/strict-security 
Make Security module strict
 2021-05-18 08:43:13 +02:00
blizzz
0ab5b3e265
Merge pull request #26679 from nextcloud/bugfix/noid/fix-unauthorized-ocs-status-in-provisioning 
Fix unauthorized OCS status in provisioning
 2021-05-13 23:39:20 +02:00
Robin Appelman
b1dca57a1c
load share settings from the share manager in more places 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-05-12 16:11:28 +02:00
Joas Schilling
b6c6527705
Fix unauthorized OCS status in provisioning 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-05-12 08:16:07 +02:00
Arthur Schiwon
8413ed9475
allow to set valid scopes only in AccountProperty 
the auto-fallback to v2-local is removed as well to react on wrong input

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-05-12 01:31:15 +02:00
Robin Appelman
ed2d02d5f1
better cleanup of user files on user deletion 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-04-27 20:29:51 +02:00
Christoph Wurst
99f0b10421
Merge pull request #26591 from nextcloud/techdebt/noid/less-ilogger 
Less ILogger
 2021-04-27 15:38:12 +02:00
Joas Schilling
48c50277a9
Merge pull request #26718 from nextcloud/bugfix/noid/fix-ratelimit-template 
Fix ratelimit template
 2021-04-27 15:18:02 +02:00
Joas Schilling
c52a026f55
Merge pull request #26572 from nextcloud/bugfix/noid/throw-401-when-authentication-is-provided-and-invalid 
Throw "401 Unauthenticated" when authentication is provided but invalid
 2021-04-27 14:37:28 +02:00
Joas Schilling
df47445c01
Fix unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-04-27 14:34:32 +02:00
Joas Schilling
174f4dd043
Fix ratelimit template 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-04-27 13:55:34 +02:00
Joas Schilling
aa651fd629
Merge pull request #26259 from nextcloud/feature/noid/validate-website-to-be-valid 
Validate the website field input to be a valid URL
 2021-04-26 13:56:01 +02:00
Morris Jobke
012f791c8f
Merge pull request #26375 from nextcloud/techdebt/noid/symfony-component-translation-pluralization-rules-is-deprecated 
"Symfony\Component\Translation\PluralizationRules" is deprecated
 2021-04-22 21:20:16 +02:00
Joas Schilling
d80cc76ee7
Validate the website field input to be a valid URL 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-04-22 16:34:13 +02:00
Joas Schilling
4ed296db9f
Fix Authentication test 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-04-22 15:36:34 +02:00
Robin Appelman
effb7dc8ba
set mimetype for objects uploaded to object storages 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-04-21 15:25:58 +02:00
Robin Appelman
0d5f4edc22
adjust tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-04-21 14:09:07 +02:00
Joas Schilling
2a11713337 Update CredentialsManagerTest.php 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-04-21 08:33:10 +02:00
Morris Jobke
9e8690d912
Merge pull request #26654 from nextcloud/bugfix/noid/fix-security-credentials-manager-test 
Fix security credentials manager test
 2021-04-20 22:03:52 +02:00
Roeland Jago Douma
5ee9e1f784 Move 2FA registration to IBootstrap 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-04-20 21:01:16 +02:00
Joas Schilling
7f70f3e182
Fix support tests 
2) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #0 (35, 15, 2, false)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist

3) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #1 (35, 45, 15, false)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist

4) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #2 (35, 45, 5, true)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist

5) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #3 (35, 45, 55, false)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist

Had to use the Database user backend, as using multiple interfaces is deprecated:
https://github.com/sebastianbergmann/phpunit/issues/3955
> This functionality should be deprecated as "having to use it" is almost always a symptom of bad design.
> More importantly, though, the support for the creation of test doubles that implement multiple interfaces
> resulted in code that is hard to maintain.

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-04-20 17:36:15 +02:00
Joas Schilling
c6978bac80
Fix security credentials manager test 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-04-20 17:04:24 +02:00
Joas Schilling
79ebc7f24c
Fix test by defining plurals 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-04-20 16:43:43 +02:00
Joas Schilling
5a514a9a41
Correctly replace all PHP placeholders with the parameters 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-04-20 16:42:05 +02:00
blizzz
92ca49d21d
save a whitespace today 
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-04-20 14:03:01 +02:00
Arthur Schiwon
f8d1ee5cfa
ignore mail shares of related remote share results 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-04-20 14:02:35 +02:00
J0WI
ca7b37ce5a Make Security module strict 
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
 2021-04-19 17:31:12 +02:00
Joas Schilling
751be29c73
Merge pull request #26555 from nextcloud/techdebt/noid/run-migrator-tests-on-OCI 
Run migrator tests on OCI
 2021-04-19 08:57:41 +02:00
Roeland Jago Douma
808e589035 Allow registering NotifierServices trough IBootstrap 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-04-16 13:56:28 +02:00
Joas Schilling
1670d00452 Integer 0 is not stored as Null and therefor works 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-04-16 09:57:27 +02:00
Joas Schilling
8b4ecdcc88 Test that oracle throws on EmptyValues in a NotNull columns 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-04-16 09:57:27 +02:00
Joas Schilling
e88bad4b0a Run migrator tests on OCI 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-04-16 09:57:27 +02:00
Roeland Jago Douma
b5ffca00f7 Fix unit test 
* Fix namespace
* Fix test

Was broken after https://github.com/nextcloud/server/pull/26529

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-04-16 09:47:52 +02:00
Vincent Petry
af61486aea
Separate settings for remote share expiration 
Added separate settings for default and enforced expiration date for
remote shares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-04-15 10:06:09 +02:00
Roeland Jago Douma
789bb0d0ac
Merge pull request #26266 from nextcloud/future-proof-networking 
Improve networking checks
 2021-04-12 12:42:33 +02:00
Lukas Reschke
e5a4236e68 Increase subnet matcher 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2021-04-07 12:28:59 +00:00
Lukas Reschke
4b4971ab52
Merge pull request #24966 from nextcloud/jknockaert-patch-1 
avoid fread on directories and unencrypted files
 2021-04-06 13:45:10 +02:00
Lukas Reschke
9dab851931 Adjust test 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2021-04-06 11:37:47 +00:00
Lukas Reschke
5f3abffe6f Improve networking checks 
Whilst we currently state that SSRF is generally outside of our threat model, this is something where we should invest to improve this.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2021-04-06 11:37:47 +00:00
Morris Jobke
5fb909faa5
Merge pull request #24055 from nextcloud/bugfix/noid/enfore-no-notnull-for-boolean-to-store-false 
Enforce no notnull for boolean to store false
 2021-04-01 18:30:26 +02:00
Julius Härtl
37591f05dc
Get the parent directory before creating a file from a template 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-04-01 13:48:21 +02:00
Joas Schilling
f9d4fa2d38
Rename the method to match what it does 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-31 10:21:18 +02:00
Joas Schilling
3696ef5b96
Don't allow Notnull for boolean columns 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-31 10:21:17 +02:00
kesselb
2212a67fbc
Merge pull request #25961 from nextcloud/enh/events/2fa_provider 
Add real events for enabled 2fa providers for users
 2021-03-30 23:13:36 +02:00
Roeland Jago Douma
f3738eeff7
Merge pull request #25280 from nextcloud/explicit-file-permissions 
Set umask before operations that create local files
 2021-03-30 21:55:50 +02:00
Arthur Schiwon
be3ae9a44b
gracefully handle deleteFromSelf when share is already gone 
- handling race conditions

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-03-30 12:59:40 +02:00
Joas Schilling
8d3fdf24c8
Merge pull request #26353 from nextcloud/techdebt/noid/make-testcase-class-compatible-with-phpunit-9.5 
Make Testcase class compatible with phpunit-9.5
 2021-03-29 10:47:37 +02:00
Joas Schilling
cd35a5c71d
Make Testcase class compatible with phpunit-9.5 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-29 09:43:08 +02:00
J0WI
d58d6199d9 Cleaner normalizePath regex 
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
 2021-03-27 21:29:28 +01:00
J0WI
5f468c0248 Cleaner removePassword regex 
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
 2021-03-27 18:42:58 +01:00
Vincent Petry
cc54f718f5
Add known user check in avatar when v2-private scope 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-03-26 13:07:10 +01:00
Vincent Petry
bb008be28a
Added PlaceholderAvatar with own cached images 
When avatar scope is private, the PlaceholderAvatar is used to deliver a
placeholder avatar based on the user's initials.

This was implemented as a separate class for now to avoid messing with
the existing UserAvatar implementation and its generated vs
non-generated logic.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-03-26 13:07:09 +01:00
Vincent Petry
b73df5846c
Add property scope tests for AccountManager 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-03-26 13:07:09 +01:00
Vincent Petry
278a73789e
Map old account scope properties to new names 
Use new scope values in settings page.
Adjust all consumers to use the new constants.
Map old scope values to new ones in account property getter.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-03-26 13:07:08 +01:00
Vincent Petry
b81a1c1bdb
Add new v2-private account scope 
Added new v2-private account manager scope that restricts the scope
further by excluding public link access.

Avatars with v2-private account scope are now showing the guest avatar
instead of the real avatar.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-03-26 13:07:05 +01:00
Morris Jobke
ab48d5e8cb
Cleanup unneeded code around database.xml 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2021-03-24 22:15:44 +01:00
Robin Appelman
e5dc1a8085
Set umask before operations that create local files 
this solves issues where "other php stuff" is messing with the umask

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-23 14:52:31 +01:00
Morris Jobke
1c074e7602
Merge pull request #26198 from nextcloud/unified-search-node 
Handle limit offset and sorting in files search
 2021-03-22 21:48:51 +01:00
Roeland Jago Douma
3c5cf825b3 Add real events for enabled 2fa providers for users 
* Shiny new events
* Listener to still emit the old event

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-03-22 20:57:10 +01:00
John Molakvoæ (skjnldsv)
15767643f2
Fix sharebymail tests 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-03-22 06:50:47 +01:00
Daniel Calviño Sánchez
f99876997a
Remove duplicated query for email shares 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
 2021-03-22 06:50:47 +01:00
Robin Appelman
bfe3712372
handle ordering in folder search 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-19 16:07:54 +01:00
Julius Härtl
76170a58eb
Log and continue when failing to update encryption keys during for individual files 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-03-19 14:12:07 +01:00
Robin Appelman
feed42dd6d
folder filtering in sql 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-19 13:41:00 +01:00
Roeland Jago Douma
1286848731
Merge pull request #23718 from nextcloud/already-shared-error-message 
expand 'path is already shared' error message
 2021-03-19 13:39:22 +01:00
Robin Appelman
de713967c0
cleanup fileinfo creation 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-19 13:35:37 +01:00
Vincent Petry
7bf5adb1fa
Merge pull request #26200 from nextcloud/bugfix/26197/fix-expiration-validation-confusion 
Update user share must use correct expiration validation
 2021-03-19 10:51:21 +01:00
Robin Appelman
bd229e7548
handle limit and offset in folder file search 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-18 17:38:31 +01:00