Commit graph

3263 commits

Author SHA1 Message Date
Vincent Petry
8809de1eef
Merge pull request #31966 from nextcloud/unencrypted-size
store unencrypted size in the unencrypted_size column
2022-06-13 11:55:37 +02:00
Vincent Petry
8e61671b82
Merge pull request #32364 from nextcloud/dav-listeners
🧹 Remove all legacy event dispatchers from CalDAV & CardDAV backends
2022-06-10 15:57:35 +02:00
Christoph Wurst
92d64617e6
Merge pull request #26582 from nextcloud/enhancement/logger-function
Add a helper function that makes it easier to log from anywhere
2022-06-07 11:22:26 +02:00
Robin Appelman
8238582e59
store unencrypted size in the unencrypted_size column
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-06-02 16:07:00 +02:00
Robin Appelman
2a68819a67
add case statement to sql function builder
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-06-02 15:52:12 +02:00
Robin Appelman
813b50ed42
make expression build return IQueryFunction instead of string
this allows passing the expressions to further expressions without them being escaped as column names

Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-06-02 15:52:08 +02:00
blizzz
df89e7fd39
Merge pull request #32485 from nextcloud/debt/noid/psalm-streamer-fh
[Psalm] Fix docblock for addFileFromStream
2022-05-31 14:22:05 +02:00
Joas Schilling
cf9660fdf0
Merge pull request #32628 from nextcloud/bugfix/noid/json-throw
Use JSON_THROW_ON_ERROR instead of custom error handling
2022-05-31 10:06:21 +02:00
Côme Chilliet
fa041dabf4 Add the ISizeEstimationMigrator interface for method getExportEstimatedSize
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-05-30 17:49:05 +00:00
Julius Härtl
3901a93c72
Use JSON_THROW_ON_ERROR instead of custom error handling
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-05-30 19:17:49 +02:00
Côme Chilliet
09917b8583 Implement getExportEstimatedSize in migrators
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-05-30 07:36:13 +00:00
Côme Chilliet
f20b7e5764 Add a method to get estimated export size in IMigrator
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-05-30 07:36:13 +00:00
Carl Schwan
e4378fd18c
Merge pull request #32349 from nextcloud/enh/projects-event
Add event to load additional scripts for projects
2022-05-27 18:36:40 +02:00
Daniel Kesselberg
be99ea969e
Fix type for resource
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-05-24 22:05:59 +02:00
Côme Chilliet
45a75c631e
Merge pull request #32555 from nextcloud/fix/revert-api-break
Revert api break
2022-05-24 09:06:00 +02:00
Joas Schilling
53af533853
Merge pull request #32560 from nextcloud/feature/noid/preferences-api
Add API to change preferences
2022-05-24 07:58:00 +02:00
Carl Schwan
6147bb611c
Revert api break
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-24 06:59:40 +02:00
Joas Schilling
31dc9aa682
Add API to change preferences
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-23 16:44:23 +02:00
Joas Schilling
be4faebc47
Adjust docs to the same as the implementation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-23 12:56:47 +02:00
Carl Schwan
8d599c3410
Merge pull request #32378 from nextcloud/fix/psalm-userbackend
Fix psalm issues related to the user backend
2022-05-23 11:41:21 +02:00
Christoph Wurst
450136b7cf
Add a helper function that makes it easier to log from anywhere
Our DI is able to inject a logger implementation to any server and app
class if they want one. However, sometimes DI isn't applicable or hard
to add. In those cases we typically fell back to the *service locator*
pattern where we acquired a logger from the server via a global
variable.

There were some issues with that
* `\OC` is a private class, apps are not supposed to use it
* `\OC::$server` is a global variable, a well known anti-pattern
* `\OC::$server->get(...)` uses the service locator anti-pattern
* `\OC::$server->get(...)` may throw
* `\OC::$server->get(LoggerInterface::class)` is not scoped to an app

With this patch I'm proposing a new helper function ``\OCP\Log\logger``
that can be used to acquire a logger more easily. This function is meant
to be public API and therefore apps may use it and there is an optional
parameter to specifiy the app ID.
The function hides all the ugly details about the global variable and
the potentially thrown exceptions from the user. Therefore it's
guaranteed that you always get a logger instance. In the worst case you
get a noop, though those occasions should be rare.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-05-23 09:53:38 +02:00
Carl Schwan
9ec0cb0a90 Fix psalm issues related to the user backend
- Reflect the actual return value returned by the implementation in the
  the interface. E.g. IUser|bool -> IUser|false
- Remove $hasLoggedIn parameter from private countUser implementation.
  Replace the two call with the equivalent countSeenUser
- getBackend is nuallable, add this to the interface
- Use backend interface to make psalm happy about call to undefined
  methods. Also helps with getting rid at some point of the old
  implementActions

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-20 17:14:58 +02:00
Joas Schilling
ad908cd87a
Make appName of TemplateResponse accessible in BeforeTemplateRenderedEvent
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-20 15:03:40 +02:00
Joas Schilling
bc82fa48d1
Merge pull request #32406 from nextcloud/debt/noid/psalm-warning-idbconnection
[Psalm] Fix spelling for PreConditionNotMetException
2022-05-20 14:32:33 +02:00
Thomas Citharel
28b0da59ce
Fix a doctype in OCP for IAddressBook
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-05-17 15:09:49 +02:00
Côme Chilliet
a4f23b17a9
Merge pull request #32404 from nextcloud/debt/noid/psalm-warning-iaddressbook
[Psalm] Drop redundanten return comment
2022-05-17 14:17:43 +02:00
John Molakvoæ
9e18a3be2d
Merge pull request #32405 from nextcloud/debt/noid/psalm-warning-isearchrequest 2022-05-17 08:29:32 +02:00
Thomas Citharel
4d26a9afa0
Allow to tweak default scopes for accounts
Close #6582

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-05-16 22:54:51 +02:00
Carl Schwan
53169890d6 Fix psalm errors fron the end of the baseline file
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-16 10:58:26 +02:00
Daniel Kesselberg
00b9e576b4
Fix spelling for PreConditionNotMetException
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-05-15 22:05:55 +02:00
Daniel Kesselberg
f43df2b917
Fix spelling for return type
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-05-15 22:03:28 +02:00
Daniel Kesselberg
c65952a5e8
Drop redundanten return comment
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-05-15 21:57:50 +02:00
John Molakvoæ
85758a4f70
Merge pull request #31662 from nextcloud/modernize-contactmenu 2022-05-13 20:14:31 +02:00
John Molakvoæ
20a648ed95
Merge pull request #32384 from nextcloud/improve-psalm-server-get 2022-05-13 20:13:58 +02:00
Carl Schwan
7f899b3bc8 Improve psalm annotation to make it stricter
Now using class-string<T> as input will only return T, and any other
string will return mixed

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-13 16:14:01 +02:00
Daniel Kesselberg
7cd356ee7d
Fix psalm warning for zip response due wrong type
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-05-13 15:50:26 +02:00
Carl Schwan
23771f0587
Merge pull request #32077 from nextcloud/cleanup/lock
Cleanup lock related code
2022-05-12 20:57:38 +02:00
Thomas Citharel
232322fe06
Modernize contacts menu
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-05-12 18:31:59 +02:00
Carl Schwan
fcae6a68c3 Cleanup lock related code
- Port to QueryBuilder
- Improve the doc a bit
- Add type hinting

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-12 15:09:58 +02:00
Joas Schilling
7d218bfb0a
Merge pull request #32344 from nextcloud/fix/always-free-db-result-qbmapper-find-entities
Always free the DB result in QBMapper::findEntities
2022-05-12 11:05:03 +02:00
Julius Härtl
9a6869943e
Introduce event for loading additional script on projects
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-05-12 10:50:13 +02:00
Carl Schwan
fc1db22629
Merge pull request #32339 from nextcloud/appdatafactory-public
Make it possible to get the appdata folder using the public API
2022-05-12 10:45:38 +02:00
Christoph Wurst
1cd05a06fa
Always free the DB result in QBMapper::findEntities
Without this patch it only happened if the code ran through without any
errors. Now the result is also freed in the case of an error.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-05-12 09:51:37 +02:00
Carl Schwan
a392cd70fb Make it possible to get the appdata folder using the public API
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-11 23:28:37 +02:00
Joas Schilling
d18a293ee5
Add talk-poll to the ROS definitions
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-11 14:37:26 +02:00
Carl Schwan
da64a3a7e8
Merge pull request #31900 from nextcloud/feat/server-container-public
Add a public replacement for OC::$server->get
2022-05-10 23:23:06 +02:00
Carl Schwan
f945c0cbc6 Add a public replacement for OC::$server->get
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-10 18:51:12 +02:00
Vincent Petry
7718c9776c
Merge pull request #32113 from nextcloud/bugfix/noid/fix-csp-merging-bools
Add CSP policy merge priority for booleans
2022-05-05 17:26:48 +02:00
Louis
7ccfddbe64
Merge pull request #31963 from nextcloud/feat/use_setting_in_dav_search
Use share setting in DAV search
2022-05-04 13:38:03 +02:00
Joas Schilling
902476fa20
Extract the EmojiService from user status and add an OCP interface
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-28 07:09:44 -03:00