Carl Schwan
aeecb72e96
Fix a few psalm issues and moved back to psalm/phar 4.18
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-12 20:03:06 +01:00
MichaIng
79cdb565dc
Avoid zero division in setup checks
...
Fixes: https://github.com/nextcloud/server/issues/30532
Signed-off-by: MichaIng <micha@dietpi.com>
2022-01-11 10:26:57 +00:00
MichaIng
82c1beaacb
Enhance and complement OPcache setup checks
...
The current OPcache recommendations match the PHP defaults, but the values are much higher than required to run Nextcloud, even with a high number of installed apps. On the other hand, when other applications use the same OPcache instance, the recommended values might not be sufficient. Accurate recommendations need to take into account actual OPcache usage.
With this commit, recommendations are shown to raise the config value if more than 90% of max cache size or number of keys is used.
The checks whether the module is loaded and whether the OPcache is properly configured have been merged into a single function. This allowed to reduce the overhead of OPcache configuration checks when the module is not loaded.
A check has been added whether Nextcloud is permitted to use the OPcache API. Without this, inconsistencies during core or app upgrades may cause errors and OPcache usage cannot be determined for the new usage based checks.
OPcache usage based checks are skipped when Nextcloud is not permitted to use the API.
Signed-off-by: MichaIng <micha@dietpi.com>
2021-12-19 23:38:21 +01:00
Joas Schilling
19d070850b
Make sure trusted_proxies is an array
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 15:13:24 +01:00
Christopher Ng
50a6612c1f
Refine profile backend for frontend visibility requirements
...
- Provide metadata
- Dynamic displayId
- Add appId
- Filter out unused parameter config properties from the existing profile config
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-11-04 00:17:29 +00:00
Vitor Mattos
6f7ca3432c
show warning on personal settings page
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2021-10-23 00:54:51 +02:00
Vitor Mattos
e55ceb2bb1
Show warning on admin settings page
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2021-10-23 00:54:50 +02:00
John Molakvoæ
b2c32b7e6c
Merge pull request #27731 from ZitronePlus/master
2021-10-22 12:04:07 +02:00
John Molakvoæ
c98039c1df
Merge pull request #26725 from nextcloud/fix-federated-scope-not-shown-when-public-addressbook-upload-is-disabled
2021-10-22 11:52:56 +02:00
Julien Veyssier
0bef570fe9
Merge pull request #29256 from nextcloud/fix/noid/harmonize-appstoreenabled-check
...
Fix appstoreenabled check
2021-10-21 12:42:14 +02:00
Pytal
f7b3d521f8
Merge pull request #28751 from nextcloud/feat/28139/profile-page
2021-10-18 23:03:58 -07:00
Christopher Ng
309354852f
Profile backend
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-10-19 04:59:35 +00:00
Christoph Wurst
f432dd2e2e
Add scheduling availability settings
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-18 20:21:51 +02:00
Julien Veyssier
facb50ebcc
fix appstoreenabled check in Fetcher so it's coherent with AppSettingsController
...
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2021-10-18 12:39:43 +02:00
Christoph Wurst
4b8f8c5203
Deprecate PHP7.3 for Nextcloud 23
...
* 7.3 reaches EOL shortly after the release of 23.0.0
* Nextcloud 24 will require PHP7.4
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-18 09:15:54 +02:00
Bjoern Schiessle
664bd5802f
add 'supported'-label to all supported apps, also if they are not downloaded yet
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2021-10-06 22:17:50 +02:00
Joas Schilling
0dae8805c2
Improve icon and section title of "Admin privileges"
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2021-10-06 19:13:16 +02:00
Carl Schwan
6958d8005a
Add admin privilege delegation for admin settings
...
This makes it possible for selected groups to access some settings
pages.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-09-29 21:43:31 +02:00
szaimen
d253d52007
Merge pull request #28837 from nextcloud/show-warning-if-sharing-app-disabled
...
Show warning on the share settings when the File Shares app is disabled
2021-09-20 12:11:42 +02:00
szaimen
3eb1d23720
Merge pull request #28838 from stefan-schilling/enh/16719-integrity-check-temp-dir
...
Issue 16719: CheckSetupController.php now checks configured temporary directory for existence and if it's writable
2021-09-17 18:19:22 +02:00
Stefan
eb46011680
Issue 16719: CheckSetupController.php: now injecting reference to ITempManager, rather than obtaining using it manually
...
Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>
2021-09-17 13:32:42 +02:00
Stefan
8758b36ebb
Issue 16719: CheckSetupController.php now checks configured temporary directory for existence and if it's writable
...
Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>
2021-09-17 13:32:42 +02:00
Thomas Citharel
b3c7927260
Show warning on the share settings when the File Shares app is disabled
...
Closes #3706
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2021-09-15 16:33:03 +02:00
Arthur Schiwon
d93e2548f0
only offer to set locally verified mails as primary
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-15 15:38:49 +02:00
Arthur Schiwon
fe5e672654
let user choose notification email in user settings
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-15 15:38:40 +02:00
Arthur Schiwon
27865d03c0
use specific email getter where necessary
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 19:23:05 +02:00
Christoph Wurst
506b411dfc
Merge pull request #28332 from nextcloud/work/carl/argon2i2
...
Only recommand for php-sodium on >= PHP 7.4
2021-08-31 08:59:27 +02:00
Christopher Ng
cc5815dcd0
Provide initial state
...
- camelCase language strings
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-08-27 05:06:12 +00:00
Christopher Ng
d4d59493a2
Provide initial state
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-08-23 21:29:47 +00:00
Daniel Calviño Sánchez
1e19b1cc99
Hide "federated" scope when Federation app is disabled
...
If the Federation app is disabled it is not possible to synchronize the
users from a different server.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-08-18 19:56:10 +02:00
Julius Härtl
f49a751283
Do not retain VerifyUserData job when lookup server is not available
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-08-17 11:39:24 +02:00
Carl Schwan
07ccccecad
Only recommand for php-sodium on >= PHP 7.4
...
This is because php-sodium will solve the missing PASSWORD_ARGON2I
constant problem only on >= php 7.4, previously argon2 wasn't part of
the standard extension and was disabled on Centos/RHEL.
So installing php-sodium on php 7.2 for example wouldn't hide the
message. Tested on Fedora with php 7.4, Centos 7 with php 7.2,
Centos 8 with php 7.2 and openSUSE with php 7.4.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-08-06 14:22:09 +02:00
Christoph Wurst
43e41ca532
Merge pull request #28259 from nextcloud/work/carl/sodium-check
...
Check that php was compiled with argon2 support or that the php-sodium extensions is installed
2021-07-30 17:34:10 +02:00
Carl Schwan
8e51a5feda
Check that php was compiled with argon2 support or that the php-sodium
...
extensions is installed
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-07-30 15:11:55 +02:00
Julien Veyssier
416d10f76c
refs #21045 add app config to disable unlimited quota and to set max quota
...
avoid unlimited quota as default_quota fallback value if unlimited quota is not allowed
avoid getting/setting/displaying unlimited default quota if not allowed
implement tests for unlimited quota restrictions
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-29 19:31:36 +00:00
Marco Ambrosini
a4d1c55624
Allow to disable group change notification
...
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
2021-07-28 12:23:47 +02:00
Joas Schilling
f86f594a3a
Merge pull request #27860 from J0WI/alphanumeric-rnd
...
Introduce ISecureRandom::CHAR_ALPHANUMERIC
2021-07-16 12:46:20 +02:00
Christopher Ng
74aa115125
Refine unsupported federation scope checks
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-07-16 05:46:04 +00:00
Christopher Ng
ef41d5977a
Provide initial state
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-07-15 10:16:06 +02:00
J0WI
3b656446af
Introduce ISecureRandom::CHAR_ALPHANUMERIC
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-07-08 15:11:31 +02:00
Gary Kim
b78f3a57d1
Migrate HintException to OCP
...
Signed-off-by: Gary Kim <gary@garykim.dev>
2021-06-30 15:28:02 -04:00
ZitronePlus
1d0a40a4a6
Fix for #26526
...
fix for sql query
replaced double quotes with single quotes.
Query should now also work for dbs with sql_mode including "ANSI" and "ANSI_QUOTES"
2021-06-30 14:52:48 +02:00
Lukas Reschke
25ab4059c6
Add security.txt
...
Ref https://securitytxt.org
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-06-23 13:58:47 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +02:00
Valdnet
9c6b01abeb
l10n: Spelling unification
...
Spelling unification in Transifex.
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-06-02 17:49:32 +02:00
Arthur Schiwon
847ed37afc
do not use private AccountManager in UsersController
...
- extends IAccountProperty for verificationData getters and setters
- implementation thereof ^
- and of course adaption of UsersController
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-25 14:35:38 +02:00
Morris Jobke
f1dbabd910
Merge pull request #26727 from nextcloud/group-exclude-link-share
...
Add option to exclude groups from creating link shares
2021-05-21 15:35:39 +02:00
Roeland Jago Douma
4a2775a442
Harden apptoken check
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-05-17 16:05:45 +02:00
blizzz
b8b2e796bf
Merge pull request #26959 from nextcloud/techdebt/noid/verifiyuserdata-iaccountmanager
...
VerifyUserData shall use IAccountManager, not private API
2021-05-12 23:35:39 +02:00
Arthur Schiwon
9977027321
VerifyUserData shall use IAccountManager, not private API
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-12 22:57:20 +02:00
Arthur Schiwon
a49588bbe5
PersonalInfo settings to use public AccoutManager API
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-12 22:55:34 +02:00
Robin Appelman
0e6321957d
allow excluding groups from creating link shares
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-05-12 16:11:31 +02:00
Joas Schilling
aa651fd629
Merge pull request #26259 from nextcloud/feature/noid/validate-website-to-be-valid
...
Validate the website field input to be a valid URL
2021-04-26 13:56:01 +02:00
Daniel Calviño Sánchez
67dd087ce4
Fix deleting properties of user settings when not given explicitly
...
The controller can receive an optional subset of the properties of the
user settings; values not given are set to "null" by default. However,
those null values overwrote the previously existing values, so in
practice any value not given was deleted from the user settings. Now
only non null values overwrite the previous values.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +02:00
Daniel Calviño Sánchez
ac0c18327e
Fix TypeError when "email" is not given in the controller request
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +02:00
Daniel Calviño Sánchez
a7431817b9
Respect additional user settings not covered by the controller
...
"AccountManager::updateUser()" wipes previous user data with whichever
user data is given (except for some adjustments, like resetting the
verified status when needed). As the controller overrode the properties
those properties would lose some of their attributes even if they are
not affected by the changes made by the controller. Now the controller
only modifies the attributes set ("value" and "scope") to prevent that.
Note that with this change the controller no longer removes the
"verified" status, but this is not a problem because, as mentioned,
"AccountManager::updateUser()" resets them when needed (for example,
when the value of the website property changes).
This change is a previous step to fix overwritting properties with null
values, and it will prevent the controller from making unexpected
changes if more attributes are added in the future.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +02:00
Daniel Calviño Sánchez
8cae515daa
Use constants from interface rather than class
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:40 +02:00
Joas Schilling
d80cc76ee7
Validate the website field input to be a valid URL
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-22 16:34:13 +02:00
Morris Jobke
3e7f7e5f9b
Merge pull request #26474 from nextcloud/caugner-patch-mariadb-in-mysql-support-warning
...
Mention MariaDB in MySQL support warning
2021-04-21 16:26:37 +02:00
Vincent Petry
af61486aea
Separate settings for remote share expiration
...
Added separate settings for default and enforced expiration date for
remote shares.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:06:09 +02:00
Claas Augner
17963ea089
Mention MariaDB in MySQL support warning
2021-04-09 12:31:16 +02:00
Roeland Jago Douma
bd2e6309b5
Merge pull request #25605 from nextcloud/trusted-proxy-warning-localhost
...
dont show trusted proxy warning when the proxy and remote are both localhost
2021-04-01 13:27:26 +02:00
Vincent Petry
5d14fd4396
Make extra user profile fields always editable
...
The fields for phone number, address, website and twitter are now
editable regardless whether federated sharing and the lookup server
are enabled or not.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +01:00
Vincent Petry
278a73789e
Map old account scope properties to new names
...
Use new scope values in settings page.
Adjust all consumers to use the new constants.
Map old scope values to new ones in account property getter.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +01:00
Joas Schilling
61ed57b757
Rename some parameters and methods to make the API more clear
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 20:30:29 +01:00
Joas Schilling
07095fd122
Also clear the knownUser when changing via the settings endpoint
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 19:37:10 +01:00
Joas Schilling
5b53b6f977
Add a setting to restrict returning a full match unless in phonebook or same group
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:25:57 +01:00
Joas Schilling
b71268e38b
Add a config setting to restrict autocompletion to phonebook matches
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:19:55 +01:00
Roeland Jago Douma
e44be839bb
Fix some types in the Settings Personal pages
...
* Fix types
* Typed the code
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-08 11:05:41 +01:00
Joas Schilling
f92d21e80e
Merge pull request #25870 from nextcloud/techdept/settings/move_group_activity_events
...
Move group activities to events
2021-03-05 13:05:06 +01:00
Roeland Jago Douma
f492a6aac3
Move group activities to events
...
Use the fancy events.
Nicer code
Nicely isolated code
win-win
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-03 11:33:33 +01:00
Roeland Jago Douma
bc961baa40
Move some settings over to the IInitialState
...
The old one has been deprecated. Part one of many.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 21:11:56 +01:00
Roeland Jago Douma
2afa1c5739
Merge pull request #25862 from nextcloud/techdept/psalm/some_loggers
...
Move away some ILoggers
2021-03-02 15:01:44 +01:00
Lukas Reschke
41dc18342f
Merge pull request #25854 from nextcloud/techdept/psalm/checksetupcontroller
...
Fix lying docblocks
2021-03-02 13:33:21 +01:00
Roeland Jago Douma
38f761f25f
Move away some ILoggers
...
Makes psalm happier
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 10:47:25 +01:00
Christoph Wurst
7be2ce82e7
Merge pull request #25544 from nextcloud/refactor/app-password-created-event
...
Move app_password_created to a typed event
2021-03-02 08:18:59 +01:00
Roeland Jago Douma
3d0dff0d2b
Fix lying docblocks
...
* typed the return
* removed unneeded temp variable
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-01 16:48:04 +01:00
dependabot-preview[bot]
eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0
...
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard ) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases )
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md )
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-18 13:31:24 +01:00
Roeland Jago Douma
bd8b1786c5
Some psalm fixes in the settings app
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-15 10:00:35 +01:00
Roeland Jago Douma
7d8e9baa77
Revert "use the configured forwarded headers for the setup check"
2021-02-13 18:03:32 +01:00
Robin Appelman
01118a2218
use the configured forwarded headers for the setup check
...
instead of always checking against the same header
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-12 14:22:27 +01:00
Robin Appelman
cc0cc68c8d
dont show trusted proxy warning when the proxy and remote are both localhost
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-12 13:32:51 +01:00
Christoph Wurst
f8808e260d
Move app_password_created to a typed event
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-09 18:49:35 +01:00
Christoph Wurst
378f116a63
Do not show 2FA settings if the user has no providers available
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-22 13:55:22 +01:00
Christoph Wurst
c1d4f8161b
Migrate internal classes to the OCP db col types
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-12 14:09:13 +01:00
Vincent Petry
eeac11a687
Fix casing of MySQLPlatform class name
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-01-12 09:39:59 +01:00
Roeland Jago Douma
6c8f2dc7bc
Merge pull request #25016 from nextcloud/enh/noid/add-check-for-unsupported-db
...
Add setup check to verify that the used DB version is still supported…
2021-01-11 14:21:42 +01:00
Morris Jobke
24d436cb60
Remove unneeded casts that were found by Psalm
...
In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see https://github.com/nextcloud/server/pull/24521 )
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-11 13:14:41 +01:00
Morris Jobke
bffa61fc32
Add setup check to verify that the used DB version is still supported in the next major release
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-08 13:38:32 +01:00
Christoph Wurst
8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-08 11:45:19 +01:00
Julius Härtl
068e3b2c1e
Set the user language when adding the footer
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-07 15:31:55 +01:00
Julius Härtl
abfb72378f
Hide client link in welcome mail if an empty customclient_desktop config is set
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-07 10:45:54 +01:00
Christoph Wurst
90d0732828
Fix updating user settings
...
The requests dispatched from the personal settings page don't always
send all the possible params but just a subset. Hence requests currently
fail on master e.g. when you update your email. This makes the arguments
optional again.
Regression of da9462b482
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-05 12:59:50 +01:00
Christoph Wurst
9ce3ea3368
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-30 14:07:05 +01:00
Roeland Jago Douma
adc4f1a811
Merge pull request #22916 from J0WI/unifiy-links-to-php.net
...
Unify links to php.net
2020-12-22 09:53:31 +01:00
Christoph Wurst
f37e150d1c
Merge pull request #24702 from nextcloud/enhancement/well-known-handler-api
...
Add well known handlers API
2020-12-18 13:34:04 +01:00
Christoph Wurst
d89a75be0b
Update all license headers for Nextcloud 21
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 18:48:22 +01:00
Christoph Wurst
6995223b1e
Add well known handlers API
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 13:13:05 +01:00
Joas Schilling
96253c7c1b
Add missing parent::__construct() calls to Jobs
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-14 16:35:12 +01:00
Julius Härtl
a0444bc69c
Merge pull request #24247 from nextcloud/bugfix/noid/ocm-providerId-string
2020-12-09 17:25:59 +01:00