upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-20 00:12:30 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 38
84882 commits 679 branches 1186 tags 6.6 GiB
Commit graph

101 commits

Author SHA1 Message Date
Julius Knorr
a45f4b0cdc
fix: Fix setting name inconsistency between backend and frontend 
Signed-off-by: Julius Knorr <jus@bitgrid.net>
 2025-12-12 13:08:34 +01:00
nfebe
40246d9a19 fix(sharing): Add isTrustedServer flag to lookup results 
When `show_federated_shares_to_trusted_servers_as_internal` is enabled,
lookup server results were being filtered out because they lacked the
`isTrustedServer` flag. This adds the flag to lookup results by:

- Injecting TrustedServers service into LookupPlugin
- Adding `server` and `isTrustedServer` fields to each lookup result
- Updating tests to reflect new structure

This ensures lookup results from trusted servers appear in internal
sharing while non-trusted servers are correctly filtered out.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
 2025-11-24 23:32:40 +01:00
Carl Schwan
503a65ddd0 refactor: Run rector 
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
 2025-11-18 17:45:54 +01:00
Daniel Calviño Sánchez
c40fcba5a4 fix: Fix user collaborators returned when searching for mail collaborators 
The MailPlugin collaborator returned results for both user and mail
collaborators, but it was registered only for mail collaborators. While
it might make sense to move the user results to the UserPlugin instead
that change would be more complex and riskier, so for now the MailPlugin
is now registered for both user and mail collaborators and the results
are limited only to the registered type.

As the plugins are registered only with their class and then resolved
when needed using dependency injection it is not possible (as far as I
know) to provide an explicit parameter in the constructor to
differentiate whether the MailPlugin should return user or mail
collaborators. To overcome this two subclasses are introduced,
MailByMailPlugin and UserByMailPlugin, which just hardcode in their
constructor the collaborator type that their parent MailPlugin must use,
and those subclasses are the ones registered instead of the MailPlugin
(which still contains all the logic).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2025-11-11 01:20:17 +01:00
Daniel Calviño Sánchez
2c841b2337 test: Rename data providers to match the name of their tests 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2025-11-11 00:54:39 +01:00
Daniel Calviño Sánchez
74fd144003 test: Replace magic value with named constant of share type 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2025-11-11 00:54:39 +01:00
Daniel Calviño Sánchez
a0e8d943f1 test: Rename parameters to show that they are expected values 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2025-11-11 00:54:38 +01:00
Daniel Calviño Sánchez
45f2683a73 test: Fix parameter documentation 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2025-11-11 00:54:38 +01:00
nfebe
c9bb6eedc6 fix: Include email when searching share suggestions 
Signed-off-by: nfebe <fenn25.fn@gmail.com>
 2025-10-09 06:53:51 +01:00
nfebe
c1d9e22c51 fix(sharing): Adapt share suggestions to match trusted servers configs 
When `show_federated_shares_to_trusted_servers_as_internal` is enabled
but `show_federated_shares_as_internal` is not, filter federated share
suggestions to only include trusted servers. Previously, searching for
an email address would suggest non-trusted federated servers.

Resolved: #54511
Signed-off-by: nfebe <fenn25.fn@gmail.com>
 2025-10-09 06:53:46 +01:00
Daniel Kesselberg
83a691709c
refactor: use IEmailValidator.isValid instead of IMailer.validateEmailAddress 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2025-10-04 21:54:22 +02:00
Côme Chilliet
5e9af71509
fix(tests): Fix UserPluginTest methods expectation 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-09-27 13:47:40 +02:00
Côme Chilliet
ac61839d1e
fix(tests): Fix PHPUnit deprecation warnings in tests 
Turn data providers into static methods, mostly.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-09-27 13:05:32 +02:00
Ferdinand Thiessen
66eb021ece
refactor: remove duplicated types and add return types 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-07-23 15:59:26 +02:00
Robin Appelman
aa15f9d16d
chore: run rector 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-07-01 22:45:52 +02:00
Ferdinand Thiessen
5981b7eb51
chore: apply new CSFixer rules 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

# Conflicts:
#	apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
 2025-07-01 16:26:50 +02:00
Robin Appelman
29e39c0a2e
chore: run rector on tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-06-12 18:31:58 +02:00
Joas Schilling
3e7db013c1
test: Fix non-static data providers 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-05-15 08:25:01 +02:00
Joas Schilling
c24f5fb256
test: Finish migrating tests/Core/ to PHPUnit 10 compatible code 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-05-02 16:47:42 +02:00
Joas Schilling
b77011a918
test: Prepare more tests for PHPUnit 10 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-04-30 09:18:01 +02:00
Julius Knorr
46f531adec test: Adapt tests to properly use valid email addresses 
Signed-off-by: Julius Knorr <jus@bitgrid.net>
 2025-03-26 11:51:52 +01:00
Ferdinand Thiessen
00d08a4f69
fix(lookup-server): disable lookup server for non-global scale setups 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-03-11 14:26:47 +01:00
Ferdinand Thiessen
34251c4375
fix(lookup-server): do not query data by default 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-03-11 14:26:47 +01:00
provokateurin
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-19 14:21:20 +02:00
Ferdinand Thiessen
44c7248749
refactor(Collaboration): Use non-deprecated methods 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-19 00:35:20 +02:00
Christoph Wurst
49dd79eabb
refactor: Add void return type to PHPUnit test methods 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2024-09-15 22:32:31 +02:00
Daniel Kesselberg
af6de04e9e
style: update codestyle for coding-standard 1.2.3 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2024-08-25 19:34:58 +02:00
Joas Schilling
280d70a5f4
fix(federation): Fix missing protocol on CloudID remote 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-06-27 11:26:08 +02:00
Andy Scherzinger
1f7e2ba599
chore: Add SPDX header 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2024-05-13 17:41:36 +02:00
Joas Schilling
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-11-23 10:36:13 +01:00
Côme Chilliet
8d5165e8dc
Adapt tests to config value typing 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-05 17:42:14 +02:00
Côme Chilliet
f5c361cf44
composer run cs:fix 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-20 11:45:08 +01:00
Robin Appelman
1626a56dda
adjusts tests for CloudIdManager 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-08-31 15:47:00 +02:00
Louis Chemineau
347ca20f4e Rename setting name to reduce its length 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2022-06-27 11:04:17 +02:00
Côme Chilliet
c7e1c36362
Remove at matcher uses in tests/lib 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-06-16 17:43:17 +02:00
Vincent Petry
cd95fce105
Merge pull request #31932 from nextcloud/feat/ignore_second_dn 
Add settings to ignore second display name in search
 2022-04-13 09:52:38 +02:00
Louis Chemineau
37f1c8640e Add settings to ignore second display name in search 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2022-04-12 17:27:59 +02:00
Maxence Lange
10eafd70c8 confirm user is internal to globalscale 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2022-04-12 09:11:05 -01:00
Carl Schwan
7ecb65f725
Add check before sending email that email address is valid 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-01-11 20:59:44 +01:00
Julius Härtl
2fe8042fff
Add integration tests for email completion 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-12-08 09:08:54 +01:00
Julius Härtl
7179002600
Allow to get a local cloud id without going through the contacts manager 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-07-14 16:08:05 +02:00
Joas Schilling
181aab416a
Fix warnings about logException 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-06-04 10:57:09 +02:00
Thomas Citharel
1c0d975654
Make dav respect disallowing sharing with groups 
Closes #25390

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2021-05-26 11:19:59 +02:00
Joas Schilling
df47445c01
Fix unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-04-27 14:34:32 +02:00
blizzz
92ca49d21d
save a whitespace today 
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-04-20 14:03:01 +02:00
Arthur Schiwon
f8d1ee5cfa
ignore mail shares of related remote share results 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-04-20 14:02:35 +02:00
Roeland Jago Douma
b5ffca00f7 Fix unit test 
* Fix namespace
* Fix test

Was broken after https://github.com/nextcloud/server/pull/26529

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-04-16 09:47:52 +02:00
Joas Schilling
cf434d5107
Also limit to user group in case enumeration is enabled for groups and phonenumbers 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-17 11:20:30 +01:00
Joas Schilling
9a189bc710
Improve search results when only phonebook-matches can we autocompleted 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-17 09:51:31 +01:00
Joas Schilling
236aa194e2
Restrict autocompletion also based on the phonebook known users 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-10 17:19:55 +01:00