upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-12 10:10:49 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 20
62919 commits 1040 branches 1221 tags 8.4 GiB
Commit graph

20560 commits

Author SHA1 Message Date
Christoph Wurst
92d64617e6
Merge pull request #26582 from nextcloud/enhancement/logger-function 
Add a helper function that makes it easier to log from anywhere
 2022-06-07 11:22:26 +02:00
Joas Schilling
6d5d91f6f9
Merge pull request #32556 from nextcloud/bugfix/noid/fix-comments-query-handling 
Create query parameters on correct objects to make debugging easier
 2022-06-03 15:31:40 +02:00
Joas Schilling
8e59d49701
Merge pull request #32435 from nextcloud/revert-32278-remove-default-php 
Revert "Remove call to already default php.ini values"
 2022-06-03 14:16:24 +02:00
Julius Härtl
0f0e74a78c Cleanup temporary files after finishing the write to object storage 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-06-02 12:57:18 +00:00
blizzz
1d1b9d936b
Merge pull request #32690 from nextcloud/bugfix/noid/fix-mountpoint-matching-encryption 
Trim mount point before matching in encryption code
 2022-06-02 13:47:18 +02:00
Christopher Ng
57c66bf7cb Use Image class from public API 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2022-06-02 00:37:36 +00:00
Vincent Petry
a704bcf97f
Trim mount point before matching in encryption code 
Often times the mount point has a leading slash.
This fix sanitizes it to make sure matching works.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-06-01 18:10:59 +02:00
Nextcloud bot
e6177afeda
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-06-01 02:32:26 +00:00
Christoph Wurst
b17c4a6072 Check background job type 
It is assumed that a job class loaded from the jobs table is an IJob,
but due to programming error the job might be of another type. Then the
setters will most likely fail.

This patch adds an interface type check so only correct jobs are used,
anything else is ignored.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2022-05-31 15:24:30 +00:00
blizzz
df89e7fd39
Merge pull request #32485 from nextcloud/debt/noid/psalm-streamer-fh 
[Psalm] Fix docblock for addFileFromStream
 2022-05-31 14:22:05 +02:00
Joas Schilling
279e06a80f
Merge pull request #32587 from nextcloud/bugfix/noid/improve-jsconfighelper 
Improve JSConfigHelper code quality a bit
 2022-05-31 10:29:30 +02:00
Joas Schilling
cf9660fdf0
Merge pull request #32628 from nextcloud/bugfix/noid/json-throw 
Use JSON_THROW_ON_ERROR instead of custom error handling
 2022-05-31 10:06:21 +02:00
Nextcloud bot
016895d539
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-31 02:33:09 +00:00
Pytal
4873faa951
Merge pull request #32206 from nextcloud/enh/migrator-add-estimatedsize-getter 2022-05-30 17:16:33 -07:00
Côme Chilliet
fa041dabf4 Add the ISizeEstimationMigrator interface for method getExportEstimatedSize 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-05-30 17:49:05 +00:00
Julius Härtl
3901a93c72
Use JSON_THROW_ON_ERROR instead of custom error handling 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-05-30 19:17:49 +02:00
Côme Chilliet
7140201a32
Merge pull request #32634 from nextcloud/debt/noid/psalm-moveable-mount 
[Psalm] Fix docblock for return type
 2022-05-30 17:05:50 +02:00
Carl Schwan
1164c762eb
Merge pull request #31948 from nextcloud/core-cleanup-74 
Update core to PHP 7.4 standard
 2022-05-30 14:37:37 +02:00
Carl Schwan
e86bcc8953
Merge pull request #32655 from nextcloud/fix/handle-non-existing-settings 
Handle non existing settings again
 2022-05-30 12:53:36 +02:00
Joas Schilling
f9efc410fa
Restore old behaviour of sending flase for not found apps 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-05-30 12:41:35 +02:00
Joas Schilling
eb1a69d627
Improve JSConfigHelper code quality a bit 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-05-30 12:33:45 +02:00
Carl Schwan
63f589109b Handle non existing settings again 
See https://github.com/nextcloud/server/pull/28189#issuecomment-1140874991

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-30 11:06:55 +02:00
Côme Chilliet
09917b8583 Implement getExportEstimatedSize in migrators 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-05-30 07:36:13 +00:00
Côme Chilliet
f20b7e5764 Add a method to get estimated export size in IMigrator 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-05-30 07:36:13 +00:00
Nextcloud bot
5a12e8f906
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-29 02:33:23 +00:00
Daniel Kesselberg
f399fd41ec
Fix docblock for return type 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2022-05-27 20:05:46 +02:00
Carl Schwan
e4378fd18c
Merge pull request #32349 from nextcloud/enh/projects-event 
Add event to load additional scripts for projects
 2022-05-27 18:36:40 +02:00
Julius Härtl
ac79137816
Merge pull request #32592 from nextcloud/fix/noid/allow-rememberme-token-apache-auth-backend 
allow use of rememberme cookies for IApacheAuth backends
 2022-05-27 17:21:08 +02:00
Git'Fellow
8d876358dd
Move Gd failed operations to debug level 
Instead of error
 2022-05-25 18:26:42 +02:00
Arthur Schiwon
a4a9e7601a
allow use of rememberme cookies for IApacheAuth backends 
- e.g. enables it for SAML backend

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2022-05-25 13:09:06 +02:00
Nextcloud bot
d32f683ad6
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-25 02:36:02 +00:00
Daniel Kesselberg
be99ea969e
Fix type for resource 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2022-05-24 22:05:59 +02:00
Daniel Kesselberg
95ec67ecd7
Fix docblock for addFileFromStream 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2022-05-24 22:05:59 +02:00
Côme Chilliet
45a75c631e
Merge pull request #32555 from nextcloud/fix/revert-api-break 
Revert api break
 2022-05-24 09:06:00 +02:00
Joas Schilling
53af533853
Merge pull request #32560 from nextcloud/feature/noid/preferences-api 
Add API to change preferences
 2022-05-24 07:58:00 +02:00
Carl Schwan
6147bb611c
Revert api break 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-24 06:59:40 +02:00
Joas Schilling
1d14f08b56
Merge pull request #32554 from nextcloud/followup/32378/adjust-docs-on-interface 
Adjust docs to the same as the implementation
 2022-05-24 06:52:53 +02:00
Nextcloud bot
17bdfb1284
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-24 02:32:52 +00:00
Joas Schilling
31dc9aa682
Add API to change preferences 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-05-23 16:44:23 +02:00
Joas Schilling
5b82ad0b30
Create query parameters on correct objects to make debugging easier 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-05-23 13:02:36 +02:00
Joas Schilling
be4faebc47
Adjust docs to the same as the implementation 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-05-23 12:56:47 +02:00
Carl Schwan
8d599c3410
Merge pull request #32378 from nextcloud/fix/psalm-userbackend 
Fix psalm issues related to the user backend
 2022-05-23 11:41:21 +02:00
Christoph Wurst
450136b7cf
Add a helper function that makes it easier to log from anywhere 
Our DI is able to inject a logger implementation to any server and app
class if they want one. However, sometimes DI isn't applicable or hard
to add. In those cases we typically fell back to the *service locator*
pattern where we acquired a logger from the server via a global
variable.

There were some issues with that
* `\OC` is a private class, apps are not supposed to use it
* `\OC::$server` is a global variable, a well known anti-pattern
* `\OC::$server->get(...)` uses the service locator anti-pattern
* `\OC::$server->get(...)` may throw
* `\OC::$server->get(LoggerInterface::class)` is not scoped to an app

With this patch I'm proposing a new helper function ``\OCP\Log\logger``
that can be used to acquire a logger more easily. This function is meant
to be public API and therefore apps may use it and there is an optional
parameter to specifiy the app ID.
The function hides all the ugly details about the global variable and
the potentially thrown exceptions from the user. Therefore it's
guaranteed that you always get a logger instance. In the worst case you
get a noop, though those occasions should be rare.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2022-05-23 09:53:38 +02:00
Nextcloud bot
74d81655e8
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-05-23 02:31:03 +00:00
Carl Schwan
b70c6a128f Update core to PHP 7.4 standard 
- Typed properties
- Port to LoggerInterface

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-20 22:18:06 +02:00
Carl Schwan
d90583ca28
Merge pull request #32486 from nextcloud/debt/noid/psalm-username 
[Psalm] Rename $userName to $username  to align with child classes
 2022-05-20 18:19:53 +02:00
Carl Schwan
9ec0cb0a90 Fix psalm issues related to the user backend 
- Reflect the actual return value returned by the implementation in the
  the interface. E.g. IUser|bool -> IUser|false
- Remove $hasLoggedIn parameter from private countUser implementation.
  Replace the two call with the equivalent countSeenUser
- getBackend is nuallable, add this to the interface
- Use backend interface to make psalm happy about call to undefined
  methods. Also helps with getting rid at some point of the old
  implementActions

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-20 17:14:58 +02:00
Joas Schilling
ad908cd87a
Make appName of TemplateResponse accessible in BeforeTemplateRenderedEvent 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-05-20 15:03:40 +02:00
Joas Schilling
bc82fa48d1
Merge pull request #32406 from nextcloud/debt/noid/psalm-warning-idbconnection 
[Psalm] Fix spelling for PreConditionNotMetException
 2022-05-20 14:32:33 +02:00
John Molakvoæ
87ce03db1a
Merge pull request #32410 from nextcloud/bugfix/noid/imaginary-exception 2022-05-20 08:14:17 +02:00