upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-22 14:50:17 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 53
79508 commits 888 branches 1195 tags 8.3 GiB
Commit graph

15399 commits

Author SHA1 Message Date
Ferdinand Thiessen
324582729a
fix(lookup-server): disable lookup server for non-global scale setups 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-03-11 21:54:06 +01:00
Ferdinand Thiessen
aa7300b53d
fix(lookup-server): do not query data by default 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-03-11 21:39:33 +01:00
skjnldsv
f00d596b8c fix(systemtags): prevent tag edition if restricted 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

[skip ci]
 2025-03-06 15:11:51 +00:00
Louis Chemineau
fb41438db1 fix(login): Properly target public page with attribute 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-03-05 17:02:26 +00:00
Andy Scherzinger
5c0babe27b
Merge pull request #51251 from nextcloud/backport/50989/stable31 
[stable31] fix: Use case insensitive check when validating login name
 2025-03-05 17:47:50 +01:00
Marcel Müller
44e89610ed fix: No IFactory in constructor 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
 2025-03-05 11:34:02 +00:00
Joas Schilling
93f039fb96 fix(files): Don't do session related work in the constructor of the View 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-03-05 11:34:02 +00:00
Cleopatra Enjeck M.
0535716391 fix: use mb_strtolower to convert login name 
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
 2025-03-05 06:20:07 +00:00
Cleopatra Enjeck M.
90f83ac234 fix: Improve string comparison 
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
 2025-03-05 06:20:07 +00:00
Cleopatra Enjeck M.
449676be7c fix: Use case insensitive check when validating login name 
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
 2025-03-05 06:20:07 +00:00
Robin Appelman
0ae944db2c feat: log query for dbal exceptions 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-03-04 15:33:54 +00:00
Andy Scherzinger
eb250fae02
Merge pull request #51197 from nextcloud/fix/51022/simpler-request-pre-upgrade 
[stable31] fix(userconfig): simpler db request pre-upgrade
 2025-03-04 13:11:20 +01:00
Kate
b0566ad780
Merge pull request #51203 from nextcloud/backport/51194/stable31 
[stable31] refactor(TempManager): Simplify and unify implementations and remove legacy behavior
 2025-03-04 10:16:24 +01:00
provokateurin
e8b7ddd14e
fix(Share20\Manager): Propagate user and group deletion to remote share providers 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-03-04 07:57:00 +01:00
provokateurin
64ed0c05dd
fix(Share20): Convert broken hooks to IEventListener 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-03-04 07:56:59 +01:00
Maxence Lange
1fac9cfa14 fix(userconfig): simpler db request before 31 upgrade 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2025-03-03 14:46:41 -01:00
provokateurin
b42d26b42f refactor(TempManager): Simplify and unify implementations and remove legacy behavior 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-03-03 15:25:00 +00:00
Louis
4e7a3c1f9e
Merge pull request #51090 from nextcloud/backport/51051/stable31 
[stable31] feat: Close sessions created for login flow v2
 2025-03-03 12:28:48 +01:00
Louis Chemineau
2f71b7e197
fix(login): Support subfolder install for ephemeral sessions 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-03-03 11:00:29 +01:00
Louis Chemineau
ab01b76a19
fix(login): Also check legacy annotation for ephemeral sessions 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-03-03 11:00:29 +01:00
Joas Schilling
25268f2fdf
Merge pull request #51058 from nextcloud/backport/51049/stable31 
[stable31] fix(l10n): Improve english source strings
 2025-02-27 16:51:47 +01:00
Louis Chemineau
e840ee72b2 feat: Close sessions created for login flow v2 
Sessions created during the login flow v2 should be short lived to not leave an unexpected opened session in the browser.

This commit add a property to the session object to track its origin, and will close it as soon as possible, i.e., on the first non public page request.

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-02-27 07:59:49 +00:00
Louis Chemineau
fe56b3ccc2 fix: Report duplicated extra files in integrity check 
The `array_diff` is not comparing the array keys. This means that an extra key with an expected hash will not be reported. Using `array_diff_assoc` will report such files.

For example, copying `status.php` to `status 2.php`, will only be reported with the new version.

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-02-26 13:26:38 +00:00
Joas Schilling
1a60bca362 fix(l10n): Improve english source strings 
- No leading/trailing whitespace
- Use asci single quote

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-02-26 13:08:49 +00:00
Robin Appelman
ea678c0280 feat: support migrating an instance to sharding 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-02-25 21:43:54 +00:00
Louis Chemineau
8a2437927d fix: Initialize lastConnectionCheck after first connection 
We are checking whether the DB connection is alive once every 30 seconds. But when we are lacking the last check time, we are skipping the check and reconnect logic. This is causing the reconnect logic to never fire in those cases.

It seems to me that "those cases", are actually always the case, as upon initialization, we are not using the proper connection name to store the time.

In the `connect()` logic, when `$this->_conn` is null, `$this->getConnectionName()` is returning `replica`, so `$this->lastConnectionCheck` will be equal to `['replica' => time()];`

60711ea4cf/lib/private/DB/Connection.php (L215-L221)

60711ea4cf/lib/private/DB/Connection.php (L891-L893)

2b6d7bf65f/doctrine/dbal/src/Connections/PrimaryReadReplicaConnection.php (L136-L139)

Then, if the connection name ends up as being 'primary', the reconnect logic is skipped:

60711ea4cf/lib/private/DB/Connection.php (L874-L880)

Follow-up of https://github.com/nextcloud/server/pull/41819

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-02-25 11:07:34 +00:00
Ferdinand Thiessen
06ddb7aff6 refactor: convert sanitize account properties repair step to background job 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-24 15:23:20 +00:00
Ferdinand Thiessen
29e5e8a31b fix: Optimize repair step performance 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-24 15:23:20 +00:00
Ferdinand Thiessen
e9c4c59998 fix: validate account properties as a repair step 
Replace `ValidatePhoneNumber` from Nextcloud 21 with a new repair step,
`ValidateAccountProperties` which validates and sanitizes all account
properties.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-24 15:23:20 +00:00
Côme Chilliet
a9ad23e3d8 fix: Also remove digits at the start and underscore on both ends of appid 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
 2025-02-19 18:39:20 +01:00
Côme Chilliet
adf5b72939 fix: Only keep allowed characters in appid, and flag the method as escaping 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-02-19 18:39:20 +01:00
Andy Scherzinger
08e3e213d3
Merge pull request #50797 from nextcloud/backport/50781/stable31 
[stable31] perf(files): faster query to fetch incomplete directories
 2025-02-19 18:38:21 +01:00
Joas Schilling
4b1b16430d fix(cron): Keep job class limitation when searching for the next job 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-02-19 09:28:34 +00:00
skjnldsv
0823f924c0 fix(files): properly forward open params from short urls 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2025-02-18 12:42:23 +00:00
Git'Fellow
361a6757b1 fix(repair): PHP8.3 deprecation warning 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2025-02-15 11:10:17 +00:00
Benjamin Gaussorgues
d056e4dc74 perf(files): faster query to fetch incomplete directories 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2025-02-13 14:24:44 +00:00
Robin Appelman
5eac86afec fix: don't use cached root info from shared cache if the watcher has detected an update 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-02-11 20:35:46 +01:00
Robin Appelman
e813f3d605 fix: make locked exception path relative to the view 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-02-11 16:29:43 +00:00
John Molakvoæ
1946fdf80d fix: psalm and OCP @since declarations 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
 2025-02-09 21:09:12 +01:00
skjnldsv
63d9a11575 fix: make sure we process mime extensions as string 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2025-02-09 21:09:12 +01:00
Ferdinand Thiessen
e550ad7bbe
fix(FediverseAction): Ensure valid fediverse links are generated 
Harden also for existing values of the profile.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-06 15:46:15 +01:00
Ferdinand Thiessen
ac1a448765
fix(AccountManager): Sanitize social media handles 
Ensure to only accept valid X and fediverse handles.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-06 15:46:15 +01:00
John Molakvoæ
806e5ac30f
Merge pull request #50675 from nextcloud/backport/50193/stable31 
[stable31] fix(oauth2): adjust db schemas when migrating from owncloud
 2025-02-06 10:23:29 +01:00
Marcel Klehr
75585be67f fix(TaskProcessing\Manager): Always use distributed cache and use PHP serialize 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2025-02-06 07:52:04 +00:00
Marcel Klehr
f9450f2d20 fix: lib/private/TaskProcessing/Manager.php 
Co-authored-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2025-02-06 07:52:04 +00:00
Marcel Klehr
ec3660a3c2 fix(TaskProcessing\Manager): Always use distributed cache and use PHP serialize 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2025-02-06 07:52:04 +00:00
Richard Steinmetz
2c51ff1e3b fix(oauth2): adjust db schemas when migrating from owncloud 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2025-02-05 21:17:28 +00:00
Andy Scherzinger
23cb06dfc1
Merge pull request #50565 from nextcloud/backport/50530/stable31 
[stable31] fix(ConvertType): Read dbtype in createConnectionParams and remove safeguard
 2025-01-31 16:52:12 +01:00
Nils Wenninghoff
8a6d9ffdc1 fix(ConvertType): Read dbtype in createConnectionParams and remove safeguard 
Signed-off-by: Nils Wenninghoff <nils@ungemein.cool>
 2025-01-30 10:50:16 +00:00
Louis Chemineau
a56cff70e1 fix: Exclude non accepted shares when computing access list 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-01-30 09:18:41 +00:00