Commit graph

1824 commits

Author SHA1 Message Date
Joas Schilling
8dbc006009 fix(sharing): Don't redirect when accepting a share failed
Signed-off-by: Joas Schilling <coding@schilljs.com>
2026-03-30 11:12:56 +00:00
Salvatore Martire
97b3812983 fix(files_sharing): respect config to skip certificate verification
This is important especially for local development, as certificate are

self-signed.

Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
2026-03-19 12:39:04 +01:00
Ferdinand Thiessen
1703951540 fix: use canDownload for permissions on federated shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-03-17 21:57:28 +00:00
Ferdinand Thiessen
ca1cf76c0f fix(files_sharing): make legacy downloadShare endpoint compatible with legacy behavior
This needs to be able to directly download files if specified to only
download a single file and not a folder.
Also it was possible to either pass a files array json encoded or a
single file not encoded at all.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-02-20 18:21:34 +00:00
Côme Chilliet
fb673b0d85 chore: fix or suppress psalm errors for BeforeZipCreatedEvent
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2026-01-20 15:09:18 +00:00
Côme Chilliet
7a88cb0709 fix(files_sharing): Switch back event path to be relative to user folder
This is clearly the original intent, the parameter name in ViewOnly is
 $userFolder, and the similar event for single file download uses
 paths relative to user folder as well.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2026-01-20 15:09:18 +00:00
Côme Chilliet
102c5183e1 fix(files_sharing): Fix BeforeZipCreatedListener path handling
Path of directory is relative to root folder, not user folder.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2026-01-20 15:09:18 +00:00
Benjamin Gaussorgues
e0ef795ae8 chore: add chunked queries on occ sharing:delete-orphan-shares
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-01-08 08:50:43 +00:00
Côme Chilliet
6cdac077a4 chore: Improve wording in debug log
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2025-11-25 10:47:18 +00:00
Côme Chilliet
97ddc1c9e1 fix(files_sharing): Allow deleting a share of a missing file
This can happen in various scenarios, we should allow the user to delete
 the share in this situation.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-11-25 10:47:18 +00:00
nfebe
299662e05d fix(sharing): Allow reasonable control 4 'Hide download' on fed shares
When creating public links from federated shares, users should be able to set
the 'Hide download' option independently as long as they are more restrictive
than the original share permissions.

Previously, the `checkInheritedAttributes` method was ignoring user preferences
and always overriding the hideDownload setting based solely on inherited
permissions, preventing users from disabling downloads even when the parent
share allowed them.

This fix implements some sort of inheritance logic:
- Users can only be MORE restrictive than parent shares, never LESS restrictive
- If parent hides downloads -> child MUST hide downloads (enforced)
- If parent allows downloads -> child can CHOOSE to hide or allow downloads
- If parent forbids downloads entirely -> child cannot enable downloads

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-11-04 14:03:06 +01:00
nfebe
424880c372 fix(files_sharing): Only send password on change
The password param should never be sent if the intention is not

remove it or update it.

This commit adapts the frontend and backend to this rule to avoid weird bugs

especially around updating new shares.

Signed-off-by: nfebe <fenn25.fn@gmail.com>

[skip ci]
2025-10-29 19:10:49 +00:00
Micke Nordin
ef8f9c2a52 fix(ocm): probe standardized .well-known endpoint
- Add `.well-known/ocm` to remote endpoint discovery checks.
- Improves compatibility with newer OCM deployments when probing remote servers.

Signed-off-by: Micke Nordin <kano@sunet.se>
2025-10-29 06:35:51 +00:00
Andy Scherzinger
6d47668fda
Merge pull request #55961 from nextcloud/backport/55955/stable32
[stable32] fix(dav): allow multiple link shares token in session
2025-10-28 22:09:12 +01:00
Daniel
2948acb488
Merge pull request #55984 from nextcloud/backport/55529/stable32
[stable32] fix: make share recursion error more informative
2025-10-28 21:16:49 +01:00
Joas Schilling
e880479aab
fix(federation): Increase the size of owner to allow oCIS cloud ids
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-10-27 16:39:44 +01:00
Robin Appelman
42b8c25e15 fix: make share recursion error more informative
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-10-24 12:20:52 +00:00
skjnldsv
4a7f5000ef fix(dav): allow multiple link shares token in session
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-10-23 14:11:06 +00:00
nfebe
2c103fe1d1 refactor(ShareApiController): Streamline share providers & add error logging
1. Consolidated the repetitive provider code into a clean loop
2. Added exception handling to log unexpected errors

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-10-01 16:26:25 +00:00
Benjamin Gaussorgues
6db16b18c9 perf(mounts): avoid array_merge in mounts loop
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2025-09-09 14:33:21 +00:00
Louis Chemineau
2e2994d6a4 fix(encryption): Correctly set encrypted to 0 when copying
If encryption got disabled, copying should set encrypted to 0 for the
 new unencrypted copy. For instance when using encryption:decrypt-all

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-09-08 22:35:57 +02:00
Robin Appelman
b849f71e8f feat: allow filtering sharing:delete-orphan-shares by share owner or target
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-08-27 21:46:42 +02:00
Richard Steinmetz
b7dc720848
feat: calendar federation
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-08-27 17:14:15 +02:00
provokateurin
37175e0e2b
fix(files_sharing): Also hide own reshares in shared with me section
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-08-18 11:38:05 +02:00
Richard Steinmetz
b38c07c682
Merge pull request #54229 from nextcloud/perf/mount-provider-join-array-merge
perf: join array_merge calls in MountProvider::getMountsForUser()
2025-08-15 15:25:39 +02:00
Maxence Lange
cb84ccc57d feat(preset): share password protection
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-08-12 14:37:32 -01:00
nfebe
e7f4de6296 fix(files_sharing): Implementation conditional federation placeholder
This commits addresses an annoyance where the share input placeholder would
suggest sharing via federated cloud ID even if federation was disabled.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-08-11 18:54:56 +01:00
Ferdinand Thiessen
ae5d57371a feat(files_sharing): show GS users similar to internal users
- resolves: https://github.com/nextcloud/server/issues/52497

Ensure that when global scale is enabled the federated users are shown
just like internal users.
Meaning no server part but instead use the email address like with internal.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-08-11 09:18:16 +00:00
Richard Steinmetz
0bd5128d45
perf: join array_merge calls in MountProvider::getMountsForUser()
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-08-04 08:18:12 +02:00
nfebe
2bb8c72c47 feat(files_sharing): Toggle display for trusted server shares
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-07-29 13:24:49 +01:00
Maxence Lange
33bff30e1d feat(lexicon): moving out from unstable
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-07-24 15:56:33 -01:00
Ferdinand Thiessen
74ff1c64f0
Merge pull request #53979 from nextcloud/fix/settings-share-folder
fix(files_sharing): ensure share folder exists in the settings
2025-07-17 23:16:31 +02:00
Ferdinand Thiessen
a18e61a1e5
feat(files_sharing): add config option for extending link-share permissions
This allows the admin to control the behavior whether link shares with
READ permissions should be extended to also gain SHARE permissions,
allowing users (public share receivers) to add the share to their cloud.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-07-17 16:59:36 +02:00
Ferdinand Thiessen
f3857f705d
fix(files_sharing): ensure share folder exists in the settings
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-07-16 18:23:12 +02:00
Côme Chilliet
90a2c77abf
fix: Use Server::get in files_sharing DeletedShareAPIController
In this case we do not want the application DI container because we are
 requesting classes from other applications, so it’s better to ask the
 server container. We use \OCP\Server::get for this.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-08 13:32:15 +02:00
Côme Chilliet
ab310ce938
fix: Fix issues and tests in DIContainer and friends
Some tests related to MiddlewareDispatcher are still failing.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-08 13:32:14 +02:00
Robin Appelman
aa15f9d16d
chore: run rector
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-07-01 22:45:52 +02:00
Ferdinand Thiessen
5981b7eb51
chore: apply new CSFixer rules
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

# Conflicts:
#	apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
John Molakvoæ
bd00b75b29
Merge pull request #53671 from nextcloud/fix/read-only-share-download 2025-07-01 15:11:06 +02:00
provokateurin
8e580f8548
fix(files_sharing): Hide own reshares
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-07-01 08:23:53 +02:00
skjnldsv
9806a9830c feat(files_sharing): allow viewing files with download disabled
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-06-26 11:47:53 +02:00
nfebe
1f8a2307bd fix: Set public link upload email notification to opt-in
This now sets `isDefaultEnabled` to false. This makes email notifications for file uploads
to public links disabled by default (opt-in) for users.

This addresses concerns about new notifications being enabled by
default for existing users, leading to unexpected emails.

Related: https://github.com/nextcloud/server/pull/46945

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-06-17 13:57:13 +01:00
skjnldsv
bf3ce79abd feat(files_sharing): show Account menu on public pages
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-06-11 16:43:53 +02:00
Ferdinand Thiessen
495c364268
chore: use consistent casing for header names (required by openAPI)
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-06-09 19:24:26 +02:00
Ferdinand Thiessen
60ccc85e76
fix(files_sharing): show note, label and list of uploaded files on file drop
This was missing from the Vue migration of the public share view:
- Show the note as the description of the file drop
- Show the label as the heading of the file drop if available
- Show list of uploaded files for verification

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-26 15:11:36 +02:00
Louis
a48bc55e2a
Merge pull request #52810 from nextcloud/artonge/feat/do_not_require_samesite_strict_cookie_on_public.php 2025-05-22 10:30:16 +02:00
Louis Chemineau
ec1db0c32a
fix: Replace the deprecated direct download link with the public DAV endpoint
Follow-up of #48098

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-05-21 16:01:54 +02:00
Joas Schilling
9637fe6474
Revert "fix(files_sharing): Filter own shares that are reshares" 2025-05-19 17:16:39 +02:00
provokateurin
7c6602cd8d
fix(files_sharing): Filter own shares that are reshares
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-19 08:18:16 +02:00
Ferdinand Thiessen
4a9dc6c64d
refactor: move tag handling from files handler to files_sharing
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-16 13:09:03 +02:00