Commit graph

683 commits

Author SHA1 Message Date
nfebe
a508699f48 fix(login): Improve CSRF error message for better user understanding
This commit changes the CSRF error message displayed in the login form to
provide more specific information to the user. Instead of the generic less helpful error.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-03-25 16:35:39 +01:00
Valdnet
2e5fa36e60
fix(l10n): remove unnecessary space
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2025-03-02 12:46:05 +01:00
Maksim Sukharev
4a7531ea0f fix: wipe local storages on log out
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-02-25 16:59:07 +01:00
Ferdinand Thiessen
72d48de6eb fix(login): only show error state on login box if user interacted
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-17 11:00:43 +00:00
skjnldsv
bc79917d3e feat(core): offer clipboard fallback for non-secure environments
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-04 15:17:15 +01:00
nfebe
ab9dbe048e fix(unified-search): filteredProviders now inherits all provider props
The main providers come from both the backend and client side plugins such as `in-folder` search.
The main providers may carry callbacks functions and other information that should be passed to the `filteredProviders`.
This is important because the current code does not make a distinction between `filteredProviders` and `providers`
rightly so, becuase they are the same thing!

Without the mentioned distinction above, sooner or later, we try to access a property on the `filteredProviders` which we
did not transfer with the manual property copy.

----

This fix prevents in-folder search from searching everywhere when "load more results" is clicked; Essentially ignoring the in-folder
search filter.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-02-03 16:04:50 +00:00
nfebe
3324b10307 fix: Use searchFrom property for client side plugins
The client-side plugin `in-folder` uses the `files` provider, this makes it

overlap with the main files provider itself.

This change follows eecda06f1a after it was discovered

that some apps/providers like `dav` use providers from another app like `contacts`

Signed-off-by: nfebe <fenn25.fn@gmail.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2025-01-31 12:01:28 +00:00
SebastianKrupinski
405cd7627c fix: unified search provider id
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2025-01-31 11:40:30 +00:00
nfebe
a6a100ee64 fix(unified-search): Prevent multiple file picker triggers in in-folder search
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2025-01-29 15:57:33 +00:00
nfebe
9d0238b291 refactor: Drop deprecated use of defineStore
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-01-29 16:47:21 +01:00
nfebe
c680e74a82 fix(unified-search): Use appId for searching
Each provider may search from a particular app so we should use that for searching.

Before this commit, we used `provider.id` instead of `provider.appId` the problem with the previous
approach is that it forces the provider id to be a valid search provider (an app that supports search)
limiting the developers ability to use unique IDs to identify the different providers (especially plugin providers)
inside the places filter.

For example the Files search plugin "In folder" (search in folder plugin) was required to have id as `files` while the
files provider itself already has id as `files`.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-01-29 16:47:21 +01:00
Maksim Sukharev
0f41c35c17 fix(UnifiedSearch): request data only when opening modal
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-18 15:16:46 +01:00
nfebe
d2ea5d2a61 feat: Adapt providers disabled property to match user applied filters
Some filters are only available for certain providers, the UI should give the user
a hint to what providers such filters are available in.

Currently, if a filter (date or person) is not support by an a provider, the provider is
blurred out in the places dropdown.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-01-17 11:31:18 +01:00
Ferdinand Thiessen
f5f3ae2c19 fix: Redirect user to login if session is terminated
If a session timed out or was closed in another tab,
then currently the user gets random error messages.
This intercepts 401 responses (should only happen if logged out, or the
users does something wrong).

If we get a 401, we make sure its because of the session,
by checking if the user can access the files app.
If that is also the case we forward the user to the login page
and set the redirect URL to the last used URL.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-09 09:48:44 +01:00
Max
13189d7990
fix(share): render conflict modal in public shares
Handle templates with license comments in `octemplate.js`.

Signed-off-by: Max <max@nextcloud.com>
2024-12-19 09:54:21 +01:00
Ferdinand Thiessen
94262a5c5c fix(core): Do not use v-html for translation output
The content that can be renderered does *not* include HTML (see
`recommended` object).
But `v-html` was used, this is potentially dangerous, even though we
sanitize the translation values, so no urgent harm but better safe than
sorry.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-11-19 09:49:07 +00:00
Benjamin Gaussorgues
93a3288bd1
Merge pull request #48652 from nextcloud/backport/48638/stable30 2024-10-30 10:06:46 +01:00
Ferdinand Thiessen
2dea20bd4f
fix(unified-search): Close on second ctrl+f
Also only add the event listener if short-cuts are not disabled for accessibility reasons.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-28 14:43:25 +01:00
Christopher Ng
cae3621395 chore: Add text file icon class
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-10-10 11:29:53 -07:00
Christopher Ng
3b1a46fd73 fix: Fix inaccessible content on public pages due to overlapping footer
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-09-06 15:43:13 -07:00
fenn-cs
c637b23f65 fix(UnifiedSearch): Restore normal dialog size
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-09-02 15:38:21 +01:00
fenn-cs
716b8c896e fix(UnifiedSearch): Focus search input on open
Resolves : https://github.com/nextcloud/server/issues/47056

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-08-20 23:13:31 +02:00
Ferdinand Thiessen
70c6ff9e11 fix(AppMenu): Prevent menu entries from jumping on hover
Only grow and shrink app menu entry if needed

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-14 12:34:37 +00:00
Ferdinand Thiessen
ea021df9fa
chore(deps): Update @nextcloud/auth to v2.4.0 and use getCSPNonce where possible
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-13 17:54:47 +02:00
Ferdinand Thiessen
ed16793089
fix: Make focussed app menu entry wider to see full name
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-08 18:24:35 +02:00
Ferdinand Thiessen
7cef884297
fix: Make app menu overflow entries vertically aligned
The `name` property expects a `text` and just adds basically a "heading" for the text,
so lets instead just utilize the default slot.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-07 22:32:04 +02:00
Ferdinand Thiessen
91f78936c9 fix: Ensure app overflow menu is rendered centered
1. Fix app menu overflow button to be centered
2. Ensure the overflow calculation always just removed one element (incl. refactor to use `@vueuse`)
3. Ensure we use 1.5 line height for app menu, otherwise some languages look squashed under the app icon

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-07 21:29:00 +02:00
Sanskar Soni
55bb6ee87e feat(core): add selection for recommended apps
Signed-off-by: Sanskar Soni <sanskarsoni300@gmail.com>
2024-08-06 17:30:15 +02:00
Ferdinand Thiessen
b2d053589a
fix(user_status): Adjust AccountMenu entry for user status
fixup: Adjust to design comments

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-06 09:20:52 +02:00
Ferdinand Thiessen
674805c994
fix(core): Migrate UserMenu / AccountMenu to NcListItem
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-06 09:20:48 +02:00
skjnldsv
3ca6eb5098 fix(core): app menu notification should be in the top right
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-01 08:19:17 +00:00
skjnldsv
b92e0c7c6b fix(core): do not show unread notification on app menu hover
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-07-31 15:30:05 +00:00
skjnldsv
937bb4a539 fix(core): app menu label position and animation
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-31 15:26:07 +00:00
Ferdinand Thiessen
842c21f96b
feat(files): Implement files list filters for name, modified time and type
Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-25 19:33:23 +02:00
Ferdinand Thiessen
4bcb0734cd
refactor: Fix some linting issues in frontend code
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-19 22:45:13 +02:00
skjnldsv
9b84831c8d fix(files_sharing): adjust IAttributes API and files_versions
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-12 20:14:30 +02:00
Ferdinand Thiessen
d82565d67d
refactor(core): Split app menu into components
This allows to split one large block of code into three components with each one usecase.
Allowing for better readability and maintainablility.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-10 01:35:24 +02:00
Ferdinand Thiessen
a96b5940dd
chore: Make active apps initial state consistent with OCS API
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-10 01:35:24 +02:00
Ferdinand Thiessen
691f570237
chore: Enable ESLint for apps and fix all errors
Nevertheless this causes a huge amount of new warnings.
Previously the shell script for directories to lint was wrong it was generating all app names to lint,
but was missing the `apps/` prefix. Causing only `core` to be linted.

Co-authored-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-09 17:13:30 +02:00
Ferdinand Thiessen
4d6a21a379
refactor(core): Make AJAX cron script work without jQuery
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-28 17:28:10 +02:00
Ferdinand Thiessen
362c6238fc
fix: Allow to reset unified search using the nextcloud:unified-search:reset event
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-27 12:13:14 +02:00
Ferdinand Thiessen
dd3dcf3703
fix(unified-search): Also show local search on apps management
Co-authored-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-27 12:13:14 +02:00
Ferdinand Thiessen
e9dccef474
fix: Open unified search by pressing ctrl + F
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-27 12:13:14 +02:00
Ferdinand Thiessen
0885245235
refactor(styles): Make padding not a magic value
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-27 12:13:14 +02:00
Ferdinand Thiessen
0ff17b857b
fix(UnifiedSearch): Implement design comments and focus input on open
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-27 12:13:14 +02:00
Marco Ambrosini
6ee965f0d9
feat: Add in-app search
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Marco Ambrosini <marcoambrosini@icloud.com>
2024-06-27 12:13:14 +02:00
Ferdinand Thiessen
81ad28f910
chore(deps): Update debounce to 2.1.0
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-23 16:53:10 +02:00
Ferdinand Thiessen
50b9fb46cb
fix: Adjust icon generation to bring back themed icons
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-17 12:07:18 +02:00
Marcel Müller
f6e6d7a834 fix(login): Prevent submitting the login form multiple times
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2024-06-06 12:00:30 +02:00
Marcel Müller
95148ffe92 fix(login): Disable login button when already logging in
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2024-06-06 12:00:30 +02:00