Commit graph

1503 commits

Author SHA1 Message Date
Anna Larch
7c4ceb444c Add group display name cache
Signed-off-by: Anna Larch <anna@nextcloud.com>
2022-11-28 11:52:55 +00:00
Julius Härtl
8629d8e44f
Check share attributes on preview endpoints
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-10-25 11:35:31 +02:00
Carl Schwan
0de71a73e5
Merge pull request #34502 from nextcloud/fix/correct-attribute-resharing
Propagate attributes when resharing
2022-10-20 17:03:02 +02:00
Carl Schwan
0f0f132959
Merge pull request #34624 from nextcloud/fix/files_external_psalm
Multiple fix for files external
2022-10-20 16:53:43 +02:00
Carl Schwan
a5ea677370 Rename file1 and file2 to source and target in Storage abstraction
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-18 17:21:47 +02:00
Carl Schwan
54031e370a Fix various other small psalm issues
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-17 12:40:35 +02:00
Carl Schwan
0a2a4d8687 Fix incorrect argument name in inherited method
The arguments now need to be the same as in the parent method

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-17 12:39:22 +02:00
Carl Schwan
60313683e2 Fix checkpassword undocummented null parameter
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-17 12:38:21 +02:00
Carl Schwan
c6b8a3bec3 Fix permission not being int
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-17 12:37:46 +02:00
Carl Schwan
53e408f76a Fix exception getCode type
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-17 12:36:50 +02:00
Carl Schwan
3a11128e6c Fix type when getting appconfig with int
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-17 12:36:05 +02:00
Vincent Petry
95d45c2058
Merge pull request #34471 from starypatyk/dav_read_share_notes
Reduce number of database queries during WebDAV propfind request
2022-10-14 15:33:13 +02:00
Simon L
d967488ec0
Merge pull request #34544 from nextcloud/fix/more-flexible-date-validation
More flexible date validation
2022-10-13 01:10:55 +02:00
Carl Schwan
9eb67ad57d More flexible date validation
Fix #34542

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-11 23:02:10 +02:00
Carl Schwan
8e3f21d9ed Small progress with fixing unit tests
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-11 14:00:15 +02:00
Carl Schwan
cf39885b53 Propagate attributes when resharing
When updating a share, load the node from the initiator instead of the
owner similar to how this is done when creating the share.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-10 17:06:29 +02:00
Roeland Jago Douma
c6e100ed32
type closure to make psalm a bit happier
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2022-10-09 21:41:18 +02:00
Dariusz Olszewski
255d1dd686 Read notes from share already loaded into memory
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-10-07 23:24:12 +02:00
tobiasKaminsky
610bbaed68 includeTags -> include_tags
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-09-28 13:17:56 +00:00
Joas Schilling
2acf9ffafe
Ignore invalid share types
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-09-26 09:40:53 +02:00
Tobias Kaminsky
5b3fb7a8ff
Update apps/files_sharing/lib/Controller/ShareAPIController.php
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com>
2022-09-21 08:28:03 +02:00
tobiasKaminsky
ebd28ef9e0
Show include tags on single share
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-09-19 11:36:52 +02:00
tobiasKaminsky
4a4a3874da
Add includeTags to /share/id 2022-09-19 11:11:09 +02:00
Carl Schwan
02d55eb90f
Merge pull request #33941 from nextcloud/fix/public-sharing
Only normalize data in public shares and not crud
2022-09-15 16:43:01 +02:00
Carl Schwan
7ded5a769b
Only normalize data in public shares and not crud
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-08 14:51:28 +02:00
luz paz
9d26671f05 Fix typos in apps/ subdirectory
Found via `codespell -q 3 -S l10n,./apps/files_external/3rdparty -L adn,ba,boxs,keypair,jus,optionel,ressource,tabel ./apps/`

Signed-off-by: luz paz <luzpaz@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-09-05 12:59:54 +00:00
Max
99aa938452 feature: first take on using the viewer to render single file shares
Signed-off-by: Max <max@nextcloud.com>
2022-08-25 21:59:19 +00:00
Vincent Petry
5f90a6a5e2
Merge pull request #33574 from nextcloud/search-share-query-filter-no-init
directly build the search filter for shared storage instead of setting up the source cache
2022-08-23 14:15:24 +02:00
Joas Schilling
7e11778190
Use user name cache in activity providers
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-19 10:48:32 +02:00
Robin Appelman
b731c95b79 further pre-filter search result before setting up share source cache
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-17 13:49:21 +02:00
Robin Appelman
b6f8b8da60 directly build the search filter for shared storage instead of setting up the source cache
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-17 11:58:57 +02:00
Carl Schwan
8004aa7721
Make DisplayNameCache return null if user doesn't exists
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-16 14:10:05 +02:00
Robin Appelman
8367b99c59
fix external share scanner not propagating locking-opt-out
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-03 17:12:30 +02:00
Carl Schwan
6ba9a4a752
Disable locking on federated shares
The old inneficiant code didn't do locking and adding locking is
creating issues

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-03 15:17:55 +02:00
Carl Schwan
fa48430feb
Revert "Revert "Remove inefficient fed share scanner""
This reverts commit 6667007bf2.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-03 15:17:51 +02:00
Carl Schwan
7b723813ce
Multiple fixes
- Fix tests
- Use non deprecated event stuff
- Add a bit of type hinting to the new stuff
- More safe handling of instanceOfStorage (share might not be the first
  wrapper)
- Fix resharing

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-31 19:37:59 +02:00
Carl Schwan
ab1a20522b
Enforcing permission during resharing
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-28 16:54:13 +02:00
Vincent Petry
bbb5043c07
Inherit hide download from share attributes
When resharing by link, if the download permission was removed through
share attributes, convert it to the hide download flag.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:54:13 +02:00
Vincent Petry
3cfb4cbf94
Block download when needed on direct download endpoint
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:54:13 +02:00
Vincent Petry
2ee659e547
Fix view-only code after code review comments
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:24 +02:00
Vincent Petry
54a0d8fe64
Don't reset share attributes when not specified
When not specified in the OCS call, don't reset the share attributes.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:23 +02:00
Vincent Petry
03b1791cca
Fix share attribute related tests + code style
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:22 +02:00
Vincent Petry
9493f86de3
Fix share controller to accept share attributes alone
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:22 +02:00
Vincent Petry
a95c19e14b
Add share attributes + prevent download permission
Makes it possible to store download permission

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:22 +02:00
Louis Chemineau
f525067930 Add argument to getSharesInFolder enable deep share lookup
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-07-26 12:17:46 +00:00
Louis Chemineau
0fb4ecadae Recursively fetch subshares
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-07-26 12:17:46 +00:00
Louis Chemineau
13e7ebbe4b Change share owner when moving share out of share
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-07-26 12:17:46 +00:00
Vincent Petry
8ca910976d Update owner of subdir on move into/out of share
When moving a directory into or out of a received share, make sure to
also update the share owner column for shares that exist insie the
directory.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-26 12:17:46 +00:00
Carl Schwan
d5c23dbb9f Move CappedMemoryCache to OCP
This is an helpful helper that should be used in more place than just
server and this is already the case with groupfodlers, deck, user_oidc
and more using it, so let's make it public

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-14 15:54:31 +02:00
Vincent Petry
85cc867143
Merge pull request #31771 from nextcloud/fix/hook-encryption-cron
Fix hook encryption with cron job
2022-06-10 16:27:59 +02:00