Commit graph

153 commits

Author SHA1 Message Date
fenn-cs
faa76b94b8 Add accesibility features to quick share dropdown
- Adds appropriate aria attributes
- Uses button element for dropdown items as it's more semantically correct
- Uses trap-focus lib to trap focus when the drowpdown is active
- Adds custom handling for arrow up and down

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2023-09-07 10:54:47 +01:00
fenn-cs
f75684ec7e Close quickshare dropdown on outside click
If a user clicks anywhere outside of the quickshare dropdown,
it should be closed.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2023-09-07 10:54:47 +01:00
Grigorii K. Shartsev
1f6101d8a9 fix(files_sharing): select sharing in sidebar breaks Viewer focus trap
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2023-09-05 22:15:29 +02:00
julia.kirschenheuter
caf97891ef Replace custom input field with NcTextField
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-08-31 12:33:29 +02:00
fenn-cs
79f62632ea Improve sharing flow
This commit introduces the following changes:

- Does not create new share once user is selected for internal shares
- Adds a `SharingDetails` view for share configurations
- Adds a quick share select to enable fast changes in share permisions.

Resolves: https://github.com/nextcloud/server/issues/26691

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-08-30 17:58:01 +02:00
Ferdinand Thiessen
738c596977 fix(apps): Adjust apps for FilePicker API change
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-08-26 20:56:09 +02:00
Christopher Ng
8a51d64b09 fix(files_sharing): String translations
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-07-31 23:17:23 +00:00
Richard Steinmetz
270d3a4269
fix(files_sharing): hide download permission for circle shares
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2023-07-10 08:51:49 +02:00
John Molakvoæ
cd54f7c7f4
chore: upgrade typescript, eslint and fix lint
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-06-27 16:16:41 +02:00
Louis Chemineau
fbde8f91b6 Don't disable actions when saving share permissions
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-06-19 12:13:19 +02:00
Daniel Calviño Sánchez
d4631921b4
Show pending popover menu when password is enabled by default
When "Enforce password protection" is enabled in the sharing settings a
popover menu is shown to set a password before the share is created. On
the other hand, when "Always ask for a password" was enabled in the
sharing settings and a new link share was created the share was
immediately created with a default password; the user was not able to
specify a password (nor create the share without password).

The component template already provided the needed elements to also ask
for the password without enforcing it, but the popover menu was not
shown due to "enableLinkPasswordByDefault" being missing in "if"
conditions.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2023-05-22 12:49:23 +02:00
Daniel Calviño Sánchez
d80f8fc84f
Rename "pendingPassword" to "pendingEnforcedPassword"
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2023-05-22 12:49:15 +02:00
Simon L
f5e8268ced Use the color-primary-element* variables
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-05-13 10:15:33 +00:00
Louis Chemineau
6faf8b85d6 Do not allow to toggle between password and text in sharing
This does not makes sense as we do not have the clear text value.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-05-09 17:33:53 +02:00
Christopher Ng
8960df2d6a Fix share input id
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-05-02 02:22:29 +00:00
rakekniven
f7c115146f fix(l10n): Fixed grammar
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2023-04-18 12:08:38 +02:00
John Molakvoæ
8633f13e0a
chore(eslint): fix missing import extensions
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-03-23 08:14:19 +01:00
Michiel de Jong
c0e84cb512 Add SHARE_TYPE_SCIENCEMESH
Signed-off-by: Michiel de Jong <michiel@unhosted.org>
2023-03-08 16:46:55 +01:00
Christopher Ng
0c69619d91 Fix share select dropdown not opening when viewer is open
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-03-01 17:18:39 -08:00
julia.kirschenheuter
76999d1626 Adapt native tooltip for new structure of NcAvatar
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-02-27 15:41:35 +01:00
Christopher Ng
edcf675e6e Drop vue-clipboard2 to fix copy to clipboard
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-02-01 15:40:13 -08:00
Christopher Ng
0236c9e8cd Port files sharing selector
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-01-24 17:40:17 -08:00
Christopher Ng
41d7f9dff2 Add visible share label
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-01-12 22:42:40 +00:00
Christopher Ng
f09300b343 Differentiate share links
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-01-12 17:23:47 +00:00
Christopher Ng
de7b7d3313 Fix inability to re-enter share password after invalid input
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-01-10 19:51:14 +00:00
julia.kirschenheuter
1063fbcb10
Replace custom tooltips with native one in vue components and views
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-01-05 08:57:58 +01:00
Christopher Ng
fb2fb0d2d5 Revert "Copy to clipboard with button instead of link"
This reverts commit 4ffc022c8b.

Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-12-14 00:57:57 +00:00
Christopher Ng
08e15308cb Add success popup message for copying share links
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-12-06 01:04:10 +00:00
Christopher Ng
7c943c5ce4 Show success on share actions
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-12-03 01:09:27 +00:00
Christopher Ng
4ffc022c8b Copy to clipboard with button instead of link
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-11-24 23:50:54 +00:00
Christopher Ng
20da3d081e Add label to sharing search field
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-11-23 02:04:18 +00:00
John Molakvoæ
2b4ce7b95d
Fix date handling and saving
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-11-16 17:19:58 +01:00
Vincent Petry
3bf11dcf60
Fix visibility of internal expire date
Fixed visibility of the expiration date field for internal shares by
aligning the logic with the one from the public link shares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-10-28 18:58:52 +02:00
julia.kirschenheuter
1eac730caf Replace moment.js date with Date Object.
Replace vue2-datepicker with native date picker for expiration date.

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-10-06 08:56:06 +00:00
Vincent Petry
42bc63f1a0 Update apps/files_sharing/src/components/SharingEntryInternal.vue
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-09-27 14:05:46 +00:00
Vincent Petry
64a4abf472
Fix focussing to internal link after copy
Since a recent change to NcActions it's not possible to add a "ref"
attribute on a NcAction* component.

As a workaround, a ref was added on the NcActions parent component
instead.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-09-27 12:25:22 +02:00
Carl Schwan
3fcb05e900
Port Profile section checbox to NcCheckoxRadioSwitch component
Improve accessibility and unify the design

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-12 15:38:20 +02:00
luz paz
9d26671f05 Fix typos in apps/ subdirectory
Found via `codespell -q 3 -S l10n,./apps/files_external/3rdparty -L adn,ba,boxs,keypair,jus,optionel,ressource,tabel ./apps/`

Signed-off-by: luz paz <luzpaz@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-09-05 12:59:54 +00:00
Vincent Petry
d0473214cd
Add Nc prefix to Nc vue component names
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-25 08:38:00 +02:00
Julius Härtl
02fd7d2216 Fix label for allow download share permission
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-08-04 15:21:10 +00:00
Carl Schwan
7b723813ce
Multiple fixes
- Fix tests
- Use non deprecated event stuff
- Add a bit of type hinting to the new stuff
- More safe handling of instanceOfStorage (share might not be the first
  wrapper)
- Fix resharing

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-31 19:37:59 +02:00
Carl Schwan
ab1a20522b
Enforcing permission during resharing
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-28 16:54:13 +02:00
Julius Härtl
2fb7a1feeb
Fix adding to empty attributes and duplicate request
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-07-28 16:53:23 +02:00
Vincent Petry
a11c6e7cc3
Add share attrs + download permission support in frontend
Added download permission checkbox in frontend
Added share attributes parsing and setting in frontend.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:23 +02:00
Vincent Petry
4a8cbb82fd
Accessible names for share panel buttons
Added aria-label for the buttons on the share panel.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-07-26 23:03:38 +02:00
Vincent Petry
be6285acf6
Fix sharing panel lighthouse warnings
Replaced h5 with span and adjusted selectors.
Fixed ul/li hierarchy of some elements.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-22 17:49:55 +02:00
Christopher Ng
e0492074aa Add expanded attribute to button for listing others with access
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-07-07 17:23:50 +00:00
Cyrille Bollu
50badb3fb6 Various improvements related to the recent implementation of temporary passwords
for mail shares:

1- Changes style of "forgot password?" and "Back" button
2- Adds information about share password's expiration time in the emails sent.
3- Shows password expiration time in the Share menu
4- Fixes an issue when the message "Password expires..." would be shown for non email share types (which don't have temporary passswords)
5- At share's creation, password should only be sent when it's a permanent one

See also https://github.com/nextcloud/server/issues/31952

Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-06-08 11:29:19 +00:00
Louis Chemineau
5fee0fbd5b Fix share permissions rendering
The `SHARE` permissions falls into the `default` case in the switch case, causing the rendering to look like ` , Upload, Read`.

This PR changes the return value of the `default` case and adds a `filter` to remove those values.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-05-31 14:17:16 +02:00
John Molakvoæ
73918b8af9
Cleanup and compile
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-05-13 16:13:00 +02:00