Commit graph

2024 commits

Author SHA1 Message Date
Benjamin Gaussorgues
5a4db810e9
Merge pull request #44385 from nextcloud/backport/44360/stable27 2024-03-21 16:27:15 +01:00
Andy Scherzinger
5d84d652d6
Merge pull request #44378 from nextcloud/backport/44376/stable27
[stable27] fix(dav): ACLs for shared addressbooks
2024-03-21 15:55:07 +01:00
Anna Larch
512634fa2e fix(caldav): add EXDATE and EXRULE to confidential object
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-03-21 13:37:45 +00:00
Christoph Wurst
08a7937af5
fix(dav): ACLs for shared addressbooks
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-03-21 11:59:29 +01:00
Côme Chilliet
3b4d5eaa94
fix(dav): Add missing use for OCP\Constants
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-19 11:22:54 +01:00
Côme Chilliet
a800a685eb
chore: Break closure call on two lines to make it readable
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-19 11:22:49 +01:00
Côme Chilliet
a815f69345 fix(systemtags): Forbid tagging of readonly files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-19 09:10:06 +00:00
Julius Härtl
93c0335eb1 fix: Use proper path when trying to check if a file needs to get copied
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-03-08 10:52:45 +00:00
John Molakvoæ
42d040cb04
Merge pull request #43798 from nextcloud/backport/42459/stable27 2024-02-29 11:36:37 +01:00
John Molakvoæ
84c129d19d
Merge pull request #43799 from nextcloud/backport/39553/stable27 2024-02-29 11:36:29 +01:00
Louis Chemineau
fcc239667f fix(dav): Init ViewOnlyPlugin after auth
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-02-28 10:17:28 +01:00
Patrick Fischer
37d34f905d Bug fix: Select the correct table based on CALENDAR_TYPE_CALENDAR
Signed-off-by: Patrick Fischer <mail@patrickfischer.ch>
2024-02-23 20:38:00 +00:00
MichaIng
cb35794f02 fix(dav): fallback realm for HTTP authentication
By default, the name of the Nextcloud instance is an empty string, until changed by the admin. This leads to an empty realm sent with the WWW-Authenticate header, while the realm is mandatory for Basic HTTP authentication. Some clients have issues with an empty realm, e.g. Thunderbird cannot store passwords in this case.

This commit applies "Nextcloud" as fallback for the realm, in case the name of the Nextcloud instance is not set.

Solves: https://help.nextcloud.com/t/thunderbird-dont-save-caldav-password-because-of-missing-httprealm-or-formsubmiturl/93233

Signed-off-by: MichaIng <micha@dietpi.com>
2024-02-23 20:32:20 +00:00
John Molakvoæ
fb0a2d54fb
Merge pull request #43752 from nextcloud/backport/43732/stable27 2024-02-22 16:45:05 +01:00
Christoph Wurst
844a1b47f5
fix(dav): Rate limit calendar/subscription creation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-02-22 10:47:24 +01:00
John Molakvoæ
245a439d47
Merge pull request #43740 from nextcloud/backport/43727/stable27 2024-02-22 10:45:17 +01:00
Louis Chemineau
5606cadae7
Check share attributes when downloading versions
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-02-21 21:47:50 +01:00
John Molakvoæ
cb5020483e fix(dav): report status
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-02-21 17:08:36 +00:00
Richard Steinmetz
8e67575a71 perf: skip request without read permission
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-02-21 12:48:30 +00:00
Johannes Merkel
823aa887e5
fix(CalDAV): set acls for DeletedCalendarObjectsCollection
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
2024-01-18 08:40:09 +01:00
Richard Steinmetz
fe5b5a7fa3
fix(dav): allow multiple organizers if possible
This is very hacky! However, we want to allow saving events with multiple
organizers. Those events are not RFC compliant, but sometimes imported from major
external calendar services (e.g. Google). If the current user is not an organizer of
the event we ignore the exception as no scheduling messages will be sent anyway.

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-01-02 11:55:25 +01:00
Anna Larch
90cb0bcb8e fix(caldav): don't reuse query builder objects
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-12-16 10:05:34 +01:00
Anna Larch
becf192b6b fix(scheduling): don't send iMIP emails to rooms / resources
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-11-27 09:24:22 +01:00
Christoph Wurst
fe4be9f83d
Merge pull request #41730 from nextcloud/backport/41722/stable27
[stable27] fix(dav): Avoid date diffing if PHP is buggy
2023-11-24 16:58:46 +01:00
Christoph Wurst
69b9a56bbb fix(dav): Avoid date diffing if PHP is buggy
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-11-24 10:43:48 +00:00
Daniel Kesselberg
e7c97ad72f fix: lower threshold for system address book sync
- Switch back to countUsers to have the actual value. countSeenUsers is bad if Nextcloud is connected to a larger directory, but only a part is using Nextcloud and therefore the seen count is much lower because the sync is done for all users.
- Lower the threshold to 100 for smaller installations.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-11-22 19:53:52 +00:00
Christoph Wurst
f3e95bf05a
Merge pull request #41245 from nextcloud/backport/40665/stable27
[stable27] fix(dav): Reduce CalDAV backend memory footprint
2023-11-15 23:48:04 +01:00
Arthur Schiwon
337445746d
Merge pull request #41371 from nextcloud/backport/41354/stable27
[stable27] fix: Validate that we have a proper distributed cache configured
2023-11-15 22:40:40 +01:00
Julius Härtl
f81aa8041d fix: Validate that we have a proper distributed cache configured
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-11-10 08:32:23 +00:00
Robin Appelman
e46ef2b355 get children from dav node when preloading system tags
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-11-08 17:36:15 +00:00
Christoph Wurst
d1e501a8d6 fix(dav): Reduce CalDAV backend memory footprint
fetchAll inflates memory. Fetching in a loop allows GC to run earlier
and more often.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-11-06 12:48:24 +01:00
Richard Steinmetz
28f58a8af9 fix(dav): expand recurrences when searching
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2023-09-26 08:04:33 +00:00
Daniel Kesselberg
efb01db387 fix: use faster method to fetch user count
countUsers: the actual user count reported by the backend.
countSeenUsers: count every user who was logged in once.

1: We should avoid expensive operations (like asking every backend for it's user count) in migrations.
2: The current check is wrong because countUsers returns an array. var_dump([] > 1000) => true ;)

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-09-18 14:09:01 +02:00
Robin Appelman
e14858007d only triger metadata preload logic when at least one metadata is requested
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-09-18 09:31:06 +00:00
Robin Appelman
9b3d8f334b don't preload metadata for the sub-childen
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-09-18 09:31:05 +00:00
Daniel Kesselberg
0da5cb3b85 fix(caldav): add webroot to objectid for activities
A calendar uri includes the webroot: example.com/cloud/remote.php/dav/calendars/alice/personal/
The calendar app uses base64(calendar uri) as identifier for calendar objects.

Without this patch the links from activity app to calendar app don't work for installations in a subdirectory.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-09-13 19:34:03 +00:00
Robin Appelman
ee8c1a5c60
only determine quota_include_external_storage once for quota wrapper
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-09-07 16:25:23 +02:00
Robin Appelman
9242e8939f
only get logger when needed in sabre/directory
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-09-07 16:25:16 +02:00
Anna Larch
9459352f53 fix(CalDAV): check birthday calendar owner
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-09-07 09:25:08 +02:00
Anna Larch
6354dce7ea fix(CardDAV): allow disabling of the system address book via config option
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-09-05 10:22:52 +02:00
Anna Larch
b3526ea81f fix(CardDAV): only run upgrade sync if 1000 users or less
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-08-27 14:04:44 +00:00
Anna Larch
504f396d33 fix(CardDAV): set owner-principal, displayname properties for SAB
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-08-24 15:07:24 +02:00
Robin Appelman
dbc80b02b9 don't bother checking dav acl's in files
any permissions for files is handled in the filesystem layer anyway

Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-08-18 08:08:34 +00:00
John Molakvoæ
8065a2f635
Merge pull request #39904 from nextcloud/backport/38397/stable27 2023-08-16 15:44:16 +02:00
John Molakvoæ
de7822477c
Merge pull request #39858 from nextcloud/backport/39568/stable27 2023-08-16 15:43:10 +02:00
Johannes Merkel
8dae579261 enh(contacts): show/hide addressbooks for all
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
2023-08-16 10:47:40 +00:00
Robin Appelman
526a1404c0 cache calendar objects from calendarQuery
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-08-14 09:10:19 +00:00
Robin Appelman
234ae93f18 preload shares for calendars when listing calendars
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-08-14 09:10:19 +00:00
Daniel Kesselberg
f10972e2fe fix: close cursor after reading the invitation
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-08-11 16:37:37 +00:00
Jamie McClelland
b025e67d8d ensure outerquery ->where() function doesn't clobber earier ->andWhere()
Signed-off-by: Jamie McClelland <jm@mayfirst.org>
2023-08-10 12:54:20 +02:00