Commit graph

790 commits

Author SHA1 Message Date
Julius Härtl
f3419c5f57
feat(settings): Add setup check for apcu cache expunge
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-08-27 10:45:32 +02:00
Daniel Kesselberg
af6de04e9e
style: update codestyle for coding-standard 1.2.3
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-08-25 19:34:58 +02:00
Joas Schilling
04944aaa23
fix(security): Update expiration date in security.txt
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-08-14 09:58:02 +02:00
Kate
4673e1a391
Merge pull request #46816 from nextcloud/refactor/settings/security-attributes 2024-08-14 09:38:08 +02:00
Ferdinand Thiessen
0563757ea4 fix(SetupCheck): Properly check public access to data directory
When checking for public (web) access to the data directory the status is not enough
as you might have a webserver that forwards to e.g. a login page.
So instead check that the content of the file matches.

For this the `.ncdata` file (renamed from `.ocdata`¹) has minimal text content
to allow checking.

¹The file was renamed from the legacy `.ocdata`, there is a repair step to remove the old one.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-08 22:08:42 +02:00
Git'Fellow
4488714148
Merge pull request #46353 from nextcloud/skipOPcacheCLI
fix(setupchecks): Skip checking for OPcache settings if running checks from CLI
2024-08-01 20:02:25 +02:00
Anupam Kumar
cf4326539e
fix(AdminSettings/AI): show pref list of only the enabled translation providers
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
2024-08-01 13:36:37 +05:30
provokateurin
f012c996ee
refactor(settings): Replace security annotations with respective attributes
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-07-27 22:49:43 +02:00
Benjamin Gaussorgues
2ddfbf3e79
Merge pull request #45092 from nextcloud/fix/user-provider-search-shown 2024-07-24 16:38:13 +02:00
Louis
7266a9ef33
Merge pull request #46418 from nextcloud/artonge/feat/user_admin_delegation
feat(users): Add users and group management to admin delegation
2024-07-24 11:15:54 +02:00
Richard Steinmetz
b37fb43a32
feat: let users configure their first day of week
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-07-22 22:35:46 +02:00
Louis Chemineau
3574d7eec8
feat(users): Enable features for delegated user admins
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-07-22 19:58:44 +02:00
Louis Chemineau
dff8815449
feat(users): Add support for admin delegation for users and groups management
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-07-22 17:17:35 +02:00
Joas Schilling
047479ccf9
feat(security): Add public API to allow validating IP Ranges and checking for "in range"
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-07-19 16:28:03 +02:00
Benjamin Gaussorgues
202e5b1e95
feat(security): restrict admin actions to IP ranges
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-07-19 16:28:03 +02:00
Marcel Klehr
7cb67c67c7
Merge pull request #46509 from nextcloud/feat/settings/taskprocessing
feat(settings/admin/ai): Add Task Processing API settings
2024-07-17 18:24:11 +02:00
Marcel Klehr
9dca5ae0e0
feat(settings/admin/ai): Add Task Processing API settings
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-17 15:24:19 +02:00
Anna Larch
2201bce7d3 fix(caldav): lower scheduling table size warning
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-07-17 11:20:49 +02:00
Christopher Ng
e8cacc50a2 chore(settings): Rename user groups
- "Active accounts" -> "All accounts"
- "Recent accounts" -> "Recently active"

Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-07-11 11:19:09 -07:00
Christopher Ng
51e9651436 chore(l10n): Translate group names
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-07-11 11:19:09 -07:00
Christopher Ng
07319a118b feat: Add Recent accounts section
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-07-11 11:19:09 -07:00
Git'Fellow
fa84f52c3f
fix: typo
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-08 15:11:35 +02:00
Git'Fellow
372c9d2ee6
fix: check both CLI and value
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-08 15:09:29 +02:00
Git'Fellow
39f052407a
fix(setupchecks): Skip checking for OPcache if running from CLI
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-08 10:43:20 +02:00
Ferdinand Thiessen
8fc498fb82
fix(IntegrityCheck): Ensure the check is run if no results are available
If there are no cached results the current implementation was also returning an empty array,
but this was the same as when there was a successful run.
So to distinguish this we return `null` if there are *no* results.
In this case we need to rerun the integrity checker.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-03 11:37:49 +02:00
Ferdinand Thiessen
682faad0b3
Merge pull request #46009 from nextcloud/refactor/ajax-cron
refactor(cron): Use `IAppConfig` for cron settings and migrate ajax cron away from jQuery
2024-06-29 16:29:34 +02:00
Daniel
02983f3317
Merge pull request #46190 from nextcloud/bug/45047/skip-check-when-disk-free-space-disabled
fix(setupchecks): skip check when disk_free_space is disabled
2024-06-29 15:59:17 +02:00
Ferdinand Thiessen
14778811b4
refactor: Use IAppConfig for setting cron type
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-28 18:00:39 +02:00
Daniel Kesselberg
fd9fd1b6fb
fix(setupchecks): skip check when disk_free_space is disabled
Make it easier to discover that the check failed because disk_free_space is disabled.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-06-28 13:06:49 +02:00
Ferdinand Thiessen
6601adcd6d
refactor(SetupCheck): Make mariadb and mysql version variables
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-27 16:22:42 +02:00
Ferdinand Thiessen
6e48ca1cf8
fix(settings): Adjust SetupCheck for supported database versions
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-27 16:15:16 +02:00
MichaIng
ea994fe8fb
fix(settings): make trailing slash for caldav/carddav redirects optional
#43939 moved the CalDAV/CardDAV redirect checks from the frontend to a new backend API.

Since the backend does not send an authentication header, checking for the expected response code 207 of the DAV endpoint does not work anymore, hence the URL of the last redirect is checked instead.

This URL is expected to contain a trailing slash, which was not required before, since the DAV endpoint works properly without it (when authenticated).

While a trailing slash in the redirect does no harm, it causes many setups to throw an admin panel warning, while in fact the redirects work properly. Furthermore, the proposed "/.well-known/carddav" => "/remote.php/dav/" redirect leads to double slashes, when doing a request to "/.well-known/carddav/", which seems more wrong then right.

This change makes the trailing slash optional, hence old and adjusted setups won't throw the warning anymore, and the DAV endpoint works well in both cases.

Signed-off-by: MichaIng <micha@dietpi.com>
2024-06-24 17:52:22 +02:00
Robin Appelman
e74f71b32e feat: add setup check for needed mimetype migrations
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-18 14:46:19 +02:00
Arthur Schiwon
98b5cdc43d
Merge pull request #43942 from nextcloud/fix/43612/avoid-pwd-confirm-sso
fix(Session): avoid password confirmation on SSO
2024-06-07 11:25:36 +02:00
Arthur Schiwon
f6d6efef3a
refactor(Token): introduce scope constants
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-06-05 19:01:14 +02:00
Andy Scherzinger
ec5b60af28
chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-06-03 20:33:31 +02:00
Anna Larch
ad78f7e48e fix(caldav): automatically delete outdated scheduling objects
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-05-31 13:14:01 +02:00
Jake Nabasny
f863290572
feat(ldap): sync additional properties to profile and SAB
Synced from LDAP to profile:
- Date of birth

Synced from LDAP to SAB (via the profile):
- Biography
- Date of birth

Original code by Jake Nabasny (GitHub: @slapcat)

Co-authored-by: Jake Nabasny <jake@nabasny.com>
Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-05-30 12:01:13 +02:00
Archisman Das
e1331d9edc fix:Ensure security.txt file ends with a newline character
Signed-off-by: Archisman Das <archisman.officials@gmail.com>
2024-05-27 09:36:39 +02:00
Côme Chilliet
c31d6b1fdc
Merge pull request #45262 from nextcloud/check-HttpsUrlGeneration
fix(SetupChecks): Detect CLI mode in HTTPS / URL generator check
2024-05-13 12:06:21 +02:00
Daniel
99f89bb3de
Merge pull request #45242 from nextcloud/check-memcache-memcached
fix(setupCheck): Only warn when memcache present w/o memcached
2024-05-13 11:53:27 +02:00
Ferdinand Thiessen
ef320200b9
fix: Move hint about firewall issues to common helper string
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-13 09:27:19 +02:00
Julius Härtl
a5fc9b1563
Merge pull request #45272 from nextcloud/check-db-missing-indices
feat(SetupChecks): Refactor DatabaseHasMissingIndices
2024-05-13 07:55:39 +02:00
Josh Richards
5b5178abe7 fix(SetupChecks): Detect CLI mode in HTTPS / URL generator check
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-12 18:09:36 -04:00
Josh Richards
229e5444c9 feat(SetupChecks): Refactor DatabaseHasMissingIndices
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-11 10:29:42 -04:00
Josh Richards
29157149c8 fix: oops vendor string embedded in version
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-10 16:41:29 -04:00
Josh Richards
2e94ec8832 fix: only compare major version of pgsql
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-10 16:41:29 -04:00
Josh Richards
3ce8c6d0db fix: refactor postgresql check to match mariadb/mysql
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-10 16:41:29 -04:00
Josh Richards
f486be8da1 fix: only compare minor mariadb version differences
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-10 16:41:29 -04:00
Josh Richards
2abd67cc02 fix(setupChecks): update db version checks
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-10 16:41:29 -04:00
Josh Richards
c0e395cc0d fix(setupCheck): Only warn when memcache present w/o memcached
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-09 11:45:16 -04:00
Côme Chilliet
37262c860a
fix(setupchecks): Fix opcache buffer check
This was broken by last codestyle update, maybe even before because of
 operator precedence. Now using vars to make it readable and correct at
 the same time.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-30 09:23:59 +02:00
Benjamin Gaussorgues
efea956c64
fix(search): show user search provider for deactivated and admin pages
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-04-29 11:47:48 +02:00
Christopher Ng
2b04a80f90 feat: Add legal notice and privacy policy links to help page
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-04-22 15:19:59 -07:00
Côme Chilliet
733a818139
fix: Migrate a few more classes away from OC_App::getAppPath
Also fixed AppTest

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-22 12:19:01 +02:00
Richard Steinmetz
9ef70f0c4e feat: drop support for php 8.0
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-04-08 11:28:54 +02:00
Anna
f63c0cf921
Merge pull request #44306 from nextcloud/settings/show-indextoreplace-warning
fix(settings): show warning for indexToReplace as part of missing indices
2024-04-05 13:14:43 +02:00
Josh
66fad4ae93 fix(SetupChecks): Add hint about dns/firewall if mjs check can't run
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-04-02 18:10:22 +02:00
Côme Chilliet
ec5133b739 fix: Apply new coding standard to all files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 14:16:21 +02:00
Joas Schilling
b08563df32
fix(security): Update expiration date in security.txt
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-03-28 11:20:58 +01:00
Ferdinand Thiessen
5453c1d7fa
feat(settings): Allow to sort groups in the account management alphabetically
We can do this purly in the frontend - but when enforced from the backend using the existing system config,
we need to follow the requirement. We then show a warning about the configuration.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-27 12:04:03 +01:00
Ferdinand Thiessen
14addf3fdb
fix(settings): Also verify that trusted_proxies only contains IP addresses (with range)
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-26 14:50:57 +01:00
Johannes Merkel
33a0aa6994
fix(settings): show warning for indexToReplace as part of missing indices
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
2024-03-19 11:44:00 +01:00
Ferdinand Thiessen
bae133bf4f fix(AppDiscoverFetcher): Do not remove entries as expired that have no expiry date
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-19 09:36:06 +01:00
Corentin Damman
0fa9f3049f feat(files_sharing): allow to specify allowed groups to share instead of excluded groups
Relates to #3387

Signed-off-by: Corentin Damman <c.damman@intopix.com>
2024-03-15 16:52:59 +01:00
Julien Veyssier
ba94de2510
fix: when no AI setting has been set, make sure the selected text processing provider is the same as the one that will be used
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-03-15 13:17:29 +01:00
Ferdinand Thiessen
df502c114d
feat(settings): Cache app discover images to ensure privacy of users
Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-14 20:45:25 +01:00
Ferdinand Thiessen
f4efb762ec
feat: Allow to fetch app discover json and provide frontend API route
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-14 20:45:24 +01:00
Côme Chilliet
d435f0c3d3
Merge pull request #44067 from nextcloud/fix/migrate-header-check-to-setupcheck
Migrate header check to setupcheck API
2024-03-14 14:39:35 +01:00
Côme Chilliet
6278cf181e
fix: Improve HSTS warning wording as suggested by reviewer
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-14 11:49:47 +01:00
Ferdinand Thiessen
002fda62f1 fix(settings): posix_getpwuid can return false which should not be accessed using array operation
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-13 16:13:03 +01:00
Côme Chilliet
9f819f311f feat: Migrate HSTS check to Security headers SetupCheck
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +01:00
Côme Chilliet
d7193ef65e fix: Migrate security headers check tests and fix the SetupCheck implementation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +01:00
Côme Chilliet
310377e496 fix: Fix Security headers setup check behavior
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +01:00
Côme Chilliet
1fffdf4763 fix: Fix ocm-provider setup check failure detection
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +01:00
Côme Chilliet
a47a1e6249 feat: Migrate header check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +01:00
Maxence Lange
519e434573 fix(updatenotification): spread the use of new appconfig
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-03-13 02:22:11 -01:00
Andrey Borysenko
865fd3ba08
fix: add missing copyrights and strict types
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-03-12 18:14:40 +02:00
jld3103
4ac2375ca2
feat: Add declarative settings
Signed-off-by: jld3103 <jld3103yt@gmail.com>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-03-12 13:56:54 +02:00
Ferdinand Thiessen
58f57fd13f
fix(settings): Adjust order of parameters for runRequest
Fixing invalid request to host `HEAD`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-08 11:21:51 +01:00
Côme Chilliet
1ea88a73f6 feat(settings): Migrate .well-known URL setup check to new API
Co-authored-by: Côme Chilliet <come.chilliet@nextcloud.com>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-07 14:06:08 +01:00
John Molakvoæ
a6a962d5a2
fix(settings): adjust source maps setup check wording and log level
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-03-06 15:11:32 +01:00
John Molakvoæ (skjnldsv)
f0494e2b5a
feat(settings): add JavaScript Source Maps support .js.map setup check
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-03-06 11:16:10 +01:00
Côme Chilliet
5794e1c9d6
Merge pull request #43906 from nextcloud/enh/migrate-ssl-url-setupcheck
feat(settings): Migrate SSL access and URL generation check to SetupCheck API
2024-03-04 15:54:47 +01:00
Ferdinand Thiessen
ef2c312b18
feat(settings): Migrate data directory protection check to SetupCheck
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-29 13:54:01 +01:00
Côme Chilliet
ca246dc35c
feat(settings): Migrate SSL access and URL generation check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-29 12:21:36 +01:00
Ferdinand Thiessen
ad747ab62b
feat(settings): Migrate OCM / OCS provider tests to SetupCheck
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-27 14:52:10 +01:00
Andrii Rublov
a72706f1e6
Merge branch 'master' into fix/pages-titles-apps
Signed-off-by: Andrii Rublov <github.a@rublov.me>
2024-02-25 13:48:38 +01:00
John Molakvoæ
b080113fdd
Merge branch 'master' into fix/42480/user-admin-not-admin
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-02-24 19:31:22 +01:00
Ferdinand Thiessen
00386a5407 fix(settings): Use initial state instead of custom state for server data
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-23 21:59:02 +01:00
Ferdinand Thiessen
dd7fba2c95 fix(settings): Only use id in categories - drop duplicated ident property
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-23 21:59:02 +01:00
Andrii Rublov
8d22d341c8 [Bugfix]: Titles of pages (dashboard, apps-settings, users-settings) #43327
Signed-off-by: Andrii Rublov <airublev@outlook.com>
2024-02-23 18:39:23 +01:00
Arthur Schiwon
c98b0462e3 fix(admin role): fix old and wrong way to determine whether user is admin
- fixes Settings knowing who is an admin of non-local group backend groups
- obsoletes and removes a little old, deprecated code
- double checks proper parameter type on Group\Manager::isAdmin
- also fixes legacy OC_User code to check whether user is an admin

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-02-19 18:57:22 +01:00
Ferdinand Thiessen
398b042af7
enh(settings): Migrate WOFF2 loading check to a SetupCheck
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-15 02:17:20 +01:00
Ferdinand Thiessen
096d66edc8
enh(settings): Add trait for setup checks that need to access the webserver using HTTP requests
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-15 02:17:16 +01:00
John Molakvoæ
524ed97d62
fix: replace Account name by Login
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-13 21:08:10 +01:00
Vincent Petry
839ddaa354
feat: rename users to account or person
Replace translated text in most locations

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2024-02-13 21:06:30 +01:00
Simon L
9228adba73 do not break personal settings page is viewer is not there
Signed-off-by: Simon L <szaimen@e.mail.de>
2024-02-09 12:28:06 +01:00
Côme Chilliet
303e2febc7
Merge pull request #43387 from nextcloud/fix/migrate-away-from-ilogger-in-jobs 2024-02-08 18:27:44 +01:00
Louis Chemineau
898df41de9
Revert "Merge branch 'master' of github.com:nextcloud/server"
This reverts commit d9d60238c7, reversing
changes made to ba3fdb0cdc.
2024-02-08 15:31:19 +01:00
Simon L
ca5f7adebc
Merge pull request #43435 from nextcloud/enh/noid/do-not-break-personal-settings-without-viewer
do not break personal settings page is viewer is not there
2024-02-08 14:39:18 +01:00
Simon L
686e2683ed fix psalm
Signed-off-by: Simon L <szaimen@e.mail.de>
2024-02-08 14:12:28 +01:00
Côme Chilliet
166773879b fix!: Migrate jobs away from deprecated interfaces
BREAKING CHANGE: Removed ILogFactory::getCustomLogger deprecated method

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-08 10:28:29 +01:00
Simon L
b0c57ed65f do not break personal settings page is viewer is not there
Signed-off-by: Simon L <szaimen@e.mail.de>
2024-02-07 14:29:22 +01:00
Côme Chilliet
618fae7759
Merge pull request #43215 from nextcloud/rakekniven-patch-3
fix(i18n): Adapted spelling of Unicode
2024-02-01 11:07:46 +01:00
Baptiste Fotia
9af96d9f9a feat(php,vue): Create a new parameter
Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
2024-01-31 10:44:40 +01:00
rakekniven
8663da1e50
fix(i18n): Adapted spelling of Unicode
Reported at Transifex

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2024-01-30 16:54:21 +01:00
Côme Chilliet
8bcc2d352e chore: Fix missing template parameter for IEventListener
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-30 10:57:15 +01:00
Ferdinand Thiessen
cff36b7156
Merge pull request #42331 from nextcloud/fix/auth-token-settings
fix(settings): Disable renaming for tokens marked to be wiped
2024-01-29 18:47:19 +01:00
Ferdinand Thiessen
d49b70773b
fix(settings): Disable renaming for tokens marked to be wiped
This otherwise a WipeException will be thrown when trying to rename

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-29 13:53:45 +01:00
Côme Chilliet
936c6a2928 Migrate debug mode check to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-29 10:11:03 +01:00
Côme Chilliet
3be505f9c2
Rename to "Push service" and enable on all instances to avoid trouble
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-25 15:23:54 +01:00
Côme Chilliet
67541f21f6
Migrate fair use of free push service check to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-25 13:05:59 +01:00
Côme Chilliet
9add64f30e
Merge writable temporary space check with the s3 one, and improve
It will now show available space and path of both PHP and Nextcloud
 temporary directories if they differ.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-25 11:47:30 +01:00
Côme Chilliet
ccbc5fc273
Remove old version of temporary space setup check and fix tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-25 11:47:29 +01:00
Côme Chilliet
058f7d5664
Migrate available temp space check to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-25 11:47:29 +01:00
Côme Chilliet
10664e9529 Migrate MySQL utf8mb4 check to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-23 17:34:04 +01:00
John Molakvoæ
4dc224fa2c
Merge pull request #42999 from nextcloud/fix/mjs-setup-check-local 2024-01-23 15:13:24 +01:00
Côme Chilliet
c43144fc7d
Remove bz2 leftover description
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-22 15:56:40 +01:00
Côme Chilliet
f13b2fb103
Add missing recommended modules gmp and bcmath
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-22 15:08:59 +01:00
Côme Chilliet
4c34216305
Fix description for exif PHP module
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-22 15:07:37 +01:00
Côme Chilliet
ca3e1a531a
Merge gmp and bcmath module checks with the existing PHP modules setup check
Also add description for why each module is recommended

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-22 15:07:21 +01:00
Côme Chilliet
d51522750e
Merge pull request #42821 from J0WI/rm-bz2-check
Remove disputed bz2 check
2024-01-22 11:11:36 +01:00
Ferdinand Thiessen
d2cb90bda2
fix(settings): Allow to connect to local address when checking for .mjs support
Also reduce the severity in case of a failed check to warning.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-21 20:20:53 +01:00
provokateurin
b64ab5fba8
refactor: Migrate IgnoreOpenAPI attributes to OpenAPI
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-01-18 16:14:17 +01:00
Côme Chilliet
a77bab2f95
Migrate set_time_limit setup check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-18 12:36:53 +01:00
Ferdinand Thiessen
1334055ab8
Merge pull request #42812 from nextcloud/enh/migrate-memcached-setupcheck
Migrate memcached PHP module setup check to new API
2024-01-18 12:23:02 +01:00
Côme Chilliet
5ad549a72f
Migrate memcached PHP module setup check to new API
Merged it with the other existing memcache setup check as it fits

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-18 09:40:43 +01:00
rakekniven
b09fa57c16
fix(i18n): Change cli to uppercase
Like all other occurences.

Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2024-01-18 09:18:05 +01:00
Côme Chilliet
0e889da4a8
Remove obsolete check of curl SSL version
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-16 16:14:40 +01:00
Côme Chilliet
46ebe16c83 Migrate Cron checks to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-16 10:49:19 +01:00
Côme Chilliet
0483064f07 Migrate overwrite.cli.url setup check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-16 09:05:40 +01:00
Côme Chilliet
80d58f0162
Merge pull request #41312 from nextcloud/feat/migrate-code-integrity-check 2024-01-16 09:04:24 +01:00
J0WI
1cb7ccfb45 Remove disputed bz2 check
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2024-01-15 23:45:47 +00:00
Ferdinand Thiessen
265e9060f8
Merge pull request #42436 from nextcloud/enh/add-mjs-setup-check
enh(settings): Add SetupCheck to ensure webserver correctly serves `.mjs` files
2024-01-15 18:21:42 +01:00
Côme Chilliet
24f8b04908
Remove CSRF check from code integrity rescan
Did not find a way to get a valid token from SetupCheck

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-15 11:50:48 +01:00
Côme Chilliet
1c4d43923a
Use highlight rich objecttype to render links in CodeIntegrity setup check
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-15 11:50:48 +01:00
Côme Chilliet
f06b8da249
Migrate code integrity to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-15 11:50:38 +01:00
Andrey Borysenko
09ee265353
Add missing ProviderWithId check
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-01-14 17:58:00 +02:00
Julius Härtl
2df26608ef
Merge pull request #42649 from nextcloud/enh/machine-translation-provider-with-id 2024-01-11 21:50:50 +01:00
Côme Chilliet
f789732922
Merge pull request #42640 from nextcloud/fix/fix-authentication-exceptions-2
Always catch OCP versions of authentication exceptions
2024-01-11 18:51:43 +01:00
Côme Chilliet
8fc39aeb1c Use IToken from OCP instead of OC
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 14:02:15 +01:00
Côme Chilliet
95ea6188dc Suppress or fix psalm errors related to InvalidTokenException
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 14:02:15 +01:00
Côme Chilliet
eee9f1eec4 Always catch OCP versions of authentication exceptions
And always throw OC versions for BC

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 14:02:15 +01:00
Côme Chilliet
d1f2add10c Migrate PHP imagick module check to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 11:28:59 +01:00
Ferdinand Thiessen
c5fbd969dd Update apps/settings/lib/SetupChecks/JavaScriptModules.php
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-10 11:58:51 +01:00
Ferdinand Thiessen
995b23e818 enh(settings): Add SetupCheck to ensure webserver correctly serves .mjs files
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-10 11:58:51 +01:00
Marcel Klehr
1fd0c2979e enh(OCP\Translation): Add ITranslationProviderWithId
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-01-10 11:16:14 +01:00
Joas Schilling
2c815256f2
Merge pull request #42590 from nextcloud/add-settings-section-type-attribute
Add settings section type attribute on settings app-content section
2024-01-10 09:23:26 +01:00
Côme Chilliet
3d4c4f19b4
Migrate app dir owner check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-08 17:37:14 +01:00
Côme Chilliet
94d0399229
Improve PHP opcache setup check and reduce level in some cases
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-08 16:03:53 +01:00
Côme Chilliet
c92fbca6e6
Fix small psalm issue
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-08 15:09:09 +01:00
Côme Chilliet
f6df5dae34
Remove unsupported <code> tag and use quotes instead
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-08 15:09:09 +01:00
Côme Chilliet
989b5ffbab
Remove unused properties from CheckSetupControllerTest
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-08 15:09:09 +01:00
Côme Chilliet
3f13a1a47e
Migrate opcache check to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-08 15:09:09 +01:00
Thomas Citharel
c75fbf8a83
Add data-active-section-type attribute to app-content settings section
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2024-01-05 09:58:46 +01:00
Marcel Klehr
53be798a70
Merge branch 'master' into enh/text-processing-provider-with-id 2023-12-19 16:14:13 +01:00
Marcel Klehr
928fee8ab4 enh(SpeechToText): Allow providers to declare a dynamic ID instead of using className
this allows AppAPI to register anonymous classes as SpeechToText providers

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-12-19 12:31:21 +01:00
Marcel Klehr
2e0141165a
Merge branch 'master' into enh/text-processing-provider-with-id
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-12-19 12:29:03 +01:00
Joas Schilling
26f4ec66af
feat(setupcheck): Add setup check for maintenance_window_start config
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-12-18 11:29:38 +01:00
Benjamin Gaussorgues
208e6bc492 feat(settings): add occ commands to handle admin delegation
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-12-13 09:25:24 +01:00
Côme Chilliet
95ea46c99c Merge SQlite warning to existing SupportedDatabase setup check
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-12-07 15:45:27 +01:00
1 Man Projects
6ef5958007
Fix AppSettingsController.php overwriting currentLanguage
Fix for CurrentLanguage being overwritten by currentVersion thus breaking App-View

Signed-off-by: 1 Man Projects <reed@1manprojects.de>
2023-12-05 20:24:35 +01:00
Côme Chilliet
60bc97e543
Migrate away from deprecated doctrine/dbal getName function
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-28 14:08:10 +01:00
Côme Chilliet
51758117a7
Migrate database pending bigint conversions check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-28 14:07:47 +01:00
Côme Chilliet
9a1f5edb65 Missing things in database should be warning, not info
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +01:00
Côme Chilliet
a0e365f6d2 Switch from deprecated hasPrimaryKey to getPrimaryKey function
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +01:00
Côme Chilliet
1b547c7db8 Migrate missing primary key database check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +01:00
Côme Chilliet
ad88c04f2d Migrate missing index database check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +01:00
Côme Chilliet
2cb1c0f2dc Migrate missing column database check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +01:00
Joas Schilling
011390aacb
Merge pull request #41640 from nextcloud/bugfix/noid/fix-memory-limit-setup-check
fix(setupcheck): Fix memory limit setup check
2023-11-27 06:39:57 +01:00
Arthur Schiwon
c5caae1bf0
Merge pull request #41678 from nextcloud/branchoff/master-is-now-29
Master is now 29
2023-11-23 12:02:20 +01:00
Joas Schilling
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +01:00
Joas Schilling
61572c1985
fix(security): Update expiration date in security.txt
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-23 10:09:39 +01:00
Valdnet
318875a16e
Add quotation marks
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-11-23 08:43:20 +01:00
Valdnet
ea3865138f
Correct spelling
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-11-23 08:39:17 +01:00
Andy Scherzinger
83c6db44c7
Merge pull request #41642 from nextcloud/Valdnet-patch-1
Correct spelling of Brute Force and other fixes
2023-11-22 19:27:46 +01:00
Valdnet
0acd07c362
Change "brute force" to "brute-force"
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-11-22 14:22:47 +01:00
Benjamin Gaussorgues
0d8aa6894a
feat(search): hide user search if not on user list
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-22 08:47:53 +01:00
Valdnet
94e05ea919
Correct a typo
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-11-21 15:45:33 +01:00
Valdnet
519fad9206
Add quotation marks
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-11-21 15:40:01 +01:00
Valdnet
6475f2f8be
Add quotation marks
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-11-21 15:32:38 +01:00
Valdnet
f5a40c2219
Correct spelling of Brute Force
Correcting the spelling of "Bruteforce" to "Brute Force"

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-11-21 15:19:16 +01:00
Joas Schilling
4fe363f882
fix(setupcheck): Fix memory limit setup check
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-21 14:47:21 +01:00
Côme Chilliet
24c2c09aea
Merge pull request #41438 from nextcloud/feat/migrate-forwarded-for-headers-check
Migrate forwarded for headers check
2023-11-21 09:50:38 +01:00
Côme Chilliet
ad372869bc
Fix tests for setupchecks
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-20 18:03:15 +01:00
Ferdinand Thiessen
22163c60d4
enh(settings): Migrate admin settings for sharing to vue
This is required to get the fixes for a11y from `@nextcloud/vue`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-11-20 17:07:55 +01:00
Côme Chilliet
1f4e0927ba
Improve success messages for ForwarderForHeaders setup check
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-20 16:12:19 +01:00
Côme Chilliet
f023216cf4
Make it an error if address is not known and we are not in CLI
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-20 15:52:28 +01:00
Côme Chilliet
f47a2bbcae
Improve wrong configuration error message when we know it’s wrong.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-20 15:45:46 +01:00
Côme Chilliet
0107c7ea24 Migrate Forwarded For Headers check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-20 11:36:42 +01:00
Côme Chilliet
0da05fc73b
Merge pull request #41435 from nextcloud/feat/migrate-bruteforce-throttle-check
Migrate bruteforce throttle check
2023-11-20 11:32:06 +01:00
Côme Chilliet
70acf44a45
Merge pull request #41086 from nextcloud/feat/migrate-memory-limit-setup-check
Migrate memory_limit check to new SetupCheck API
2023-11-14 10:50:31 +01:00
Benjamin Gaussorgues
8be988b645 Fix application search provider order
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-13 16:38:49 +01:00
Côme Chilliet
fe8b5d47ae
Migrate Bruteforce Throttle check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-13 16:26:59 +01:00
Côme Chilliet
7495236034
Migrate memory_limit check to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-13 15:55:46 +01:00
Marcel Klehr
f6d765fc1f fix: Use getId() in ArtificialIntelligence settings
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-11-08 16:47:22 +01:00
Côme Chilliet
86290dd888
Add missing dots in PhpModules setup check descriptions
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 14:15:47 +01:00
Côme Chilliet
00d3856b92
Revert "Migrate code integrity to SetupCheck API"
This reverts commit aa2d315d95d37b48752d0e92d0ce79913be1d4f1.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:04 +01:00
Côme Chilliet
0fd5ed9854
Migrate 32bit check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:03 +01:00