upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-26 00:27:49 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 29
83004 commits 874 branches 1197 tags 8.4 GiB
Commit graph

1215 commits

Author SHA1 Message Date
Joas Schilling
6cccdf98f4
test: Migrate CardDAV tests to PHPUnit10 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-05-25 22:22:57 +02:00
Joas Schilling
154d390c02
test: Migrate CalDAV tests to PHPUnit10 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-05-25 14:11:17 +02:00
Louis
a48bc55e2a
Merge pull request #52810 from nextcloud/artonge/feat/do_not_require_samesite_strict_cookie_on_public.php 2025-05-22 10:30:16 +02:00
Louis Chemineau
009d0c550c
fix: Move CSRF check from base to PublicAuth for public.php 
This currently prevent directly accessing a ressource when clicking on a link on a third party site. Example, clicking on `https://example.com/public.php/dav/files/pqLWcA269zfzXez/?accept=zip` in a GitHub comment.

Skipping the check is an issue with password protected shares, as it allows third party sites to request the ressource when the user already entered the password, aka CSRF.  So after removing the check from `base.php`, we need to add the it again in the `PublicAuth` plugin.

We also add a redirect to be helpful to the user.

**Warning**: this adds the limitation that clicking on a direct download link for password protected shares will redirect you to the password form, and then to the main share view.

Fix #52482

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-05-21 16:01:36 +02:00
Richard Steinmetz
9a74d9a1a5
fix(caldav): don't send invitations to circles 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2025-05-21 13:28:57 +02:00
Ferdinand Thiessen
e693a5d4a5
fix(dav): correctly handle uploading folders with same name as a file 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-05-16 14:38:41 +02:00
provokateurin
78a175fc74
refactor: Apply rector refactorings 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-05-14 15:29:02 +02:00
Daniel Kesselberg
c05d3fdb2e
fix(caldav): prevent unshare entry creation for owner unsharing 
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- https://github.com/nextcloud/server/pull/43117
- https://github.com/nextcloud/server/pull/47737

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2025-05-14 09:03:32 +02:00
John Molakvoæ (skjnldsv)
4495794a0b
feat(dav): allow uploading folders to public shares 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2025-05-13 16:03:20 +02:00
Daniel
1c2b4f2a41
Merge pull request #52586 from nextcloud/bugfix/noid/remove-sleep-from-throttler 
fix(throttler): Always use the sleepDelayOrThrowOnMax instead of deprecated sleepDelay
 2025-05-06 19:22:53 +02:00
John Molakvoæ
24c6a1ff0b
Merge pull request #52182 from nextcloud/feat/dav/public-share-chunked-upload 2025-05-06 14:25:28 +02:00
SebastianKrupinski
a2d4f8d3f1
feat: Calendar Export 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
 2025-05-06 11:09:33 +02:00
provokateurin
46f5b07322
feat(dav): Enable chunked upload for public shares 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-05-05 13:23:11 +02:00
provokateurin
7f0953d520
refactor(dav): Replace baseuri manipulation with RootCollection for public shares 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-05-05 13:23:11 +02:00
Richard Steinmetz
d0fcb7e638
fix(dav): move orphan cleaning logic to a chunked background job 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2025-05-05 12:13:09 +02:00
Joas Schilling
7964f338dc
fix(throttler): Remove the sleep from the throttler that throws 
The sleep is not adding benefit when it's being aborted with 429
in other cases anyway.

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-05-02 11:27:29 +02:00
skjnldsv
58aaddeca5 fix(dav): check the owner displayName scope before giving attribute 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2025-04-30 08:37:08 +02:00
Hamza Mahjoubi
58ffd9d06e fix: check if config is enabled before creating a default contact 
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
 2025-04-28 11:46:32 +02:00
Louis
b2a187d296
Merge pull request #51729 from nextcloud/artonge/support_oc_checksum_in_bulk_upload 
feat: Support OC-Checksum in bulk upload
 2025-04-15 09:49:38 +02:00
Louis Chemineau
3bb2a92962
feat: Support OC-Checksum in bulk upload 
To align with the rest of Nextcloud.

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-04-01 14:35:21 +02:00
Richard Steinmetz
246da73a36
fix(oauth2): retain support for legacy ownCloud clients 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2025-04-01 11:25:52 +02:00
Hamza Mahjoubi
099d9fb9be feat: add example contact on first login 
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
 2025-03-26 10:57:39 +01:00
skjnldsv
6fc453540b fix(dav): filter user files when updating tags 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2025-03-25 12:30:03 +01:00
Hamza Mahjoubi
c9d9abd46e fix(cardav): only show useres from enabled addressBooks in contacts menu 
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
 2025-03-17 11:56:34 +01:00
Daniel Kesselberg
db86cf8db1 fix: skip caching lastSeenQuotaUsage for remote shares 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2025-03-14 10:24:34 +01:00
Edward Ly
dee1d4fff3
feat(dav)!: migrate OCA calendar object events to OCP 
Signed-off-by: Edward Ly <contact@edward.ly>
 2025-03-07 08:09:53 -08:00
Christoph Wurst
ec664b0aea fix(dav): Create SAB at installation 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2025-03-06 18:40:30 +01:00
Côme Chilliet
64863c9d46
chore: Apply new rector configuration to apps folder 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-02-13 11:46:42 +01:00
Côme Chilliet
ed5b7ae161
chore: re-apply current rector configuration to apps folder 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-02-13 11:45:33 +01:00
Côme Chilliet
ed9b47462f
Merge pull request #49648 from nextcloud/fix/clarify-app-manager-methods 
Clarify app manager method names
 2025-02-13 11:33:52 +01:00
Côme Chilliet
f758f565d4
fix: Replace getInstalledApps calls with getEnabledApps 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-02-13 10:19:20 +01:00
Côme Chilliet
355fef6ff9
fix(tests): Order card properties by name to avoid issues 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-02-10 16:08:21 +01:00
Côme Chilliet
4924fe9a12 fix(dav): Migrate from hooks to user events 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-02-10 14:52:18 +01:00
Raimund Schlüßler
66e87fa455 fix(TasksSearchProviderTest): adjust deep link to Tasks app 
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
 2025-01-24 22:35:20 +01:00
Richard Steinmetz
f0702ad89f
Merge pull request #50034 from nextcloud/rename-deleted-default-calendar-in-trashbin 
fix(caldav): rename default calendar to keep it in the trashbin instead of purging it
 2025-01-11 16:33:44 +01:00
Sebastian Krupinski
3ab0d672b1
Merge pull request #49852 from nextcloud/fix/issue-49756-translations 
fix: change translation logic to handle plurals better
 2025-01-07 08:49:03 +00:00
Robin Appelman
757076af29
fix: explicitly ignore nested mounts when transfering ownership 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-01-06 14:45:35 +01:00
Thomas Citharel
ef0e2213ea
fix(caldav): rename default calendar to keep it in the trashbin instead of purging it 
When doing a PROPFIND on default-calendar-url, if the current default calendar (fallbacking on personal uri)
is in the trashbin, it's being purged so that it's recreated.

This leads to loss of data.

We can simply rename the calendar URI and add a unique suffix so that it doesn't conflict with the new calendar
being created.
Shares are fine because they reference the resourceid and not the calendar URI.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2025-01-06 11:45:05 +01:00
SebastianKrupinski
a912556a89 fix: change translation logic to handle plurals better 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
 2025-01-06 10:21:19 +01:00
Joas Schilling
f9ee3505a0
Merge pull request #49731 from nextcloud/bugfix/noid/allow-to-get-permissions-of-a-principal 
fix(calendar): Fix getting the permissions of the user
 2024-12-16 15:02:51 +01:00
Joas Schilling
fddbc54003
test: Adjust tests to proof exclusion of other principal permissions 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-12-16 08:36:25 +01:00
Sebastian Krupinski
dd89911b31
Merge pull request #49528 from nextcloud/fix/issue-47879-property-serialization 
fix: replace null character when serializing
 2024-12-13 20:20:42 -05:00
SebastianKrupinski
0628eb62f3 fix: return 204 instead of 404 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
 2024-12-13 11:47:18 -05:00
SebastianKrupinski
c1dd8ddf59 fix: replace null character when serializing 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
 2024-12-13 11:46:26 -05:00
Julius Knorr
cba556d641
Merge pull request #48612 from nextcloud/fix/activity-log-for-favorites-in-dav 
add activity logging for favorites in dav
 2024-12-12 15:18:47 +01:00
SebastianKrupinski
04cb122af2 fix: disable both iTip and iMip messages 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
 2024-12-10 12:39:49 -05:00
SebastianKrupinski
a92547888c fix: add support for Microsoft time zones 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
 2024-12-09 12:39:37 -05:00
skjnldsv
0c7e259151 feat(systemtags): allow setting color with occ 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-12-06 10:19:42 +01:00
skjnldsv
adf8a454dd feat(systemtags): add color support backend 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-12-06 10:19:42 +01:00
Robin Appelman
e4d0882b31
fix: improve assembly stream 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-12-05 14:12:36 +01:00
grnd-alt
2d02d83597 fix(dav): add activity logging for favorites in dav 
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
 2024-12-03 20:56:36 +01:00
Marcel Müller
303a21fc9d chore(absence): Add capability for absence replacement support 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
 2024-12-01 23:15:32 +01:00
Marcel Müller
66d4f0e4c0 chore(absence): Add capability for absence api 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
 2024-12-01 23:15:32 +01:00
skjnldsv
8c0f8db6ca feat(config): add maximum.supported.desktop.version 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-11-27 11:39:49 +01:00
Daniel Kesselberg
6b383faf41
Revert "fix(dav): Always respond custom error page on exceptions" 
This reverts commit 9992e7d439.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2024-11-22 11:55:25 +01:00
Thomas Citharel
d3068f5db5
feat(dav): increase default calendar subscription refresh rate to one day 
With the performance benefits from #43541 it makes sense

Reference https://github.com/nextcloud/server/issues/46171#issuecomment-2487910923

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2024-11-20 10:07:29 +01:00
Richard Steinmetz
d61d62b64f
Merge pull request #48833 from nextcloud/fix/issue-48732-exdate-rdate-property-instances 
fix: RDATE and EXDATE property instances
 2024-11-15 07:49:13 +01:00
SebastianKrupinski
fbd8afb405 fix: use invokePrivate for test 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
 2024-11-14 10:46:47 -05:00
SebastianKrupinski
3e870695bc feat: mail provider settings 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
 2024-11-12 13:19:35 -05:00
SebastianKrupinski
bfa23ff6c7 feat: Add X-NC-Disable-Scheduling property to allow skipping scheduling 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
 2024-11-11 12:40:55 -05:00
Joas Schilling
298948c28c
ci: Skip currently PHP 8.4 incompatible test 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-11-08 14:18:24 +01:00
skjnldsv
f24b93e506 feat(dav): add systemtag object IDs listing 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-10-29 09:08:30 +01:00
Kate
070adc1131
Merge pull request #48790 from nextcloud/refactor/apps/constructor-property-promotion 2024-10-22 12:47:45 +02:00
SebastianKrupinski
3f4210e737 fix: override iTip Broker to fix several issues 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
 2024-10-21 14:21:28 -04:00
SebastianKrupinski
de22119775 fix: RDATE and EXDATE property instances 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
 2024-10-21 14:08:43 -04:00
provokateurin
381077028a
refactor(apps): Use constructor property promotion when possible 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-21 12:37:59 +02:00
Pablo Zmdl
280adb3e94 feat: configurable request timeout for carddav sync 
Big federated setups may need a longer timeout, which they now can
configure.

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
Co-authored-by: Josh <josh.t.richards@gmail.com>
 2024-10-17 22:27:10 +02:00
Côme Chilliet
1580c8612b
chore(apps): Apply new rector configuration to autouse classes 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-10-15 10:40:25 +02:00
provokateurin
2489608a72
refactor(dav): Add Storage parameter strong types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-07 15:00:07 +02:00
Anna
004d7dac91
Merge pull request #48508 from nextcloud/fix/webcal-subscription-jobs-middleware 
fix(caldav): add missing handlers
 2024-10-02 15:12:26 +02:00
escoand
a5eb38f277
fix(dav): don't crash subscription on invalid calendar object 
Signed-off-by: escoand <escoand@users.noreply.github.com>
 2024-10-02 11:33:18 +02:00
Anna
e333bc3c8f
Merge pull request #47788 from nextcloud/feat/add-addressbook-list-command 
feat(carddav): add command to list address books
 2024-10-02 10:35:44 +02:00
Anna Larch
d30c0669a6 fix(caldav): add missing handlers 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2024-10-01 22:12:37 +02:00
Daniel Kesselberg
870816466f
fix: make federation address book sync work with allow_local_remote_servers = false 
Client.preventLocalAddress expects an absolute URL, which means the base_uri option cannot be used.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2024-10-01 18:00:46 +02:00
Anna Larch
6468ec5716 feat(carddav): add command to list address books 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2024-09-30 11:53:02 +02:00
provokateurin
256a8d8903
test: Fix IStorage return types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-26 17:29:48 +02:00
Côme Chilliet
8927510685
Merge pull request #48223 from nextcloud/feat/add-rector-config 
Add rector config
 2024-09-23 15:10:30 +02:00
Joas Schilling
bec14dc4a5
Merge pull request #48215 from nextcloud/bugfix/noid/run-all-unit-tests 
fix(tests): Fix test selection and run unit tests of DAV and user_status
 2024-09-23 12:49:30 +02:00
Côme Chilliet
1a4978c4ea
chore: Apply rector configuration to apps folder 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-20 17:51:00 +02:00
Ferdinand Thiessen
051ee7e7fd
chore: Get rid of travis in DAV app 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-19 20:53:31 +02:00
Anna Larch
69119eb13b
test: fix ContactsMigratorTest 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2024-09-19 19:29:57 +02:00
Hamza
34445ea9d1
Merge pull request #47399 from nextcloud/fix/47275/driverException 
fix: expand select and group by for calendar reminder backend
 2024-09-19 16:57:17 +02:00
Hamza Mahjoubi
ab3a239853 fix: expand select and group by for calandar reminder backend 
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
 2024-09-19 15:25:16 +02:00
provokateurin
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-19 14:21:20 +02:00
Robin Appelman
627980ec2a test: fix service overwrite in PartFileInRootUploadTest 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-09-18 16:10:14 +02:00
Côme Chilliet
03b969fb95
chore: Improve typing and phpdoc comments 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-16 20:29:48 +02:00
Côme Chilliet
801733e523
fix: Remove OCP\Files\Storage interface deprecated since version 9 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-16 18:10:48 +02:00
John Molakvoæ
816ffa469a
Merge pull request #48044 from nextcloud/fix/cast-node-names-to-string 2024-09-16 11:08:50 +02:00
Anna
d46f271b1f
Merge pull request #48049 from nextcloud/refactor/void-tests 
refactor: Add void return type to PHPUnit test methods
 2024-09-16 00:11:41 +02:00
Anna Larch
eb8cec2b96 test: cast node name and data to string 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2024-09-15 23:05:59 +02:00
Christoph Wurst
49dd79eabb
refactor: Add void return type to PHPUnit test methods 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2024-09-15 22:32:31 +02:00
Anna Larch
d5177c8e8f test(dav): imip service test expects integers for last occurence 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2024-09-15 22:28:37 +02:00
Ferdinand Thiessen
5fc715a9e2
fix: Adjust unit tests and protect against XSS 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-06 17:16:10 +02:00
Camila
0a72756d96
fix(dav): Update 403 error message 
* The user should get a more friendly warning when their desktop client version is not supported anymore by the server.
  See #nextcloud/desktop/issues/6273
* Update BlockLegacyClientPluginTest to reflect the new 403 error message.

Signed-off-by: Camila Ayres <hello@camilasan.com>
 2024-09-06 17:15:45 +02:00
Louis Chemineau
9992e7d439
fix(dav): Always respond custom error page on exceptions 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-09-05 16:17:32 +02:00
Ferdinand Thiessen
0d41c49918 fix(dav): Pre-check if node can be copied or moved in DAV files plugin 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-08-28 17:22:20 +02:00
Daniel Kesselberg
af6de04e9e
style: update codestyle for coding-standard 1.2.3 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2024-08-25 19:34:58 +02:00
Anna Larch
5bbc23a261 fix(caldav): allow renaming of birthday calendars 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2024-08-20 10:16:57 +02:00
Richard Steinmetz
b8ec68d212
Merge pull request #46723 from nextcloud/feat/add-delta-sync-to-subscription-calendars 
feat(webcal): only update modified and deleted events from webcal calendars
 2024-08-14 08:57:03 +02:00
Christoph Wurst
7641e768b3
Merge pull request #45435 from nextcloud/feat/dav/upcoming-events-api 
feat(dav): Add an API for upcoming events
 2024-08-14 06:54:43 +02:00