Add config option shareapi_bundle_reshare_with_edit to include reshare
permission in "Allow editing" bundle. Default is true to maintain
backward compatibility.
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Handle backward compatibility when config.defaultPermissions includes
the SHARE permission (value 31) which was previously part of
BUNDLED_PERMISSIONS.ALL. Now that ALL no longer includes SHARE, the
comparison must strip SHARE before checking against bundled permissions.
This fixes an issue where the Advanced Settings section would be
auto-expanded for new shares, causing a toggle to close it instead
of opening it.
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Remove PERMISSION_SHARE from bundled permissions for ALL and ALL_FILE.
Update quick share selector to consistently strip share permission
when comparing, ensuring backwards compatibility with existing shares.
Signed-off-by: nfebe <fenn25.fn@gmail.com>
The backend returns type 'dir' for folders (from FileInfo::TYPE_FOLDER),
but the frontend expects 'folder'. This mismatch caused federated shared
folders to display incorrectly as files in the "Shared with you" view.
Signed-off-by: nfebe <fenn25.fn@gmail.com>
When `showFederatedSharesToTrustedServersAsInternal` is enabled, the
trusted server filter was incorrectly applied to both internal and
external sharing sections. This prevented users from sharing with
federated users on non-trusted servers via the external share UI.
The filter now only applies to the internal section, allowing
non-trusted federated shares to appear in the external section.
Fixes: https://github.com/nextcloud/server/issues/56622
Signed-off-by: nfebe <fenn25.fn@gmail.com>
The password param should never be sent if the intention is not
remove it or update it.
This commit adapts the frontend and backend to this rule to avoid weird bugs
especially around updating new shares.
Signed-off-by: nfebe <fenn25.fn@gmail.com>
This API was deprecated in Nextcloud 23.
It was replaced with `OCA.Sharing.ExternalShareAction` which now have a proper API
by using `registerSidebarAction` from `@nextcloud/sharing` instead.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
When `show_federated_shares_to_trusted_servers_as_internal` is enabled
but `show_federated_shares_as_internal` is not, filter federated share
suggestions to only include trusted servers. Previously, searching for
an email address would suggest non-trusted federated servers.
Resolved: #54511
Signed-off-by: nfebe <fenn25.fn@gmail.com>
This fixes apps providing vue components, which is invalid and does not
always work - and never work with Vue 3.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
`newPassword` is the unsaved password, while `share.password` is the
current saved password.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
The condition was checking shares.length to display the Others with
access component, but shares is filled only on expanding that section,
rendering the section never visible.
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
1. Use correct color
2. Do not mix legacy icon classes with MDI icons this will show two
icons...
3. Use proper aria label and put status into the title
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
The checkbox appears checked when no password is set (share.password ===
undefined)
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>