Commit graph

593 commits

Author SHA1 Message Date
Ferdinand Thiessen
bb1d814e04
fix(files_sharing): adjust for @nextcloud/files v4
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-02-12 11:50:07 +01:00
Ferdinand Thiessen
f075051f4a
test: remove testing internal of libraries and test only app code
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-02-10 14:50:41 +01:00
Ferdinand Thiessen
e088473929
refactor(files_sharing): adjust note to recipient files header
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-02-10 14:50:41 +01:00
Ferdinand Thiessen
7a60e43dd5
refactor(files_sharing): adjust for files library interfaces and remove sideeffects
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-02-06 10:28:57 +01:00
nfebe
b7dceb0b17 feat(sharing): Make share permission in bundled edit configurable
Add config option shareapi_bundle_reshare_with_edit to include reshare
permission in "Allow editing" bundle. Default is true to maintain
backward compatibility.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2026-02-05 07:36:04 +01:00
Ferdinand Thiessen
e25f864e28
chore(legacy): fix @stylistic/exp-list-style ESLint rule
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-01-26 00:05:29 +01:00
Ferdinand Thiessen
985b66c64f
feat(files): render filters in top bar
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-01-22 16:31:48 +01:00
nfebe
2cdbd7fa15 fix(sharing): strip share permission before comparing to bundled perms
Handle backward compatibility when config.defaultPermissions includes
the SHARE permission (value 31) which was previously part of
BUNDLED_PERMISSIONS.ALL. Now that ALL no longer includes SHARE, the
comparison must strip SHARE before checking against bundled permissions.

This fixes an issue where the Advanced Settings section would be
auto-expanded for new shares, causing a toggle to close it instead
of opening it.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2026-01-20 19:30:47 +01:00
nfebe
8526999ad5 feat(sharing): remove share permission from "Allow editing" default
Remove PERMISSION_SHARE from bundled permissions for ALL and ALL_FILE.
Update quick share selector to consistently strip share permission
when comparing, ensuring backwards compatibility with existing shares.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2026-01-20 19:30:47 +01:00
Ferdinand Thiessen
d3813798bf
chore: update @nextcloud/files to v4.0.0-rc.0
- update library
- adjust sidebar tab handling

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-01-16 22:22:57 +01:00
Robin Appelman
de286709f8 feat: hide "External Shares" section if no external shares can be created
Signed-off-by: Robin Appelman <robin@icewind.nl>
2026-01-08 11:49:02 +00:00
Ferdinand Thiessen
f9a137ea87
refactor(files): migrate favorite sidebar action to new Sidebar API
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-01-05 02:23:15 +01:00
Ferdinand Thiessen
7077685bf8
refactor(files_sharing): migrate to new Files Sidebar API
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-01-05 02:23:15 +01:00
Ferdinand Thiessen
9919c2bc91
chore(files): adjust getContents to use AbortController
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-12-23 21:08:33 +01:00
Ferdinand Thiessen
77f9897060
chore(files): adjust code for breaking change of Navigation.setActive
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-12-23 20:17:34 +01:00
Ferdinand Thiessen
ec617b6b3e fix(files_sharing): ensure that external section is mounted
Make sure the external section is mounted before trying to assign it the
node prop.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-12-19 16:25:34 +00:00
skjnldsv
492bdb7010
chore: update @nextcloud/files to 4.0.0
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-12-11 12:44:16 +01:00
nfebe
13df65850e fix(files_sharing): Normalize dir type to folder for federated shares
The backend returns type 'dir' for folders (from FileInfo::TYPE_FOLDER),
but the frontend expects 'folder'. This mismatch caused federated shared
folders to display incorrectly as files in the "Shared with you" view.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-12-11 10:49:41 +01:00
nfebe
08382282ea fix(sharing): allow federated shares to non-trusted servers
When `showFederatedSharesToTrustedServersAsInternal` is enabled, the
trusted server filter was incorrectly applied to both internal and
external sharing sections. This prevented users from sharing with
federated users on non-trusted servers via the external share UI.

The filter now only applies to the internal section, allowing
non-trusted federated shares to appear in the external section.

Fixes: https://github.com/nextcloud/server/issues/56622

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-12-10 17:41:11 +01:00
nfebe
8e7cbcea40 fix(files_sharing): Allow removing password from link shares
Fixes regression from a28834b163

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-12-08 12:42:57 +01:00
Ferdinand Thiessen
f1d28332a6 chore: manually adjust event names (update:checked to update:modelValue)
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-11-25 16:25:54 +01:00
Ferdinand Thiessen
42112c8d30 chore: auto fix ESLint issues
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-11-25 16:25:54 +01:00
skjnldsv
d32878e6db fix(files_sharing): sidebar link share password checkbox
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-11-18 04:59:03 +00:00
Ferdinand Thiessen
0059d17ae3
refactor(files_trashbin): migrate app to Vue 3
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-11-14 17:01:21 +01:00
Ferdinand Thiessen
85b6a0628d
fix(files_sharing): use webroot for public links
Regression of https://github.com/nextcloud/server/pull/55750

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-11-13 20:36:40 +01:00
Luka Trovic
f0cfb52439 fix(sharing): clean old federation shares when select another file/folder
Signed-off-by: Luka Trovic <luka@nextcloud.com>
2025-11-06 09:50:23 +01:00
Andy Scherzinger
67b8be5926 style(icons): Replace icon with outline variant
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2025-10-27 16:29:55 +01:00
nfebe
a28834b163 fix(files_sharing): Only send password on change
The password param should never be sent if the intention is not
remove it or update it.

This commit adapts the frontend and backend to this rule to avoid weird bugs
especially around updating new shares.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-10-21 16:54:55 +01:00
Ferdinand Thiessen
7fbc2ca25e feat: add new link endpoint when using globalscale
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-10-15 18:58:10 +00:00
Ferdinand Thiessen
2b39cb49ab
refactor: adjust code for breaking changes in @nextcloud/dialogs v7
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-10-15 13:45:12 +02:00
Ferdinand Thiessen
23be816568 chore!(files_sharing): remove deprecated OCA.Sharing.ExternalLinkActions
This API was deprecated in Nextcloud 23.
It was replaced with `OCA.Sharing.ExternalShareAction` which now have a proper API
by using `registerSidebarAction` from `@nextcloud/sharing` instead.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-10-14 13:34:54 +02:00
Maksim Sukharev
a4d440e1f0 fix(files_sharing): correctly handle error in case of failing share creation
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-10-14 09:27:05 +02:00
nfebe
c1d9e22c51 fix(sharing): Adapt share suggestions to match trusted servers configs
When `show_federated_shares_to_trusted_servers_as_internal` is enabled
but `show_federated_shares_as_internal` is not, filter federated share
suggestions to only include trusted servers. Previously, searching for
an email address would suggest non-trusted federated servers.

Resolved: #54511
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-10-09 06:53:46 +01:00
Ferdinand Thiessen
ca65cf72d8
chore: add missing import of the logger
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-10-02 13:19:43 +02:00
Ferdinand Thiessen
91f3b6b4ee
chore: adjust code to new codestyle
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-10-02 13:19:42 +02:00
Ferdinand Thiessen
99a026218b
fix(sharing): ensure to check new password
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-09-26 12:02:29 +02:00
Ferdinand Thiessen
ee962f3a37 feat(files_sharing): provide web-components based sidebar API
This fixes apps providing vue components, which is invalid and does not
always work - and never work with Vue 3.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-09-18 15:45:20 +02:00
Ferdinand Thiessen
fdac770f56 fix(files_sharing): use newPassword always for the unsaved password
`newPassword` is the unsaved password, while `share.password` is the
current saved password.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-09-13 11:38:23 +02:00
Ferdinand Thiessen
a2c373b7ea fix: the account files filter should also work in trashbin
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-09-03 18:38:49 +02:00
Andy Scherzinger
e135a595d4
Merge pull request #54841 from nextcloud/fix/files-inline-sharing-status
fix(files_sharing): add some gap between text and sharing status icon
2025-09-03 18:36:58 +02:00
Ferdinand Thiessen
b1cbcb6a84 fix(files_sharing): add some gap between text and sharing status icon
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-09-03 18:00:32 +02:00
Ferdinand Thiessen
7cc564bfd1 fix(l10n): use productName instead of hardcoded 'Nextcloud' where possible
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-09-03 16:24:50 +02:00
Andy Scherzinger
5087e3376a style(icon): Use material symbol variant of upload icon
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2025-08-27 15:19:47 +00:00
Salvatore Martire
0d6e9f8410 fix(files_sharing): remove condition on "Others with access"
The condition was checking shares.length to display the Others with
access component, but shares is filled only on expanding that section,
rendering the section never visible.

Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
2025-08-27 12:14:34 +00:00
Andy Scherzinger
ec84001af7 style(icon): Use material symbol variant of delete icon
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2025-08-27 12:29:34 +02:00
Ferdinand Thiessen
cde2618356 fix(files_sharing): correctly apply icons and copy share link
1. Use correct color
2. Do not mix legacy icon classes with MDI icons this will show two
   icons...
3. Use proper aria label and put status into the title

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-08-26 20:07:37 +00:00
Salvatore Martire
eaaa9070ed fix(files_sharing): do not check password checkbox by default
The checkbox appears checked when no password is set (share.password ===
undefined)

Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
2025-08-26 17:50:30 +02:00
provokateurin
d4b05201d8
fix(files_sharing): Correctly reject pending remote shares
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-08-25 14:55:27 +02:00
John Molakvoæ
d5417d63e0
Merge pull request #54410 from nextcloud/fix/sharing-status-action-sidebar-promise-return 2025-08-21 11:24:15 +02:00
skjnldsv
88d7275c60 chore(files_sharing): remove unused legacy scripts
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-08-20 14:28:36 +00:00