upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-18 21:21:48 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 16
75985 commits 974 branches 1224 tags 8.6 GiB
Commit graph

14641 commits

Author SHA1 Message Date
Git'Fellow
52669438a6 fix(files): Make sure file pointer exists 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2025-03-19 23:25:14 +01:00
Joas Schilling
1b7b66e3af fix(auth): Allow 2FA challenges for Ephemeral sessions 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-03-18 09:16:33 +00:00
Ferdinand Thiessen
92c48d0394
fix(lookup-server): disable lookup server for non-global scale setups 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-03-11 21:58:09 +01:00
Ferdinand Thiessen
e674631f9b
fix(lookup-server): do not query data by default 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-03-11 21:56:45 +01:00
Louis Chemineau
3f2dddd882 fix(login): Properly target public page with attribute 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-03-05 16:59:52 +00:00
Andy Scherzinger
07b1313061
Merge pull request #51253 from nextcloud/backport/50989/stable29 
[stable29] fix: Use case insensitive check when validating login name
 2025-03-05 17:48:48 +01:00
Marcel Müller
76c1bbf48b fix: No IFactory in constructor 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
 2025-03-05 11:41:20 +00:00
Joas Schilling
df1f3c1768 fix(files): Don't do session related work in the constructor of the View 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-03-05 11:41:20 +00:00
Cleopatra Enjeck M.
3f1c70bad3 fix: use mb_strtolower to convert login name 
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
 2025-03-05 06:20:53 +00:00
Cleopatra Enjeck M.
9db02f2612 fix: Improve string comparison 
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
 2025-03-05 06:20:53 +00:00
Cleopatra Enjeck M.
a98f37bc89 fix: Use case insensitive check when validating login name 
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
 2025-03-05 06:20:53 +00:00
Louis
e906134afe
Merge pull request #51060 from nextcloud/backport/51050/stable29 
[stable29] fix: Report duplicated extra files in integrity check
 2025-03-04 13:40:11 +01:00
Stephan Orbaugh
d8040d7d7f
Merge pull request #51201 from nextcloud/backport/51194/stable29 
[stable29] refactor(TempManager): Simplify and unify implementations and remove legacy behavior
 2025-03-04 10:20:18 +01:00
Stephan Orbaugh
04ae493e0f
Merge pull request #51204 from nextcloud/backport/51000/stable29 
[stable29] fix(FederatedShareProvider): Delete external shares when groups are deleted or users removed from a group
 2025-03-04 10:19:45 +01:00
John Molakvoæ
ed720978bc fix: psalm and OCP @since declarations 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>

Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
 2025-03-04 09:30:42 +01:00
skjnldsv
1672a357bd fix: make sure we process mime extensions as string 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2025-03-04 09:29:12 +01:00
provokateurin
b51aad472c
fix(Share20\Manager): Propagate user and group deletion to remote share providers 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-03-04 08:01:03 +01:00
provokateurin
3ca39e3d94
fix(Share20): Convert broken hooks to IEventListener 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-03-04 08:00:59 +01:00
provokateurin
7e8ffd332b
refactor(TempManager): Simplify and unify implementations and remove legacy behavior 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-03-04 07:50:44 +01:00
Louis Chemineau
7588237dc0
fix: Report duplicated extra files in integrity check 
The `array_diff` is not comparing the array keys. This means that an extra key with an expected hash will not be reported. Using `array_diff_assoc` will report such files.

For example, copying `status.php` to `status 2.php`, will only be reported with the new version.

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-03-03 16:15:24 +01:00
Andy Scherzinger
dfc5dee9ce
Merge pull request #51088 from nextcloud/backport/51051/stable29 
[stable29] feat: Close sessions created for login flow v2
 2025-03-03 15:26:32 +01:00
Louis Chemineau
d7bc7f8aa4
fix(login): Support subfolder install for ephemeral sessions 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-03-03 11:42:42 +01:00
Louis Chemineau
9f78eaaa97
fix(login): Also check legacy annotation for ephemeral sessions 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-03-03 11:42:42 +01:00
Louis Chemineau
ff5a03e890
feat: Close sessions created for login flow v2 
Sessions created during the login flow v2 should be short lived to not leave an unexpected opened session in the browser.

This commit add a property to the session object to track its origin, and will close it as soon as possible, i.e., on the first non public page request.

Signed-off-by: Louis Chemineau <louis@chmn.me>

[skip ci]

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-03-03 11:38:04 +01:00
Ferdinand Thiessen
8830bdbb1a refactor: convert sanitize account properties repair step to background job 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-27 12:59:09 +01:00
Ferdinand Thiessen
fb714dfd40 fix: Optimize repair step performance 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-27 12:59:09 +01:00
Ferdinand Thiessen
62d122adfa fix: validate account properties as a repair step 
Replace `ValidatePhoneNumber` from Nextcloud 21 with a new repair step,
`ValidateAccountProperties` which validates and sanitizes all account
properties.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-27 12:59:09 +01:00
Joas Schilling
c63c27d8d5
fix(l10n): Improve english source strings 
- No leading/trailing whitespace
- Use asci single quote

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-02-26 15:27:20 +01:00
Louis Chemineau
f9a4e80a72 fix: Initialize lastConnectionCheck after first connection 
We are checking whether the DB connection is alive once every 30 seconds. But when we are lacking the last check time, we are skipping the check and reconnect logic. This is causing the reconnect logic to never fire in those cases.

It seems to me that "those cases", are actually always the case, as upon initialization, we are not using the proper connection name to store the time.

In the `connect()` logic, when `$this->_conn` is null, `$this->getConnectionName()` is returning `replica`, so `$this->lastConnectionCheck` will be equal to `['replica' => time()];`

60711ea4cf/lib/private/DB/Connection.php (L215-L221)

60711ea4cf/lib/private/DB/Connection.php (L891-L893)

2b6d7bf65f/doctrine/dbal/src/Connections/PrimaryReadReplicaConnection.php (L136-L139)

Then, if the connection name ends up as being 'primary', the reconnect logic is skipped:

60711ea4cf/lib/private/DB/Connection.php (L874-L880)

Follow-up of https://github.com/nextcloud/server/pull/41819

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-02-25 11:08:43 +00:00
Andy Scherzinger
3009d6441d
Merge pull request #50876 from nextcloud/backport/50807/stable29 
[stable29] fix(files): properly forward open params from short urls
 2025-02-19 18:34:42 +01:00
skjnldsv
9cee2c44c4 fix(files): properly forward open params from short urls 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2025-02-19 09:52:53 +01:00
Josh
635dbdc785 fix(Mailer): Fix sendmail binary fallback 
Signed-off-by: Josh <josh.t.richards@gmail.com>
 2025-02-17 19:21:42 +01:00
Andy Scherzinger
50d5aede17
Merge pull request #50795 from nextcloud/backport/50781/stable29 
[stable29] perf(files): faster query to fetch incomplete directories
 2025-02-17 19:15:40 +01:00
Robin Appelman
e020cbbfe7 fix: make locked exception path relative to the view 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-02-15 16:51:00 +01:00
Git'Fellow
62c266deed fix(repair): PHP8.3 deprecation warning 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2025-02-15 11:07:37 +00:00
Benjamin Gaussorgues
ce4d271386
perf(files): faster query to fetch incomplete directories 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2025-02-14 11:00:07 +01:00
Louis Chemineau
ef4281ebe3 fix(files): Correctly copy the cache information on copy operations 
Needed to copy the `encrypted` flag of encrypted files when those files are two level down in a moved folder.

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-02-13 23:37:04 +00:00
Louis Chemineau
8a8a92b88f
feat: Use inline password confirmation in external storage settings 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-02-11 11:56:30 +01:00
Ferdinand Thiessen
c4cc3f2888
fix(FediverseAction): Ensure valid fediverse links are generated 
Harden also for existing values of the profile.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-09 13:46:27 +01:00
Ferdinand Thiessen
4a7c8834d0
fix(AccountManager): Sanitize social media handles 
Ensure to only accept valid X and fediverse handles.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-09 13:46:26 +01:00
Richard Steinmetz
d8e5b6a229
fix(oauth2): adjust db schemas when migrating from owncloud 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2025-02-06 10:19:57 +01:00
Robin Appelman
804a0ec567 fix: explicitly ignore nested mounts when transfering ownership 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-02-05 09:39:28 +01:00
Robin Appelman
7a37fdddc5 fix: translate mount move error messages 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-02-05 09:39:28 +01:00
Robin Appelman
5b4ceb0eaa fix: improve checks for moving shares/storages into other mounts 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-02-05 09:39:28 +01:00
provokateurin
53c02d6b9d
fix(Http): Only allow valid HTTP status code values via template 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-02-03 12:11:01 +01:00
Kate
7bf9848334
Merge pull request #50600 from nextcloud/backport/50549/stable29 2025-02-01 11:19:36 +01:00
Ferdinand Thiessen
7246b5d3c9 fix(OC_Files): Fix error response when event was not set 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-31 18:38:32 +00:00
Ferdinand Thiessen
a0d7d107f5
fix(sharing): Move permission validation to share manager 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-31 18:46:07 +01:00
Kate
2053455b56
Merge pull request #50563 from nextcloud/backport/50530/stable29 2025-01-31 08:51:10 +01:00
Nils Wenninghoff
3ef04909b7
fix(ConvertType): Read dbtype in createConnectionParams and remove safeguard 
Signed-off-by: Nils Wenninghoff <nils@ungemein.cool>
 2025-01-30 12:21:30 +01:00