Commit graph

746 commits

Author SHA1 Message Date
Louis Chemineau
d7775cba6a
fix: Dispatch favorite event with an actual path
The `$path` argument was added in https://github.com/nextcloud/server/pull/48612, but was never actually used by the callers. The path was therefore missing in the favorite/unfavorite events, which lead to a broken activity information.

I also added a fallback to handle `addToFavorites` and `removeFromFavorites`, which are part of a public API, and are calling `tagAs` and `untag` without `$path`.

Fix https://github.com/nextcloud/activity/issues/2134

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-09-15 16:52:28 +02:00
Joas Schilling
08df13a7cc fix(dashboard): Fix favorite dashboard icon
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-09-03 14:52:33 +00:00
Carl Schwan
dfe5214d52 fix(trash): Fix order of metadata deletion
First query metadata for live photo and then delete the metadata, by
making the SyncLivePhotosListener priority higher than the default.

Partially fix #54274

Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>
2025-08-24 20:18:49 +02:00
provokateurin
987af4193d
fix(files): Always transfer incoming shares when doing ownership transfer to prevent broken reshares
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-07-01 13:08:13 +02:00
provokateurin
918473d7f2
fix(files): Limit transferring incoming shares to the selected path
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-07-01 13:05:25 +02:00
Robin Appelman
881abecd34 fix: don't scan the same storage multiple times
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-06-25 11:38:30 +00:00
Jonas
6bca885efe fix(SyncLivePhotosListener): Don't handle copy event emitted from us
Running $peerFile->copy() causes a second BeforeNodeCopiedEvent now,
which we don't want to handle.

Signed-off-by: Jonas <jonas@freesources.org>
2025-05-28 11:50:12 +00:00
Robin Appelman
97cf88da29 perf: improve query to determine which users need a background scan
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-05-27 12:37:51 +00:00
Elizabeth Danzberger
8b5a2d3512 chore: update open api spec
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2025-05-26 18:03:24 +02:00
Elizabeth Danzberger
52ae766a8e feat: only load template fields when requested
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2025-05-26 18:03:24 +02:00
Ferdinand Thiessen
c18c75cb52 docs(files): add more documentation about WCF and links to the admin docs
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-26 10:12:50 +02:00
Ferdinand Thiessen
41b9a7ec9b feat(files): add command to (dis)enable windows compatible filenames
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-26 10:12:50 +02:00
Ferdinand Thiessen
3ce306ec57 feat(files): add command to automatically rename filenames
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-26 10:12:50 +02:00
Robin Appelman
780766b63c fix: keep IObjectStoreMetaData in private namespace for backports
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-05-16 10:41:27 +02:00
Robin Appelman
4ff14790af feat: move streaming output helps to command base class
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-05-16 10:41:27 +02:00
Robin Appelman
18997b0199 feat: rework object listing
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-05-16 10:41:27 +02:00
Robin Appelman
e0ec7db29c feat: add command to list orphan objects
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-05-16 10:41:27 +02:00
Robin Appelman
f0cab800ab feat: add command to list objects
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-05-16 10:41:27 +02:00
Robin Appelman
a324dbec2e feat: add command to get object metadata
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-05-16 10:41:27 +02:00
Robin Appelman
a4a5bcaacb fix: better error message when trying to scan a folder that is already being scanned
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-05-13 14:06:15 +02:00
provokateurin
67e60d9711 fix(files): Fix non-string values for activity rich object strings
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-06 12:06:43 +00:00
rakekniven
7c57fff83b fix(notification): Notification in activity shows "Rich subject or a parameter for ..."
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2025-05-01 11:16:15 +00:00
SebastianKrupinski
aee4328b1f fix:remote account activity translation
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2025-03-22 08:21:57 -04:00
grnd-alt
cdad92d2bb feat: improve occ file:transfer-ownership logging
Signed-off-by: grnd-alt <github@belakkaf.net>
2025-03-20 00:56:11 +01:00
Ferdinand Thiessen
3ac9a316bb
feat(files): allow to ignore warning to change file type
* Missing pieces of https://github.com/nextcloud/server/issues/46528
  * Add checkbox to not show this dialog again
  * Add user config as suggested by designers in files settings to
    reenable or diable this behavior.
  * Fix behavior of dialog: It says "keep .ext" but it does not keep the
    extension but cancels the operation. From the button label the user
    expects that the operation is continued but with the old extension.
  * Added more test coverage by adding component tests.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-04 21:12:42 +01:00
skjnldsv
0823f924c0 fix(files): properly forward open params from short urls
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-18 12:42:23 +00:00
provokateurin
9d1cab21b2 fix(files): Fix folder preview for favorites widget
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-02-03 09:57:02 +00:00
Julius Knorr
11926bc789 fix: Only hide template folder creation if default was changed to empty
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-01-30 10:23:35 +00:00
Pawel Boguslawski
64e261dad7 fix: Hide "Create templates folder" option if templates are disabled in configuration
When both `skeletondirectory` and `templatedirectory` are set to empty
strings in configuration, templates folder creation should be disabled
and no Create templates folder option should be present
in new folder menu.

Related: https://github.com/nextcloud/server/issues/39266
Related: https://github.com/nextcloud/server/issues/46455
Author-Change-Id: IB#1156403

Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2025-01-27 16:19:00 +00:00
Ferdinand Thiessen
76ac30f576 fix(files): Harden thumbnail endpoint
- Catch all thrown exceptions and handle in such a way you do not get
  information about forbidden files.
- Resepect download permissions of shares.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-26 15:20:35 +00:00
skjnldsv
7d8bb60bfe feat(files): add conversion action
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-01-22 16:29:36 +00:00
skjnldsv
abd3cb60fc fix(files): more conversion tests and translate error messages
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-01-17 18:22:58 +01:00
Julius Knorr
fc9af34799
fix: Log exceptions that happen during file conversion
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-01-17 12:06:36 +01:00
John Molakvoæ
35db02c4f9
Merge pull request #50208 from nextcloud/feat/conversion-adjusting
fix(files): conversion api simplification and conflict check
2025-01-16 19:31:14 +01:00
skjnldsv
7cbcbdc051 fix(files): conversion api simplification and conflict check
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-01-16 18:35:40 +01:00
Daniel
f9354dab23
Merge pull request #49761 from nextcloud/transfer-share-skip-notfound
fix: skip transfering shares that we can't find
2025-01-16 17:58:06 +01:00
Elizabeth Danzberger
fdfeb7f265
feat(api): File conversion API
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2025-01-15 16:38:18 -05:00
yemkareems
91f568e01b
feat(dashboard): added new FavouriteWidget to display favorite files in dashboard widget
* Added widget star icon
* run build/autoloaderchecker.sh
* removed unwanted IWidget and usersession
* renamed id
* renamed class to FavoriteWidget
* removed limit logic
* removed IAPIWidget
* ui fixes to remove rounded corners and make the ui/ux similar to recommendation widget.
* cs fix + composer fix no dev and review comments from Joas and Côme addressed
* added count and removed slice

Signed-off-by: yemkareems <yemkareems@gmail.com>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
2025-01-14 21:51:32 +01:00
Kate
e686b93d73
Merge pull request #49905 from nextcloud/chore/deps/openapi-extractor 2025-01-06 16:35:00 +01:00
Robin Appelman
757076af29
fix: explicitly ignore nested mounts when transfering ownership
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-06 14:45:35 +01:00
provokateurin
085d4c9364
refactor(OpenAPI): Adjust scopes to match previous behavior
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-06 14:30:40 +01:00
Robin Appelman
c00724bac8 fix: skip transfering shares that we can't find
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-03 15:21:17 +01:00
Arthur Schiwon
13fefc4612
feat(Navigation): emit dedicated event for loading additional entries
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-12-18 12:50:11 +01:00
Julius Knorr
cba556d641
Merge pull request #48612 from nextcloud/fix/activity-log-for-favorites-in-dav
add activity logging for favorites in dav
2024-12-12 15:18:47 +01:00
Louis Chemineau
8be7b9ea40
fix: Copying a live photo to a folder with a conflicting mov file
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-12-04 16:23:39 +01:00
Louis Chemineau
e37664bd08
fix: Handle copy of folders containing live photos
We need to recursively look for live photos in the folder,
and then handle them as usual.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-12-04 15:38:35 +01:00
grnd-alt
8d953aeb8d refactor(tags): move favorite event dispatching to tags.php
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
2024-12-03 20:56:36 +01:00
grnd-alt
2d02d83597 fix(dav): add activity logging for favorites in dav
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
2024-12-03 20:56:36 +01:00
provokateurin
715e7143f0
fix(files_sharing,files): Do not validate shares before adjusting the owner
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-25 10:27:31 +01:00
Daniel
1f6d0f0eb6
Merge pull request #49407 from nextcloud/feat/occ-files-cleanup-help
feat(files): Add help to / update description of `files:cleanup`
2024-11-21 11:00:31 +01:00