Commit graph

20484 commits

Author SHA1 Message Date
Thomas Citharel
618bbb313c Fix reading blob data as resource
PostgreSQL returns data as resource when using IQueryBuilder::PARAM_LOB
(which is used for QBMapper).

Previously we just converted this resource using settype, which produced
things like "Resource id #14" instead of the actual resource data.

Now we read the stream correctly if the returned data is a resource

See context at #22472

Fixes #22439

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-07-25 15:59:36 +00:00
Vincent Petry
a2166864d4
Merge pull request #33326 from nextcloud/backport/33308/stable24
[stable24] always triger setup of builtin storage wrappers
2022-07-25 17:04:19 +02:00
blizzz
22822a836d
Merge pull request #33252 from nextcloud/backport/32963/stable24
[stable24] also use nextcloud certificate bundle when downloading from s3
2022-07-22 23:54:41 +02:00
Robin Appelman
2c6cd0daf8 always triger setup of builtin storage wrappers
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-07-22 20:24:35 +00:00
Jonas
78a3bfd120
Merge pull request #33212 from nextcloud/backport/33211/stable24
[stable24] Fix listening for circle events in SetupManager
2022-07-19 10:25:45 +02:00
Arthur Schiwon
7af9f2741f fix loading legacy app.php with multi app dir
- requireAppFile() only appends /appinfo/app.php
- without the absolute path, require_once looks into include_path
- the first match in inlcude_path however migth be different from appPath
- fixed by providing the tested(!), full path to the app


Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-07-19 06:18:59 +00:00
Jonas
786317e1cb
Fix listening for circle events in SetupManager
So far, SetupManager listened for deprecated events that are no longer
triggered. Instead, use the circle events that actually get triggered
when adding or removing a circle or circle member. Also, these events
get triggered on each instance of a globalscale setup.

Fixes: #33210

Signed-off-by: Jonas <jonas@freesources.org>
2022-07-18 21:09:37 +01:00
Robin Appelman
d4de68f1d4 only use nextcloud bundle when explicitly enabled
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-07-18 07:54:55 +00:00
Robin Appelman
e640ee4720 also use nextcloud certificate bundle when downloading from s3
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-07-18 07:54:54 +00:00
Nextcloud bot
ce7b2c1329
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-14 02:25:32 +00:00
John Molakvoæ
dec16a9543
Merge pull request #33157 from nextcloud/backport/33153/stable24 2022-07-08 08:28:29 +02:00
Nextcloud bot
09d6d02234
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-08 02:24:48 +00:00
John Molakvoæ
b3ee9b7b98
Merge pull request #32983 from nextcloud/backport/32242/stable24 2022-07-07 11:47:34 +02:00
Joas Schilling
d306757ffb Only ignore attempts of the same action
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-07-07 09:03:55 +00:00
John Molakvoæ
447a238c59
Merge pull request #32997 from nextcloud/backport/32980/stable24 2022-07-07 10:49:43 +02:00
John Molakvoæ
8d8fa86194
Merge pull request #32986 from nextcloud/backport/stable24/31771 2022-07-07 10:26:42 +02:00
Christopher Ng
51e20dd6c5 Do not save invalid display name to the database
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-07-06 20:54:17 +00:00
Carl Schwan
7c1c7ba5bf
Merge pull request #32483 from nextcloud/backport/32451/stable24
[stable24] Fix cropped image generated when not asked
2022-07-06 17:33:07 +02:00
Carl Schwan
c3621f2a11 Fix cropped image generated when not asked
The $crop parameter was not propagated to the imaginary pipeline and
instead it used the smartcrop algorithm always

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-06 14:33:04 +02:00
Nextcloud bot
f64b78d11b
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-06 02:23:47 +00:00
Nextcloud bot
7e3f811104
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-04 02:23:43 +00:00
Carl Schwan
ebe3c5b00e
Merge pull request #33078 from nextcloud/backport/32924/stable24
[stable24] Enable binary protocol again
2022-07-01 15:07:55 +02:00
Arthur Schiwon
4744a62776
memcached should not throw arbitrary exceptions
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-07-01 00:15:37 +02:00
Carl Schwan
f32c53e5a1
Enable binary protocol again
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-01 00:15:28 +02:00
Jonas
aec0899efd Check whether entry is of type ICacheEntry in Cache->remove()
In some scenarios (file not in cache, but partial data of it in the
object), Cache->get() might return an array, which leads to errors like
"Call to a member function getId() on array".

So check whether the returned entry is of type ICacheEntry before doing
operations on it in Cache->remove().

Fixes: #33023

Signed-off-by: Jonas <jonas@freesources.org>
2022-06-30 12:25:26 +00:00
Carl Schwan
47934494f6
Merge pull request #33069 from nextcloud/backport/33065/stable24
[stable24] Fix detection of firefox in ContentSecurityPolicyNonceManager
2022-06-30 10:19:22 +02:00
Nextcloud bot
381ac6a26a
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-30 02:23:59 +00:00
Carl Schwan
467780ff4e Fix detection of firefox in ContentSecurityPolicyNonceManager
Reuse Request::USER_AGENT_FIREFOX, and also update the safari detection
since safari < 12 is not supported anymore and we can remove a bit of
code duplication

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-06-30 00:46:47 +00:00
Arthur Schiwon
771d38918a
avoid early DI of IAppManager
- might break install

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-06-28 23:47:00 +02:00
Carl Schwan
334ed35042
Merge pull request #33049 from nextcloud/backport/32982/stable24
[stable24] Fix metadata extraction
2022-06-28 21:46:42 +02:00
Carl Schwan
de4f7b5c9c Fix metadata extraction
The metadata extraction only happens when the size is not equal to 0,
but due to a regression in FileInfo the size is always zero.

This fix the regression.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-06-28 13:37:59 +00:00
Louis Chemineau
82fea7d000 Rename setting name to reduce its length
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-06-28 09:55:45 +00:00
Nextcloud bot
ca316d5454
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-28 02:28:38 +00:00
Arthur Schiwon
28eac9c961 load widgets only of enabled apps
- per design, all enabled apps have their registration run
- limitations, e.g. enabled by group, are not considered in that state,
  because we do not have a session (and might need apps?)
- before instantiation of widget it has to be checked whether the providing
  app is actually enabled for the logged in user.
- a public interface is being changed, but it is not meant to be
  implemented or used outside of the core handling. Therefore save to
  backport.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-06-23 15:48:33 +00:00
Côme Chilliet
fc1258cb1c Improve local domain detection
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-06-23 10:53:49 +00:00
Carl Schwan
b4edbb3af5 Fix hook encryption with cron job
Make sure the setup fs is set before using the Update service

Fix #29674

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-06-22 22:42:25 +02:00
Thomas Citharel
08035833cf Fix logging data context to file
It was only logged when an exception was provided or when using
logData (which is not being much used).

We make sure the interpolated parameters are not logged.

Only tested with file write logger, but shouldn't work differently.

Crash reporters always had the context.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-06-22 18:26:25 +00:00
Nextcloud bot
05f11310bb
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-19 02:27:58 +00:00
blizzz
a71d33ad91
Merge pull request #32904 from nextcloud/backport/32898/stable24
[stable24] Fix logger overwriting vars in some circumstances
2022-06-17 14:22:32 +02:00
Nextcloud bot
bab0753507
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-17 02:27:53 +00:00
Arthur Schiwon
6b8d6de4fc make placeholder a const for reuse
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-06-16 18:38:40 +00:00
Arthur Schiwon
ed4fcf2d17 fix overwriting original vars when logging
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-06-16 18:38:39 +00:00
Nextcloud bot
944c792cd4
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-14 02:28:25 +00:00
blizzz
a5b13da95b
Merge pull request #32842 from nextcloud/backport/32685/stable24
[stable24] Fix replacing external storage password during debug log
2022-06-13 09:55:02 +02:00
blizzz
a1d570b51a
Merge pull request #32833 from nextcloud/backport/32799/stable24
[stable24] Fix exception handling when profile data is too long
2022-06-13 09:26:47 +02:00
Christoph Wurst
e040734456 Fix replacing external storage password during debug log
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-06-13 06:18:18 +00:00
blizzz
ba27191e03
Merge pull request #32444 from nextcloud/backport/32357/stable24
[stable24] remove storage wrappers when deleting the user storage
2022-06-12 19:54:14 +02:00
Joas Schilling
d328e3cd06
Fix exception handling when profile data is too long
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-06-12 13:46:14 +02:00
Nextcloud bot
8274bb3643
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-12 02:28:02 +00:00
blizzz
eeb4de0763
Merge pull request #32708 from nextcloud/unencrypted-size-24
[24] store unencrypted size in the unencrypted_size column
2022-06-11 00:42:34 +02:00