Commit graph

2507 commits

Author SHA1 Message Date
provokateurin
78a175fc74
refactor: Apply rector refactorings
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-14 15:29:02 +02:00
Daniel Kesselberg
023b98c44b
fix(dav): only consider user's principal for unsharing entries
Before: Find all entries in `dav_shares` with `access = 5` for the user's principal, as well as group and circle memberships.

After: Find all entries in `dav_shares` with `access = 5` solely for the user's principal.

Future support for unsharing group or circle principals could be considered as a feature enhancement.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-05-14 09:03:33 +02:00
Daniel Kesselberg
c05d3fdb2e
fix(caldav): prevent unshare entry creation for owner unsharing
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- https://github.com/nextcloud/server/pull/43117
- https://github.com/nextcloud/server/pull/47737

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-05-14 09:03:32 +02:00
John Molakvoæ (skjnldsv)
b286bca485
fix(dav): remove unnecessary plugin getHTTPMethods
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2025-05-13 16:03:20 +02:00
John Molakvoæ (skjnldsv)
4495794a0b
feat(dav): allow uploading folders to public shares
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2025-05-13 16:03:20 +02:00
SebastianKrupinski
477bc4e3f1 fix: add calendar enable
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2025-05-09 09:05:21 -04:00
Daniel
1c2b4f2a41
Merge pull request #52586 from nextcloud/bugfix/noid/remove-sleep-from-throttler
fix(throttler): Always use the sleepDelayOrThrowOnMax instead of deprecated sleepDelay
2025-05-06 19:22:53 +02:00
John Molakvoæ
24c6a1ff0b
Merge pull request #52182 from nextcloud/feat/dav/public-share-chunked-upload 2025-05-06 14:25:28 +02:00
SebastianKrupinski
a2d4f8d3f1
feat: Calendar Export
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2025-05-06 11:09:33 +02:00
provokateurin
46f5b07322
feat(dav): Enable chunked upload for public shares
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-05 13:23:11 +02:00
provokateurin
a55e61d97c
feat(dav): Allow UploadHome to handle public shares
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-05 13:23:11 +02:00
provokateurin
8813df9623
refactor(dav): Pass UID from UploadHome to UploadFolder and CleanupService
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-05 13:23:11 +02:00
provokateurin
7f0953d520
refactor(dav): Replace baseuri manipulation with RootCollection for public shares
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-05 13:23:11 +02:00
provokateurin
e90e3a70fa
feat(dav): Allow share principals
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-05 13:23:10 +02:00
Richard Steinmetz
d0fcb7e638
fix(dav): move orphan cleaning logic to a chunked background job
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-05-05 12:13:09 +02:00
Joas Schilling
7964f338dc
fix(throttler): Remove the sleep from the throttler that throws
The sleep is not adding benefit when it's being aborted with 429
in other cases anyway.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-02 11:27:29 +02:00
Christoph Wurst
535253e0d2
Merge pull request #52228 from nextcloud/fix/issue-50748-calendar-object-move
fix(CalDAV): do not ignore move command object target uri
2025-04-30 16:27:48 +02:00
skjnldsv
58aaddeca5 fix(dav): check the owner displayName scope before giving attribute
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-04-30 08:37:08 +02:00
Richard Steinmetz
33a8e2226c
perf(caldav): increase chunk size in RemoveOrphanEventsAndContacts repair step
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-04-29 16:34:19 +02:00
Ferdinand Thiessen
698146c366
Merge pull request #51592 from nextcloud/fix/search-cast
fix(dav): throw invalid argument when property type does not match
2025-04-29 13:41:48 +02:00
Hamza Mahjoubi
58ffd9d06e fix: check if config is enabled before creating a default contact
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2025-04-28 11:46:32 +02:00
Ferdinand Thiessen
e33fcfddc1 fix(dav): throw invalid argument when property type does not match
* Resolves https://github.com/nextcloud/server/issues/49972

Currently a TypeError is thrown when casting fails,
this lead to a HTTP 500 error. Instead throw a proper
InvalidArgumentError so the user receives a HTTP 400.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-27 23:05:07 +02:00
Richard Steinmetz
16dd61cc28
refactor(dav): refactor inline event listeners
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-04-25 20:32:18 +02:00
Richard Steinmetz
109422f24e
refactor(dav): use first class callable syntax to boot the app
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-04-25 15:05:50 +02:00
Daniel
cc5ca58816
Merge pull request #51438 from nextcloud/perf/db/cards-properties-abid-name-value-idx
perf(db): Extend index on cards_properties to cover name and value
2025-04-24 13:33:37 +02:00
Ferdinand Thiessen
21c128754d
Merge pull request #52241 from nextcloud/bugfix/noid/fix-room-or-resource-condition
fix(caldav): Fix check for ROOM or RESOURCE condition
2025-04-23 13:54:01 +02:00
Ferdinand Thiessen
b4255a9652
fix(dav): allow uploading of files with long filenames
A filename must be less or equal 255 characters, but when adding the
`.part` and `.ocfiletransfer` extensions we might overflow this limit.
So we should also use filename hashes for uploading when the file has a
long filename, similar like when we are uploading to the user storage
directly.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-22 11:09:25 +02:00
Ferdinand Thiessen
6141ab1da6
refactor(dav): simplify length header handling
Reduce nesting and drop duplicated sections.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-22 11:09:05 +02:00
Joas Schilling
fe7c1c0aad
fix(caldav): Fix check for ROOM or RESOURCE comment
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-04-22 11:02:13 +02:00
SebastianKrupinski
1a90998edc fix: do not ignore move command object target uri
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2025-04-16 17:43:12 -04:00
Ferdinand Thiessen
ba3c504812
feat(files_sharing): add WebDAV property for the hide-download state of shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-16 20:38:20 +02:00
Louis
b2a187d296
Merge pull request #51729 from nextcloud/artonge/support_oc_checksum_in_bulk_upload
feat: Support OC-Checksum in bulk upload
2025-04-15 09:49:38 +02:00
Louis
a81440d11c
Revert "feat(bulk-upload): change the default to disabled as there are still some bugs present" 2025-04-11 23:39:25 +02:00
Tobias Kaminsky
5e9ebe4acb
Merge pull request #51431 from nextcloud/enh/noid/disable-bulk-upload
feat(bulk-upload): change the default to disabled as there are still some bugs present
2025-04-11 11:22:02 +02:00
Simon L.
5e6478fd64 feat(bulk-upload): change the default to disabled as there are still some bugs present
Signed-off-by: Simon L. <szaimen@e.mail.de>
2025-04-10 15:28:52 +02:00
Robin Appelman
5c66fead67
fix: fix preloading files with no custom properties
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-04-09 15:04:35 +02:00
Joas Schilling
a8be6314ae
fix(dav): Really only run the chunk cleanup once
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-04-08 09:59:20 +02:00
Robin Appelman
587e7c5358
Merge pull request #51010 from nextcloud/uploadfolder-rework
fix: rework UploadFolder implementation
2025-04-02 22:59:02 +02:00
Ferdinand Thiessen
fdc0b1ecf4
Merge pull request #51845 from nextcloud/zip-download-no-sabre-response
fix: don't have sabre/dav send it's own reponse if we already send the zip response
2025-04-01 19:26:04 +02:00
Robin Appelman
2b0116f0eb
fix: don't have sabre/dav send it's own reponse if we already send the zip response
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-04-01 17:29:58 +02:00
Louis Chemineau
3bb2a92962
feat: Support OC-Checksum in bulk upload
To align with the rest of Nextcloud.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-04-01 14:35:21 +02:00
Richard Steinmetz
246da73a36
fix(oauth2): retain support for legacy ownCloud clients
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-04-01 11:25:52 +02:00
Marcel Klehr
14cd98c989 fix(dav): Give proper HTTP status code on MKCOL when quota exceeded
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-03-31 10:49:11 +02:00
Hamza Mahjoubi
099d9fb9be feat: add example contact on first login
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2025-03-26 10:57:39 +01:00
skjnldsv
6fc453540b fix(dav): filter user files when updating tags
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-03-25 12:30:03 +01:00
Kate
6740804328
Merge pull request #51195 from nextcloud/feat/photo-cache-avif
feat: Allow AVIF content type in PhotoCache
2025-03-18 14:48:22 +01:00
Ferdinand Thiessen
2e60c09817
Merge pull request #51457 from nextcloud/fix/dav-csrf
fix(dav): do not require CSRF for safe and indempotent HTTP methods
2025-03-17 18:18:25 +01:00
Hamza Mahjoubi
c9d9abd46e fix(cardav): only show useres from enabled addressBooks in contacts menu
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2025-03-17 11:56:34 +01:00
Ferdinand Thiessen
fa63e646d4
fix(dav): do not require CSRF for safe and indempotent HTTP methods
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-13 12:04:30 +01:00
SebastianKrupinski
c343b4ec10 fix(CalDav): alter invitation attachment filename and type
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2025-03-12 09:31:12 -04:00