Commit graph

1312 commits

Author SHA1 Message Date
Robin Appelman
6cece4f4e1 feat: improve logging of fopen failures for smb
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-06-19 21:17:48 +00:00
Robin Appelman
3ca5423ca5 feat: add --unscanned option to files_external:scan
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-06-03 13:13:49 +00:00
Git'Fellow
0eeb8335a9 fix(files_external): Safely check if the timestamp is numeric
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-05-25 16:52:55 +02:00
Robin Appelman
4271753fc2
Merge pull request #52790 from nextcloud/backport/52441/stable31
[stable31] fix: better error message when trying to scan a folder that is already being scanned
2025-05-15 14:11:14 +02:00
Robin Appelman
a4a5bcaacb fix: better error message when trying to scan a folder that is already being scanned
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-05-13 14:06:15 +02:00
Robin Appelman
bb8be43262 feat: add command to check files_external dependencies
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-05-13 09:13:43 +00:00
provokateurin
31cd06d0e1
fix(files_external): Mark password fields for LoginCredentials and SessionCredentials as hidden and optional
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-06 09:43:36 +02:00
provokateurin
dccaf29dc5
fix(files_external): Convert VALUE_HIDDEN to FLAG_HIDDEN to allow combining VALUE_PASSWORD and FLAG_HIDDEN
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-06 09:43:35 +02:00
Kate
32413b8896
Merge pull request #51388 from nextcloud/backport/51364/stable31
[stable31] fix(files_external): Stop building path twice when checking if file exists on case insensitive SMB storage
2025-03-24 14:08:47 +01:00
skjnldsv
9ff9096e4a fix(external_storage): fix settings save
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-03-11 23:55:01 +01:00
provokateurin
6aea50c8b8 fix(files_external): Stop building path twice when checking if file exists on case insensitive SMB storage
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-11 10:47:37 +00:00
provokateurin
19601eedc3 fix(files_external): Move definition parameter to the correct place
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-02-27 14:26:10 +00:00
Christian Becker
5b51e1b0dc feat(S3): add SSE-C support in S3 External Storage
Just need to add the parameter and fix two calls. All other logic is already implemented and implicitly called through the S3ConnectionTrait

fixes #33283

Signed-off-by: Christian Becker <christian@dabecka.de>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-01-31 12:01:09 +00:00
Robin Appelman
5c0d4a4bea fix: detect deleted items as updated for smb storage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-27 09:22:03 +00:00
Benjamin Gaussorgues
12452f7f22
fix(files_external): wrong type for external mount id
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-12-13 10:27:50 +01:00
Robin Appelman
0e10bb59a1
Merge pull request #49288 from nextcloud/smb-acl-fail-soft
fix: smb: don't fail hard if we can't load acls for a file
2024-12-04 18:22:09 +01:00
provokateurin
86eec60ebb
feat(files_external): Enable ownerless shares
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-12-04 09:38:05 +01:00
Alexander Piskun
1022c47d27
Merge branch 'master' into fix/external-storage-service-cast-id 2024-12-03 15:36:02 +03:00
Oleksander Piskun
c284e49134 fix(external_storage): Cast id to int 2024-12-02 15:43:29 +03:00
Louis Chemineau
a2f2f7ce93
feat: Use inline password confirmation in external storage settings
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-11-28 11:01:54 +01:00
Marcel Klehr
9c7fd29262 fix(external_storage): Cast id to int
follow up to #49218

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-11-25 09:42:53 +01:00
Robin Appelman
cc39714fb5
fix: smb: don't fail hard if we can't load acls for a file
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-11-14 16:01:36 +01:00
skjnldsv
8b8e4763ed fix(files_external): cast storage id int
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-12 10:28:01 +01:00
John Molakvoæ
d53fde8eef
Merge pull request #49015 from nextcloud/fix/openapi/array-syntax 2024-11-06 08:56:30 +01:00
provokateurin
77114fb327
fix(OpenAPI): Adjust array syntax to avoid ambiguities
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-05 09:58:11 +01:00
Maxence Lange
8360c57189 fix(files-external): set password as sensitive
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-10-31 09:41:20 -01:00
yemkareems
3b6a36fae6
fix: add PasswordConfirmationRequired to saveGlobalCredentials
Co-authored-by: yemkareems <yemkareems@gmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-30 10:54:49 +01:00
John Molakvoæ
ed14f5fee2
Merge pull request #48788 from nextcloud/fix/788/add-password-required-to-external-storages 2024-10-29 11:33:47 +01:00
provokateurin
0de4843b73 refactor(Storage): Align all Storage constructors
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-23 13:24:18 +02:00
provokateurin
e8426996f5
fix(psalm): Fix some newly detected issues
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-21 12:37:59 +02:00
provokateurin
381077028a
refactor(apps): Use constructor property promotion when possible
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-21 12:37:59 +02:00
yemkareems
08f3e44d4a
fix: cs fix namespace
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-18 14:34:39 +05:30
yemkareems
18c0c28bce
fix: add PasswordConfirmationRequired to the eternal storages mentioned in review
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-18 14:04:34 +05:30
Git'Fellow
c254855222 chore(db): Correctly apply query types
fix: psalm

fix: error

fix: add batch

fix: fatal error

fix: add batch

chore: add batch

chore: add batch

fix: psalm

fix: typo

fix: psalm

fix: return bool

fix: revert Manager
2024-10-17 09:21:07 +02:00
yemkareems
b86dc076b5
fix: add PasswordConfirmationRequired to update and delete method
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-16 16:49:13 +02:00
yemkareems
d3f1b76ebb
fix: add PasswordConfirmationRequired to create user storages endpoint
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-16 16:49:06 +02:00
Côme Chilliet
1580c8612b
chore(apps): Apply new rector configuration to autouse classes
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-15 10:40:25 +02:00
Kate
614d8c23a0
Merge pull request #48494 from nextcloud/refactor/storage/strong-param-types 2024-10-08 15:20:17 +02:00
provokateurin
54ec472d9a
fix(BackgroundJobs): Adjust intervals and time sensitivities
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-08 11:26:53 +02:00
provokateurin
14e6734547
refactor(files_external): Add Storage parameter strong types
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-07 15:00:07 +02:00
Joas Schilling
4219969c96
fix: Ensure we only pass string to writeln()
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-07 12:11:38 +02:00
Joas Schilling
c109ae9437
ci: Fix psalm by typing the QuestionHelper
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-07 12:11:27 +02:00
Robin Appelman
103b464eea fix: use nc's binary finding logic for smb
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-10-04 15:56:31 +02:00
Joas Schilling
96f77d7b99
fix(filesexternal): Remove unneeded 3rdparty library use
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-02 23:27:44 +02:00
Côme Chilliet
6ef05bafeb
fix: Fix test of IConstructableStorage implentation by storage classes
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-30 11:21:42 +02:00
provokateurin
1302b48ca2
fix(files_external): Fix all IStorage return types
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-26 17:29:48 +02:00
Louis
c45ed55f95
Merge pull request #48359 from nextcloud/artonge/feat/compare_hashed_password_when_updating_global_cred_in_files_external
fix: Use placeholder for external storage password
2024-09-26 14:56:37 +02:00
Marcel Klehr
c8a90e941a fix(files_external): Catch correct exception
SMB#getFileInfo used to throw an icewind/smb exception, but nowadays throws \OCP\Files\ForbiddenException. This fixes downstream methods to catch the new exception.

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-09-26 09:03:08 +02:00
Louis Chemineau
20eb464835
fix: Use hashed password in files_external settings
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-25 17:50:17 +02:00
Côme Chilliet
40b404c566
Merge pull request #48111 from nextcloud/fix/move-storage-constructor-to-specific-interface
fix: Move storage constructor to specific interface
2024-09-23 15:57:38 +02:00