upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-15 22:11:17 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 28
57452 commits 882 branches 1195 tags 7.2 GiB
Commit graph

1324 commits

Author SHA1 Message Date
Christoph Wurst
36b3bc8148
Use php keywords in lowercase 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 14:04:56 +02:00
Christoph Wurst
afbd9c4e6e
Unify function spacing to PSR2 recommendation 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 13:54:22 +02:00
Christoph Wurst
41b5e5923a
Use exactly one empty line after the namespace declaration 
For PSR2

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 11:48:10 +02:00
Christoph Wurst
2fbad1ed72
Fix (array) indent style to always use one tab 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 10:16:08 +02:00
Christoph Wurst
85e369cddb
Fix multiline comments 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-08 22:24:54 +02:00
Joas Schilling
f878ea9606
Remove user name from public sharing page 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-01 17:14:38 +02:00
Christoph Wurst
1a9330cd69
Update the license headers for Nextcloud 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-31 14:52:54 +02:00
Christoph Wurst
463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports 
Remove unused imports
 2020-03-27 17:14:08 +01:00
Christoph Wurst
b80ebc9674
Use the short array syntax, everywhere 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-26 16:34:56 +01:00
Christoph Wurst
74936c49ea
Remove unused imports 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-25 22:08:08 +01:00
Christoph Wurst
37786c4d74
Convert share event to an interaction event 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-25 16:16:45 +01:00
Roeland Jago Douma
e6ec084a58
Auto accept group shares for users added to a group 
In case auto accepting is enabled (the default). Users that are newly
added to a group should not have to accept those shares.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-03-25 08:51:27 +01:00
Julius Härtl
87393a760e Remove unused properties in ShareesAPIController 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-03-20 10:43:56 +01:00
Joas Schilling
6edb93fc4a
Allow the video player on the hide download 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-03-19 15:14:00 +01:00
Joas Schilling
8db32805be
Fix willReturnOnConsecutiveCalls 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-03-13 11:11:00 +01:00
Joas Schilling
3930ab8e8a
Don't allow anchors and queries in remote urls 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-03-12 13:44:48 +01:00
John Molakvoæ
9fda1ee39f
Merge pull request #19777 from nextcloud/fix/viewer-public 
Properly emit Viewer event on files and files_sharing
 2020-03-12 08:47:14 +01:00
Joas Schilling
24d0fb9fcd
Merge pull request #19861 from nextcloud/bugfix/noid/load-remote-shares-also-when-one-is-down 
Don't break when one remote share is down
 2020-03-11 09:36:57 +01:00
John Molakvoæ (skjnldsv)
92a6530c0f Properly emit Viewer event on files and files_sharing 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2020-03-11 09:28:27 +01:00
John Molakvoæ (skjnldsv)
6c968fe77d Fix import order and formatting 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2020-03-11 09:27:20 +01:00
Joas Schilling
f4918f208e
Unify the code a bit 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-03-10 19:36:57 +01:00
Joas Schilling
bbef026aa0
Use contacts name on federated activities 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-03-10 19:36:56 +01:00
Joas Schilling
886293fdcc
Don't break when one remote share is down 
getFileInfo can also return false

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-03-09 17:00:31 +01:00
Roeland Jago Douma
7613681627
Don't try to format deleted shares 
Fixes #15455

The issue is that we have a fallback for shares to use the target. So
when the target exists again we happily format it (not that the shares
are still invalid).

This just tries to get the node. If we can't then boom.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-03-02 09:18:04 +01:00
Joas Schilling
a792a31448
Allow single file downloads so the video player works again 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-02-28 16:25:09 +01:00
Joas Schilling
841f2f3b04
Allow to overwrite share target mountpoints 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-02-17 09:04:19 +01:00
Roeland Jago Douma
302ea0650e
Merge pull request #19349 from nextcloud/bugfix/noid/prevent-download-on-secure-view 
Prevent archieved download on secure view
 2020-02-08 10:18:24 +01:00
Joas Schilling
35d4ca4d5d
Prevent archieved download on secure view 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-02-07 12:46:23 +01:00
Roeland Jago Douma
260892eb3b
Disable link shares of disabled users 
Fixes #10869

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-02-07 07:47:38 +01:00
Roeland Jago Douma
8f15e2d57a
Use the target for file notifications 
The node is not yet accessible if you did not accept the share yet.
So trying to get it results in an acception.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-01-24 12:43:17 +01:00
Julius Härtl
eb4c42d3d1
Make auto accepting the default and provide setting to enforce the share acceptance process 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-01-16 22:07:51 +01:00
Julius Härtl
fa966ebaf1
Remove global share accepter since auto-accepting is the default 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-01-16 22:07:51 +01:00
Roeland Jago Douma
960d89ae31
Listen to the right even for auto share accept 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-01-15 23:10:21 +01:00
Roeland Jago Douma
fc77f530d7
Don't show link shares hash in inherited share list 
This adds no value at all. Just showing the text "(Shared link)" now.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-01-15 09:21:53 +01:00
Christoph Wurst
6127c288e8 Fix license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-01-13 14:23:49 +01:00
Maxence Lange
554c4a7cf8 moving ->getParent earlier 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2020-01-08 08:56:14 -01:00
Julius Härtl
445274cf93
Add pending share list to frontend 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-01-07 19:35:45 +01:00
Roeland Jago Douma
fbed6a3416
A pending shares overview 
Now that we accept shares we should show an overview of shares that are
pending. This first part is the small API to get a list of the currently
pending shares.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-01-07 08:53:33 +01:00
Roeland Jago Douma
fb6b84b5c9
Accept shares when you open mail 
Fixes #18380

When you open a direct share to yourself. We should autoaccept the
share.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-01-06 16:48:21 +01:00
Roeland Jago Douma
1672ff3bef
Do not use $_GET 
The appframework is more than capable of handling this properly.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-01-05 20:13:11 +01:00
Maxence Lange
441b81a3af confirm resharing rights if viewer is current owner 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2020-01-02 11:34:20 -01:00
Christoph Wurst
1b46621cd3
Update license headers for 18 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-12-20 09:23:25 +01:00
Roeland Jago Douma
b86990988e
Use the user from the notification 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-12-18 08:37:03 +01:00
Roeland Jago Douma
e7dc91002f
Allow users to specify to accept (internal) shares by default 
Fixes #18255

A new user setting allows a user to always accept (internal) shares. For
example if they don't like accepting shares manually ;)

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-12-17 10:49:29 +01:00
Roeland Jago Douma
bb4264c565
config.php setting to always accept internal shares 
Part of #18255

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-12-16 09:07:25 +01:00
Roeland Jago Douma
c0229768f2
Fetch the share for the recipient 
Fixes #18020

For group shares your invite might be handled but that doesn't mean the
whole share is handled. So we just need to make sure to fetch the share
for the current user.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-12-09 12:23:38 +01:00
Christoph Wurst
5bf3d1bb38
Update license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-12-05 15:38:45 +01:00
Roeland Jago Douma
5e14b299bc
Expose capability if the lookup server should be queried by default 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-12-05 08:38:33 +01:00
Roeland Jago Douma
7a45413559
Always do sharee lookup on lookup server in GS 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-12-05 08:38:33 +01:00
Maxence Lange
f2c7ca4584
fixing tests + avoid duplicate in getFormattedShares() 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2019-12-03 08:13:22 +01:00
Maxence Lange
ccf7d87c11
integration tests 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
add tests on non-owner pov

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
duplicate

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
small fixes

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
removed tags

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2019-12-03 08:10:27 +01:00
Maxence Lange
5794f14df9
Inherited Shares 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
working on users with resharing rights

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
-getLogger()

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
cleaning

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
fix type

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Update SharingRightsException.php
 2019-12-03 08:10:27 +01:00
John Molakvoæ (skjnldsv)
5cb11ca642
Fix tests 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2019-12-02 13:08:43 +01:00
John Molakvoæ (skjnldsv)
0bf6fcd6cd
Create sharing entry point with constants 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2019-12-02 08:58:50 +01:00
John Molakvoæ (skjnldsv)
f8af027686
Fix files_sharing app LoadSidebar event 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2019-12-02 08:58:50 +01:00
Roeland Jago Douma
8797ff70eb
Add capabilities 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-27 14:33:13 +01:00
Roeland Jago Douma
77d136cbdf
Apply share permission mask to all files obtained via shareinfo 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-26 11:07:01 +01:00
Roeland Jago Douma
c7d5b8fc49
Merge pull request #18079 from nextcloud/fixes/phpcs 
Some php-cs fixes
 2019-11-25 14:07:00 +01:00
Roeland Jago Douma
68748d4f85
Some php-cs fixes 
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-22 20:52:10 +01:00
waleczny
6e3ea09b1c
Get first element of nodes array 
Geting first element of nodes array instead of element with key 0. In some cases key 0 not exists in this array ie. when file is shared from group folder with member of this group who have no permission to read this file.
 2019-11-18 23:33:26 +01:00
Roeland Jago Douma
e16321368f
Fixes 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-18 16:11:03 +01:00
Joas Schilling
d3b62893af
Make sure the super share also has a valid type 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-11-12 17:37:47 +01:00
Joas Schilling
6d9afca14f
Fix "Invalid parameter number: mixed named and positional parameters" 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-11-12 17:37:47 +01:00
Joas Schilling
0fe4b717dc
Correctly use the displayname of the sharer in the notification 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-11-12 17:37:47 +01:00
Joas Schilling
e79ab7d0c5
The share manager knows which provider can accept shares 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-11-12 17:37:47 +01:00
Joas Schilling
19e1892d50
Use constants for the magic strings 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-11-12 17:37:45 +01:00
Joas Schilling
43517cfac6
Accept existing shares on update 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-11-12 17:37:00 +01:00
Joas Schilling
60da25681e
Only restrict loading of group and user shares for now 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-11-12 17:37:00 +01:00
Joas Schilling
8986910a7d
Add notifications for users that are added to the group 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-11-12 17:37:00 +01:00
Joas Schilling
520042bbd0
Allow to accept group shares 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-11-12 17:36:58 +01:00
Joas Schilling
c79a56481b
Notifications for group shares 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-11-12 17:33:53 +01:00
Joas Schilling
e96c9e0e4a
Add the notifier and the API endpoint for user shares 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-11-12 17:33:50 +01:00
Joas Schilling
dcdbea54e6
Respect the accepted flag for group and user shares 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-11-12 17:13:38 +01:00
Roeland Jago Douma
1ac57e76fa
Add notification for shares about to expire 
Introduces a new command that will create notifications for users if
they have shares that will expire the next day.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-01 08:53:18 +01:00
John Molakvoæ (skjnldsv)
2fd057513a Fix current user edit/delete permissions 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2019-10-29 13:20:08 +01:00
John Molakvoæ (skjnldsv)
cc4362df4f Unify code to get shares of a file or also including subfiles 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2019-10-25 21:41:12 +02:00
John Molakvoæ (skjnldsv)
dbb6b4cbb9 Filter out duplicated shares before processing them 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2019-10-25 21:41:12 +02:00
Daniel Calviño Sánchez
8098abee60 Do not return shares with the current user 
Getting the shares of a file no longer returns shares with the current
user for consistency with the results when getting the shares including
subfiles.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2019-10-25 21:40:50 +02:00
Daniel Calviño Sánchez
1afefc2d9a Extract method to get all shares 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2019-10-25 21:39:49 +02:00
Daniel Calviño Sánchez
222e5a9a9f Add missing share types when getting shares of a file 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2019-10-25 21:39:49 +02:00
Daniel Calviño Sánchez
24febe1e41 Unify share type sorting when getting shares of a file or with subfiles 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2019-10-25 21:39:49 +02:00
Daniel Calviño Sánchez
0599536c82 Remove unneeded calls to "ShareManager::shareProviderExists()" 
"ShareManager::getSharesBy()" already checks if the share provider
exists before returning the shares and, if the provider does not exist,
it returns an empty array. Therefore it is not needed to explicitly
check if the provider exists or not.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2019-10-25 21:39:49 +02:00
j3l11234
fa4d71c456 Add support for download share on old android browser 
Signed-off-by: j3l11234 <297259024@qq.com>
 2019-10-21 21:29:49 +08:00
Daniel Calviño Sánchez
5c7c308220 Include the share in the Files_Sharing::loadAdditionalScripts event 
This provides a better context for apps using the event, for example to
load one script or another depending on whether the share is a file or a
folder.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2019-10-17 18:22:54 +02:00
Roeland Jago Douma
4a2f9fab66
Move over OCSShareAPIMIddleware to pure DI 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-10-16 22:53:09 +02:00
Joas Schilling
4d40eb61b4
List share download activity under sharing 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-10-10 08:43:54 +02:00
John Molakvoæ (skjnldsv)
ff895abac0
Fix shares read permissions 
A user with reshare permissions on a file is now able to get any share
of that file (just like the owner).

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2019-10-04 21:40:30 +02:00
John Molakvoæ (skjnldsv)
b1069b29fa
Add checks for whether a user with access to a share can delete it 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2019-10-04 19:25:11 +02:00
John Molakvoæ (skjnldsv)
f02cff1304
Extract check for whether a user with access to a share can edit it 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2019-10-04 19:25:11 +02:00
John Molakvoæ (skjnldsv)
c49469c4d8
Prevent non owners to update others link shares 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2019-10-04 08:19:07 +02:00
John Molakvoæ (skjnldsv)
c8d50538b8
Use same settings for mail share as link shares 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2019-10-04 08:19:07 +02:00
Joas Schilling
15d39c48e6
Merge pull request #17021 from nextcloud/bye-spreed-hello-talk 
Bye Spreed namespace, hello Talk!
 2019-09-11 14:59:37 +02:00
Joas Schilling
858b18e34a
Bye Spreed namespace, hello Talk! 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-09-05 15:32:58 +02:00
Joas Schilling
70807a74c7
Correctly check for new default root 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-09-04 09:28:58 +02:00
Julius Härtl
64c63bb00b
Properly initialize the CacheJail for sharing 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2019-09-03 18:07:59 +02:00
John Molakvoæ (skjnldsv)
b557f52c22
Add expiration event for shares 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2019-08-21 08:30:17 +02:00
Joas Schilling
85a80b05ac
Unify the permission checking in one place only 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-07-03 16:34:00 +02:00
Joas Schilling
7aa26b28a8
Correctly check share permissions when updating a re-sub-share 
Before this change the node you shared was checked for permissions.
This works when you reshare the folder that was shared with you.
However when you reshared a subfolder (e.g. as public link),
you could afterwards update the permissions and grant
create+update permissions although the share you receive was read-only.

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-06-27 15:27:30 +02:00
tobiasKaminsky
b65a59568e
add "askForPassword" on capabilities for sharing 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2019-05-13 20:09:00 +02:00
Morris Jobke
2565e16770
Fix public upload by also load the semaphore method 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2019-05-07 23:48:06 +02:00
Daniel Calviño Sánchez
dfe9e3fb2e Do not allow JavaScript "eval" in the public share auth page with Talk 
Talk no longer uses JavaScript "eval", so the Content Security Policy
can now be configured to prevent its use in the public share
authentication page when the password is protected by Talk.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2019-04-10 16:46:19 +02:00
Maxence Lange
749fdab3b0 do not returns shared_with === currentUser 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2019-04-01 11:17:05 -01:00
Maxence Lange
0166990f01 fixing share format 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2019-03-31 10:40:14 -01:00
Maxence Lange
efbadf0cf2 issue during last push 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2019-03-31 10:40:14 -01:00
Maxence Lange
44c1feb938 returns reshares in API 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2019-03-31 10:40:14 -01:00
Morris Jobke
4b49e2eb52
Fix unnecessary boolean cast 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2019-03-06 10:12:58 +01:00
Morris Jobke
fde4c54136
Merge pull request #13790 from fretn/master 
Fix for crashing occ files:scan
 2019-03-06 10:12:14 +01:00
Christoph Wurst
e930a0ccbe
Search sharees on lookup server when explicitly requested by user 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-02-26 19:44:49 +01:00
Morris Jobke
ee68e8f47e
Merge pull request #13514 from nextcloud/fix-public-grid-toggle 
Fix grid toggle button on public page
 2019-02-25 21:18:42 +01:00
Christoph Wurst
f3023aaa85
Show sharing recommendations 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-02-25 07:25:21 +01:00
John Molakvoæ (skjnldsv)
ee2c45d60d
Fix grid toggle button on public page 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2019-02-21 09:17:57 +01:00
Julius Härtl
2ec5e2b588
Fix writable public folder share 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2019-02-19 10:18:26 +01:00
Roeland Jago Douma
0e72d38747
Catch Request exception in testRemoteUrl 
Else the background job fails hard if the remote has for example an
invalid certificate.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-02-15 23:06:21 +01:00
Jonas Sulzer
3a5d634ccc
add myself as @author 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
 2019-01-31 22:39:01 +01:00
Jonas Sulzer
e2ec22c43d
code styling 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
 2019-01-31 22:39:00 +01:00
Jonas Sulzer
5756d96ab9
restructure code 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
 2019-01-31 22:39:00 +01:00
Jonas Sulzer
30d4024d9d
only show "Add to your Nextcloud" on share link if federation is activated 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
 2019-01-31 22:38:31 +01:00
fretn
7efcd11b8e Fix for crashing occ files:scan 
when $share === false then (int)$share['share_type'] will always be equal to (int)0

which results in following crash:

[root@server nextcloud] sudo -u apache php occ files:scan someuser
The current PHP memory limit is below the recommended value of 512MB.
Starting scan for user 1 out of 1 (someuser)
An unhandled exception has been thrown:
TypeError: Argument 1 passed to OC\OCS\DiscoveryService::discover() must be of the type string, null given, called in /var/www/html/nextcloud/apps/files_sharing/lib/External/Manager.php on line 382 and defined in /var/www/html/nextcloud/lib/private/OCS/DiscoveryService.php:65
Stack trace:
0 /var/www/html/nextcloud/apps/files_sharing/lib/External/Manager.php(382): OC\OCS\DiscoveryService->discover(NULL, 'FEDERATED_SHARI...')
1 /var/www/html/nextcloud/apps/files_sharing/lib/External/Manager.php(527): OCA\Files_Sharing\External\Manager->sendFeedbackToRemote(NULL, NULL, NULL, 'decline')
2 /var/www/html/nextcloud/apps/files_sharing/lib/External/Storage.php(216): OCA\Files_Sharing\External\Manager->removeShare('files/Someth...')
3 [internal function]: OCA\Files_Sharing\External\Storage->checkStorageAvailability()
4 /var/www/html/nextcloud/lib/private/Files/Storage/Wrapper/Wrapper.php(505): call_user_func_array(Array, Array)
5 [internal function]: OC\Files\Storage\Wrapper\Wrapper->__call('checkStorageAva...', Array)
6 /var/www/html/nextcloud/lib/private/Files/Storage/Wrapper/Wrapper.php(505): call_user_func_array(Array, Array)
7 /var/www/html/nextcloud/apps/files_sharing/lib/External/Scanner.php(89): OC\Files\Storage\Wrapper\Wrapper->__call('checkStorageAva...', Array)
8 /var/www/html/nextcloud/apps/files_sharing/lib/External/Scanner.php(44): OCA\Files_Sharing\External\Scanner->scanAll()
9 /var/www/html/nextcloud/lib/private/Files/Utils/Scanner.php(245): OCA\Files_Sharing\External\Scanner->scan('', true, 3)
10 /var/www/html/nextcloud/apps/files/lib/Command/Scan.php(172): OC\Files\Utils\Scanner->scan('/someuser', true, NULL)
11 /var/www/html/nextcloud/apps/files/lib/Command/Scan.php(249): OCA\Files\Command\Scan->scanFiles('someuser', '/someuser', false, Object(Symfony\Component\Console\Output\ConsoleOutput), false, true, false)
12 /var/www/html/nextcloud/3rdparty/symfony/console/Command/Command.php(251): OCA\Files\Command\Scan->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
13 /var/www/html/nextcloud/core/Command/Base.php(162): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
14 /var/www/html/nextcloud/3rdparty/symfony/console/Application.php(946): OC\Core\Command\Base->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
15 /var/www/html/nextcloud/3rdparty/symfony/console/Application.php(248): Symfony\Component\Console\Application->doRunCommand(Object(OCA\Files\Command\Scan), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
16 /var/www/html/nextcloud/3rdparty/symfony/console/Application.php(148): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
17 /var/www/html/nextcloud/lib/private/Console/Application.php(213): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
18 /var/www/html/nextcloud/console.php(96): OC\Console\Application->run()
19 /var/www/html/nextcloud/occ(11): require_once('/var/www/html/n...')
20 {main}[root@server nextcloud]

Signed-off-by: fretn <frederikdelaere+github@gmail.com>
 2019-01-24 11:45:53 +01:00
Julius Härtl
3828283c01
Add caching headers for public previews 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2019-01-02 22:27:46 +01:00
Joas Schilling
ee545d6840
Fix typo in "incoming" 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-12-05 11:27:38 +01:00
Morris Jobke
d8314b102e
Merge pull request #12624 from nextcloud/bugfix/noid/validate-all-rich-objects 
Validate all rich objects
 2018-12-04 22:48:54 +01:00
Morris Jobke
cae600d205
Merge pull request #12628 from nextcloud/bugfix/act-317/missing-activity-for-user-self-unshare 
Parse activity when a user self-unshares a file
 2018-11-30 10:14:26 +01:00
Robin Appelman
2c1f6331a4
Add interface to allow storages from opting out of encryption 
As opposed to hard-coding a list of excluded storages

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2018-11-29 16:31:34 +01:00
Bjoern Schiessle
1518671ad8
add capabilities for multiple share links 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2018-11-26 14:44:59 +01:00
Joas Schilling
72f8a58f89
Parse activity when a user self-unshares a file 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-11-23 13:21:52 +01:00
Joas Schilling
99bcc1363e
Fix wrong used type 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-11-23 12:39:02 +01:00
Roeland Jago Douma
a343a60a68
Handle permission in update of share better 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-11-20 09:42:01 +01:00
John Molakvoæ (skjnldsv)
1deda8fd65
Rollback to default list view 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-11-15 20:29:10 +01:00
Morris Jobke
79681ef3d9
Merge pull request #12398 from nextcloud/fix/12378 
change "Download" to "Download all files" for shared folders
 2018-11-13 17:21:09 +01:00
Jonas Sulzer
1f237c7e25
change "Download" to "Download all files" for shared folders 
fixes #12378

Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
 2018-11-10 19:10:31 +01:00
Joas Schilling
bb352fb667
Use the defined func()->count() instead of manual counting 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-11-08 15:44:45 +01:00
Morris Jobke
7940a79a41
Merge pull request #12324 from nextcloud/add-password-response-parameter-for-returning-the-password-of-link-shares 
Add "password" parameter to the response data of link shares
 2018-11-07 16:29:05 +01:00
Morris Jobke
9669d451e3
Reduce function calls 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-11-07 10:19:20 +01:00
Michael Weimann
c572c669e5
Adapts the code to the new master state 
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
 2018-11-07 10:19:20 +01:00
Michael Weimann
95a19bdfdd
Inlines the share note for file drops 
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
 2018-11-07 10:19:19 +01:00
Michael Weimann
08e681b221
Inlines the share note for file drops 
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
 2018-11-07 10:19:19 +01:00
Michael Weimann
16f379b974
Hides the header actions for file drops 
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
 2018-11-07 10:19:19 +01:00
Daniel Calviño Sánchez
b2cc2d6023 Add "password" parameter to the response data of link shares 
Due to legacy reasons the password of link shares was returned in the
"share_with" and "share_with_displayname" parameters of the response
data. Now a proper "password" parameter is returned too; the old
"share_with" and "share_with_displayname" parameters are kept, although
deprecated, and they will be removed in a future version of Nextcloud.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-11-06 23:48:28 +01:00
John Molakvoæ (skjnldsv)
5682d302c7
Add grid toggle for every files view 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-11-06 11:42:18 +01:00
Morris Jobke
cba3883410
Merge pull request #12185 from nextcloud/cleanup/dicontainer 
Cleanup the DIContainer
 2018-11-05 12:16:36 +01:00
Roeland Jago Douma
72b7c9ffa0
Merge pull request #12105 from nextcloud/using-resharing-right-to-display-shares 
Shares are displayed to users with resharing rights
 2018-11-04 21:08:11 +01:00
Roeland Jago Douma
c8cf986527
Fix files_sharing 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-11-02 19:20:37 +01:00
Maxence Lange
0fc8a0f58e
user can have his resharing rights revoked, yet seeing created shares 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2018-11-02 12:10:49 +01:00
Maxence Lange
236a293f6a
check parents resharing rights 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2018-11-02 12:10:48 +01:00
Maxence Lange
275cea5d9c
limit to circles moderator 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2018-11-02 12:09:28 +01:00
Maxence Lange
72ad2d60b5
display shares to circles moderator 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2018-11-02 12:09:28 +01:00
Maxence Lange
68c44bb642
shares are displayed to users with resharing rights 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2018-11-02 12:09:26 +01:00
Daniel Calviño Sánchez
adf80aa8b3 Add sending the password by Talk for a link share to ShareAPIController 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-11-02 01:57:48 +01:00
Bjoern Schiessle
5e90711600 allow to update lables for public link shares 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2018-11-01 02:18:55 +01:00
Bjoern Schiessle
f377a61f90 allow to add labels to shares 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2018-11-01 02:15:07 +01:00