upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-03-28 21:33:40 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 7
67226 commits 821 branches 1191 tags 6.6 GiB
Commit graph

13048 commits

Author SHA1 Message Date
Johannes Merkel
38ba696729 fix(mail): ContactManager search with fullmatch 
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
 2023-08-02 21:36:10 +02:00
Arthur Schiwon
f361b5e215
Merge pull request #39597 from nextcloud/backport/38667/stable26 
[stable26] fix(SystemTagManager): Use truncated tagName in getTag and updateTag
 2023-08-02 21:18:26 +02:00
Arthur Schiwon
105d0663f9
Merge pull request #39437 from nextcloud/backport/39309/stable26 
[stable26] fix(profile): fix getUID on nullable user variable
 2023-08-02 21:16:31 +02:00
Arthur Schiwon
c174c47f1e
Merge pull request #39370 from nextcloud/backport/39339/stable26 
[stable26] fix(node): non-existing folder is not searchable
 2023-08-02 21:16:12 +02:00
Marcel Klehr
ce7641ebfc fix(SystemTagManager): Use truncated tagName in getTag and updateTag 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-07-27 17:13:41 +00:00
Benjamin Gaussorgues
25ba08b1d3
Add instance category while checking new updates 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-07-21 12:06:49 +02:00
Joas Schilling
4a21e41313
fix(apps): Fix loading info.xml file 
Ref: https://bugs.php.net/bug.php?id=62577

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-07-20 10:47:45 +02:00
Thomas Citharel
5a6447645a fix(profile): fix getUID on nullable user variable 
As per method signature, $visitingUser is nullable, so we can't be sure calling getUid() on it will
work.

Closes #35766

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2023-07-17 13:33:58 +00:00
Arthur Schiwon
6eaaef1403 fix(node): non-existing folder is not searchable 
the previosuly introduced searchBySystemTag was not overwritten in
NonExistingFolder and could run the inherited method.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-13 14:33:05 +00:00
Julius Härtl
c7a8c3b427
Merge pull request #39232 from nextcloud/backport/39202/stable26 2023-07-10 18:08:23 +02:00
Arthur Schiwon
1c59a7a5db
Merge pull request #39031 from nextcloud/backport/38917/stable26 
[stable26] fix(l10n): Fix plural issue with different locale and language
 2023-07-10 18:05:48 +02:00
Arthur Schiwon
91a44763bd
Merge pull request #39100 from nextcloud/backport/39093/stable26 
[stable26] Silent `imagecreatefromstring()` errors
 2023-07-10 17:59:29 +02:00
Arthur Schiwon
48f27a90bd
Merge pull request #39270 from nextcloud/backport/35915/35915-stable26 
[stable26] display displayname on federated shares
 2023-07-10 17:49:34 +02:00
Maxence Lange
b9a25ce4d5 display displayname on federated shares 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2023-07-10 10:57:26 -01:00
Joas Schilling
ddff2e692d
fix(dav): Abort requests with 429 instead of waiting 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-07-10 06:32:01 +02:00
Arthur Schiwon
fc9fd0d7f2
refactor: adjust to unexposed searchBySystemTag 
- in this backport we have to drop the breaking addition in
  \OCP\Files\Folder
- this requires adjustments in check for the existance of the method but
  also in testing
- another change in \OCP\SystemTag\ISystemTagManager can be applied as
  this interface is not implemented elsewhere

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-07 16:58:07 +02:00
Arthur Schiwon
749efc1ba1 fix: cominbation of small fixes 
- possible null return
- parameter name mismatch in implementation
- incomplete unit test

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-07 14:54:56 +00:00
Arthur Schiwon
0b4db60d3b fix: include invisible tags for admins 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-07 14:54:56 +00:00
Arthur Schiwon
48c92ade85 fix: favorites view and universal search against tags 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-07 14:54:56 +00:00
Arthur Schiwon
c33f728249 fix: change if with conditionless else to switch; and a parameter value 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-07 14:54:55 +00:00
Arthur Schiwon
b172df69d6 use efficient tag retrieval on DAV report request 
- uses DAV search approach against valid files joined by systemtag selector
- reduced table join for tag/systemtag search
- supports pagination
- no changes to the output formats or similar

Example request body:

<?xml version="1.0"?>
<oc:filter-files xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns" xmlns:nc="http://nextcloud.org/ns" xmlns:ocs="http://open-collaboration-services.org/ns">
  <d:prop>
    <d:getcontentlength/>
    <d:getcontenttype/>
    <d:getetag/>
    <d:getlastmodified/>
    <d:resourcetype/>
    <nc:face-detections/>
    <nc:file-metadata-size/>
    <nc:has-preview/>
    <nc:realpath/>
    <oc:favorite/>
    <oc:fileid/>
    <oc:permissions/>
    <nc:nbItems/>
  </d:prop>
  <oc:filter-rules>
    <oc:systemtag>32</oc:systemtag>
  </oc:filter-rules>
  <d:limit>
    <d:nresults>50</d:nresults>
    <nc:firstresult>0</nc:firstresult>
  </d:limit>
</oc:filter-files>

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-07 14:54:55 +00:00
Richard Steinmetz
36b48dea52 fix(sse): don't update uncached files 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2023-07-04 20:23:47 +00:00
Arthur Schiwon
3fd03faf58
Merge pull request #38977 from nextcloud/backport/38625/stable26 
[stable26] fix: expect interface, not a specific implementation
 2023-07-04 22:08:09 +02:00
Git'Fellow
11a6de90b8 Silent imagecreatefromstring() errors 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2023-07-01 14:43:13 +00:00
Joas Schilling
756e119162
fix(l10n): Fix plural issue with different locale and language 
We need to use the language code here instead of the locale,
because Symfony does not distinguish between the two and would
otherwise e.g. with locale "Czech" and language "German" try to
pick a non-existing plural rule, because Czech has 4 plural forms
and German only 2.

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-06-27 14:15:46 +02:00
Arthur Schiwon
013d34977b
ci: adjust return annotation to older psalm version 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-26 17:07:21 +02:00
Simon L
c10f3e31e8 use getsystemvalue-functions in Mailer.php 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2023-06-26 11:06:24 +02:00
Arthur Schiwon
aec67f41a3 ci: pro forma check of existence of internal method 
createNode() is protected and used by Folder, but being an internal-only
method it shall not be exposed in the Folder or IRootFolder interface.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-23 23:04:44 +00:00
Arthur Schiwon
2b27a4cda0 refactor: declare getMount() and getMountsIn() at IRootFolder 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-23 23:04:44 +00:00
Arthur Schiwon
3813b955ee chore: ugly type juggling 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-23 23:04:40 +00:00
Arthur Schiwon
ae48fc86d2 fix: add typehine for IRootFolder 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-23 23:04:40 +00:00
Arthur Schiwon
e095311819 fix: expect interface, not a specific implementation 
- fixes a regression when deleting folders while music app was enabled,
  for a LazyRoot was passed to this method.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-23 23:04:39 +00:00
Robin Appelman
3e46f6289f
use source cache when listing folder during recursive copy 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-06-19 12:31:17 +02:00
Arthur Schiwon
5f566101f1
Merge pull request #38023 from nextcloud/backport/32877/stable26 
[stable26] allow storing multiple mounts for the same rootid in the mount cache
 2023-06-15 12:40:45 +02:00
Arthur Schiwon
00afe495bc
Merge pull request #37230 from nextcloud/backport/36033/stable26 
[stable26] invalidate existing tokens when deleting an oauth client
 2023-06-15 11:54:38 +02:00
Arthur Schiwon
d12699a451
Merge pull request #38757 from nextcloud/backport/38468/stable26 
[stable26] log failures to read certificates during listing
 2023-06-15 11:09:05 +02:00
Arthur Schiwon
794bf5b6b9
Merge pull request #37776 from nextcloud/backport/37534/stable26 
[stable26] Adjust the value of the "max-parts" parameter of the object storage 'ListPart' interface to 1000
 2023-06-13 11:46:05 +02:00
Robin Appelman
5fde58d4f0 log failures to read certificates during listing 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-06-12 12:55:51 +00:00
Julien Veyssier
793d5320c3 shorten oauth2 client names before resizing the column 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
 2023-06-07 15:32:28 +02:00
Julien Veyssier
1bd9544a8a drop the oauth2_clients trusted column, delete unsupported clients and their access tokens 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
 2023-06-07 15:32:28 +02:00
Simon L
c77aab679c
Merge pull request #38479 from nextcloud/backport/38440/stable26 
[stable26] fix: Catch Deadlock properly as execute throws Doctrine exceptions not our wrapped ones
 2023-06-06 16:23:47 +02:00
Daniel
a2ac818bd2
Merge pull request #38517 from nextcloud/backport/38496/stable26 
[stable26] fix: catch errors in id3parser library
 2023-06-01 20:37:32 +02:00
Robin Appelman
6cfd5cbe64
allow storing multiple mounts for the same rootid in the mount cache 
currently `[$userId, $rootId]` is used as the unique key for storing mounts in the mount cache,
however there are cases where the same rootid is mounted in multiple places for a user which currently leads to not all of those mounts being added to the cache.

Previously this didn't matter as the mount cache was only used to list users with access to a specific file, so a user having access to the file multiple times didn' change anything.

With 24 the mount cache is used for more cases and multiple mounts for the same id becomes relevant.
While I think there isn't a real negative effect atm besides missing the optimized path we should ensure that the mounts are properly listed

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-05-31 15:38:00 +02:00
Varun Patil
119e52f8b6
redis: move lua scripts to class and add type hints 
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
 2023-05-31 12:00:34 +02:00
Varun Patil
f5895faafa redis: use atomic operations everywhere 
This removes a lot of acrobatics in the code and does each operation
atomically using a lua script. This also reduces several round trips
to the server, and the scripts are compiled and cached server-side.

Notably, since all operations work only on a single key (except clear,
which is broken anyway and shouldn't be used), they will continue to
function and be atomic for Redis cluster.

Signed-off-by: Varun Patil <varunpatil@ucla.edu>
 2023-05-31 07:13:23 +00:00
Daniel Kesselberg
ef0cffc937 fix: catch errors in id3parser library 
We use a forked version of getID3 to read embedded images from mp3 files to use them as previews.

If the library is unable to extract a image or fails on something different we should handle it properly.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2023-05-30 13:45:48 +00:00
Julius Härtl
0a7594753f fix: execute throws docrine exceptions not our wrapped ones 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-05-26 07:46:25 +00:00
Artur Neumann
19bb66a889
public interface to invalidate tokens of user 
Signed-off-by: Artur Neumann <artur@jankaritech.com>
 2023-05-19 12:02:05 +05:45
Arthur Schiwon
7c6b47dd27
Merge pull request #38091 from nextcloud/backport/35092/stable26 
[stable26] Check return value and improve error handling on certificate manager
 2023-05-17 19:04:10 +02:00
Andy Scherzinger
4bd2f33cfe
Merge pull request #38307 from nextcloud/backport/37961/stable26 
[stable26] SystemTags endpoint to return tags used by a user with meta data
 2023-05-17 18:15:02 +02:00