The backend returns type 'dir' for folders (from FileInfo::TYPE_FOLDER),
but the frontend expects 'folder'. This mismatch caused federated shared
folders to display incorrectly as files in the "Shared with you" view.
Signed-off-by: nfebe <fenn25.fn@gmail.com>
When `showFederatedSharesToTrustedServersAsInternal` is enabled, the
trusted server filter was incorrectly applied to both internal and
external sharing sections. This prevented users from sharing with
federated users on non-trusted servers via the external share UI.
The filter now only applies to the internal section, allowing
non-trusted federated shares to appear in the external section.
Fixes: https://github.com/nextcloud/server/issues/56622
Signed-off-by: nfebe <fenn25.fn@gmail.com>
When `show_federated_shares_to_trusted_servers_as_internal` is enabled
but `show_federated_shares_as_internal` is not, filter federated share
suggestions to only include trusted servers. Previously, searching for
an email address would suggest non-trusted federated servers.
Resolved: #54511
Signed-off-by: nfebe <fenn25.fn@gmail.com>
The password param should never be sent if the intention is not
remove it or update it.
This commit adapts the frontend and backend to this rule to avoid weird bugs
especially around updating new shares.
Signed-off-by: nfebe <fenn25.fn@gmail.com>
[skip ci]
This fixes apps providing vue components, which is invalid and does not
always work - and never work with Vue 3.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
`newPassword` is the unsaved password, while `share.password` is the
current saved password.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
The condition was checking shares.length to display the Others with
access component, but shares is filled only on expanding that section,
rendering the section never visible.
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
1. Use correct color
2. Do not mix legacy icon classes with MDI icons this will show two
icons...
3. Use proper aria label and put status into the title
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
The checkbox appears checked when no password is set (share.password ===
undefined)
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
This removes:
- “enable” for settings
- “settings” for settings sections
- “all” when there is no obvious subset of items
- “show” and “open” for navigation actions
- “changes” for applying/discarding
- “to clipboard” when copying
- Explaining things that cannot happen
- Explaining things twice, right below each other
- Unnecessary technical jargon
- Text that sounds like marketing copy and serves no other purpose
Signed-off-by: kramo <git@kramo.page>
This commits addresses an annoyance where the share input placeholder would
suggest sharing via federated cloud ID even if federation was disabled.
Signed-off-by: nfebe <fenn25.fn@gmail.com>
- if this is a GS instance
- or was configured by administrator
Then show the share as internal (remote and remote group shares).
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
- resolves: https://github.com/nextcloud/server/issues/52497
Ensure that when global scale is enabled the federated users are shown
just like internal users.
Meaning no server part but instead use the email address like with internal.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
The variable is intialized to `{}` which is truthy, so instead just
check if there is a user assigned to the share info.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
`nextcloud-vue-collections` is deprecated for quite some time and was
merged into `@nextcloud/vue`. So lets drop that dependency.
Adjust the two files where it was used, one of them was itself never
used so just dropped that file.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
We need to save the previous state - here the password - so that if the
update fails we can revert the shown state.
This happens e.g. if you have the password policy app and try to add an
unsecure password.
To reproduce (with password policy):
1. Create new link share
2. enable password protection
3. use insecure password like `1234`
4. save share
Now you see that the update failed, but the password protection is still
enabled. This happened because `password` and `newPassword` were
misused. `password` was already set when `newPassword` was not saved so
we could not know to what we need to reset when the update failed.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
The title is already escaped by vue so special characters would result
in incorrect strings.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
