Ferdinand Thiessen
d0402dee06
fix(IFilenameValidator): correctly handle case insensitivity
...
- forbidden names and forbidden base names are case **insensitive**
so we need to check all lowercase here.
- add test that config value is also read case insensitive.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-24 11:46:43 +00:00
Git'Fellow
552c5e8cef
fix(files): Make sure file pointer exists
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-03-17 16:04:47 +00:00
Louis
acf19f7880
Revert "Revert "[stable30] fix: Handle copy of folders containing live photos""
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-03-05 13:45:23 +01:00
Marcel Müller
c6ca459b40
fix: No IFactory in constructor
...
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2025-03-05 11:34:03 +00:00
Joas Schilling
259919e9fd
fix(files): Don't do session related work in the constructor of the View
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-03-05 11:34:03 +00:00
Andy Scherzinger
682c8e6a61
Merge pull request #50796 from nextcloud/backport/50781/stable30
...
[stable30] perf(files): faster query to fetch incomplete directories
2025-02-17 19:15:58 +01:00
Robin Appelman
33fb176651
fix: make locked exception path relative to the view
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-15 14:42:51 +01:00
Benjamin Gaussorgues
765b4921ff
perf(files): faster query to fetch incomplete directories
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2025-02-14 10:57:26 +01:00
Andy Scherzinger
7bf1126b1f
Merge pull request #49657 from nextcloud/backport/48769/stable30
...
[stable30] Fix incorrect permissions when copying shared files
2025-02-14 10:30:46 +01:00
Louis Chemineau
a663b3e0cd
fix(files): Correctly copy the cache information on copy operations
...
Needed to copy the `encrypted` flag of encrypted files when those files are two level down in a moved folder.
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-02-13 23:35:59 +00:00
Robin Appelman
9f1666ef3d
fix: use scan_permissions when copying cache items
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-13 18:17:31 +01:00
Robin Appelman
5c9a3a2423
fix: store unmaked source permissions as scan_permissions when loading share cache items
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-13 18:17:31 +01:00
Robin Appelman
da334737e4
fix: rework move into object store to better preserve fileids
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-13 17:31:51 +01:00
Robin Appelman
e85d5df5f0
fix: preserve fileid when moving from objectstore to non-objectstore
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-13 17:31:51 +01:00
Robin Appelman
9fd7dfd1c2
fix: ensure source folder is removed from cache when moving to objectstore
...
otherwise this causes confusion down the line as it's contents will be moved to the new cache
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-13 17:31:51 +01:00
Andy Scherzinger
094ea5c885
Merge pull request #50761 from nextcloud/backport/50324/stable30
...
[stable30] fix: don't use cached root info from shared cache if the watcher has detected an update
2025-02-13 16:43:50 +01:00
Robin Appelman
3bfcd8371b
fix: don't use cached root info from shared cache if the watcher has detected an update
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-11 16:21:37 +01:00
John Molakvoæ
86408a5be7
fix: psalm and OCP @since declarations
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2025-02-06 15:15:41 +00:00
skjnldsv
80a4cb586f
fix: make sure we process mime extensions as string
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-06 15:15:41 +00:00
Robin Appelman
5d094feee0
fix: explicitly ignore nested mounts when transfering ownership
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-05 09:09:04 +01:00
Robin Appelman
6cf97e929b
fix: translate mount move error messages
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-05 09:09:03 +01:00
Robin Appelman
68829ad47c
fix: improve checks for moving shares/storages into other mounts
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-05 09:08:58 +01:00
Richard Steinmetz
b081f3b7c4
fix(s3): treat empty sse_c_key as not set
...
Co-authored-by: Christian Becker <christian@dabecka.de>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-01-29 17:34:47 +00:00
Ferdinand Thiessen
67e0ef5b72
fix(files): Do not array access null value
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 20:51:42 +01:00
Louis Chemineau
474d93625b
fix: Metadata field search
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-01-27 18:57:00 +01:00
Kate
1c99b367be
Merge pull request #49991 from nextcloud/backport/49887/stable30
2025-01-20 17:28:02 +01:00
Robin Appelman
a2bcf725a6
chore: psalm fixes
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-20 15:31:05 +01:00
Git'Fellow
1efa72d91a
fix(TemplateManager): Remove warning message
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-01-20 13:41:38 +00:00
Robin Appelman
2f9b54ab38
fix: don't skip scanner users filesystem if they have a mountpoint at /<user>/files/
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-20 14:27:24 +01:00
provokateurin
5cc14e2618
fix(View): Catch exceptions when executing mkdir for non-existent parents
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-12-17 09:40:42 +00:00
Git'Fellow
28c6c63cc5
fix(TemplateManager): Make sure TemplateFolder is a Folder
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-12-16 06:05:23 +00:00
Louis
cabedbf9c3
Revert "[stable30] fix: Handle copy of folders containing live photos"
2024-12-12 14:28:09 +01:00
John Molakvoæ
d8c3425878
Merge pull request #49650 from nextcloud/backport/49293/stable30
...
[stable30] fix: Handle copy of folders containing live photos
2024-12-12 14:19:55 +01:00
John Molakvoæ
d108a12b0e
Merge pull request #49794 from nextcloud/backport/40394/stable30
...
[stable30] fix mimetype not being updated when changing file extention on objectstore
2024-12-12 13:19:59 +01:00
Robin Appelman
c3a2d789f1
fix: fix mimetype not being updated when changing file extention on object store
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-11 09:00:44 +00:00
Louis Chemineau
9ff3ba7ce0
fix: Correctly create NonExistingFolder during copy
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-12-05 10:35:42 +01:00
Robin Appelman
46ed8cdfde
fix: don't propagate future mtimes
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-04 19:14:51 +00:00
Robin Appelman
44727d4862
fix: fix availability wrapper not applying
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-11-26 18:50:00 +01:00
Robin Appelman
3522819624
fix: throw correct exception type when we can't verify if an s3 bucket exists
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-11-26 18:49:56 +01:00
Git'Fellow
003bb0aca4
fix(storage): Try to delete existing target
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-11-21 07:44:43 +01:00
Josh Richards
1fc1543a8b
fix: Clean-up some remaining readdir calls with undesirable false evaluation potential
...
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-11-13 09:11:17 +05:30
Victor Dubiniuk
e1df152eb9
Fix Undefined variable: response notice in case of non-404 error
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-08 16:14:47 +00:00
Daniel Calviño Sánchez
1a98cd52b5
fix: Fix copying or moving from shared groupfolders
...
When copying or moving between two local storages the source path (on
disk) to copy or move from is got from the unjailed path of the source
storage. However, if the source storage has more than one jail getting
the unjailed path resolves the most external jail, but the source path
needs to be got from the most internal jail instead (the one closer to
the local storage).
This can happen, for example, with a shared groupfolder: in that case
there is an external jail for the shared storage, and one internal jail
for the groupfolder storage wrapped by the shared storage.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-10-29 15:02:49 +00:00
Julius Knorr
643e9ffb06
fix: Allow overriding shouldApplyQuota check from child classes
...
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2024-10-28 09:46:45 +01:00
Benjamin Gaussorgues
8290de3b93
Merge pull request #48077 from nextcloud/backport/47852/stable30
2024-10-02 10:43:41 +02:00
Joas Schilling
abe82432cb
fix(querybuilder): Fix boolean type so that oracle handles boolean well
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-25 08:40:53 +02:00
Kate
61f3a09dcd
Merge pull request #48233 from nextcloud/backport/48222/stable30
2024-09-20 23:02:25 +02:00
Kate
ae7241f6c8
Merge pull request #48221 from nextcloud/backport/30/fix_move_on_same_bucket
2024-09-20 10:06:14 +02:00
Robin Appelman
e8c8ab58f7
perf: reuse cache info we already have when moving to object store
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-20 07:50:23 +00:00
Christoph Fiehe
82be489f53
perf(ObjectStoreStorage): Improve (slow) move on same object bucket
...
This commit fixes the issue #47856 . When you upload a file into a group folder and when you use a single S3 bucket as primary storage, the final move operation hangs for a long time. In the background, Nextcloud initiates a copy-delete sequence from the bucket into the bucket, with causes a lot unnecessary overhead. Nextcloud thinks that the file must be imported to another storage and does not recognize that everything is done on the same object bucket. In that case, the import step can be completely skipped, which saves time, network bandwidth and reduces the load on the object storage.
The behavior improves a lot with https://github.com/nextcloud/server/pull/46013 . However, there are still some put messages that are being sent to the object storage when you use an object storage as primary storage and upload files into a group folder.
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>
2024-09-19 18:53:36 +02:00