Commit graph

378 commits

Author SHA1 Message Date
Ferdinand Thiessen
be82a4e502 fix(files_sharing): ensure share status action works also in grid view
Remove some hacks from files app about the *files_sharing* status
action, in general not sure why this hack was there instead of being in
the correct app - but it broke the grid view.

So now the sharing information is also available in grid view.

Moreover the icon is fixed in size to not overflow the actions menu.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-19 22:51:32 +01:00
Ferdinand Thiessen
985764152f
fix(files): also show file list headers on empty views
It is needed, e.g. for the note-to-recipient, that the headers
are also shown when there is no content (yet).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-17 19:41:41 +01:00
Louis Chemineau
5e49e75a15 fix(test): Add missing data-cy attribute for file actions
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2025-03-05 12:12:51 +00:00
Valdnet
32d6ba0129
fix(l10n): use do not instead of don't
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2025-03-02 12:47:10 +01:00
Joas Schilling
a5e6f46eb0
fix(l10n): Improve english source strings
- No leading/trailing whitespace
- Use asci single quote

Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-02-26 15:06:47 +01:00
skjnldsv
e5c55bf562 fix(files): handle failed node properly
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-21 14:07:13 +01:00
skjnldsv
137ff37cf8 fix(files): properly forward open params from short urls
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-19 10:13:55 +01:00
Julien Veyssier
741c0f3cda
fix(transferownership): allow searching by email, display user.shareWithDisplayNameUnique in item subline, adjust style
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2025-02-17 12:51:22 +01:00
Ferdinand Thiessen
03e15b9297
fix(files): Do not download files with openfile query flag
Instead of downloading files, if there is no other default action,
we should just open the details tab.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-13 16:00:03 +01:00
Elizabeth Danzberger
181586123b
fix(template-filler): Hide template fields with unknown labels
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2025-02-13 10:32:21 +01:00
Ferdinand Thiessen
5251b25f4e
fix(files): Correctly scroll selected file into view
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-06 00:08:47 +01:00
skjnldsv
bdc4b770ae fix(files): ensure valid mtime and fallback to crtime if defined
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-04 13:46:36 +00:00
provokateurin
8a34e0552c
fix(files): Allow opening the same file repeatedly
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-31 08:10:39 +01:00
Ferdinand Thiessen
910495de1f
fix(files): File type filter UI sync with filter state
When changing the folder the filter will be re-mounted by the file list,
so we need to pass the current state of the filter to the filter UI.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 20:25:55 +01:00
Richard Steinmetz
3efb46ca56
fix(files): sort not working after changing views
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-01-26 14:09:13 +01:00
skjnldsv
62809b5d7e fix(files): rename actions submenu back entry
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-01-22 08:23:33 +00:00
skjnldsv
71e6fbed6e fix(files): close submenu on main actions state change
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-01-22 08:23:33 +00:00
Ferdinand Thiessen
be25f51f40
fix(files): Make injected actions reactive
Provided values are not reactive by default and by design,
we must need computed to make them reactive.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-13 11:06:55 +01:00
skjnldsv
9cd52975d2 fix(files): failsafe when executing actions methods
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-12 20:32:40 +01:00
skjnldsv
0d5cda8aa4 fix(files): cancel renaming on enter if no file name changes
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-12 18:25:03 +01:00
skjnldsv
3250aeb427 fix(files): virtual scroller item size computation
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-12 12:58:16 +00:00
skjnldsv
f5f59a8414 chore(files): add selection cypress tests
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-07 23:13:57 +01:00
Louis Chemineau
592cdd9603 fix(files): Do not jump to top when fileId is set to currentFolder
Fix https://github.com/nextcloud/server/issues/48545

Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-10-29 14:38:10 +00:00
Grigorii K. Shartsev
eba431074a fix(files): add title for files list table header button
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-10-25 20:52:12 +00:00
Grigorii K. Shartsev
73d0a04241 refactor(files): migrate to @nextcloud/sharing
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-10-25 15:12:39 +02:00
Grigorii K. Shartsev
2f7eeab191 chore(files): migrate davUtils to TS
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-10-25 12:28:16 +00:00
Ferdinand Thiessen
6bf7dc1491
fix(files): Adjust NavigationQuota for Nextcloud 30 design
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-23 20:43:05 +02:00
Ferdinand Thiessen
d4685cb036 fix(files): Ensure renaming state is correctly reset
Problem: Is a node is renamed and the new name is out of the current
visible list of nodes the component will be recycled, this means
the props will change, so when the `onRename` functions is about to reset
the state the `this.source` will point to a different node.

To fix this, but also to separate business logic from visual representation,
the logic is moved into the renaming store and the component is only
responsible for rendering.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-21 13:53:08 +02:00
Ferdinand Thiessen
64cc7afb12 fix(files): Add more visual move / copy notification
* Resolves: https://github.com/nextcloud/server/issues/46645

This adds loading toast notification while the move operation is running.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-17 15:02:15 +02:00
Ferdinand Thiessen
f8bb7c8b4d
fix(files): Make openMenu watcher null safe
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-17 14:27:30 +02:00
Ferdinand Thiessen
be33321059
fix(files): Reset context menu position on close
* Resolves https://github.com/nextcloud/server/issues/46934

Ensure that after a right-click the context menu position is resetted,
so that pressing the "actions"-menu button it is displayed on the correct location.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-17 14:27:30 +02:00
Louis Chemineau
17ec9a2317 fix: Show storage full warning when storage is actually full
< 0 values for "free" do not mean that the storage is full: 6befdd6dd7/lib/public/Files/FileInfo.php (L31-L42)

Signed-off-by: Louis Chemineau <louis@chmn.me>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-09-26 08:58:26 +00:00
Louis Chemineau
ae70a426ac feat: Reset route if neither the Viewer of the Sidebar is open
When the viewer or the sidebar is opened, we add the fileid to the route.
When both of them are closed, we do not remove the fileid from the route.
This means that, upon reload, the sidebar will be opened even though it was closed previously.

This PR ensure that the fileid is removed from the route when both the Sidebar and the Viewer are closed.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-16 11:18:13 +02:00
skjnldsv
2393b855ab fix(files): undefined displayname for outdated @nextcloud/files<3.6.0 apps
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-09-05 07:23:42 +02:00
Christopher Ng
6897622546 fix(files): Fix navigating with breadcrumbs not highlighting navigation entry
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-09-03 11:44:30 -07:00
Ferdinand Thiessen
b4b93d6bcd fix(files): Node loading information should be accessible
The loading icon visually informs that the node is currently loading,
but there is no non-visual information (accessible information).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-01 11:48:05 +02:00
Louis Chemineau
edb05e6a70
fix(files): Remove margin and width to not break layout
In grid view, this was messing with the reported available list width which was breaking the computed layout.

Fix https://github.com/nextcloud/server/issues/47599

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-08-29 17:16:08 +02:00
Elizabeth Danzberger
1d9066cc68 fix: use empty template by default when pressing enter
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2024-08-29 14:16:25 +02:00
Elizabeth Danzberger
905adcaeb8 feat(templates): add support for checkboxes in template filler
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2024-08-29 05:26:58 +00:00
Ferdinand Thiessen
ceebf2df6a
fix(files): Remove huge margin on bottom
Instead make it relative to screen size.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-27 23:16:05 +02:00
Elizabeth Danzberger
c84cd0415e
fix(files): fix list gap at bottom
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-27 12:41:19 -04:00
Ferdinand Thiessen
fc64d5c838 fix(files): Reset drop notice on firefox
On firefox there is an old bug where when you move a dragged file outside
the window the `dragleave` event is never emitted.
So we just use a timeout to reset the drag over state.

Also a small change: Use the ID of the main container instead of relying on tag name and class.
(The ID is guranteed as other APIs rely on it, while the class is just used internally).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-26 19:03:42 +00:00
Ferdinand Thiessen
57bd5d06c1 fix: Access node owner by top level owner property
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-17 16:31:24 +00:00
Ferdinand Thiessen
ee4fb148b3 perf(files): Cache getContents function used for uploader
Instead of trigger a PROPFIND for every new-menu entry clicks,
or conflict handling of uploads, we can just use the cached content from the file store.
If we do not have any cache entry we fetch new, but otherwise this is not needed.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-14 09:47:56 +02:00
Ferdinand Thiessen
7fec706f68 refactor(files): Drop unneeded initial state
The initial state is no longer used, it was only used in legacy UI and in the f2v rewrite
it was only used for the `id` which can be loaded just from the URL.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-14 09:31:27 +02:00
skjnldsv
e4e12a35f5 fix(files): trim names on new node creation
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-09 11:58:37 +00:00
Christopher Ng
44bc57bc57 feat: Load limited depth tree
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-08 11:15:52 -07:00
skjnldsv
827c6fdda9 fix(files): file name and header sort buttons alignments
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-07 15:12:32 +00:00
skjnldsv
760c37b52e fix(files): show folder sharing overlay on received shares
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-02 16:52:12 +00:00
julia.kirschenheuter
ff6ba29475 fix(files): Minimize min-height of dialog form
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-02 07:10:00 +00:00