upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-29 18:11:41 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 34
78264 commits 891 branches 1201 tags 6.6 GiB
Commit graph

15077 commits

Author SHA1 Message Date
Marcel Klehr
1f0241fdfe perf(sharing): Use oc_share.{item_type, share_type} IN instead of OR equals 
to improve performance by using the db index

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2025-03-27 12:01:14 +01:00
Christoph Wurst
cf130f43d7
Merge pull request #51538 from nextcloud/backport/51380/stable30 
[stable30] fix(cardav): only show users from enabled addressBooks in contacts menu
 2025-03-26 14:54:36 +01:00
Ferdinand Thiessen
d0402dee06 fix(IFilenameValidator): correctly handle case insensitivity 
- forbidden names and forbidden base names are case **insensitive**
  so we need to check all lowercase here.
- add test that config value is also read case insensitive.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-03-24 11:46:43 +00:00
Hamza Mahjoubi
e55a375ae3 fix(cardav): only show useres from enabled addressBooks in contacts menu 
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
 2025-03-21 15:14:46 +01:00
Joas Schilling
4c2877da2f fix(auth): Allow 2FA challenges for Ephemeral sessions 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-03-18 09:16:46 +00:00
Git'Fellow
552c5e8cef fix(files): Make sure file pointer exists 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2025-03-17 16:04:47 +00:00
Ferdinand Thiessen
c0003fbd9c
fix(lookup-server): disable lookup server for non-global scale setups 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-03-11 21:52:07 +01:00
Ferdinand Thiessen
7d3047f5cb
fix(lookup-server): do not query data by default 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-03-11 21:46:55 +01:00
Robin Appelman
bcb13b1295 feat: log query for dbal exceptions 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-03-05 22:52:28 +01:00
Louis Chemineau
cc1a5e7c91 fix(login): Properly target public page with attribute 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-03-05 17:01:11 +00:00
Andy Scherzinger
7bbeae4c3c
Merge pull request #51252 from nextcloud/backport/50989/stable30 
[stable30] fix: Use case insensitive check when validating login name
 2025-03-05 17:48:25 +01:00
Louis
acf19f7880
Revert "Revert "[stable30] fix: Handle copy of folders containing live photos"" 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-03-05 13:45:23 +01:00
Marcel Müller
c6ca459b40 fix: No IFactory in constructor 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
 2025-03-05 11:34:03 +00:00
Joas Schilling
259919e9fd fix(files): Don't do session related work in the constructor of the View 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-03-05 11:34:03 +00:00
Cleopatra Enjeck M.
22fa59b378 fix: use mb_strtolower to convert login name 
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
 2025-03-05 06:20:52 +00:00
Cleopatra Enjeck M.
9dbf067f31 fix: Improve string comparison 
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
 2025-03-05 06:20:52 +00:00
Cleopatra Enjeck M.
dc68d66945 fix: Use case insensitive check when validating login name 
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
 2025-03-05 06:20:52 +00:00
Stephan Orbaugh
34bd751923
Merge pull request #51202 from nextcloud/backport/51194/stable30 
[stable30] refactor(TempManager): Simplify and unify implementations and remove legacy behavior
 2025-03-04 10:20:00 +01:00
provokateurin
194f5eae1e
fix(Share20\Manager): Propagate user and group deletion to remote share providers 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-03-04 07:58:21 +01:00
provokateurin
7b5c9feca1
fix(Share20): Convert broken hooks to IEventListener 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-03-04 07:58:21 +01:00
provokateurin
552eb2678f
refactor(TempManager): Simplify and unify implementations and remove legacy behavior 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-03-04 07:49:20 +01:00
Louis Chemineau
0c809ccc7f
fix(login): Support subfolder install for ephemeral sessions 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-03-03 11:42:43 +01:00
Louis Chemineau
a25a8f4f53
fix(login): Also check legacy annotation for ephemeral sessions 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-03-03 11:42:43 +01:00
Louis Chemineau
9141eb473f
feat: Close sessions created for login flow v2 
Sessions created during the login flow v2 should be short lived to not leave an unexpected opened session in the browser.

This commit add a property to the session object to track its origin, and will close it as soon as possible, i.e., on the first non public page request.

Signed-off-by: Louis Chemineau <louis@chmn.me>

[skip ci]

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-03-03 11:38:03 +01:00
Joas Schilling
812a4d519e
Merge pull request #51057 from nextcloud/backport/51049/stable30 
[stable30] fix(l10n): Improve english source strings
 2025-02-26 16:20:14 +01:00
Joas Schilling
a5e6f46eb0
fix(l10n): Improve english source strings 
- No leading/trailing whitespace
- Use asci single quote

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-02-26 15:06:47 +01:00
Louis Chemineau
854c3bcc62 fix: Report duplicated extra files in integrity check 
The `array_diff` is not comparing the array keys. This means that an extra key with an expected hash will not be reported. Using `array_diff_assoc` will report such files.

For example, copying `status.php` to `status 2.php`, will only be reported with the new version.

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-02-26 13:25:16 +00:00
Louis Chemineau
d3b4b21e29 fix: Initialize lastConnectionCheck after first connection 
We are checking whether the DB connection is alive once every 30 seconds. But when we are lacking the last check time, we are skipping the check and reconnect logic. This is causing the reconnect logic to never fire in those cases.

It seems to me that "those cases", are actually always the case, as upon initialization, we are not using the proper connection name to store the time.

In the `connect()` logic, when `$this->_conn` is null, `$this->getConnectionName()` is returning `replica`, so `$this->lastConnectionCheck` will be equal to `['replica' => time()];`

60711ea4cf/lib/private/DB/Connection.php (L215-L221)

60711ea4cf/lib/private/DB/Connection.php (L891-L893)

2b6d7bf65f/doctrine/dbal/src/Connections/PrimaryReadReplicaConnection.php (L136-L139)

Then, if the connection name ends up as being 'primary', the reconnect logic is skipped:

60711ea4cf/lib/private/DB/Connection.php (L874-L880)

Follow-up of https://github.com/nextcloud/server/pull/41819

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-02-25 11:07:34 +00:00
Ferdinand Thiessen
d3dbe3ab2c
refactor: convert sanitize account properties repair step to background job 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-24 16:44:49 +01:00
Ferdinand Thiessen
bb73628ebe
fix: Optimize repair step performance 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-24 16:42:45 +01:00
Ferdinand Thiessen
9fdd48dd2d
fix: validate account properties as a repair step 
Replace `ValidatePhoneNumber` from Nextcloud 21 with a new repair step,
`ValidateAccountProperties` which validates and sanitizes all account
properties.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-24 16:42:44 +01:00
Joas Schilling
0598fd74cd
Merge pull request #50900 from nextcloud/backport/50896/stable30 
[stable30] fix(cron): Keep job class limitation when searching for the next job
 2025-02-19 13:34:00 +01:00
Joas Schilling
2d1bfad11e fix(cron): Keep job class limitation when searching for the next job 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-02-19 09:27:50 +00:00
skjnldsv
137ff37cf8 fix(files): properly forward open params from short urls 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2025-02-19 10:13:55 +01:00
Andy Scherzinger
682c8e6a61
Merge pull request #50796 from nextcloud/backport/50781/stable30 
[stable30] perf(files): faster query to fetch incomplete directories
 2025-02-17 19:15:58 +01:00
Daniel
88b43178cb
Merge pull request #49481 from nextcloud/backport/49004/stable30 
[stable30] Bug/48678/restore dav error response
 2025-02-15 16:50:32 +01:00
Robin Appelman
33fb176651 fix: make locked exception path relative to the view 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-02-15 14:42:51 +01:00
Git'Fellow
4a8bea67c7 fix(repair): PHP8.3 deprecation warning 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2025-02-15 11:08:58 +00:00
Benjamin Gaussorgues
765b4921ff
perf(files): faster query to fetch incomplete directories 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2025-02-14 10:57:26 +01:00
Andy Scherzinger
7bf1126b1f
Merge pull request #49657 from nextcloud/backport/48769/stable30 
[stable30] Fix incorrect permissions when copying shared files
 2025-02-14 10:30:46 +01:00
Louis Chemineau
a663b3e0cd fix(files): Correctly copy the cache information on copy operations 
Needed to copy the `encrypted` flag of encrypted files when those files are two level down in a moved folder.

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-02-13 23:35:59 +00:00
Robin Appelman
9f1666ef3d fix: use scan_permissions when copying cache items 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-02-13 18:17:31 +01:00
Robin Appelman
5c9a3a2423 fix: store unmaked source permissions as scan_permissions when loading share cache items 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-02-13 18:17:31 +01:00
Robin Appelman
da334737e4 fix: rework move into object store to better preserve fileids 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-02-13 17:31:51 +01:00
Robin Appelman
e85d5df5f0 fix: preserve fileid when moving from objectstore to non-objectstore 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-02-13 17:31:51 +01:00
Robin Appelman
9fd7dfd1c2 fix: ensure source folder is removed from cache when moving to objectstore 
otherwise this causes confusion down the line as it's contents will be moved to the new cache

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-02-13 17:31:51 +01:00
Marcel Klehr
befca3e4b9 fix(TaskProcessing\Manager): Always use distributed cache and use PHP serialize 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2025-02-13 16:44:10 +01:00
Marcel Klehr
be1759fcdc fix(TaskProcessing\Manager): Always use distributed cache and use PHP serialize 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2025-02-13 16:44:10 +01:00
Andy Scherzinger
094ea5c885
Merge pull request #50761 from nextcloud/backport/50324/stable30 
[stable30] fix: don't use cached root info from shared cache if the watcher has detected an update
 2025-02-13 16:43:50 +01:00
Andy Scherzinger
6964531134
Merge pull request #50704 from nextcloud/backport/50660/stable30 
[stable30] fix: make sure we process mime extensions as string
 2025-02-13 16:42:50 +01:00