The condition was checking shares.length to display the Others with
access component, but shares is filled only on expanding that section,
rendering the section never visible.
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
The checkbox appears checked when no password is set (share.password ===
undefined)
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
This commits addresses an annoyance where the share input placeholder would
suggest sharing via federated cloud ID even if federation was disabled.
Signed-off-by: nfebe <fenn25.fn@gmail.com>
The variable is intialized to `{}` which is truthy, so instead just
check if there is a user assigned to the share info.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
`nextcloud-vue-collections` is deprecated for quite some time and was
merged into `@nextcloud/vue`. So lets drop that dependency.
Adjust the two files where it was used, one of them was itself never
used so just dropped that file.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
We need to save the previous state - here the password - so that if the
update fails we can revert the shown state.
This happens e.g. if you have the password policy app and try to add an
unsecure password.
To reproduce (with password policy):
1. Create new link share
2. enable password protection
3. use insecure password like `1234`
4. save share
Now you see that the update failed, but the password protection is still
enabled. This happened because `password` and `newPassword` were
misused. `password` was already set when `newPassword` was not saved so
we could not know to what we need to reset when the update failed.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
The title is already escaped by vue so special characters would result
in incorrect strings.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
When a share includes a note, ensure the note checkbox is checked and the note is
displayed when reopening the share sidebar.
Fixes: #52794.
Signed-off-by: nfebe <fenn25.fn@gmail.com>
This was missing from the Vue migration of the public share view:
- Show the note as the description of the file drop
- Show the label as the heading of the file drop if available
- Show list of uploaded files for verification
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
- Fix autoloading for new `ConfigLexicon`
- Ensure that sharing input in sharing tab respect `show-federated-shares-as-internal`:
This is important, because when federated shares are shown as internal the users should add them from the internal shares section
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Replaced multiple Array.filter() calls with a single loop to improve performance.
This avoids redundant iterations over the shares array and categorizes them more efficiently.
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
File shares can't support create or delete permissions. This change ensures those permissions are
stripped or ignored when the shared item is not a folder.
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
some leftovers where the request token is used instead of the CSP nonce.
in general this makes not much difference - but there are some cases
where those values differ.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Users asked why they should use a nickname?
"Name" covers nickname, pseudonym, username or real name.
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
If the time picker component is emitting a Date object already, then there is redundant call of `new Date(new Date())` and
therefore introduces subtle bugs, for example on chrome users could not enter expiration date with keyboard.
- Use @update:model-value instead of @change/@input for more reliable date updates
- Ensure null and invalid dates are handled correctly in onExpirationChange
- Validate date input before updating defaultExpirationDateEnabled
Resolves : https://github.com/nextcloud/server/issues/51875
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Remove some hacks from files app about the *files_sharing* status
action, in general not sure why this hack was there instead of being in
the correct app - but it broke the grid view.
So now the sharing information is also available in grid view.
Moreover the icon is fixed in size to not overflow the actions menu.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Missing piece from https://github.com/nextcloud/server/pull/50669 as we
also need to adjust the files sharing router otherwiese we can get those
exceptions.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
