Commit graph

2537 commits

Author SHA1 Message Date
Daniel Kesselberg
8b66f3518e
fix: hide guests group when searching for principals
Follow-up for https://github.com/nextcloud/server/pull/52914

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-06-17 11:19:23 +02:00
Richard Steinmetz
84c2e2a5ce
fix: enable example contact feature by default
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-06-16 11:59:34 +02:00
Richard Steinmetz
b640c161ae
fix: harmonize design of default content settings section
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-06-16 11:59:34 +02:00
Richard Steinmetz
4a6909ffef
feat: create example event when a user logs in for the first time
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-06-16 11:49:20 +02:00
Daniel Kesselberg
1ac85a3298 fix: use correct format for getlastmodified webdav property
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-06-10 13:15:31 +02:00
Hamza Mahjoubi
ed1bfe709e fix(imip): dont compare events for the reply message
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2025-06-05 12:31:13 +02:00
skjnldsv
e41e8de0e2 fix(dav): file drop nickname
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-06-05 09:09:17 +02:00
Richard Steinmetz
3b1947086c
docs(caldav): improve documentation of CalDavBackend::getCalendarsForUserCount
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-06-04 15:08:45 +02:00
Maksim Sukharev
e2265ff245 feat: link upcoming event to calendar app modal
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-06-03 09:25:11 +02:00
Thomas Citharel
9252e2689b refactor(dav): remove unused CalDAVBackend method
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2025-06-01 22:41:33 +02:00
Daniel
daa9852722
Merge pull request #52215 from nextcloud/perf/carddav/dont-query-circles
perf(carddav): don't query circle memberships
2025-06-01 19:57:13 +02:00
Richard Steinmetz
696d76f976 fix(caldav): use direct.edit route in event activities
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-06-01 14:05:36 +02:00
Robin Appelman
35930a4331
Merge pull request #53145 from nextcloud/dav-file-write-log
fix: log error when writing stream to dav file
2025-05-30 14:46:16 +02:00
Robin Appelman
b9b8db6176 fix: log error when writing stream to dav file
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-05-30 13:16:46 +02:00
Daniel Kesselberg
27d042a1bb
docs(caldav): update documentation for calendar search
Remove the documentation from the implementaitons.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-05-28 15:23:52 +02:00
Joas Schilling
9978dcfd61
fix(DAV): Check if the header is actually the expected format
Not sure how the test ever passed as it can only
throw with strict types which are not yet enabled

Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-28 09:25:47 +02:00
Daniel Kesselberg
5876653677 fix: hide guests group from principal backend
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-05-23 15:24:32 +02:00
Louis
a48bc55e2a
Merge pull request #52810 from nextcloud/artonge/feat/do_not_require_samesite_strict_cookie_on_public.php 2025-05-22 10:30:16 +02:00
Louis Chemineau
009d0c550c
fix: Move CSRF check from base to PublicAuth for public.php
This currently prevent directly accessing a ressource when clicking on a link on a third party site. Example, clicking on `https://example.com/public.php/dav/files/pqLWcA269zfzXez/?accept=zip` in a GitHub comment.

Skipping the check is an issue with password protected shares, as it allows third party sites to request the ressource when the user already entered the password, aka CSRF.  So after removing the check from `base.php`, we need to add the it again in the `PublicAuth` plugin.

We also add a redirect to be helpful to the user.

**Warning**: this adds the limitation that clicking on a direct download link for password protected shares will redirect you to the password form, and then to the main share view.

Fix #52482

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-05-21 16:01:36 +02:00
Richard Steinmetz
9a74d9a1a5
fix(caldav): don't send invitations to circles
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-05-21 13:28:57 +02:00
Christoph Wurst
80b21cdc6e
Merge pull request #52879 from nextcloud/bug/noid/clear-dav-photo-cache
Add command to clear dav's photo cache
2025-05-19 18:10:07 +02:00
Ferdinand Thiessen
e2a331f53d
Merge pull request #52890 from nextcloud/chore/move-stream-copy-implementation
chore: move streamCopy implementation from `OC_Helper` to `OCP\Files`
2025-05-17 12:01:44 +02:00
Ferdinand Thiessen
e693a5d4a5
fix(dav): correctly handle uploading folders with same name as a file
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-16 14:38:41 +02:00
Ferdinand Thiessen
3d113ab6cc
refactor(dav): use Node API instead of private files view for filedrop plugin
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-16 14:37:30 +02:00
Ferdinand Thiessen
01db539d0a
chore: move streamCopy implementation from OC_Helper to OCP\Files
The function was already there but called the legacy version.
So moved the implementation and migrated all usages of it.
Sadly the interface was slightly different so adjusted it to be
compatible with both legacy and the OCP one.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-16 13:03:05 +02:00
Richard Steinmetz
3699eed678
Merge pull request #52708 from nextcloud/fix/dav/update-rooms-resources-background-job
fix(dav): add repair step to queue job to update rooms and resources
2025-05-16 12:39:51 +02:00
Daniel Kesselberg
3d1de793b1
refactor(dav): replace IAppData with IAppDataFactory for PhotoCache
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-05-15 18:28:45 +02:00
Daniel Kesselberg
8a1ae0934e
feat: add command to clear contacts photo cache
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-05-15 17:20:57 +02:00
provokateurin
78a175fc74
refactor: Apply rector refactorings
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-14 15:29:02 +02:00
Daniel Kesselberg
023b98c44b
fix(dav): only consider user's principal for unsharing entries
Before: Find all entries in `dav_shares` with `access = 5` for the user's principal, as well as group and circle memberships.

After: Find all entries in `dav_shares` with `access = 5` solely for the user's principal.

Future support for unsharing group or circle principals could be considered as a feature enhancement.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-05-14 09:03:33 +02:00
Daniel Kesselberg
c05d3fdb2e
fix(caldav): prevent unshare entry creation for owner unsharing
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- https://github.com/nextcloud/server/pull/43117
- https://github.com/nextcloud/server/pull/47737

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-05-14 09:03:32 +02:00
John Molakvoæ (skjnldsv)
b286bca485
fix(dav): remove unnecessary plugin getHTTPMethods
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2025-05-13 16:03:20 +02:00
John Molakvoæ (skjnldsv)
4495794a0b
feat(dav): allow uploading folders to public shares
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2025-05-13 16:03:20 +02:00
Richard Steinmetz
cef60f9fd1
fix(dav): add repair step to queue job to update rooms and resources
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-05-09 17:19:43 +02:00
SebastianKrupinski
477bc4e3f1 fix: add calendar enable
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2025-05-09 09:05:21 -04:00
Daniel
1c2b4f2a41
Merge pull request #52586 from nextcloud/bugfix/noid/remove-sleep-from-throttler
fix(throttler): Always use the sleepDelayOrThrowOnMax instead of deprecated sleepDelay
2025-05-06 19:22:53 +02:00
John Molakvoæ
24c6a1ff0b
Merge pull request #52182 from nextcloud/feat/dav/public-share-chunked-upload 2025-05-06 14:25:28 +02:00
SebastianKrupinski
a2d4f8d3f1
feat: Calendar Export
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2025-05-06 11:09:33 +02:00
provokateurin
46f5b07322
feat(dav): Enable chunked upload for public shares
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-05 13:23:11 +02:00
provokateurin
a55e61d97c
feat(dav): Allow UploadHome to handle public shares
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-05 13:23:11 +02:00
provokateurin
8813df9623
refactor(dav): Pass UID from UploadHome to UploadFolder and CleanupService
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-05 13:23:11 +02:00
provokateurin
7f0953d520
refactor(dav): Replace baseuri manipulation with RootCollection for public shares
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-05 13:23:11 +02:00
provokateurin
e90e3a70fa
feat(dav): Allow share principals
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-05 13:23:10 +02:00
Richard Steinmetz
d0fcb7e638
fix(dav): move orphan cleaning logic to a chunked background job
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-05-05 12:13:09 +02:00
Joas Schilling
7964f338dc
fix(throttler): Remove the sleep from the throttler that throws
The sleep is not adding benefit when it's being aborted with 429
in other cases anyway.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-02 11:27:29 +02:00
Christoph Wurst
535253e0d2
Merge pull request #52228 from nextcloud/fix/issue-50748-calendar-object-move
fix(CalDAV): do not ignore move command object target uri
2025-04-30 16:27:48 +02:00
skjnldsv
58aaddeca5 fix(dav): check the owner displayName scope before giving attribute
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-04-30 08:37:08 +02:00
Richard Steinmetz
33a8e2226c
perf(caldav): increase chunk size in RemoveOrphanEventsAndContacts repair step
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-04-29 16:34:19 +02:00
Ferdinand Thiessen
698146c366
Merge pull request #51592 from nextcloud/fix/search-cast
fix(dav): throw invalid argument when property type does not match
2025-04-29 13:41:48 +02:00
Hamza Mahjoubi
58ffd9d06e fix: check if config is enabled before creating a default contact
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2025-04-28 11:46:32 +02:00