upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-21 14:23:17 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 15
65225 commits 874 branches 1195 tags 8.3 GiB
Commit graph

144 commits

Author SHA1 Message Date
Simon L
7acda5fab6 fix the backport 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2023-02-08 11:30:35 +01:00
Simon L
cadbccd7c7 imaginary - allow to generate heif, pdf and svg thumbnails 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2023-02-08 10:27:40 +00:00
Simon L
6d0ec357ea imaginary - add tiff to supported formats 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2023-01-25 20:15:21 +00:00
Varun Patil
2617c090d7 preview: fix HEIC orientation 
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
 2022-12-11 10:26:18 +00:00
Richard Steinmetz
8424e506c4 Fix distorted previews when using imaginary 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2022-11-11 22:02:05 +00:00
Julius Härtl
677451427e Emit typed event when preview is requested 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-10-27 13:51:28 +00:00
Julius Härtl
4baf960c21
Save getting the parent node when generating the preview 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-08-24 22:20:32 +02:00
Christopher Ng
57c66bf7cb Use Image class from public API 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2022-06-02 00:37:36 +00:00
John Molakvoæ
87ce03db1a
Merge pull request #32410 from nextcloud/bugfix/noid/imaginary-exception 2022-05-20 08:14:17 +02:00
Carl Schwan
a5a4e0df1c Fix crop condition 
Make sure that when fetching the image from the cache we don't
accidentally fetch the cropped image just because it also start with
256-256

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-19 17:25:32 +02:00
Julius Härtl
3742b7392d Add explicit return if getSmallImagePreview fails 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-05-19 17:01:01 +02:00
Carl Schwan
05bf8b4445 Fix cropped image generated when not asked 
The $crop parameter was not propagated to the imaginary pipeline and
instead it used the smartcrop algorithm always

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-17 10:19:54 +02:00
John Molakvoæ
0863a3d423
Merge pull request #32315 from nextcloud/fix/noid/preview-duplicate-folder-creation 2022-05-10 10:11:24 +02:00
Richard Steinmetz
982c846b11
Fix preview generator trying to recreate an existing folder 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2022-05-09 17:30:07 +02:00
Alexander F
00505c9a51 Set loglevel for IMagick Thumbnail error to info 
Issue #32263

Signed-off-by: Alexander Fleischer <Alexander.Fleischer@tu-ilmenau.de>
 2022-05-09 17:09:40 +02:00
Côme Chilliet
069477e608
Migrate more classes of lib/private to LoggerInterface 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-04-26 16:52:52 +02:00
John Molakvoæ
3d1f22f6d8
Generate small preview straight away if Imaginary is enabled 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2022-04-06 18:55:48 +02:00
Carl Schwan
b5c9189cfa Fix imaginary with rotated exif images 
Now do the operation in two steps:

1. Rotate the image according the exif data
2. Do the actual operation

This should only have a performance impact on image with exif rotation
data to do the rotation. For all the other images the autorotate steps
should be almost instant.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-04-04 16:38:38 +02:00
Carl Schwan
34988cff19
Merge pull request #24166 from nextcloud/imaginary-prototype 
Send images to Imaginary docker to generate previews
 2022-03-18 12:32:56 +01:00
Vincent Petry
9b6a1cc8ae
Send images to imaginary docker to generate previews 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Co-Authored-by: Vincent Petry <vincent@nextcloud.com>
 2022-03-17 08:24:07 +01:00
Côme Chilliet
13c11208d4
Ignore errors when searching for bundled preview 
When an odt file is xml and not zip, it would throw a ValueError.
It will now just ignore this file and return null for the preview.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-02-28 15:43:07 +01:00
Côme Chilliet
0daec4b27e
Fix tmp file cleaning for bundled previews 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-02-24 14:55:57 +01:00
Côme Chilliet
d43dbfa0f2
Fix typing in OC\Preview\Movie 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-02-24 14:55:48 +01:00
Côme Chilliet
ebe731f014
Fix typing in OC\Preview 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-02-24 14:42:55 +01:00
UmbrellaCodr
a0d7e27789
reduce 'Movie preview generation failed Output' log errors 
for movies under 5 seconds

Signed-off-by: UmbrellaCodr <umbrella@biohazard.cc>

Update lib/private/Preview/Movie.php

Co-authored-by: Simon L. <szaimen@e.mail.de>
 2022-02-03 17:52:37 -08:00
Carl Schwan
6312c0df69
Check style update 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-01-13 00:19:07 +01:00
Julius Härtl
6f986519fe
Merge pull request #28610 from nextcloud/enh/preview-cleanup-query 2021-12-28 13:20:02 +01:00
Côme Chilliet
3631789651
Fix resource usages in OC_Image 
This makes sure using resource or GdImage (PHP>=8) behaves the same.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2021-10-28 17:48:43 +02:00
J0WI
047cab8dd2 Use findBinaryPath for previews 
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
 2021-10-23 23:15:42 +02:00
Vincent Petry
24e0255378
Fall back to full file for video previews 
If the first 5 MB are not enough to grab a useful frame for the
thumbnail preview, fall back to reading the full file.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-09-18 10:53:00 +02:00
Julius Härtl
0670118470
Use storage filter when fetching previews to cleanup 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-08-26 22:03:05 +02:00
John Molakvoæ (skjnldsv)
40c10ab145
Properly log errors in Movie previews generation 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-08-19 09:47:12 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-06-04 22:02:41 +02:00
J0WI
74a7c2eefc Use correct getSystemValue type 
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
 2021-04-12 22:54:50 +02:00
dependabot-preview[bot]
eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0 
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-02-18 13:31:24 +01:00
Roeland Jago Douma
4d7c4b3d2f Markdown: remove redundant int cast 
For #25641

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-02-15 10:29:54 +01:00
Roeland Jago Douma
cc554890c1 Fix WebP availability check 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-02-11 11:31:38 +01:00
John Molakvoæ (skjnldsv)
d47b84be67
Add SGI and TGA preview support 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-01-22 10:42:51 +01:00
Morris Jobke
01f013661a
Fix typo in comment 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2021-01-20 15:02:32 +01:00
Julius Härtl
aed1fde6fd
Enhance markdown file preview rendering 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-01-20 11:07:55 +01:00
Roeland Jago Douma
6d4afca7ac Add support for webp 
Including handling in OC_Image
But also a preview provider

Of course only works if your php actually supports webp

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-01-19 20:17:10 +01:00
Morris Jobke
24d436cb60
Remove unneeded casts that were found by Psalm 
In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see https://github.com/nextcloud/server/pull/24521)

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2021-01-11 13:14:41 +01:00
Christoph Wurst
9ce3ea3368
Update license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-12-30 14:07:05 +01:00
Roeland Jago Douma
adc4f1a811
Merge pull request #22916 from J0WI/unifiy-links-to-php.net 
Unify links to php.net
 2020-12-22 09:53:31 +01:00
Christoph Wurst
d9015a8c94
Format code to a single space around binary operators 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-10-05 20:25:24 +02:00
J0WI
68ce17e59b Unify links to php.net 
Update all links to https://www.php.net/

Signed-off-by: J0WI <J0WI@users.noreply.github.com>
 2020-09-17 17:40:04 +02:00
Christoph Wurst
2a054e6c04
Update the license headers for Nextcloud 20 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-08-24 14:54:25 +02:00
Scott Dutton
b12a390220
Always try and show pre rendered preview 
Currently if the following situation happens

Server generates preview
Server has command removed which allows a preview to be shown
Client asks for preview, gets a 404 error when preview exists
(Mime checked before preview)

This happens more often with documents, or video as the commands are not
native PHP, they require a binary on the server.

After the fix the following would happen

Server generates preview
Server has command removed which allows a preview to be shown
Client asks for preview, gets preview which has been generated
(Mime checked after preview)

This would also allow offline generation (for example a docker image
containing the extra binaries), allowing a reduction in attack surface
of the instance serving the preview data.

Signed-off-by: Scott Dutton <scott@exussum.co.uk>
 2020-08-13 22:50:38 +02:00
Morris Jobke
408ed7ebd4
Merge pull request #22139 from nextcloud/fix/noid/check-for-preview-multibucket-fallback-as-second-step 
Check previews in multibucket fallback folder as the last step and not as first step
 2020-08-07 16:02:02 +02:00
Morris Jobke
06eb230d24
Merge pull request #22135 from nextcloud/enh/noid/occ-preview-repair 
Add occ preview:migrate to migrate previews from the old flat structure to a subfolder structure
 2020-08-07 11:09:16 +02:00