Commit graph

14914 commits

Author SHA1 Message Date
Julius Knorr
643e9ffb06 fix: Allow overriding shouldApplyQuota check from child classes
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2024-10-28 09:46:45 +01:00
Julien Veyssier
70db4f51db feat(textprocessing): factorize taskProcessingCompatibleTaskTypes
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-10-24 10:53:43 +00:00
Julien Veyssier
67437d0325 fix(textprocessing): also list types that are available in task processing
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-10-24 10:53:43 +00:00
Joas Schilling
c6f0a422b0 fix(logger): Remove more parameters of other methods
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-21 16:52:48 +00:00
Joas Schilling
97dc0aae75
Merge pull request #48763 from nextcloud/dependabot/composer/stable30/symfony-6.4
[stable30] build: Bump symfony/* to 6.4
2024-10-21 12:13:56 +02:00
Joas Schilling
fd73366def
fix(command): Make method compatible with upstream class (requires 3rdparty bump)
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-21 11:28:52 +02:00
Joas Schilling
dbb669d03d
fix(command): Make method compatible with upstream class (backportable)
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-21 11:28:51 +02:00
Kate
9e28a1e0c7
Merge pull request #48710 from nextcloud/backport/48682/stable30 2024-10-21 10:16:05 +02:00
Joas Schilling
570428e4e6 fix(comments): Document supported types and provide psalm typing
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-18 06:21:01 +00:00
Joas Schilling
bd30a7ac21 feat(comments): Support mentioning emails
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-18 06:21:01 +00:00
Ferdinand Thiessen
761f7e1f70
Merge pull request #48703 from nextcloud/backport/48673/stable30
[stable30] fix(share): Return empty string if no label is set
2024-10-17 18:25:16 +02:00
provokateurin
091428f21f fix(AppConfig): Add external JWT private key to sensitive keys
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-15 08:43:29 +00:00
Ferdinand Thiessen
dfe8f642cd fix(share): Return empty string if no label is set
* Resolves: https://github.com/nextcloud/server/issues/48629

While the database supports NULL, the typing has always said it only returns *string*.
So to not break any apps that might trust the typings we should return `''` if the database is set to `NULL`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-14 17:11:16 +00:00
Ferdinand Thiessen
198c2d3d68
fix: Skip users that still exist in backend
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-08 21:02:20 +02:00
Ferdinand Thiessen
7dd85e15b9
fix: Make user removal more resilient
Currently there is a problem if an exception is thrown in `User::delete`,
because at that point the user is already removed from the backend,
but not all data is deleted.

There is no way to recover from this state, as the user is gone no information is available anymore.
This means the data is still available on the server but can not removed by any API anymore.

The solution here is to first set a flag and backup the user home,
this can be used to recover failed user deletions in a way the delete can be re-tried.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-08 21:02:07 +02:00
Stephan Orbaugh
631ceaf6b0
Merge pull request #48558 from nextcloud/backport/48522/stable30
[stable30] fix(QueryBuilder): Account for aliases in output columns
2024-10-08 11:13:35 +02:00
Joas Schilling
3956088049 fix(config): Mark more app configs sensitive
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-07 09:00:48 +00:00
provokateurin
aab30afc25 fix(QueryBuilder): Account for aliases in output columns
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-03 13:49:00 +00:00
Marcel Klehr
685fe09f09
Merge pull request #48514 from nextcloud/backport/48513/stable30
[stable30] fix(TaskProcessing\Manager): Don't provoke PHP notice in setTaskResult
2024-10-02 11:59:02 +02:00
Benjamin Gaussorgues
8290de3b93
Merge pull request #48077 from nextcloud/backport/47852/stable30 2024-10-02 10:43:41 +02:00
Kate
a13cc43d04
Merge pull request #48093 from nextcloud/backport/47316/stable30 2024-10-02 10:10:06 +02:00
Marcel Klehr
ab8078a430 fix(TaskProcessing\Manager): Don't provoke PHP notice in setTaskResult
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-10-02 07:57:16 +00:00
Ferdinand Thiessen
7ca6e45c7a fix(theming): Use AppConfig for setting background image
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-02 09:21:57 +02:00
Vincent FarZz
b146952b63 fix: Prevent crash when refreshing metadata for files without an owner
This crash was mostly happening when using external storages and for example the command "occ memories:migrate-google-takeout"

Signed-off-by: Vincent FarZz <farcry69@live.fr>
2024-10-02 09:21:44 +02:00
Josh
95f1a7b0be
Merge pull request #48503 from nextcloud/backport/48426/stable30
[stable30] fix(config): Suppress `config.php` fopen error at install time
2024-10-01 14:10:12 -04:00
Josh
60872a1c4c fix(config): Suppress error at install time
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-10-01 16:24:11 +00:00
Arthur Schiwon
f794ad0888 fix(Auth): ignore missing token when trying to set password-unconfirmable
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-10-01 13:48:57 +00:00
Kate
6949e21c09
Merge pull request #48317 from nextcloud/backport/48307/stable30 2024-09-30 10:24:20 +02:00
Richard Steinmetz
c4ffd84439
fix: gracefully parse non-standard trusted certificates
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-09-30 09:11:42 +02:00
provokateurin
bbeda126cc fix(QueryBuilder): Restrict identifier length to 30 characters due to Oracle limitations
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-26 13:16:02 +00:00
ernolf
0551919bce
fix(share): Ensure unique share tokens
- check for token collisions and retry up to three times.
- throw after 3 attempts without finding a unique token.

Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>
2024-09-25 09:39:51 +02:00
Joas Schilling
abe82432cb
fix(querybuilder): Fix boolean type so that oracle handles boolean well
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-25 08:40:53 +02:00
Grigorii K. Shartsev
8b56189f65
Merge pull request #48127 from nextcloud/backport/48114/stable30
[stable30] fix(appstoreFetcher): get list from a custom store and remove unnecessary warning
2024-09-24 00:10:22 +05:00
Andy Scherzinger
6044c9f512
Merge pull request #48285 from nextcloud/backport/48207/stable30
[stable30] fix: Don't crash if disabled user is missing in the database
2024-09-23 21:07:08 +02:00
Louis Chemineau
9a34a6c4c4
fix(users): Don't crash if disabled user is missing in the database
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-23 18:06:38 +02:00
Daniel Kesselberg
d80be49ed7 fix: skip the integrity check for nextcloud-init-sync.lock
nextcloud-init-sync.lock is used by nextcloud/docker to prevent running the initialization script on multiple containers at the same time.

Ref: https://github.com/nextcloud/docker/issues/2299.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-09-23 15:51:42 +00:00
Kate
61f3a09dcd
Merge pull request #48233 from nextcloud/backport/48222/stable30 2024-09-20 23:02:25 +02:00
Kate
ae7241f6c8
Merge pull request #48221 from nextcloud/backport/30/fix_move_on_same_bucket 2024-09-20 10:06:14 +02:00
Robin Appelman
e8c8ab58f7 perf: reuse cache info we already have when moving to object store
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-20 07:50:23 +00:00
Christoph Fiehe
82be489f53 perf(ObjectStoreStorage): Improve (slow) move on same object bucket
This commit fixes the issue #47856. When you upload a file into a group folder and when you use a single S3 bucket as primary storage, the final move operation hangs for a long time. In the background, Nextcloud initiates a copy-delete sequence from the bucket into the bucket, with causes a lot unnecessary overhead. Nextcloud thinks that the file must be imported to another storage and does not recognize that everything is done on the same object bucket. In that case, the import step can be completely skipped, which saves time, network bandwidth and reduces the load on the object storage.

The behavior improves a lot with https://github.com/nextcloud/server/pull/46013. However, there are still some put messages that are being sent to the object storage when you use an object storage as primary storage and upload files into a group folder.

Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>
2024-09-19 18:53:36 +02:00
Robin Appelman
dd68f678b2 fix: ensure parent folder exists when writing a file to object storage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-19 13:59:08 +02:00
Robin Appelman
7b1b5526b7 fix: verify that parent exists in cache when inserting
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-19 13:59:08 +02:00
Robin Appelman
1e03bd5d18 fix: fix object store id for test object store
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-19 13:59:08 +02:00
Robin Appelman
e8c7216d5b fix: cleanup objectstore file_put_content
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-19 13:59:08 +02:00
Robin Appelman
9b07b7d9c1 fix: create intermediate directories for objectstore moveFromStorage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-19 13:59:08 +02:00
Robin Appelman
5bcd74ae87 fix: get source file before moving the cache item in objectstore moveFromStorage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-19 13:59:08 +02:00
Ferdinand Thiessen
77321bc6cf
Merge pull request #47944 from nextcloud/backport/47883/stable30
[stable30] fix(setup-checks): Ensure URL with webroot works
2024-09-19 00:19:19 +02:00
Grigorii K. Shartsev
3ee3542bdf fix(appstoreFetcher): get app list from custom app store
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-09-17 09:23:02 +00:00
Grigorii K. Shartsev
9da1675c9e fix(appstoreFetcher): remove unneeded warning
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-09-17 09:23:02 +00:00
John Molakvoæ
2308294a68 chore: improve hash_file php usage in Local Storage
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-09-16 17:08:10 +00:00