Commit graph

826 commits

Author SHA1 Message Date
John Molakvoæ (skjnldsv)
1dcee8a8ae fix(files): verify files are still accessible before downloading
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2025-08-29 07:26:05 +00:00
skjnldsv
a531cfe3e1 fix(files): filter non batch actions in header
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-08-22 21:54:24 +02:00
skjnldsv
71b618dfbc fix(files): drop usage of FileInfoModel
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-08-18 08:16:35 +00:00
Daniel Kesselberg
37619d63f9 feat(search): show alias when searching in root folder
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-07-30 06:04:38 +00:00
Côme Chilliet
5f641113ab
chore: Adapt cypress component test to contain total space
Mocked server initial state was incomplete

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-29 09:51:12 +02:00
Côme Chilliet
aaccfc27ee
fix: Correctly show free space if lower than quota in Files navigation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-29 09:51:04 +02:00
skjnldsv
a2eac7f757 fix(files): sort favorites navigation alphabetically
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-07-23 13:28:40 +00:00
John Molakvoæ
f6a336b3c5
Merge pull request #54039 from nextcloud/backport/53983/stable31
[stable31] fix(files): new folder icon color
2025-07-22 23:41:38 +02:00
Ferdinand Thiessen
e82a9f389d
refactor(files): remove custom page title handling
This conflicts with what `NcAppContent` is already doing.
So we should just remove it.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-07-22 13:47:23 +02:00
skjnldsv
2320432aeb fix(files): new folder icon color
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-07-22 10:37:08 +00:00
Ferdinand Thiessen
ec263a328a
test: adjust test code for updated @nextcloud/vue version
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-07-14 22:29:03 +02:00
Hamza
bb48b4b5ae fix: adapt rename action tests to check for parent permissions
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
2025-07-11 17:24:15 +02:00
skjnldsv
ce15c53c69 fix(files): allow renaming if parent allow creating
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-07-11 14:41:47 +00:00
Hamza
e167dc1dd7 fix: hide rename action is trashbin
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
2025-07-11 14:41:47 +00:00
skjnldsv
c9db4b9224 fix(files): ensure proper headers lifecycle
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-07-09 15:36:56 +02:00
Maksim Sukharev
725eda1a53 fix(files): provide boundaries for FileListTableHeaderActions element
- default boundaries element is 'content-vue', which includes sidebar

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-07-03 10:09:19 +00:00
Caitlin Jordan
23fb8ed7d0
fix(files): correctly handle plural translation forms
Co-authored-by: Caitlin Jordan <jordan.cait17@gmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-06-30 12:30:22 +02:00
Ferdinand Thiessen
4cbf85494c
fix(files): add plural form for selected nodes
Reported at Transifex:
> This string needs pluralization feature, because in some languages translation of "selected" differs between singular and plural.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-06-20 11:00:02 +02:00
Julien Veyssier
5751b82715
fix(files): use the correct theming instance name from capabilities to set the page title
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2025-06-18 12:51:37 +02:00
Elizabeth Danzberger
312464860a fix: do not extract fields for blank template
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>

[skip ci]
2025-06-17 19:57:34 +02:00
skjnldsv
b8591e6b82 fix(files): highlight previous folder on history up
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-06-04 06:37:14 +00:00
Ferdinand Thiessen
7178bb7064 fix(files): do nothing if view local dialog was just closed
We try to open a file in the Nextcloud client.
If this fails a dialog is shown with 3 options:

1. Retry: If it fails no further dialog is shown.
2. Open online: The viewer is used to open the file.
3. Close the dialog and nothing happens (abort).

This correctly implements 3 and also adds some comments + order file in
reading order (using `function` instead of arrow functions allows this
easily).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-06-01 15:42:27 +02:00
Ferdinand Thiessen
dad5132594 test: adjust unit tests for updated library
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-31 20:05:39 +02:00
Ferdinand Thiessen
8bb41fb708
Merge pull request #52819 from nextcloud/backport/52809/stable31
[stable31] fix(files): do not even try to fetch a preview if `has-preview` is false
2025-05-27 07:58:53 +02:00
John Molakvoæ (skjnldsv)
4ed1050ccf fix(files): do not even try to fetch a preview if èhas-preview` is false
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2025-05-26 18:57:33 +02:00
Elizabeth Danzberger
52ae766a8e feat: only load template fields when requested
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2025-05-26 18:03:24 +02:00
Ferdinand Thiessen
f699595748
fix(files): make sure to always have proper plural forms
counted words should always be translated using `n`.
We can still simply concat the segments with punctation, this always
works regardless of the language used (even with RTL / LTR languages).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-22 13:01:50 +02:00
Ferdinand Thiessen
2bb2bbcae4
fix(files_sharing): Disable folder upload on file drop shares for now
The backend does not allow creating folders currently, so we have to
disable it for now.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-17 12:04:36 +02:00
skjnldsv
12334c162a fix(files): middle click & ctrl new tab
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-05-15 21:49:29 +02:00
Louis Chemineau
5a71a3b1a7 fix: Forward attributes to the sidebar
Needed for Photos' sidebar tab

Signed-off-by: Louis Chemineau <louis@chmn.me>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2025-04-30 18:52:44 +00:00
Ferdinand Thiessen
73bcc0a739 refactor(files): use new hide-download WebDAV property for download action
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-27 14:26:16 +02:00
John Molakvoæ (skjnldsv)
532f8948d1 fix(files): prevent dragging preview when drag-drop
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2025-04-22 18:08:38 +00:00
Ferdinand Thiessen
c6ebf1c7cb fix(files): Ensure actions never overflow filename
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2025-04-03 08:23:58 +00:00
skjnldsv
f069e12dfa fix(files): right click actions menu flicker
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-04-02 14:38:21 +00:00
Fabian Zwemke
7b429c8a44 fix(files): Properly encode URLs when preparing ZIP download
Signed-off-by: Fabian Zwemke <fabian@zwemke.de>
2025-03-27 11:05:36 +00:00
Ferdinand Thiessen
046e4b2d59
test: fix CI when running Karma tests
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-20 15:41:58 +01:00
Ferdinand Thiessen
e9c242e2a2
fix(files): also show file list headers on empty views
It is needed, e.g. for the note-to-recipient, that the headers
are also shown when there is no content (yet).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-20 15:37:43 +01:00
Ferdinand Thiessen
b07ef78fa2 fix(files_sharing): ensure share status action works also in grid view
Remove some hacks from files app about the *files_sharing* status
action, in general not sure why this hack was there instead of being in
the correct app - but it broke the grid view.

So now the sharing information is also available in grid view.

Moreover the icon is fixed in size to not overflow the actions menu.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-19 22:49:05 +01:00
Ferdinand Thiessen
5eff90005e
fix(files): also enable delete action if trashbin is disabled
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-13 21:30:43 +01:00
Ferdinand Thiessen
a9bea3b944
fix(files_sharing): ensure downloaded file has the correct filename
Single file shares use the share token as source name, so we need to use
the displayname. To do so we need to set the download attribute to the
displayname of the file to download.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-05 09:32:41 +01:00
Ferdinand Thiessen
3ac9a316bb
feat(files): allow to ignore warning to change file type
* Missing pieces of https://github.com/nextcloud/server/issues/46528
  * Add checkbox to not show this dialog again
  * Add user config as suggested by designers in files settings to
    reenable or diable this behavior.
  * Fix behavior of dialog: It says "keep .ext" but it does not keep the
    extension but cancels the operation. From the button label the user
    expects that the operation is continued but with the old extension.
  * Added more test coverage by adding component tests.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-04 21:12:42 +01:00
Ferdinand Thiessen
9458225989
fix(files_trashbin): disable bulk download for trashbin
The backend does not allow bulk download within the trashbin,
so we need to disable this also on the frontend.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-03 18:20:32 +01:00
Ferdinand Thiessen
18c3cc14bd
refactor: use eventbus for updated filters
prevent filters not applied if `filtersChanged` was set before file list
mounted.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-03 14:20:54 +01:00
Ferdinand Thiessen
a3f663a2ff
fix(files): Ensure the filter instance is mounted
`reset` could be called before the filters are mounted,
in this case it is valid to update the presets, but we must not try to
access the vue instance (as it does not exist yet).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-03 14:20:54 +01:00
Valdnet
26d3a8f48f
fix(l10n): use do not instead of don't
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2025-03-02 12:43:38 +01:00
Joas Schilling
25268f2fdf
Merge pull request #51058 from nextcloud/backport/51049/stable31
[stable31] fix(l10n): Improve english source strings
2025-02-27 16:51:47 +01:00
Varun Patil
752bc004ae fix(files): exception when share-attributes is undefined
Signed-off-by: Varun Patil <varunpatil@ucla.edu>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2025-02-27 12:21:16 +00:00
Joas Schilling
1a60bca362 fix(l10n): Improve english source strings
- No leading/trailing whitespace
- Use asci single quote

Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-02-26 13:08:49 +00:00
Valdnet
fc0b59bb8f fix(l10n): Spelling standardization
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2025-02-25 17:42:13 +00:00
skjnldsv
2131496291 fix(files): do not show extension warning for folders renaming
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-19 15:36:13 +00:00