Commit graph

32593 commits

Author SHA1 Message Date
Anna Larch
9479ac8376 fix(dav): cast parameters to string
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-15 18:47:59 +02:00
Côme Chilliet
317c4ba50a
fix(user_ldap): Use %n in plural translation to avoid a crash in L10N
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-15 18:38:12 +02:00
Louis Chemineau
699ce26e42
fix: Restore missing dot in FilesListVirtual.vue
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-15 11:09:37 +02:00
Nextcloud bot
353cb1f866
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-15 00:26:39 +00:00
Louis
3c9111e4f8
Merge pull request #47920 from nextcloud/artonge/feat/reset_route_when_sidebar_and_viewer_are_close
feat: Reset route if neither the Viewer of the Sidebar is open
2024-09-14 23:49:47 +02:00
Louis Chemineau
2da1c5717e
feat: Reset route if neither the Viewer of the Sidebar is open
When the viewer or the sidebar is opened, we add the fileid to the route.
When both of them are closed, we do not remove the fileid from the route.
This means that, upon reload, the sidebar will be opened even though it was closed previously.

This PR ensure that the fileid is removed from the route when both the Sidebar and the Viewer are closed.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-14 21:50:23 +02:00
John Molakvoæ
6a6910f7d4
Merge pull request #47928 from nextcloud/bugfix/noid/update-opendyslexic 2024-09-14 21:19:19 +02:00
Git'Fellow
07a6fd11d0
fix(files_external): Check key exists before accessing it
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-09-14 11:21:17 +02:00
Nextcloud bot
26aa322e44
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-14 00:21:21 +00:00
Côme Chilliet
bcb4e781a4
Merge pull request #47927 from nextcloud/fix/migrate-away-from-oc_app
Migrate away from OC_App to IAppManager
2024-09-13 17:44:38 +02:00
John Molakvoæ (skjnldsv)
0f519f4856 fix(files_external): broken credentials dialog
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-09-13 14:32:07 +00:00
Côme Chilliet
dfa994ef28
Merge pull request #47865 from nextcloud/admin_audit/enh/move-to-event-listeners-v2
Move admin_audit to proper event listeners v2
2024-09-13 16:21:44 +02:00
Ferdinand Thiessen
be1cd7a308
refactor(settings): CheckServerResponseTrait always expect absolute path
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-13 13:09:40 +02:00
Ferdinand Thiessen
9e979d42b4
fix(setup-checks): Ensure URL with webroot works
We basically mock the way `URLGenerator::getAbsoluteURL` works,
so we must make sure that the URL might already contain the webroot.
Because `baseURL` and `cliURL` also contain the webroot we need to remove
the webroot from the URL first.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-13 13:06:24 +02:00
Côme Chilliet
7ed583cb8e
chore: Migrate cleanAppId and getAppPath calls to IAppManager from OC_App
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-13 10:08:43 +02:00
Nextcloud bot
c9e4598360
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-13 00:20:46 +00:00
Joas Schilling
0c224393f5
fix(tests): Test OTF font file
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-12 23:04:16 +02:00
Joas Schilling
599a94fc9a
fix(a11y): Update OpenDyslexic from 0.920 to 2.001
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-12 16:53:13 +02:00
Josh
2480567005
Merge pull request #47526 from nextcloud/jtr/fix-ftp-custom-port-ui
fix(files_external): Handling in FTP UI for custom ports
2024-09-12 09:34:47 -04:00
Josh
56c744d263
Merge pull request #47527 from nextcloud/fix-sftp-custom-port-ui
fix(files_external): Handling in SFTP UI for custom ports
2024-09-12 09:34:32 -04:00
Arthur Schiwon
c8fc2e8a67
fix(LDAP): check index before accessing it
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-09-12 11:18:18 +02:00
Nextcloud bot
ecdc144d1d
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-12 00:20:20 +00:00
Ferdinand Thiessen
5fc514877b
Merge pull request #47586 from nextcloud/fix/color
fix(theming): Add migration to restore primary color after separating primary and background
2024-09-11 15:10:09 +02:00
Ferdinand Thiessen
7a345f68dc fix(files): Make openMenu watcher null safe
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-11 13:44:12 +02:00
John Molakvoæ
2b5dd11d97
Merge pull request #47339 from nextcloud/fix/leave-share-instead-of-delete
fix: Display 'Leave share' instead of 'Delete'
2024-09-11 13:42:15 +02:00
skjnldsv
bb37954abb fix(files_sharing): adjust permissions from custom edit and delete check methods
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-09-11 13:17:42 +02:00
Pytal
897c341c5d
Merge pull request #47881 from nextcloud/fix/new-group-icon
fix(settings): Add back create group icon
2024-09-11 02:19:39 -07:00
Nextcloud bot
4bc8ba5b22
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-11 00:21:11 +00:00
Christopher Ng
e6b57e076d fix(settings): Add back create group icon
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-09-10 14:11:51 -07:00
Ferdinand Thiessen
9dbf88816c
Merge pull request #47848 from nextcloud/fix/files-context-menu
fix(files): Reset context menu position on close
2024-09-10 18:13:13 +02:00
Ferdinand Thiessen
531862d474
fix: Use migration instead of repair step for restoring custom color
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-10 17:51:27 +02:00
Ferdinand Thiessen
c7d9068be9
chore: Use IAppConfig instead of IConfig->getAppValue
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-10 17:51:26 +02:00
Ferdinand Thiessen
ee1585d809
fix: Add repair step to restore primary color after separating primary and background
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-10 17:49:36 +02:00
Ferdinand Thiessen
4efd39ec23
fix(theming): Allow to specify a userId manually in BackgroundService
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-10 17:49:35 +02:00
provokateurin
f7246a9b7a
fix(INotification): Restrict rich object parameters type
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-10 16:37:42 +02:00
Côme Chilliet
957ac81a56
fix(admin_audit): Remove now unused methods and classes
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-10 14:48:15 +02:00
Côme Chilliet
ec37338d73
chore(admin_audit): Fix License headers on new files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-10 14:06:22 +02:00
Thomas Citharel
f532d3b286
feat(admin_audit): Move admin_audit hooks to modern event listeners
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2024-09-10 14:06:12 +02:00
Carl Schwan
986a3d45f8
feat(user_ldap): Introduce user id assigned typed events for LDAP usage
Based on work from https://github.com/nextcloud/server/pull/32019

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2024-09-10 14:06:11 +02:00
Ferdinand Thiessen
49c2d1819e
fix(files): Reset context menu position on close
* Resolves https://github.com/nextcloud/server/issues/46934

Ensure that after a right-click the context menu position is resetted,
so that pressing the "actions"-menu button it is displayed on the correct location.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-10 13:19:25 +02:00
Pytal
d4313c2b89
Merge pull request #47294 from nextcloud/fix/natural-order-tree
fix(files): Sort tree views correctly by natural order
2024-09-10 01:00:31 -07:00
Richard Steinmetz
5afe212103
Merge pull request #47737 from nextcloud/fix/also-allow-unsharing-for-circles
fix(caldav, carddav): also allow unsharing of circle shares
2024-09-10 07:42:17 +02:00
Nextcloud bot
a51c200cab
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-10 00:37:30 +00:00
Christopher Ng
060783c4f4 fix(files): Render folders in natural sort order
- Nodes are returned from the endpoint in an undefined order

Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-09-09 16:11:43 -07:00
Christopher Ng
6b079e67a2 fix(files): Sort tree views correctly by natural order
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-09-09 16:11:43 -07:00
Andy Scherzinger
8ea42224ec
Merge pull request #47845 from nextcloud/feat/webhook_listeners-remove-all-from-appid
Add an endpoint to remove all webhook registrations from an app
2024-09-09 20:39:56 +02:00
Kate
3a85997940
Merge pull request #47523 from nextcloud/fix/theming/custom-apps-order 2024-09-09 18:04:41 +02:00
Jonas
0e4438fc04
Merge pull request #47841 from nextcloud/fix/files-sharing-openfile
fix(files_sharing): Open single-file-share by default
2024-09-09 16:44:15 +02:00
Grigorii K. Shartsev
4e68e88f2c
Merge pull request #47807 from nextcloud/fix/files_sharing--password-label
fix(files_sharing): password checkbox and labels in link share
2024-09-09 19:41:46 +05:00
Ferdinand Thiessen
80e4319a2c
Merge pull request #47803 from nextcloud/chore/add-migration-attribute
chore(files_sharing): Add migration attribute for `share.reminder_sent` column
2024-09-09 16:21:42 +02:00
Grigorii K. Shartsev
9348c1efba fix(files_sharing): add accessible labels in link share creation
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-09-09 14:58:30 +02:00
Grigorii K. Shartsev
2fea735418 fix(files_sharing): checkbox for password in link share is not shown
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-09-09 14:58:30 +02:00
Côme Chilliet
22a2893add
chore(webhook_listeners): Update openapi.json
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-09 14:50:52 +02:00
Ferdinand Thiessen
fccb132e2b fix(files_sharing): Open single-file-share by default
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-09 14:49:21 +02:00
Côme Chilliet
4459af41c9
feat(webhook_listeners): Add API endpoint to remove all registrations from an AppAPI app
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-09 14:41:20 +02:00
Côme Chilliet
4fc8aa5a06
feat(webhook_listeners): Add mapper method to remove all registrations from a given AppAPI id
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-09 14:39:41 +02:00
provokateurin
d5e98cd190
fix(NavigationManager): Skip invalid default navigation entries
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 11:04:36 +02:00
provokateurin
0a3093d05d
fix(theming): Use NavigationManager to handle default entries
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 11:04:36 +02:00
provokateurin
b0baaaed9d
feat(NavigationManager): Add default entries handling
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 11:04:36 +02:00
rakekniven
e6bfd8f213 fix: Update AdminAI.vue
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2024-09-09 09:53:39 +02:00
rakekniven
784fc4aa3f chore(i18n): adapted lowercase
Reported at Transifex

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2024-09-09 09:50:59 +02:00
Nextcloud bot
a2cfcf3ca7
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-09 00:23:27 +00:00
Nextcloud bot
926bd29617
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-08 00:36:35 +00:00
Ferdinand Thiessen
46472d3f4c
Merge pull request #43281 from nextcloud/feature/minSupportDesktopVerMsg
enh: update desktop client unsupported version (403) error message
2024-09-07 16:24:27 +02:00
Ferdinand Thiessen
fb28ba1b64
Merge pull request #47806 from nextcloud/chore/cleanup-public-share
chore(files_sharing): Do not use files source files but directly the library
2024-09-07 13:56:14 +02:00
Nextcloud bot
7a6191ebb9
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-07 00:36:58 +00:00
Ferdinand Thiessen
5fc715a9e2
fix: Adjust unit tests and protect against XSS
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 17:16:10 +02:00
Camila
0a72756d96
fix(dav): Update 403 error message
* The user should get a more friendly warning when their desktop client version is not supported anymore by the server.
  See #nextcloud/desktop/issues/6273
* Update BlockLegacyClientPluginTest to reflect the new 403 error message.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 17:15:45 +02:00
Ferdinand Thiessen
f06fdb04a3
chore(files_sharing): Do not use files source files but directly the library
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 16:53:42 +02:00
Ferdinand Thiessen
1ea902a195
chore(files_sharing): Add migration attribute for share.reminder_sent column
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 14:46:33 +02:00
Ferdinand Thiessen
b7e2d5032f
fix(files): Fallback icons should fill the container
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 14:08:51 +02:00
Marcel Klehr
c43353d6e6 fix: Display 'Leave share' instead of 'Delete'
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-09-06 13:50:52 +02:00
Ferdinand Thiessen
4a90d5328c
test: Add end-to-end tests for new public share Vue UI
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:48 +02:00
Ferdinand Thiessen
be884eeaec
fix(files): "Edit locally" action should not be shown on public shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:48 +02:00
Ferdinand Thiessen
018af2a2fe
fix(files): Do not add click listener if there is no default action on public shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:48 +02:00
Ferdinand Thiessen
cb4c569486
fix(files_sharing): Ensure sidebar share entry lists are labelled
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:48 +02:00
Ferdinand Thiessen
c9dc0afcb1
fix(files): "New folder" menu entry requires read permission
This will disable "New folder" menu entry for file-drop shares.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:48 +02:00
Ferdinand Thiessen
11fdf4e2a7
chore(files_sharing): Remove now unused legacy scripts
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
80033bde88
fix(files): Disable internal views on public shares
This is needed because some views have side effects, like `favorites` doing requests on registration time.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
1dafdce3e7
fix(files_sharing): Set file-request header for nextcloud/upload
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
3134053497
fix(files_sharing): Disable sharing status action for public shares
This is disabled to not leak personal information into the public

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
1d16bc47ff
fix(files_sharing): Handle download permission the same way for public and internal shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
e93ceea804
fix(files): Do not allow copy action on public shares without create permission
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
a84de3c755
feat(files): Allow to download files on public shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
ada6a61688
fix(files): Do not allow rename action on single-file-shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
563f8e7c5d
refactor(files_sharing): Make file structure more clear
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
f0a765ee46
fix(files): Disable copy-move-action of single file shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
f109c1a044
refactor(files): Make RouterService provide a protected getter for the router to allow injecting the files_sharing router
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
82a7a3971d
fix(files): Adjust files list for sharing permissions on public shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
819f5cea9b
fix(files): Fix file previews for public shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
767e87a466
fix(files): Do not use favorite, sidebar and view-in-folder action for public shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
96c8275586
feat(files_sharing): Migrate public share to use Vue files list
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:42 +02:00
Nextcloud bot
e4fa996701
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-06 00:25:10 +00:00
Ferdinand Thiessen
ede38709b5
chore(files): Use public API where possible
This is not fixing all issues in the helper,
but at least where possible use the public methods.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-05 23:00:27 +02:00
Anna Larch
17ef20c5f3 fix(dav): also allow unsharing of circle shares
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-05 21:34:20 +02:00
Anna Larch
8af7ecb257 chore: adjust code to adhere to coding standard
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-05 21:23:38 +02:00
Louis
4566cf791d
Merge pull request #47770 from nextcloud/artonge/fix/always_respond_custom_error_page_on_exceptions
fix(dav): Always respond custom error page on exceptions
2024-09-05 20:13:45 +02:00
Stephan Orbaugh
3f79566974
Merge pull request #47519 from nextcloud/fix/transfer-ownership-encrypted-files
feat(transfer-ownership): Correctly react to encrypted files
2024-09-05 17:58:44 +02:00
Louis Chemineau
9992e7d439
fix(dav): Always respond custom error page on exceptions
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-05 16:17:32 +02:00
Côme Chilliet
0555900134 fix(transfer-ownership): Improve comments according to code review
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-05 14:44:50 +02:00