Commit graph

664 commits

Author SHA1 Message Date
Anna Larch
1ce46c1fca refactor: move to new activity exception
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-17 12:06:24 +02:00
John Molakvoæ
f5512ca062
Merge pull request #47792 from nextcloud/chore/use-public-api-helper 2024-09-16 11:20:58 +02:00
provokateurin
b0baaaed9d
feat(NavigationManager): Add default entries handling
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 11:04:36 +02:00
Ferdinand Thiessen
ede38709b5
chore(files): Use public API where possible
This is not fixing all issues in the helper,
but at least where possible use the public methods.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-05 23:00:27 +02:00
Anna Larch
8af7ecb257 chore: adjust code to adhere to coding standard
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-05 21:23:38 +02:00
Côme Chilliet
0555900134 fix(transfer-ownership): Improve comments according to code review
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-05 14:44:50 +02:00
Côme Chilliet
d92bf388b1 feat(transfer-ownership): Correctly react to encrypted files
For E2EE encrypted files, we abort the transfer.
For SSE encrypted files, we abort only if not using master key.
Also fixed the check for when the path to a single file is used.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-05 14:44:50 +02:00
Louis Chemineau
2574cbfa61
chore: Apply php:cs recommendations
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-08-28 10:44:18 +02:00
Robin Appelman
b21a399d1a
fix: implement sharding compatible cleanup for various bits
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:27:14 +02:00
Robin Appelman
e538f4699d
fix: adjust systemtag orphan cleanup query to work with sharding
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:21:20 +02:00
Robin Appelman
80a25531f7
fix: make background scan job compatible with sharding
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:21:19 +02:00
Christopher Ng
71e653c0bc perf(files): Do not block files page load with server-side favorites retrieval
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-27 14:33:39 -07:00
Daniel Kesselberg
af6de04e9e
style: update codestyle for coding-standard 1.2.3
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-08-25 19:34:58 +02:00
Robin Appelman
0f9ea1992c perf: improve cleanup of tags/comments
delete entire chunk at once instead of one-by-one

Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-15 17:13:57 +02:00
Ferdinand Thiessen
7fec706f68 refactor(files): Drop unneeded initial state
The initial state is no longer used, it was only used in legacy UI and in the f2v rewrite
it was only used for the `id` which can be loaded just from the URL.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-14 09:31:27 +02:00
Christopher Ng
36cf891b7f feat(files): Update openapi
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-08 10:52:20 -07:00
Christopher Ng
e9083db768 feat(files): Allow specifying path and depth for returned folder tree
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-08 10:52:20 -07:00
Ferdinand Thiessen
4150492ffc
fix(files): When redirecting to a file (internal link) then it should open by default
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-03 13:53:53 +02:00
Christopher Ng
012e2687ab feat(files): Update openapi spec
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-01 09:17:56 -07:00
Christopher Ng
0def7fa71c feat(files): Allow toggling folder tree
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-01 09:17:56 -07:00
Christopher Ng
aa4d82d428 feat(files): Implement endpoint to retrieve a user's folder tree
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-01 09:14:44 -07:00
Kate
13921cab98
Merge pull request #46807 from nextcloud/refactor/files/security-attributes 2024-08-01 15:40:40 +02:00
Julius Härtl
a6d421e767
chore: Remove deprecated legacy search backend
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-08-01 12:33:18 +02:00
provokateurin
3fde60db85
refactor(files): Replace security annotations with respective attributes
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-07-27 22:44:01 +02:00
Andy Scherzinger
4f2a29adf9
Merge pull request #46672 from nextcloud/fix/preview-invalid-id
Avoid using partial file info as valid one
2024-07-25 19:37:30 +02:00
Elizabeth Danzberger
b749a89a33
fix: PHP formatting
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2024-07-25 11:11:41 +02:00
Elizabeth Danzberger
efe03ee690
feat: Add support for filling fields to backend components
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2024-07-25 11:11:40 +02:00
Julius Härtl
6c1e896a03 fix: Ignore preview requests for invalid file ids
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-07-22 22:32:34 +02:00
Ferdinand Thiessen
0936af9960
feat(files): Allow to configure Windows filename compatibility in the settings
This adds an admin setting to toggle Windows filename compatibility.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Louis <louis@chmn.me>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-17 16:17:14 +02:00
Ferdinand Thiessen
f4ede27cdb
refactor: Remove deprecated Util function for filename validation to FilenameValidator
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-16 12:49:10 +02:00
Ferdinand Thiessen
bdbeabafa7
feat: Add forbidden_filename_basenames config option
This allows to configure forbidden filenames (the full filename like `.htaccess`)
and also forbidden basenames like `com0` where `com0`, `com0.txt` and `com0.tar.gz` will match.
We need this as only using basenames was too restrictive and will cause problems on some systems when updating.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-15 19:39:18 +02:00
Ferdinand Thiessen
a229723b8c
feat: Add new forbidden filename options to Capabilities
Allow clients to access the new filename validation options
and make frontend name validation possible.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-11 13:31:54 +02:00
Benjamin Gaussorgues
ec39228b89
Merge pull request #46059 from nextcloud/perf/remove_useless_session 2024-06-27 11:15:50 +02:00
Joas Schilling
8130968a35
feat(notifications): Migrate server INotifiers to new exceptions
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-06-25 11:56:24 +02:00
Benjamin Gaussorgues
71dffd9b70
perf(session): remove useless session open
`UseSession` isn’t used in theses controllers.
Not using it should avoid a few session locks.

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-06-24 10:17:05 +02:00
Louis Chemineau
f7c9ac8b54
fix(files): Rename openFileInfo to fileInfo
And check if openFile is set in the URL before opening a file.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-06-19 15:38:13 +02:00
Julius Härtl
40a416ba00
perf: Tell browsers to cache storage stats endpoint as it is cached
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-06-18 23:00:17 +02:00
Ferdinand Thiessen
1550af87cd
fix(files): Properly handle denied ownership transfers
When the receiver denies the transfer the notification handler was missing,
so no notification was created for the transfer owner.

But also the internal notification was created two times:
1. When rejecting the transfer
2. By the reject function when dismissing the notification

This is fixed by only relying on the dismiss function.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-14 17:35:59 +02:00
Ferdinand Thiessen
4bd9bc7b06
feat(files): Use receiving users language for the ownership transfer target folder
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-29 20:19:58 +02:00
Andy Scherzinger
5b7dcc1427
chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-29 08:58:16 +02:00
Côme Chilliet
4c27e88b40
fix(files): Fix ownership transfer encrypted files detection
Discovered by psalm update

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-30 09:23:59 +02:00
Ferdinand Thiessen
c6f3aecef1
fix(files): Use string array instead of string for forbidden characters
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-04-29 17:15:00 +02:00
Ferdinand Thiessen
6a281f019c fix(files): Use OCP\Util::getForbiddenFileNameChars instead of direct access to system config
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-04-29 17:01:32 +02:00
Ferdinand Thiessen
38f4451a23
fix(files): Also restore shares after ownership transfer for object storage
When a file is moved between different storages then the file id is not (always) preserved.
This means the file id has to be adjusted for all shares.

So in case the file id does not exist anymore we try to find the new file id based on the
target path of the transfer and the path suffix of the share.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-04-18 13:51:47 +02:00
Robin Appelman
1d34f0a824 feat: cleanup filecache_extended items by default
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-04-15 20:30:57 +02:00
Daniel Kesselberg
2f6cc92491 feat: remove orphaned entries from filecache_extended
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-04-15 20:30:57 +02:00
Côme Chilliet
ec5133b739 fix: Apply new coding standard to all files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 14:16:21 +02:00
Christopher Ng
66e77d41c8 feat: Add iconSvgInline to TemplateFileCreator
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-03-20 15:50:52 -07:00
John Molakvoæ
0379a8d7a9
Merge pull request #41973 from nextcloud/files-scan-path-option 2024-03-15 13:14:29 +01:00
Louis Chemineau
2de9880d79
fix(files): Do not require files_trashbin in live photo sync listener
Fix https://github.com/nextcloud/server/issues/43299

Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-03-14 10:55:44 +01:00