Commit graph

800 commits

Author SHA1 Message Date
rakekniven
cca0a757fe chore(18n): More natural english
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2025-05-23 09:36:58 +02:00
Marcel Klehr
f8f26952d1 feat(SetupChecks): Add check for TaskProcessing pickup speed
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-05-22 12:50:00 +02:00
provokateurin
82fb8f8508
refactor: Extend rector to core/
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-15 00:16:54 +02:00
provokateurin
78a175fc74
refactor: Apply rector refactorings
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-14 15:29:02 +02:00
Ferdinand Thiessen
1ae3fa4003
chore: replace leagcy OC_Helper calls with OCP\Util
- Replace legacy calls with OCP\Util
- Add missing deprecation notices
- Inline implementation in OCP\Util and call it from OC_Helper

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-14 10:18:04 +02:00
Ferdinand Thiessen
1ba88da113
chore: compile assets
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-27 11:38:42 +02:00
Ferdinand Thiessen
6d8c49f0d4
fix(settings): group admins only can add users to their groups
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-27 11:35:40 +02:00
Ferdinand Thiessen
8cc0c266d5
feat(settings): provide user groups for accounts list
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-27 11:35:40 +02:00
provokateurin
eb98e99530 fix(settings): Handle email change restriction separately from display name change restriction
Co-authored-by: provokateurin <kate@provokateurin.de>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Louis <louis@chmn.me>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-02 19:06:25 +02:00
rakekniven
e43a8b473c chore(i18n): Aligned grammar
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2025-03-31 16:58:07 +02:00
Christopher Ng
2bd1d16157 perf(settings): Remove computation of all groups
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-03-28 14:12:52 -07:00
Ferdinand Thiessen
a243e9cfbb
fix(webauthn): do not require bcmath or gmp - not needed anymore
The extensions are not required anymore but only recommended for
performance. See also:
https://github.com/web-auth/webauthn-framework/issues/213

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-19 11:19:49 +01:00
Ferdinand Thiessen
38e8f30fb7
Merge pull request #51378 from nextcloud/fix/lookup-server-connector-v2
fix(lookup-server): disable when not using global scale
2025-03-11 21:17:11 +01:00
Ferdinand Thiessen
00d08a4f69
fix(lookup-server): disable lookup server for non-global scale setups
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 14:26:47 +01:00
Ferdinand Thiessen
5e4910e10e
fix(lookup-server): do not upload data by default
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 14:26:47 +01:00
Git'Fellow
659747e5b1 fix(AppDiscover): Ensure created cache folder is safe-chars only
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-03-10 19:11:17 +01:00
Côme Chilliet
c59400dea1 chore: Move magic number into a documented const
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-10 11:30:18 +01:00
Côme Chilliet
0b449f302b fix: Correctly count disabled users for SAML groups subadmins
If too many users return -1 as for LDAP so that link is shown

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-10 11:30:18 +01:00
skjnldsv
29405f0964 fix(systemtags): unify restrict_creation_to_admin handling
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-03-06 11:29:57 +01:00
Johan Bernhardsson
c39741fd65 fix: Change SQL query so that it is ansi safe
Signed-off-by: Johan Bernhardsson <johan.bernhardsson@redpill-linpro.com>
2025-02-27 09:00:06 +01:00
Joas Schilling
095ab4419e
fix(l10n): Improve english source strings
- No leading/trailing whitespace
- Use asci single quote

Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-02-26 09:54:32 +01:00
Ferdinand Thiessen
f91db181af
feat(setupcheck): check logging level for validity
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-22 14:08:19 +01:00
Ferdinand Thiessen
082e85f6da
Merge pull request #50779 from nextcloud/chore/mailer-tests
test(Mailer): Align tests for mailer with stable30
2025-02-18 17:52:12 +01:00
Côme Chilliet
17fffdbbcb
fix(settings): Inject subadmin manager and adapt tests, resolve a FIXME comment
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 12:48:12 +01:00
Côme Chilliet
64863c9d46
chore: Apply new rector configuration to apps folder
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 11:46:42 +01:00
Côme Chilliet
ed5b7ae161
chore: re-apply current rector configuration to apps folder
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 11:45:33 +01:00
Côme Chilliet
a3685551f7
fix: Replace isInstalled calls with isEnabledForAnyone or isEnabledForUser
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 10:19:19 +01:00
Josh
84293441e8
test(Mailer): Align tests for mailer with stable30
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-12 13:29:58 +01:00
Git'Fellow
a509494107 fix(emailTemplate): use instance Name instead of Url in subject
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-02-12 11:52:22 +01:00
Joas Schilling
0a6eeb497b
fix(setupcheck): Update setup check for PHP version to be more accurate
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-02-10 11:50:09 +01:00
Ferdinand Thiessen
2a0f81da53
fix(provisioning_api): Correct limit for editUser
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-06 11:58:24 +01:00
Andy Scherzinger
4a7c0b3267
Merge pull request #50281 from nextcloud/fix/fix-email-setupcheck-with-null-smtpmode
fix(settings): Fix setup check when mail_smptmode is set to "null"
2025-01-30 09:33:24 +01:00
Andy Scherzinger
4145dedba0
Merge pull request #50425 from nextcloud/fix/openapi/outdated-specs
Fix outdated OpenAPI specs
2025-01-26 22:08:35 +01:00
Josh
8a7b1617d0 fix(settings): Add some context to the PHP memory limit error
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-01-26 17:54:19 +01:00
Josh
b452dc0697 fix(SetupChecks): Pass webfinger if a handler is there
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-01-26 13:03:05 +01:00
provokateurin
e473a26676
fix(settings): Add back adminstration scope for LogSettingsController
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-25 17:16:39 +01:00
Joas Schilling
3302f1461f
fix(security): Update .well-known/security.txt expiration date
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-01-23 08:42:30 +01:00
nfebe
f7c46b6809 feat(systemtags): toggle for system tag creation in admin settings
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-01-22 20:07:25 +01:00
Côme Chilliet
b8de5e0d09
fix(settings): Fix setup check when mail_smptmode is set to "null"
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-01-20 17:12:19 +01:00
Christopher Ng
1a43fc5718 feat(sharing): Toggle custom tokens setting as admin
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-01-15 15:50:43 -08:00
Git'Fellow
cd147cd1a3
fix(setupchecks): Binary data can have problems with serialize
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-01-09 23:42:07 +01:00
Josh
1304590d6c
Merge pull request #49977 from nextcloud/jtr-perf-checks-connectivity-https-proto
perf(settings): Speed up InternetConnectivity setup check
2025-01-09 12:09:33 -05:00
Kate
e7122a6864
Merge pull request #49882 from nextcloud/fix/http/template-valid-status-codes 2025-01-08 11:10:57 +01:00
Josh
35cb5d84ca perf(settings): Speed up InternetConnectivity setup check
Specify default protocol (https://) rather than let default handling test both http:// and https://

Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-01-07 16:49:28 -05:00
John Molakvoæ
cd236c7941
Merge pull request #49891 from nextcloud/refactor/settings/mail-settings-parameters 2025-01-07 16:59:02 +01:00
provokateurin
960168fd96
fix(settings): Fix log file download return type
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-07 15:44:48 +01:00
Joas Schilling
17e8948360
Merge pull request #49988 from nextcloud/jtr-locale-personal-info
fix(settings): show the correct initial locale in Personal info
2025-01-07 15:42:43 +01:00
provokateurin
f52aa9ad32
refactor(provisioning_api): Rename AUserData to AUserDataOCSController to allow openapi-extractor to detect it as OCS
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-06 14:30:40 +01:00
provokateurin
98275fb806
refactor(settings): Use parameters explicitly when setting mail settings
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-06 08:40:52 +01:00
Josh
5e27d1415a
fix(settings): show the correct initial locale in Personal info
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-12-29 12:33:29 -05:00
Jana Peper
ee31b3bbe5 fix: error handling for wrong json values
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
2024-12-18 18:32:34 +01:00
Jana Peper
d87302c651 feat: add error flags for json_decode
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
2024-12-18 18:32:34 +01:00
Jana Peper
8cac92665d feat: filter disabled apps in task types requests
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
2024-12-18 18:32:34 +01:00
Jana Peper
32b57e7b41 feat: save state in db
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
2024-12-18 18:32:34 +01:00
Joas Schilling
1cbfe55271
fix(setupcheck): Disable PhpMaxFileSize setupcheck for now
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-12-04 08:35:20 +01:00
Joas Schilling
1bcc381e28
fix(setupcheck): Make the Memcache setupcheck use the cache
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-12-02 09:18:07 +01:00
Joas Schilling
d1e17e78b7
fix(activity): Fix activity object type warnings
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-11-27 10:54:15 +01:00
skjnldsv
52020b5ea6 fix(settings): psalm PhpMaxFileSize setup check warning
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-19 18:27:35 +00:00
skjnldsv
4a88848109 feat(settings): add big file upload setup checks
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-19 16:43:41 +01:00
Ferdinand Thiessen
9e327a5890
fix(apps-store): Remove apps from force-enabled state when uninstalled
If an app is force-enabled and then uninstalled the force-enabled state was kept.
This is now removed, so when the app should be re-installed the compatibility should be reevaluated.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-11-18 14:09:54 +01:00
rakekniven
49c7f7dd1c
chore(i18n): Fixed grammar
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2024-11-14 12:59:14 +01:00
Daniel
22e2419b28
Merge pull request #48134 from nextcloud/feat/mail-provider-settings
feat: mail provider settings
2024-11-13 14:31:21 +01:00
Ferdinand Thiessen
a3e80e4195
feat: Update supported PostgreSQL versions
12 is now EOL but 17 was released and should be supported and tested.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-11-13 02:50:13 +01:00
SebastianKrupinski
3e870695bc feat: mail provider settings
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-11-12 13:19:35 -05:00
Benjamin Gaussorgues
46abfc6d50
Merge pull request #48792 from nextcloud/chore/update_mysql_setup_check_i18n 2024-11-05 10:06:29 +01:00
rakekniven
25d1628e30
chore(i18n): Fix grammar
Reported at Transifex

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2024-11-03 16:34:57 +01:00
Benjamin Gaussorgues
a40f21b4db chore(setupchecks): update translation for MySQL row format check
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-10-30 09:56:02 +01:00
Benjamin Gaussorgues
34ade098bd fix(users): use correct active user count
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-10-30 07:53:10 +01:00
Andrey Borysenko
a12b4da6af
fix(ci): psalm, suppress undefined for viewApps
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-10-29 20:54:08 +02:00
Andrey Borysenko
e4d586697c
WIP: address review comments, small fixes
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-10-29 20:54:08 +02:00
Andrey Borysenko
3a840c102a
fix(ci): suppress UndefinedClass for AppAPI related classes since it's bundled
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-10-29 20:54:07 +02:00
Andrey Borysenko
95b06309f3
feat(app_api): add initial state data for AppAPI UI part
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>

# Conflicts:
#	apps/settings/lib/Controller/AppSettingsController.php

# Conflicts:
#	apps/settings/lib/Controller/AppSettingsController.php
2024-10-29 20:54:05 +02:00
Kate
e8dbf022c9
Merge pull request #48919 from nextcloud/fix/settings/userid-dependency-injection 2024-10-28 11:44:16 +01:00
Claudio Cambra
5969b4bea8
fix(appsmanagement): Fix exception on generating preview url for screenshots
Some installed apps meant for older server versions might unexpectedly
offer up screenshot values in a non-string format (e.g. health). Avoid
an exception by checking first if the first app screenshot is indeed a
string and otherwise we take the value of the parameter

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-10-28 08:29:16 +01:00
provokateurin
35d614057c
fix(settings): Fix dependency injection
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-28 08:14:17 +01:00
Josh
4c9877c082
fix(settings): Change "setup warnings" -> "setup checks" in Overview
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-10-23 17:31:59 -04:00
Ferdinand Thiessen
6d2c63ecff
fix(settings): Do not use null on string parameter for sharing disclaimer
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-23 20:12:32 +02:00
Kate
b5ac989ecd
Merge pull request #48854 from nextcloud/fix/proxy-app-screenshot 2024-10-23 17:18:13 +02:00
Ferdinand Thiessen
3b6915e96d
fix(app-store): Also proxy images of locally installed apps
Before this only app store apps got their screenshots proxied,
but this will cause locally installed apps to not be correctly shown on the app-store.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-23 13:36:27 +02:00
Ferdinand Thiessen
9955b13564
fix(app-store): Ensure the groups property is always an array
If the value was a string, like a single group, then `json_decode` will also yield only a string.
So in this case we ensure the property is always an array with that value.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-23 13:32:36 +02:00
provokateurin
381077028a
refactor(apps): Use constructor property promotion when possible
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-21 12:37:59 +02:00
Benjamin Gaussorgues
7e99fd31ea
Merge pull request #48547 from nextcloud/feat/row_format_check 2024-10-18 11:59:58 +02:00
Marcel Müller
74d179edf3 fix(appstore): Hide last modified information for shipped apps
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2024-10-16 23:51:56 +02:00
Côme Chilliet
1580c8612b
chore(apps): Apply new rector configuration to autouse classes
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-15 10:40:25 +02:00
Christopher Ng
40823775d9 fix: Fix empty sections appearing in search results
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-10-08 10:57:20 -07:00
Benjamin Gaussorgues
f70f70e0db
feat(setupchecks): add row format setup check for MySQL databases
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-10-08 17:13:30 +02:00
Maksim Sukharev
0d6acbf9e4 fix: do not reduce count for subadmins if they are members of group
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2024-10-02 18:32:53 +02:00
Kate
54cdd42ba9
Merge pull request #48437 from nextcloud/fix/noid/count-disabled-correct 2024-09-30 11:59:06 +02:00
Maksim Sukharev
2b2b4e9e96 fix: correctly count disabled users for subadmins
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2024-09-28 18:46:16 +02:00
Ferdinand Thiessen
b5256181a4
fix(settings): Sort all settings - incl declarative settings - by priority
Previously declarative settings were sorted by priority but behind the "native" settings,
this is now fixed, meaning a declarative setting with higher priority than an `ISetting` will
be correctly rendered before that `ISetting` in the settings list.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-28 14:08:26 +02:00
Ferdinand Thiessen
9bc0aa03b2
fix: Ensure app discover section is returned as list
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-24 12:34:22 +02:00
Joas Schilling
096f893d46
fix(activity): Update more activity providers to use new exceptions
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-23 12:31:59 +02:00
Julius Knorr
606241caeb
chore(legacy): Introduce public version ct plass and drop version methods from OC_Util
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2024-09-20 14:53:34 +02:00
provokateurin
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-19 14:21:20 +02:00
Josh Richards
e019eae347 fix(setupChecks): Having transactional file locking disabled is not supported
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-09-19 12:50:59 +02:00
John Molakvoæ (skjnldsv)
26abc86eca
feat: add profile pronouns
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-09-17 22:20:36 +02:00
Ferdinand Thiessen
f5b73d2c77
fix: Remove legacy settings forms
`OC_App::getForms` was always returning an empty array,
because there were no setter for `adminForms` or `personalForms` anymore.
So removed all that legacy settings forms logic.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-17 14:54:39 +02:00
Anna Larch
1ce46c1fca refactor: move to new activity exception
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-17 12:06:24 +02:00
Robin Appelman
ede0c26b78
Merge pull request #46480 from nextcloud/fix/mailer-binaryfinder-fallback
fix(Mailer): Fix sendmail binary fallback
2024-09-16 18:18:14 +02:00
Josh
87aa1267a8 fix(Mailer): Fix sendmail binary fallback
feat: add debug logging to sendmail binary finder

Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-09-16 15:20:29 +02:00