upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-23 15:21:00 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 42
83210 commits 873 branches 1197 tags 8.3 GiB
Commit graph

475 commits

Author SHA1 Message Date
Maxence Lange
8b9e7e235d ocm controller 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2023-09-20 08:23:45 -01:00
jld3103
c6806684d2
files_sharing: Add OpenAPI spec 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-07-31 16:58:49 +02:00
John Molakvoæ
8e1c693be5
fix(files_sharing): error and size/mtime for deleted shares 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2023-07-11 13:55:10 +02:00
John Molakvoæ
f5f142d31b
fix: adjust testing 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2023-07-11 13:52:28 +02:00
John Molakvoæ
6f54f72bb4
feat(sharing): add sharing overview view 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2023-07-11 13:52:27 +02:00
Benjamin Gaussorgues
29c1848eda
Migrate files sharing to PSR LoggerInterface 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-07-06 14:08:42 +02:00
Maxence Lange
d2efd0e03c displayname on federated shares 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2023-06-28 09:28:03 -01:00
Faraz Samapoor
12e3594299 Refactors "strpos" calls in /apps/files_sharing to improve code readability. 
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
 2023-06-02 20:08:40 +03:30
Louis Chemineau
6b53e4b13a Mutualize expireDate handling when creating and updating a share 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2023-04-27 16:26:24 +02:00
rakekniven
86b17e2248 Update apps/files_sharing/lib/Controller/ShareAPIController.php 
Co-authored-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2023-04-18 12:08:38 +02:00
rakekniven
eaaeb32074 fix(l10n): Fixed grammar 
Reported at Transifex.
  
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>


Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2023-04-18 12:08:38 +02:00
Michiel de Jong
c0e84cb512 Add SHARE_TYPE_SCIENCEMESH 
Signed-off-by: Michiel de Jong <michiel@unhosted.org>
 2023-03-08 16:46:55 +01:00
Julius Härtl
38ca468502
Merge pull request #36515 from nextcloud/fix/sharees-remove-deck 2023-02-16 21:17:16 +01:00
Vincent Petry
1fed799826
Merge pull request #36452 from nextcloud/perf/share-availability-check 
perf(federation): Only request root share info for checking availability
 2023-02-03 13:34:35 +01:00
jld3103
30858df737
Remove Deck from Sharees API 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-02-03 12:01:37 +01:00
Louis Chemineau
4ab3c16403 Pluggable share provider 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2023-02-02 15:41:26 +01:00
Julius Härtl
7e3ea019d1
chore: Add return types 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-01-31 11:42:33 +01:00
Julius Härtl
7cc9ba28a7
perf(federation): Only request root share info for checking availability 
Otherwise this would request a full recursive dirctory listing while the result is never being used

Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-01-31 11:41:34 +01:00
Jan-Philipp Litza
a7abe2c35a Honor permissions of new link share via OCS API 
The API currently overrides the supplied permissions with "read only"
when a file is shared via link. It allows to update the permissions
later, however.

This keeps the default to "read only" but honors the permissions
supplied by API call if any.

Signed-off-by: Jan-Philipp Litza <jpl@plutex.de>
 2022-12-06 16:00:20 +01:00
Julius Härtl
8629d8e44f
Check share attributes on preview endpoints 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-10-25 11:35:31 +02:00
Carl Schwan
0de71a73e5
Merge pull request #34502 from nextcloud/fix/correct-attribute-resharing 
Propagate attributes when resharing
 2022-10-20 17:03:02 +02:00
Carl Schwan
54031e370a Fix various other small psalm issues 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 12:40:35 +02:00
Carl Schwan
60313683e2 Fix checkpassword undocummented null parameter 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 12:38:21 +02:00
Carl Schwan
c6b8a3bec3 Fix permission not being int 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 12:37:46 +02:00
Carl Schwan
53e408f76a Fix exception getCode type 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 12:36:50 +02:00
Carl Schwan
3a11128e6c Fix type when getting appconfig with int 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 12:36:05 +02:00
Simon L
d967488ec0
Merge pull request #34544 from nextcloud/fix/more-flexible-date-validation 
More flexible date validation
 2022-10-13 01:10:55 +02:00
Carl Schwan
9eb67ad57d More flexible date validation 
Fix #34542

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-11 23:02:10 +02:00
Carl Schwan
8e3f21d9ed Small progress with fixing unit tests 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-11 14:00:15 +02:00
Carl Schwan
cf39885b53 Propagate attributes when resharing 
When updating a share, load the node from the initiator instead of the
owner similar to how this is done when creating the share.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-10 17:06:29 +02:00
Roeland Jago Douma
c6e100ed32
type closure to make psalm a bit happier 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2022-10-09 21:41:18 +02:00
tobiasKaminsky
610bbaed68 includeTags -> include_tags 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-09-28 13:17:56 +00:00
Tobias Kaminsky
5b3fb7a8ff
Update apps/files_sharing/lib/Controller/ShareAPIController.php 
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com>
 2022-09-21 08:28:03 +02:00
tobiasKaminsky
ebd28ef9e0
Show include tags on single share 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-09-19 11:36:52 +02:00
tobiasKaminsky
4a4a3874da
Add includeTags to /share/id 2022-09-19 11:11:09 +02:00
Carl Schwan
02d55eb90f
Merge pull request #33941 from nextcloud/fix/public-sharing 
Only normalize data in public shares and not crud
 2022-09-15 16:43:01 +02:00
Carl Schwan
7ded5a769b
Only normalize data in public shares and not crud 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-09-08 14:51:28 +02:00
luz paz
9d26671f05 Fix typos in apps/ subdirectory 
Found via `codespell -q 3 -S l10n,./apps/files_external/3rdparty -L adn,ba,boxs,keypair,jus,optionel,ressource,tabel ./apps/`

Signed-off-by: luz paz <luzpaz@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
 2022-09-05 12:59:54 +00:00
Max
99aa938452 feature: first take on using the viewer to render single file shares 
Signed-off-by: Max <max@nextcloud.com>
 2022-08-25 21:59:19 +00:00
Carl Schwan
7b723813ce
Multiple fixes 
- Fix tests
- Use non deprecated event stuff
- Add a bit of type hinting to the new stuff
- More safe handling of instanceOfStorage (share might not be the first
  wrapper)
- Fix resharing

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-07-31 19:37:59 +02:00
Carl Schwan
ab1a20522b
Enforcing permission during resharing 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-07-28 16:54:13 +02:00
Vincent Petry
bbb5043c07
Inherit hide download from share attributes 
When resharing by link, if the download permission was removed through
share attributes, convert it to the hide download flag.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-07-28 16:54:13 +02:00
Vincent Petry
54a0d8fe64
Don't reset share attributes when not specified 
When not specified in the OCS call, don't reset the share attributes.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-07-28 16:53:23 +02:00
Vincent Petry
03b1791cca
Fix share attribute related tests + code style 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-07-28 16:53:22 +02:00
Vincent Petry
9493f86de3
Fix share controller to accept share attributes alone 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-07-28 16:53:22 +02:00
Vincent Petry
a95c19e14b
Add share attributes + prevent download permission 
Makes it possible to store download permission

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-07-28 16:53:22 +02:00
Joas Schilling
148498bba5
Merge pull request #32741 from nextcloud/Valdnet-patch-2 
l10n: Delete apostrophe
 2022-06-10 15:54:14 +02:00
Cyrille Bollu
50badb3fb6 Various improvements related to the recent implementation of temporary passwords 
for mail shares:

1- Changes style of "forgot password?" and "Back" button
2- Adds information about share password's expiration time in the emails sent.
3- Shows password expiration time in the Share menu
4- Fixes an issue when the message "Password expires..." would be shown for non email share types (which don't have temporary passswords)
5- At share's creation, password should only be sent when it's a permanent one

See also https://github.com/nextcloud/server/issues/31952

Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
 2022-06-08 11:29:19 +00:00
Joas Schilling
50c697dbd4
Fix unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-06-07 20:40:55 +02:00
Valdnet
dfe7243338
l10n: Delete apostrophe 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-06-07 16:41:38 +02:00
Vincent Petry
f5c8fa4f11
Properly reset pw expiration 
When requesting a new password for share by mail link, now we correctly
reset the expiration date.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-04-13 15:46:30 +02:00
Cyrille Bollu
c6a5c07041 Adds a "Request password" button to the public share authentication page for shares 
of type TYPE_EMAIL, when the "video verification" checkbox isn't checked. Users accessing
non-anonymous public shares (TYPE_EMAIL shares) can now request a temporary password themselves.

- Creates a migration step for the files_sharing app to add the 'password_expiration_time'
  attribute to the oc_shares table.
- Makes share temporary passwords' expiration time configurable via a system value.
- Adds a system config value to allow permanent share passwords

-Fixes a typo in a comment in apps/files_sharing/src/components/SharingEntryLink.vue

See https://github.com/nextcloud/server/issues/31005

Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
 2022-04-11 21:58:24 +02:00
Simon L
1ceb6cdb38
Merge pull request #31684 from nextcloud/user-share-permissions-merge 
take permissions from multiple paths into account for share permissions
 2022-04-05 17:37:46 +02:00
Robin Appelman
278b13155a
take permissions from multiple paths into account for share permissions 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-03-31 16:47:35 +02:00
Louis
47f1ba6ea6
Merge pull request #31240 from nextcloud/Valdnet-patch-3 
l10n: Add a dot
 2022-03-31 14:57:25 +02:00
Valdnet
1e487c2a09
l10n: Spelling unification in Transifex. 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-03-18 10:14:34 +01:00
szaimen
ccd08877e8 Fix too many file download notifications when watching a video 
Signed-off-by: szaimen <szaimen@e.mail.de>
 2022-03-07 19:50:15 +00:00
Valdnet
522d9c1d1f
l10n: Delete dot 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-02-17 15:03:53 +01:00
Valdnet
c72718c61b
l10n: Add a dot 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-02-17 14:07:51 +01:00
Louis Chemineau
da435b1e67 Support CRUD share permissions 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2022-02-15 11:54:17 +01:00
szaimen
f0424378f6 Revert "Add non-breaking space in the file size" 
Signed-off-by: szaimen <szaimen@e.mail.de>
 2022-02-10 10:35:19 +01:00
Carl Schwan
46c0ceb59c
Add non-breaking space in the file size 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-01-14 09:19:15 +01:00
Joas Schilling
d49ad7ea47
Limit more contact searches 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-12-08 18:58:54 +01:00
Julius Härtl
5116bf146f
Allow to pass note when creating a share and send it with directly in the share mail when set 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-12-03 10:17:02 +01:00
John Molakvoæ
90b47ab7f0
Merge pull request #28764 from nextcloud/feat/sharing-link-event 2021-09-10 09:31:18 +02:00
John Molakvoæ
c56c317d82
Emit event on link share action 
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
 2021-09-10 08:36:45 +02:00
Arthur Schiwon
27865d03c0
use specific email getter where necessary 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-09-09 19:23:05 +02:00
Hinrich Mahler
961f8958c0
Let users choose a share_folder 2021-09-06 16:39:11 +02:00
szaimen
0c27faf711 Update "Sending password by Nextcloud Talk failed" sentence 
Signed-off-by: szaimen <szaimen@e.mail.de>
 2021-07-07 13:39:57 +02:00
Gary Kim
b78f3a57d1
Migrate HintException to OCP 
Signed-off-by: Gary Kim <gary@garykim.dev>
 2021-06-30 15:28:02 -04:00
Julius Härtl
c0474ba364
Use product name in places where it is appropriate rather than the instance name 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-06-16 11:42:53 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-06-04 22:02:41 +02:00
Joas Schilling
e4b5645883
Also make other shares listen to the "Allow sharing with groups" 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-05-26 11:19:58 +02:00
Valdnet
9749968308
l10n: Unify spelling 
Spelling unification in Nextcloud applications.
 2021-05-20 09:22:08 +02:00
Morris Jobke
6f31d20f3d
Merge pull request #26580 from castillo92/patch-2 
Fix casing of exception string
 2021-05-18 09:29:45 +02:00
Roeland Jago Douma
701294520a Add bruteforce protection to the shareinfo endpoint 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-05-12 09:34:45 +02:00
Valdnet
505863c55e
l10n: Change to a capital letter 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-04-27 12:38:28 +02:00
Roeland Jago Douma
dcd45427a6 Make lookup search explicit 
Speedsup sharee lookup quite a bit.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-04-19 20:05:21 +02:00
castillo92
12948aa217
Update ShareAPIController.php 
Change to capital letters in an abbreviation.

Signed-off-by: castillo92 javiercizquierdo@gmail.com
 2021-04-16 08:56:20 +02:00
Vincent Petry
8680bafc5c
Implement expiration date for federated shares 
Add expiration date field in UI.
Save expiration date when creating or updating federated share.
Read expiration date from DB in federated share provider.
Applies to both federated user and group shares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-04-15 10:02:00 +02:00
J0WI
74a7c2eefc Use correct getSystemValue type 
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
 2021-04-12 22:54:50 +02:00
Vincent Petry
278a73789e
Map old account scope properties to new names 
Use new scope values in settings page.
Adjust all consumers to use the new constants.
Map old scope values to new ones in account property getter.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-03-26 13:07:08 +01:00
Daniel Calviño Sánchez
f99876997a
Remove duplicated query for email shares 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
 2021-03-22 06:50:47 +01:00
John Molakvoæ (skjnldsv)
100d5d9a47
Add labels to mail shares 
Now the email is shown on a second line if a label is set.

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-03-22 06:34:09 +01:00
Vincent Petry
6997344931
Log exceptions when creating share 
Because the exceptions don't always contain a useful message for the UI,
but also because in some cases we need to find out what went wrong.

In some setups, a ShareNotFoundException might happen during creation
when we try to re-read the just written share. Usually related to Galera
Cluster where node syncing wait is not enabled.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-03-15 12:00:41 +01:00
Roeland Jago Douma
988b9f49c5 Fix invalid check after constructing DateTime 
We construct an object. Either that works on not.But the result can't be
false.

Found by psalm

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-03-08 16:32:34 +01:00
dependabot-preview[bot]
eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0 
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-02-18 13:31:24 +01:00
Morris Jobke
24d436cb60
Remove unneeded casts that were found by Psalm 
In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see https://github.com/nextcloud/server/pull/24521)

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2021-01-11 13:14:41 +01:00
Christoph Wurst
d89a75be0b
Update all license headers for Nextcloud 21 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-12-16 18:48:22 +01:00
Arthur Schiwon
d8ad4ef6b5
use a consistent default value for sharing.maxAutocompleteResults 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-12-15 11:53:39 +01:00
Julius Härtl
102402bfcb
Show unique displayname context in the user share list entries 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-14 11:14:59 +01:00
Julius Härtl
c4ea37b8a1
Address minor comments 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-09 15:51:41 +01:00
Julius Härtl
f3150f29a7
Introduce deck share type to ShareAPIController 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-09 13:20:24 +01:00
Julius Härtl
e906138d8d
Let sharees endpoint properly handle deck shares 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-09 13:20:23 +01:00
Maxence Lange
28252594a2 circleId too short in some request 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2020-11-13 08:59:22 -01:00
Morris Jobke
0390a90d70
Return correct error message on share download without read permission 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-10-26 16:22:27 +01:00
Richard Steinmetz
89f7e2ab64
Indicate preview availability in share api responses 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2020-10-13 14:12:42 +02:00
John Molakvoæ (skjnldsv)
6adb19b296
Show filename on share link download 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2020-09-17 19:55:47 +02:00
Roeland Jago Douma
7e6f04490e
Merge pull request #22393 from nextcloud/fix/license-headers-20 
Update the license headers for Nextcloud 20
 2020-08-24 22:03:00 +02:00
John Molakvoæ (skjnldsv)
6d576a9100
Fix missing FN from federated contact 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2020-08-24 15:15:32 +02:00
Christoph Wurst
2a054e6c04
Update the license headers for Nextcloud 20 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-08-24 14:54:25 +02:00
John Molakvoæ
565ccb08cd
Merge pull request #22109 from nextcloud/feature/20931/followup-1 2020-08-17 22:13:45 +02:00
Georg Ehrke
5b26487f14
Expose status via Collaborators API 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
 2020-08-14 17:04:52 +02:00
Daniel Kesselberg
6f8147b18f
Fix some MissingDocblockType or InvalidDocblock warnings. 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-08-14 15:10:48 +02:00
Julius Härtl
217a69ebf9
Add BeforeTemplateRenderedEvent for files_sharing 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-07-15 13:55:26 +02:00
Gary Kim
a2cedcefee
Add user input for link share labels 
Signed-off-by: Gary Kim <gary@garykim.dev>
 2020-07-14 10:02:17 +08:00
Joas Schilling
89ed2c37bf
Update share type constant usage 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-24 16:49:16 +02:00
Daniel Calviño Sánchez
37f231333f Fix reference to wrong class name 
\OCP\IShare does not exist; the right name is \OCP\Share\IShare,
although it is already imported as IShare.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-05-29 01:41:06 +02:00
Roeland Jago Douma
ef34f72167
Have share permissions on link shares if it is enabled 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-05-15 08:18:03 +02:00
John Molakvoæ (skjnldsv)
a26ca1e638
Do not filter id matching userId on non-user-share shares 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-05-05 21:36:46 +02:00
John Molakvoæ (skjnldsv)
ff20da637e Fix federated link sharing permissions 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-05-04 11:48:11 +00:00
Roeland Jago Douma
d466a7b808 Allow to navigate to others with access from the sidebar 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-04-29 17:53:35 +00:00
Christoph Wurst
cb057829f7
Update license headers for 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-29 11:57:22 +02:00
Morris Jobke
1738e17e20
Merge pull request #19793 from nextcloud/bugfix/noid/link-to-federated-reshare 
Fix resharing of federated shares that were created out of links
 2020-04-27 11:05:34 +02:00
Roeland Jago Douma
4114bce1e5
Merge pull request #17623 from j3l11234/master 
Add support for download share on old android browser
 2020-04-24 16:01:45 +02:00
Robin Appelman
7a4ea4a6b6
make php-cs happy 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-04-23 13:35:30 +02:00
Julius Härtl
5646f7c761
Link shares have reshare permission if outgoing federated shares are enabled 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-04-21 14:35:29 +02:00
John Molakvoæ (skjnldsv)
7eceba7dae Fix Sharing recommendation user display 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-04-21 07:48:10 +00:00
Joas Schilling
609b8aff12
Also disallow ; in remote urls 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-14 18:56:06 +02:00
Christoph Wurst
caff1023ea
Format control structures, classes, methods and function 
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 14:19:56 +02:00
Christoph Wurst
14c996d982
Use elseif instead of else if 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 10:35:09 +02:00
Christoph Wurst
008e6d7e84
Merge pull request #20391 from nextcloud/refactor/spaces-cleanup 
Remove all extra whitespace PSR2 does not like
 2020-04-09 20:39:37 +02:00
Christoph Wurst
64510932b8
Merge pull request #20384 from nextcloud/techdebt/lowercase-keywords 
Use php keywords in lowercase
 2020-04-09 16:25:14 +02:00
Christoph Wurst
44577e4345
Remove trailing and in between spaces 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 16:07:47 +02:00
Christoph Wurst
36b3bc8148
Use php keywords in lowercase 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 14:04:56 +02:00
Christoph Wurst
afbd9c4e6e
Unify function spacing to PSR2 recommendation 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 13:54:22 +02:00
Christoph Wurst
85e369cddb
Fix multiline comments 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-08 22:24:54 +02:00
Joas Schilling
f878ea9606
Remove user name from public sharing page 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-01 17:14:38 +02:00
Christoph Wurst
1a9330cd69
Update the license headers for Nextcloud 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-31 14:52:54 +02:00
Christoph Wurst
463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports 
Remove unused imports
 2020-03-27 17:14:08 +01:00
Christoph Wurst
b80ebc9674
Use the short array syntax, everywhere 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-26 16:34:56 +01:00
Christoph Wurst
74936c49ea
Remove unused imports 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-25 22:08:08 +01:00
Julius Härtl
87393a760e Remove unused properties in ShareesAPIController 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-03-20 10:43:56 +01:00
Joas Schilling
6edb93fc4a
Allow the video player on the hide download 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-03-19 15:14:00 +01:00
Joas Schilling
8db32805be
Fix willReturnOnConsecutiveCalls 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-03-13 11:11:00 +01:00
Joas Schilling
3930ab8e8a
Don't allow anchors and queries in remote urls 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-03-12 13:44:48 +01:00
John Molakvoæ
9fda1ee39f
Merge pull request #19777 from nextcloud/fix/viewer-public 
Properly emit Viewer event on files and files_sharing
 2020-03-12 08:47:14 +01:00
John Molakvoæ (skjnldsv)
92a6530c0f Properly emit Viewer event on files and files_sharing 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2020-03-11 09:28:27 +01:00
John Molakvoæ (skjnldsv)
6c968fe77d Fix import order and formatting 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2020-03-11 09:27:20 +01:00
Joas Schilling
886293fdcc
Don't break when one remote share is down 
getFileInfo can also return false

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-03-09 17:00:31 +01:00
Roeland Jago Douma
7613681627
Don't try to format deleted shares 
Fixes #15455

The issue is that we have a fallback for shares to use the target. So
when the target exists again we happily format it (not that the shares
are still invalid).

This just tries to get the node. If we can't then boom.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-03-02 09:18:04 +01:00
Joas Schilling
a792a31448
Allow single file downloads so the video player works again 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-02-28 16:25:09 +01:00
Roeland Jago Douma
302ea0650e
Merge pull request #19349 from nextcloud/bugfix/noid/prevent-download-on-secure-view 
Prevent archieved download on secure view
 2020-02-08 10:18:24 +01:00
Joas Schilling
35d4ca4d5d
Prevent archieved download on secure view 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-02-07 12:46:23 +01:00
Roeland Jago Douma
260892eb3b
Disable link shares of disabled users 
Fixes #10869

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-02-07 07:47:38 +01:00
Roeland Jago Douma
fc77f530d7
Don't show link shares hash in inherited share list 
This adds no value at all. Just showing the text "(Shared link)" now.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-01-15 09:21:53 +01:00
Christoph Wurst
6127c288e8 Fix license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-01-13 14:23:49 +01:00
Maxence Lange
554c4a7cf8 moving ->getParent earlier 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2020-01-08 08:56:14 -01:00
Julius Härtl
445274cf93
Add pending share list to frontend 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-01-07 19:35:45 +01:00
Roeland Jago Douma
fbed6a3416
A pending shares overview 
Now that we accept shares we should show an overview of shares that are
pending. This first part is the small API to get a list of the currently
pending shares.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-01-07 08:53:33 +01:00