upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-23 07:08:34 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 35
59544 commits 878 branches 1195 tags 8.3 GiB
Commit graph

4733 commits

Author SHA1 Message Date
Morris Jobke
ab48d5e8cb
Cleanup unneeded code around database.xml 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2021-03-24 22:15:44 +01:00
Robin Appelman
e5dc1a8085
Set umask before operations that create local files 
this solves issues where "other php stuff" is messing with the umask

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-23 14:52:31 +01:00
Morris Jobke
1c074e7602
Merge pull request #26198 from nextcloud/unified-search-node 
Handle limit offset and sorting in files search
 2021-03-22 21:48:51 +01:00
Roeland Jago Douma
3c5cf825b3 Add real events for enabled 2fa providers for users 
* Shiny new events
* Listener to still emit the old event

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-03-22 20:57:10 +01:00
John Molakvoæ (skjnldsv)
15767643f2
Fix sharebymail tests 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-03-22 06:50:47 +01:00
Daniel Calviño Sánchez
f99876997a
Remove duplicated query for email shares 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
 2021-03-22 06:50:47 +01:00
Robin Appelman
bfe3712372
handle ordering in folder search 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-19 16:07:54 +01:00
Julius Härtl
76170a58eb
Log and continue when failing to update encryption keys during for individual files 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-03-19 14:12:07 +01:00
Robin Appelman
feed42dd6d
folder filtering in sql 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-19 13:41:00 +01:00
Roeland Jago Douma
1286848731
Merge pull request #23718 from nextcloud/already-shared-error-message 
expand 'path is already shared' error message
 2021-03-19 13:39:22 +01:00
Robin Appelman
de713967c0
cleanup fileinfo creation 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-19 13:35:37 +01:00
Vincent Petry
7bf5adb1fa
Merge pull request #26200 from nextcloud/bugfix/26197/fix-expiration-validation-confusion 
Update user share must use correct expiration validation
 2021-03-19 10:51:21 +01:00
Robin Appelman
bd229e7548
handle limit and offset in folder file search 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-18 17:38:31 +01:00
Robin Appelman
50e374c12f
only require user to be set in a query that handles tags 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-18 17:16:28 +01:00
Vincent Petry
a9e3d2a10f
Update user share must use correct expiration validation 
Updating a user or group share now uses the correct method for the
validation of the expiration date. Instead of using the one from links
it uses the one for internal shares.

To avoid future confusion, the method "validateExpirationDate" has been
renamed to "validateExpirationDateLink".

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-03-18 17:12:28 +01:00
Robin Appelman
9e3775618b
log full expection during repair step 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-18 08:45:17 +01:00
Julius Härtl
a2f3077ee8
Skip db migration simulation for core schema changes 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-03-17 21:08:22 +01:00
Joas Schilling
0d46fafd41
Merge pull request #26161 from nextcloud/bugfix/noid/improve-matching-of-phonebook-searches 
Improve search results when only phonebook-matches can we autocompleted
 2021-03-17 15:22:03 +01:00
Joas Schilling
cf434d5107
Also limit to user group in case enumeration is enabled for groups and phonenumbers 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-17 11:20:30 +01:00
Joas Schilling
9a189bc710
Improve search results when only phonebook-matches can we autocompleted 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-17 09:51:31 +01:00
Vincent Petry
e559afb8d4
Merge pull request #25136 from nextcloud/cachejail-search-filter 
do cachejail search filtering in sql
 2021-03-15 17:45:30 +01:00
Robin Appelman
a550649708
expand 'path is already shared' error message 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-15 15:55:08 +01:00
Robin Appelman
32551b9ff7
Merge pull request #25722 from nextcloud/objectstore-copy-cross 
apply object store copy optimization when 'cross storage' copy is wit…
 2021-03-12 16:10:18 +00:00
Joas Schilling
a609074c18
Fix Test class name 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-12 08:53:43 +01:00
Joas Schilling
5b53b6f977
Add a setting to restrict returning a full match unless in phonebook or same group 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-10 17:25:57 +01:00
Joas Schilling
236aa194e2
Restrict autocompletion also based on the phonebook known users 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-10 17:19:55 +01:00
Robin Appelman
c87b1a50d9 apply object store copy optimization when 'cross storage' copy is within the same object store 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-09 20:31:27 +01:00
Roeland Jago Douma
30e096f3f5 Allow overwriting isAuthenticated 
* Some implementations might check for different things
* IT will not change how the current ones work

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-03-09 09:17:30 +01:00
Roeland Jago Douma
615721df82
Merge pull request #25925 from nextcloud/techdept/psalm/ActionProviderStore 
Pimp ActionProviderStore
 2021-03-08 09:20:45 +01:00
Roeland Jago Douma
f04a2ce19f Pimp ActionProviderStore 
* Fix paradoxale condition
* Add types
* Move away from ILogger

Makes psalm happy, and thus me happy

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-03-04 12:29:49 +01:00
Roeland Jago Douma
7b9ca4f7c2 Add some typing to SharedStorage 
Makes psalm a bit more happy.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-03-04 10:49:42 +01:00
Roeland Jago Douma
5325c3002c
Merge pull request #25917 from nextcloud/techdept/kill_deprecated/ocp_api 
Remove deprecated \OCP\API
 2021-03-03 21:57:34 +01:00
Roeland Jago Douma
cc744740b7 Remove deprecated \OCP\API 
Time to remove this forgood now.
Remaining constant moved over
The world is a tiny bit better

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-03-03 20:54:32 +01:00
Roeland Jago Douma
68ec18323d Fix types in the Group Manager 
Psalm found an issue. However the issue found was because of lying
docblocks. Fixed those and did some typing to make it all better.

For #25839

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-03-03 14:52:47 +01:00
dependabot-preview[bot]
eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0 
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-02-18 13:31:24 +01:00
Joas Schilling
645f83121e
Cache the user backend info for 300s 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-02-15 10:36:08 +01:00
Roeland Jago Douma
24d4c3eeab
Merge pull request #25577 from nextcloud/enhancement/app-code-checker-noop 
Make the app code checker a NOOP
 2021-02-13 15:51:41 +01:00
Christoph Wurst
883848b58a
Micro-optimize validation of empty email addresses 
Then we don't have to construct any validators.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-02-11 15:15:38 +01:00
Christoph Wurst
e618ea83b5
Make the app code checker a NOOP 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-02-11 11:46:02 +01:00
Roeland Jago Douma
d5dea10517
Merge pull request #25378 from nextcloud/bugfix/noid/mention-match-improvements 
Improve mention matches
 2021-02-11 10:33:15 +01:00
Roeland Jago Douma
7bacd710a1
Merge pull request #25460 from nextcloud/fix/apppassword/always_renew 
Always renew apppasswords on login
 2021-02-10 21:09:20 +01:00
Roeland Jago Douma
cd457cc68b Always renew apppasswords on login 
Else you can end up that you renewed your password (LDAP for example).
But they still don't work because you did not use them before you logged
in.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-02-10 19:02:37 +01:00
Christoph Wurst
aabd73912e
Type the service registration 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-02-10 09:44:24 +01:00
Christoph Wurst
abc61a9f63
Fix the legacy dispatcher argument order 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-02-09 10:47:14 +01:00
Joas Schilling
86109f77e0 Fix unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-02-06 13:07:06 +01:00
Christoph Wurst
f6ddda8dad
Test the symfony adapter 
To prevent regression in the future.

And make sure we always return an object …

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-02-05 12:14:47 +01:00
Daniel Kesselberg
b68c3a5836
Add test for dbal exception wrapping 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2021-02-03 19:43:52 +01:00
Arthur Schiwon
d4a45b4cac
test: adjust expectation 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-01-29 19:32:12 +01:00
Arthur Schiwon
558f062ca6
add repair job for unencoded calendars 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-01-29 17:29:10 +01:00
Christoph Wurst
7d9dceb1af
Add negative version comparison test for version suffixes 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-01-27 16:01:26 +01:00
Christoph Wurst
b4f71ccf4d
Fix app fetcher php comparison to allow wider ranges 
When app app specifies php 7.4 as upper limit we have to allow the
installation on php>7.4.0. The previous version check didn't do that.
This adjusts the regexes to discard any irrelevant suffix after the
three version numbers so that we can use more fine granular checks than
php's version_compare can do out of the box, like for php 7.4 we only
compare the major and minor version numbers and ignore the patch level.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-01-26 16:35:43 +01:00
Robin Appelman
e511a539b7
adjust tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-01-26 15:55:38 +01:00
Robin Appelman
5ae0be08b4
fix search in nested jails 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-01-26 15:30:54 +01:00
Robin Appelman
27f9df2e87
fix cachjail searching for root 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-01-26 15:30:50 +01:00
Robin Appelman
a44aab11f7
do cachejail search filtering in sql 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-01-26 15:30:46 +01:00
Christoph Wurst
99d525eb36
Convert 2FA token type to string 
The IConfig service is documented to handle its data as strings, hence
this changes the code a bit to ensure we store keys as string and
convert them back when reading.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-01-22 14:09:37 +01:00
Morris Jobke
d84e1f1951
Re-use fetched dependencies in lib/base.php 
Reduces calls to DI container by reusing already fetched dependencies.

For status.php it went from 355 to 344.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2021-01-20 21:55:16 +01:00
Joas Schilling
90c3013d40
Cleanup the constructor 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-01-18 11:32:50 +01:00
blizzz
f9ab7575e7
Merge pull request #25036 from nextcloud/fix/noid/limitied-allowed-items-db-in_2 
respect DB restrictions on number of arguments in statements and queries
 2021-01-14 11:36:42 +01:00
Roeland Jago Douma
9b58a027e3
Allow installing/updating of apps again 
The Guzzle API changed. We shall now use sink

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-01-12 10:51:41 +01:00
blizzz
7cdc7adf59
Merge pull request #25038 from nextcloud/bugfix/noid/install-mysql8-with-php8 
Don't try a transaction for the migrator on MySQL
 2021-01-11 18:07:11 +01:00
Joas Schilling
2d34ca4143
Only rollback when not MySQL 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-01-11 16:11:02 +01:00
Arthur Schiwon
f9484d15cb
DB: warn on parameter number constraints 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-01-11 13:43:34 +01:00
Christoph Wurst
c3cb288268
Bump scssphp/scssphp from 1.0.3 to 1.4.0 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-01-11 12:41:25 +01:00
Christoph Wurst
f0c6cfde3a
Rollback failed transactions in TestCase.php to not break followup tests 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-01-08 11:45:19 +01:00
Christoph Wurst
8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-01-08 11:45:19 +01:00
Jasper Knockaert
261966ace5
Update EncryptionTest.php 2021-01-05 21:45:50 +01:00
Jasper Knockaert
664e74a82e
2nd attempt to fix tests 2021-01-05 20:41:02 +01:00
Jasper Knockaert
87c640193b
attemtp to fix test 2021-01-05 19:09:16 +01:00
Julius Härtl
98560c80ea
Properly handle result when copying with failure and throw in tests 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-01-05 09:20:35 +01:00
Julius Härtl
ee842f1c43
Fix writeStream mocking 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-01-05 09:20:35 +01:00
Christoph Wurst
b981cb0718
Merge pull request #19942 from ACTom/add-mindmap-icon 
Add mindmap type file icon
 2020-12-28 10:13:38 +01:00
ACTom
d9db6ae84e
Readd test getOnlyDefaultAliases() 
Signed-off-by: ACTom <i@actom.me>
 2020-12-28 13:59:10 +08:00
Maxence Lange
e0bafb7475
deleteChildren only returns array 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2020-12-23 11:00:47 +01:00
Christoph Wurst
f37e150d1c
Merge pull request #24702 from nextcloud/enhancement/well-known-handler-api 
Add well known handlers API
 2020-12-18 13:34:04 +01:00
Christoph Wurst
6995223b1e
Add well known handlers API 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-12-16 13:13:05 +01:00
Arthur Schiwon
d8ad4ef6b5
use a consistent default value for sharing.maxAutocompleteResults 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-12-15 11:53:39 +01:00
Julius Härtl
131fcac91e
Show unique displayname context in the sharing input 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-14 11:14:59 +01:00
Roeland Jago Douma
3c693db0ca
Merge pull request #24605 from nextcloud/enh/share-deck 
Add deck share provider support
 2020-12-10 14:30:08 +01:00
Julius Härtl
a0444bc69c
Merge pull request #24247 from nextcloud/bugfix/noid/ocm-providerId-string 2020-12-09 17:25:59 +01:00
Julius Härtl
85e6cbc87a
Extend dummy factory in tests 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-09 13:20:25 +01:00
Joas Schilling
d04b7cf03d
Skip the test if Imagick is misconfigured 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-12-09 09:07:20 +01:00
Joas Schilling
86a3b7e7bf
Merge pull request #24486 from nextcloud/feature/noid/phone-number-validation 
Phone number validation and search
 2020-12-08 17:05:38 +01:00
Julius Härtl
4f927721b2
Add temporary test for migrating int to string 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-08 16:06:13 +01:00
Roeland Jago Douma
6a7e849090
php cs fix 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-12-07 15:44:04 +01:00
Roeland Jago Douma
c02e6fcae2
fix appconfig tests 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-12-07 15:44:04 +01:00
Roeland Jago Douma
b668850aa1
Fix filesystem tests 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-12-07 15:44:04 +01:00
Roeland Jago Douma
a25b46f494
Make sure we can also run with escapedshell args 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-12-07 15:44:04 +01:00
Roeland Jago Douma
48679ae39f
Make sure we just check for the keys 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-12-07 15:44:03 +01:00
Roeland Jago Douma
d690f90928
Do not run image tests on php8 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-12-07 15:44:03 +01:00
Roeland Jago Douma
1670eabdb3
Do not run on php8 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-12-07 15:44:03 +01:00
Roeland Jago Douma
6b7731a852
Move to new phpunit 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-12-07 15:44:03 +01:00
Roeland Jago Douma
988ce1374c
Don't check on php8 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-12-07 15:44:03 +01:00
Roeland Jago Douma
c084008df2
Avatar fixes 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-12-07 15:44:03 +01:00
Roeland Jago Douma
9317e0f0f0
Fix test traits for phpunit 9 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-12-07 15:44:03 +01:00
Joas Schilling
f0ca76aefb
Add and fix unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-12-07 14:19:38 +01:00
Joas Schilling
da9462b482
Make code strict 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-12-07 14:19:37 +01:00
Morris Jobke
c0a05c0412
Add notification for user limit 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-12-02 15:20:03 +01:00
Morris Jobke
d87705a894
Allow subscription to indicate that a userlimit is reached 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-12-02 15:20:03 +01:00
Morris Jobke
83a75c670b
Replace static call to Share::unshare with ShareManager->deleteShare in tests 
And then cleanup all the code that is dead then...

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-11-30 09:51:18 +01:00
Roeland Jago Douma
2172432420
Merge pull request #23912 from nextcloud/objectstore-copy 
use in objectstore copy
 2020-11-25 16:09:26 +01:00
Robin Appelman
9d4848e863
use in objectstore copy 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-11-24 15:16:58 +01:00
Arthur Schiwon
16a78f535a
set the display name of federated sharees from addressbook 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-11-24 11:30:11 +01:00
Morris Jobke
efe644137d
[encryption] Remove dependency fetching inside the constructor and move them to method call parameters 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-11-22 22:35:02 +01:00
Morris Jobke
1b613c84e9
Merge pull request #24007 from nextcloud/select-distinct-multiple 
allow selecting multiple columns with SELECT DISTINCT
 2020-11-19 22:39:01 +01:00
Roeland Jago Douma
66013f906d
Merge pull request #24189 from nextcloud/enh/csp/frame-ancestors 
Set frame-ancestors to none if none are filled
 2020-11-18 11:29:28 +01:00
Roeland Jago Douma
9163790b7c
Set frame-ancestors to none if none are filled 
frame-ancestors doesn't fall back to default-src. So when we apply a
very restricted CSP we should make sure to set it to 'none' and not
leave it empty.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-11-18 10:13:36 +01:00
Roeland Jago Douma
72a9c35be3
Remove some IRouter methods 
This is not the end. IRouter needs to burn.
But it is a start.

🎵 we didn't start the fire 🎵

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-11-17 14:08:20 +01:00
Robin Appelman
a61a757b85
allow selecting multiple columns with SELECT DISTINCT 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-11-16 15:45:17 +01:00
Daniel Calviño Sánchez
4d3cb1533e Add unit tests for "validateExpirationDateInternal" 
They were copied and adjusted as needed from the tests for
"validateExpirationDate".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-11-16 08:54:19 +01:00
Daniel Calviño Sánchez
baaaacd650 Add explicit time to test date for clarity 
This shows in a clearer way that the expected expiration date is the
original one, but without time.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-11-12 11:57:34 +01:00
Daniel Calviño Sánchez
578b57837a Add unit test for expiration date with date and with default 
This adds back what was being actually tested in the unit test fixed in
the previous commit.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-11-12 11:57:34 +01:00
Daniel Calviño Sánchez
70018ddabf Fix unit test for expiration date without date but with default 
The expiration date was explicitly given, so it was not testing what it
should. Moreover, "link_defaultExpDays" needs to be mapped when testing
the default value (even if it will just fallback to the value of
"shareapi_expire_after_n_days").

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-11-12 11:57:32 +01:00
Daniel Calviño Sánchez
3a53c2b6e5 Fix unit test method name 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-11-12 11:57:31 +01:00
Daniel Calviño Sánchez
e997f0fa46 Fix unit test for verifying enforced valid expiration date. 
The enforced expiration date was not actually enabled, as for that
"shareapi_default_expire_date" needs to be explicitly set to "yes".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-11-12 11:57:31 +01:00
Daniel Calviño Sánchez
8f1fff40e8 Fix unit test for verifying enforced expire date too far in the future 
The test should fail if no exception was thrown, and no exception was
thrown due to a missing configuration parameter. However, the use of
"addToAssertionCount(1)" made the test pass even if no exception was
thrown and, therefore, to silently fail.

Now the missing configuration parameter was added and the test will fail
if the expected exception is not thrown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-11-12 11:57:29 +01:00
Daniel Calviño Sánchez
ec92e82571 Add unit tests to enforce a relaxed default share expiration date 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-11-12 11:57:28 +01:00
Daniel Calviño Sánchez
4dbeab5cff Remove wrong and misleading comment 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-11-12 11:57:26 +01:00
Daniel Calviño Sánchez
72f51422ec Remove extra spaces 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-11-12 11:57:25 +01:00
Daniel Calviño Sánchez
7cfa2701b9 Fix typo in variable name 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-11-12 11:57:23 +01:00
Daniel Calviño Sánchez
c8dc51f0ba Fix typos in method names 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-11-12 11:57:22 +01:00
Morris Jobke
42a033bbc4
Change to full class names for the encryption app DI in preparation of auto-wiring 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-11-11 21:30:45 +01:00
Joas Schilling
0c695d97ec
Fix unique key in test table 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-10 21:39:19 +01:00
Joas Schilling
61c767128c
Skip the insertIfNotExists() tests on Oracle because it doesn't work with clob 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-10 15:34:35 +01:00
Joas Schilling
74c0143001
Easier debugging and spell fix 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-10 15:34:35 +01:00
Joas Schilling
e313777cd6
Use a different column for the primary key as we can not insert it on oracle 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-10 15:34:35 +01:00
Julius Härtl
2050517d44
Add github action for oci8 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-11-10 15:34:35 +01:00
Joas Schilling
8027dcbc6f
Don't leave cursors open when tests fail 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-09 12:28:17 +01:00
Joas Schilling
c07720de77
Use query builder instead of OC_DB in OC\Files\* 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-09 09:05:15 +01:00
John Molakvoæ
d25e5366b8
Merge pull request #23934 from nextcloud/enh/avoid_scss_compile 2020-11-07 10:11:50 +01:00
Morris Jobke
3e6e9186d8
Fix tests to return config default values 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-11-07 10:11:20 +01:00
Morris Jobke
659ea6ad79
Merge pull request #23851 from nextcloud/enh/read_env_only_once 
Read the env variables only once
 2020-11-06 22:35:00 +01:00
Joas Schilling
da1c2bdfe6
Fix repair mimetype step to not leave stray cursors 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-06 10:33:59 +01:00
Roeland Jago Douma
f7a2b71627
Fix tests 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-11-06 09:37:45 +01:00
Joas Schilling
ede7510854
Add a function to get the unread count for multiple objects in one go 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-04 11:01:21 +01:00
Morris Jobke
8d02ee9ac7
Merge pull request #21693 from nextcloud/fix/noid/import-certificates-only-by-system 
Improve CertificateManager to not be user context dependent
 2020-11-03 21:48:37 +01:00
Morris Jobke
f03bb4716b
Remove OCSResponse type hint - see #23827 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-11-03 10:43:32 +01:00
Morris Jobke
dc479aae2d
Improve CertificateManager to not be user context dependent 
* removes the ability for users to import their own certificates (for external storage)
* reliably returns the same certificate bundles system wide (and not depending on the user context and available sessions)

The user specific certificates were broken in some cases anyways, as they are only loaded if the specific user is logged in and thus causing unexpected behavior for background jobs and other non-user triggered code paths.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-11-03 00:13:01 +01:00
Roeland Jago Douma
fa6a790859
Remove deprecated OCSResponse 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-11-01 14:12:27 +01:00
Robin Appelman
de7026f6e4
use file name instead of path in 'not allowed to share' message 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-10-29 16:43:21 +01:00
Morris Jobke
7ed11b6dfa
Merge pull request #23765 from nextcloud/techdebt/noid/sudadmin-events-into-typed-events 
Add typed events for adding and removing a subadmin
 2020-10-29 11:18:01 +01:00
Morris Jobke
765ee60eea
Change tests to typed event listener 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-10-28 23:10:23 +01:00
Morris Jobke
6e35457fcc
Remove unused private ForwardEmitter and LegacyEmitter 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-10-28 22:23:39 +01:00
Morris Jobke
e4f53ff91b
Add typed events for adding and removing a subadmin 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-10-28 21:55:08 +01:00
Roeland Jago Douma
cf1af5b83b
Merge pull request #23496 from lynn-stephenson/fix/related-key-issue 
Fixes related key issue.
 2020-10-27 20:23:07 +01:00
Joas Schilling
1f1244fdcc
Fix PHP CS 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-10-22 11:00:54 +02:00
Joas Schilling
8600e51df5
Fix manager creation and testing 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-10-22 10:54:03 +02:00
John Molakvoæ
766590d204
Merge pull request #23173 from nextcloud/feat/comments-sidebar-vue 2020-10-20 20:46:21 +02:00
John Molakvoæ (skjnldsv)
6cd7549509
Bump @nextcloud/vue to 3.0.0 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-10-20 18:02:45 +02:00
Joas Schilling
4bc821edd9
PSR logger for accounts 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-10-20 17:41:47 +02:00