Commit graph

13098 commits

Author SHA1 Message Date
Arthur Schiwon
96eca4a3ea fix(ci): update return type in php doc
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-10-11 14:41:43 +02:00
Robin Appelman
29c36f85b0 fix type hints
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-10-11 14:41:43 +02:00
Robin Appelman
0fde240089 fix unencrypted folder size when no children with unencrypted size set are left
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-10-11 14:41:43 +02:00
Robin Appelman
ed6606e86b fix unencrypted_size for files when scanning
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-10-11 14:41:43 +02:00
Robin Appelman
1a70ba6421 fix unencrypted_size for folders when scanning the filesystem with encryption enabled
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-10-11 14:41:43 +02:00
Arthur Schiwon
2fc6a6751a
Merge pull request #38815 from nextcloud/backport/38490/stable26
[stable26] emit an event when a message is logged
2023-10-11 12:10:38 +02:00
Maxence Lange
76340f7ea8
Merge pull request #40781 from nextcloud/backport/40745/stable26
[stable26] fix ocm-provider rewrite rules
2023-10-11 07:25:41 -01:00
Christoph Wurst
a5241ba93e fix: Log critical session renewal and logout paths
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-10-10 10:06:00 +00:00
Arthur Schiwon
582b42bb8e
Merge pull request #40351 from nextcloud/backport/40349/stable26
[stable26] fix(autoloader): no apcu no side effects
2023-10-09 22:55:00 +02:00
Christoph Wurst
02e27b8db6 fix(user): Log affected user of app token login name mismatch
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-10-06 08:32:46 +00:00
Maxence Lange
2f78b6e58b fix ocm-provider rewrite rules
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-10-05 08:56:08 +00:00
jld3103
ab2c222c12
Fix Dashboard IManager getWidgets return annotation
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-09-29 09:01:21 +02:00
Maxence Lange
1bd9d9143b ocm services
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-09-22 19:46:42 -01:00
Joas Schilling
e772fe68a4 fix(comments): Use provided offset in best effort when loading comments
When we didn't find the "$lastKnownComment" the whole condition was ignored.
Now we still use the ID as an offset.
This is required as a fall-back for expired messages in Talk
and deleted comments in other apps.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-09-19 14:06:12 +00:00
Robin Appelman
c1452aa6bd emit an event when a message is logged
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-09-18 16:33:30 +02:00
Côme Chilliet
49d52dd33a Use nullsafe call syntax instead of additionnal check
Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2023-09-18 10:38:23 +00:00
Côme Chilliet
f0c3cbeeae Set files_sharing:hide_disabled_user_shares to 'yes' to hide shares from disabled users
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-18 10:38:22 +00:00
Julius Härtl
81f3ed25f0
fix: Only read unencrypted_size when file is actually encrypted
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-09-12 15:06:01 +02:00
Julius Härtl
6a5dc8ce06
fix: Only store unencrypted_size if path should be encrypted
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-09-12 15:06:01 +02:00
Arthur Schiwon
e4fbb49f38 fix(autoloader): no apcu no side effects
apcu lead to side effects especially with app management and (soft)
inter-dependencies, and lead also to 500 server errors. While we could
add management to clear apcu cache in many cases (may stil leave edge
cases) the performance benefit is marginally as also class maps are
already cached in opcache. Hence, the simple and effective way to go is
to not use apcu for autoloading.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-09-08 18:56:19 +00:00
Côme Chilliet
5434b35ac7
Merge pull request #40280 from nextcloud/backport/40233/stable26
[stable26] Detect aborted connection in OC\Files\View and stop writing data to the output buffer
2023-09-07 09:31:44 +02:00
Joas Schilling
a1cb0b4460 fix(ratelimit): Only use memory cache backend for redis
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-09-06 18:09:54 +02:00
max-nextcloud
dc73199e2f
Merge pull request #39991 from nextcloud/backport/39770/stable26
[stable26] fix: always use display name from correct backend
2023-09-06 13:26:42 +02:00
Arthur Schiwon
d5f6249b76
Merge pull request #40167 from nextcloud/backport/40108/stable26
[stable26] feat: add switch to disable dns pinning
2023-09-06 10:34:48 +02:00
Arthur Schiwon
4230aa8dd3
Merge pull request #40085 from nextcloud/backport/40077/stable26
[stable26] fix(cache): Remove displayname cache entry on delete
2023-09-05 19:11:28 +02:00
Côme Chilliet
342cb33f71 Apply suggestions from code review in View.php
Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-05 17:06:11 +00:00
Côme Chilliet
ea2b28e1fc Lower log to debug for connections aborted by the client
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-05 17:06:11 +00:00
Côme Chilliet
b7d82f7c01 Detect aborted connection in OC\Files\View and stop writing data to the
output buffer

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-05 17:06:10 +00:00
Arthur Schiwon
1c29d87f48
Merge pull request #40232 from nextcloud/sharing-mask-wrapper-26
[26] move share permission logic to storage wrapper
2023-09-05 19:04:41 +02:00
Arthur Schiwon
f755b50a6b
Merge pull request #40187 from nextcloud/backport/39017/stable26
[stable26] fix(s3): fix handling verify_bucket_exists parameter
2023-09-05 19:00:40 +02:00
Arthur Schiwon
f7d890cd66
Merge pull request #39726 from nextcloud/backport/39698/stable26
[stable26] Catch more invalid cache source storage paths
2023-09-05 18:59:48 +02:00
Daniel
02e009867b
Merge pull request #40260 from nextcloud/backport/40234/stable26 2023-09-05 09:52:35 +02:00
Daniel Kesselberg
c2a2416e0c enh: skip processing for empty response
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-09-04 20:17:17 +00:00
Robin Appelman
065f636cb7
cleanup di for share permissions wrapper
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-09-04 14:21:19 +02:00
Robin Appelman
1340133526
more share permission logic to storage wrapper
this way we only have to determine the share permissions once

Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-09-04 14:21:11 +02:00
John Molakvoæ
c3f146b965 fix: prevent sharing permissions on user root folder
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-09-04 09:19:44 +00:00
Thomas Citharel
7deef46668 fix(s3): fix handling verify_bucket_exists parameter
If 'verify_bucket_exists' is set to false in the config.php s3 configuration, it's supposed to avoid
verifying that the bucket exists. However empty(falsy) will  always return true, so this condition
would not work.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2023-08-31 21:33:05 +00:00
Daniel Kesselberg
652a8a8f7a
feat: add switch to disable dns pinning
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-08-30 22:21:55 +02:00
Anna Larch
651405a320 fix(CalDAV): check voject exists before attempting any operation
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-08-29 08:18:30 +00:00
Joas Schilling
61e61fb9c3
fix(cache): Remove displayname cache entry on delete
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-29 08:53:09 +02:00
Andy Scherzinger
f3619d8558
Merge pull request #39872 from nextcloud/backport/38714/stable26
[stable26] select the fileid first when looking for incomplete files
2023-08-28 13:44:48 +02:00
Côme Chilliet
36f9ca2218 fix(loggging): user log condition feature
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-08-24 15:04:54 +02:00
Max
aa709291cf
fix: always use display name from correct backend
Overwrite the display name after the account is initialized
when using an instacne of IGetDisplayNameBackend.

Before when using a variation of user_oidc and registering
a Backend.php implementing IGetDisplayNameBackend
the personal setting page shows 'uid'.

The UserManager/AccountManager seems not to use consistently
the correct backend.

The correct backend is used in this sequence:

server/lib/private/TemplateLayout.php

          $userDisplayName = \OC_User::getDisplayName();
          $this->assign(user_displayname, $userDisplayName);

In the settings page, it definitely not calls the registered backend,
but seems to fall back to default Backend and shows (usually) uid
or a value from the standard account property table.

Signed-off-by: Max <max@nextcloud.com>
2023-08-22 09:47:51 +02:00
Anna
fcaa6760af
Merge pull request #39935 from nextcloud/fix/stable26/transfer-ownership
[stable26] fix: don't emit Hooks when hookpaths are empty
2023-08-21 09:06:18 +02:00
Joas Schilling
361d8f2742 fix(memcache): Fix comparison of Memcache configs to classes
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-17 21:48:23 +00:00
Anna Larch
fe26271c78 fix: don't emit Hooks when hookpaths are empty
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-08-17 15:00:49 +02:00
Ferdinand Thiessen
15ea32c1e1 fix: Prevent PHP warnings when optional CacheEntry attributes are unset
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-08-17 10:03:53 +00:00
Robin Appelman
690d9bac5e select the fileid first when looking for incomplete files
this seems to improve mariadbs index selection

Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-08-14 19:15:41 +00:00
John Molakvoæ
fe85d7d05d fix: simplify sourceData check
Co-authored-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2023-08-05 22:04:35 +00:00
Josh Richards
c4505160a0 Catch more invalid cache source storage paths
OC\Files\Cache\Cache::get can return string|false|null, not just string|false.

- nextcloud/server#26270 added handling of false, but null is needed too.
- Well, or we change the default $resullt to false, but I'm not sure if that has other ramifications and the real need here is to simply catch situations where the cache source storage path is not valid for whatever reason

Related: nextcloud/server#19009

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2023-08-05 22:04:35 +00:00