Commit graph

2150 commits

Author SHA1 Message Date
skjnldsv
14c1b53b56 fix(dav): also return shared-with-me shares data
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-06-12 13:23:39 +02:00
Richard Steinmetz
051d94117f fix(caldav): event links in shared calendar notifications
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-06-11 18:42:56 +00:00
Joas Schilling
c57df2777a fix(dav): Don't log access control as error
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-06-10 11:57:00 +00:00
Hamza Mahjoubi
aafab6987b fix(dav): Rate limit address book creation
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2024-06-07 12:14:42 +02:00
Christoph Wurst
402bb77753
fix(dav): Add retention time to sync token cleanup
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-06-04 19:07:01 +02:00
Anna Larch
fc33ee0527 fix(CalDAV): remove UNKNOWN from room / resource consideration
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-06-04 12:32:09 +02:00
Anna
13c4787193
Merge pull request #45640 from nextcloud/backport/45235/stable28
[stable28] fix(caldav): automatically delete outdated scheduling objects
2024-06-04 12:08:33 +02:00
Anna Larch
57f7f0278e fix(caldav): automatically delete outdated scheduling objects
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-06-03 17:31:03 +02:00
Daniel Kesselberg
0d920c87d4 feat(caldav): order the calendar objects by start date for search
Sorting the events by the start date leads to more predictable results for the search API consumers.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-06-03 12:18:19 +02:00
Daniel Kesselberg
4be308ab26 fix(caldav): event search with limit and timerange
Event recurrences are evaluated at runtime because the database only knows the first and last occurrence.

Given, a user created 8 events with a yearly reoccurrence and two for events tomorrow.
The upcoming event widget asks the CalDAV backend for 7 events within the next 14 days.

If limit 7 is applied to the SQL query, we find the 7 events with a yearly reoccurrence and discard the events after evaluating the reoccurrence rules because they are not due within the next 14 days and end up with an empty result even if there are two events to show.

The workaround for search requests with a limit and time range is asking for more row than requested and retrying if we have not reached the limit.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-06-03 12:18:19 +02:00
Daniel
06c01c568d
Merge pull request #44197 from nextcloud/backport/44130/stable28
[stable28] fix(dav): Add occ command to fix missing caldav sync tokens
2024-06-03 11:16:24 +02:00
Daniel Kesselberg
951a679788 feat(caldav): expose calendar subscriptions
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-05-31 17:58:45 +02:00
Christoph Wurst
8dd067a763
fix(dav): Add occ command to fix missing caldav sync tokens
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-05-31 14:41:38 +02:00
Anna Larch
5188f08fad fix(userstatus): catch unique constrain violation on revert
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-05-28 17:44:27 -04:00
Anna Larch
19f95cd10d fix(caldav): loop through all events for busy events
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-05-14 13:34:01 +00:00
Joas Schilling
f294ea13a8 fix(DAV): Migrate known exceptions to Sabre exceptions when copying
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-04-24 16:31:29 +00:00
Benjamin Gaussorgues
8d91e071d7
Merge pull request #44473 from nextcloud/backport/44017/stable28 2024-04-17 11:24:12 +02:00
Côme Chilliet
85491ff1e8 fix(dav): Fix quota check for chunk upload
Do not ignore OC-Total-Length when Content-Length and
 X-Expected-Entity-Length are missing

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-04 12:49:28 +00:00
Robert C. Schaller
823a07bb1d fix(dav): wrong comparison method between two events
Old comparison implementation compares each element of the array against each other with no respect for the associated array label, which leads to wrongful removals because one value is accidentally present in a completely different label. New comparison works 'by-label' individually.

Partly fixes #41084 because changes between 'SEQUENCE' not present, 'SEQUENCE:0' and 'SEQUENCE:1' were not detected in the old implementation and thus no email update sent.

Co-authored-by: Christoph Wurst <ChristophWurst@users.noreply.github.com>
Signed-off-by: Robert C. Schaller <gtbc_robert.schaller@rsxc.de>
2024-03-26 08:49:34 +00:00
Andy Scherzinger
1b237b19f1
Merge pull request #44386 from nextcloud/backport/44360/stable28
[stable28] fix(caldav): add EXDATE and EXRULE to confidential object
2024-03-21 16:35:28 +01:00
Andy Scherzinger
fb3d58d4a5
Merge pull request #44377 from nextcloud/backport/44376/stable28
[stable28] fix(dav): ACLs for shared addressbooks
2024-03-21 15:55:23 +01:00
Anna Larch
2e0eb60177 fix(caldav): add EXDATE and EXRULE to confidential object
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-03-21 13:39:49 +00:00
Christoph Wurst
e6df2a4981
fix(dav): ACLs for shared addressbooks
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-03-21 11:56:42 +01:00
Côme Chilliet
7f50e5f2d8 chore: Break closure call on two lines to make it readable
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-19 09:08:00 +00:00
Côme Chilliet
52aa280735 fix(systemtags): Forbid tagging of readonly files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-19 09:08:00 +00:00
Julius Härtl
0bc8908666 fix: Use proper path when trying to check if a file needs to get copied
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-03-12 17:57:30 +01:00
John Molakvoæ
e9e027a9e2
Merge pull request #43796 from nextcloud/backport/42459/stable28 2024-02-29 11:34:48 +01:00
John Molakvoæ
ac6fe28da4
Merge pull request #43800 from nextcloud/backport/39553/stable28
[stable28] Bug fix: Select the correct table based on CALENDAR_TYPE_CALENDAR
2024-02-29 11:31:16 +01:00
Louis Chemineau
427508bac0 fix(dav): Init ViewOnlyPlugin after auth
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-02-28 10:17:39 +01:00
Patrick Fischer
76560a51b6 Bug fix: Select the correct table based on CALENDAR_TYPE_CALENDAR
Signed-off-by: Patrick Fischer <mail@patrickfischer.ch>
2024-02-23 20:46:07 +00:00
MichaIng
54f47f53a8 fix(dav): fallback realm for HTTP authentication
By default, the name of the Nextcloud instance is an empty string, until changed by the admin. This leads to an empty realm sent with the WWW-Authenticate header, while the realm is mandatory for Basic HTTP authentication. Some clients have issues with an empty realm, e.g. Thunderbird cannot store passwords in this case.

This commit applies "Nextcloud" as fallback for the realm, in case the name of the Nextcloud instance is not set.

Solves: https://help.nextcloud.com/t/thunderbird-dont-save-caldav-password-because-of-missing-httprealm-or-formsubmiturl/93233

Signed-off-by: MichaIng <micha@dietpi.com>
2024-02-23 20:29:43 +00:00
Christoph Wurst
c7ddc5fd54 fix(dav): Rate limit calendar/subscription creation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-02-22 15:16:09 +01:00
Louis Chemineau
0e07be4b88 Check share attributes when downloading versions
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-02-21 21:49:23 +01:00
Richard Steinmetz
4adda64d4e perf: skip request without read permission
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-02-21 12:46:33 +00:00
John Molakvoæ
647b8746b0 fix(files): add mount root property and adjust delete wording
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-02-06 20:50:47 +00:00
Thomas Citharel
020c2960b8 fix(caldav): only call getTimestamp() on actual DateTime data
For some reason the value of $component['DTSTART'][0] may not be a DateTimeImmutable

Closes #42464

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2024-02-03 14:24:09 +01:00
Joas Schilling
aa24c671dc fix(userstatus): Also set the user status when the user has no status at all
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-25 10:10:41 +00:00
Anna Larch
a3095303d5 fix(userstatus): CALL status should overwrite MEETING status
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-01-25 10:10:41 +00:00
provokateurin
98d64ea05d refactor: Migrate IgnoreOpenAPI attributes to OpenAPI
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-01-19 09:12:34 +01:00
Johannes Merkel
a509c85662
fix(CalDAV): set acls for DeletedCalendarObjectsCollection
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
2024-01-18 08:39:24 +01:00
John Molakvoæ
e5f4eb487d
fix(files): better upload error handling
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-01-16 10:27:38 +01:00
Joas Schilling
ac3f3a0629
fix(dav): Fix user status "Undefined array key 0 at StatusService.php#98"
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-15 09:15:25 +01:00
Richard Steinmetz
f38ce5c1d5
fix(dav): allow multiple organizers if possible
This is very hacky! However, we want to allow saving events with multiple
organizers. Those events are not RFC compliant, but sometimes imported from major
external calendar services (e.g. Google). If the current user is not an organizer of
the event we ignore the exception as no scheduling messages will be sent anyway.

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-01-02 11:54:08 +01:00
jld3103
4da91f56e4 fix(dav): Hide less than minute diff in calendar notification title
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-12-20 21:22:55 +00:00
Anna Larch
5fd10dc398 fix(userstatus): set user status to 'In a meeting' if calendar is busy
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-12-19 15:47:29 +00:00
Louis Chemineau
8cb5d47341 Use FileInfo's metadata for hidden prop
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-12-19 13:31:46 +00:00
Joas Schilling
1a45dd0b8c
Merge pull request #42351 from nextcloud/backport/42304/stable28
[stable28] fix(ooo): add new ooo status with new emoji
2023-12-19 09:05:33 +01:00
Louis Chemineau
112063bb5e Don't query oc_properties for metadata props
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-12-18 15:20:49 +00:00
Anna Larch
deb4bef923 fix(ooo): add new ooo status with new emoji
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-12-18 12:06:57 +00:00
Joas Schilling
261de22ce9
Merge pull request #42152 from nextcloud/backport/42144/stable28
[stable28] fix(caldav): don't reuse query builder objects
2023-12-15 15:11:59 +01:00