upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-24 15:53:36 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 11
77738 commits 867 branches 1197 tags 8.3 GiB
Commit graph

1701 commits

Author SHA1 Message Date
Ferdinand Thiessen
c84c256261
fix: Adjust preview for view-only shares 
Previously there was a different behavior for public shares (link-shares) and internal shares,
if the user disabled the view permission.
The legacy UI for public shares simply "disabled" the context menu and hided all download actions.
With Nextcloud 31 all share types use the consistent permissions attributes,
which simplifies code, but caused a regression: Images can no longer been viewed.

Because on 30 and before the attribute was not set, previews for view-only files
were still allowed. Now with 31 we need a new way to allow "viewing" shares.

So this is allowing previews for those files, but only for internal usage.
This is done by settin a special header, which only works with custom requests,
and not by opening the URL directly.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-28 15:52:27 +01:00
Kate
8b5e1bac90
Merge pull request #48918 from nextcloud/fix/files_sharing/cleanup-error-messages 2024-10-28 12:47:12 +01:00
Kate
5efb175665
Merge pull request #48614 from nextcloud/refactor/storage/constructors 2024-10-28 10:19:41 +01:00
provokateurin
aacb3ddc1e
fix(files_sharing): Cleanup error messages 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-28 09:07:41 +01:00
fenn-cs
227b8462d8 refactor(ShareApiController): Check for null and empty strings with empty() 
Proactive measure to avoid warnings in higher php versions as well possible type errors

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-10-24 18:37:42 +01:00
fenn-cs
e2d2a17810 fix(ShareAPI): Send mails for mail shares by default 
It looks like, the frontend it needs to provide the `sendMail` param
for the backend to decide wether mails would be sent.

Our UI does not have that at the moment so it should default to sending
emails always for mail shares.

Not exactly sure how this was handled earlier but this is a good starting point.

Resolves : https://github.com/nextcloud/server/issues/48012

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-10-24 14:41:07 +01:00
provokateurin
0de4843b73 refactor(Storage): Align all Storage constructors 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-23 13:24:18 +02:00
provokateurin
381077028a
refactor(apps): Use constructor property promotion when possible 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-21 12:37:59 +02:00
Joas Schilling
5262bc6be3
fix(activity): Fix download activity parameters 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-10-19 22:50:44 +02:00
dependabot[bot]
bb598c8451
chore(deps): Bump nextcloud/coding-standard in /vendor-bin/cs-fixer 
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 1.3.1 to 1.3.2.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v1.3.1...v1.3.2)

---
updated-dependencies:
- dependency-name: nextcloud/coding-standard
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-19 07:57:35 +02:00
Git'Fellow
a1681b0756 chore(db): Apply query prepared statements 
Fix: psalm

fix: bad file

fix: bug

chore: add batch

chore: add batch

chore: add batch

fix: psalm
 2024-10-17 20:30:47 +02:00
Git'Fellow
c254855222 chore(db): Correctly apply query types 
fix: psalm

fix: error

fix: add batch

fix: fatal error

fix: add batch

chore: add batch

chore: add batch

fix: psalm

fix: typo

fix: psalm

fix: return bool

fix: revert Manager
 2024-10-17 09:21:07 +02:00
Côme Chilliet
1580c8612b
chore(apps): Apply new rector configuration to autouse classes 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-10-15 10:40:25 +02:00
Ferdinand Thiessen
64dd4ce0ee
revert: "fix(files_sharing): Make share labels nullable" 
This reverts commit 01c4fa3ba8.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-14 15:16:25 +02:00
Kate
614d8c23a0
Merge pull request #48494 from nextcloud/refactor/storage/strong-param-types 2024-10-08 15:20:17 +02:00
provokateurin
54ec472d9a
fix(BackgroundJobs): Adjust intervals and time sensitivities 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-08 11:26:53 +02:00
provokateurin
1642a34e8a
refactor(files_sharing): Add Storage parameter strong types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-07 15:00:07 +02:00
Ferdinand Thiessen
e9d590674d
feat(files_sharing): Make ShareController download route use the DAV ZipFolderPlugin 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-28 13:18:34 +02:00
provokateurin
376d5665bb
fix(files_sharing): Fix all IStorage return types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-26 17:29:47 +02:00
provokateurin
13d1cb730f
fix(files_sharing): Check if propfind response is valid before accessing share permission props 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-26 14:35:31 +02:00
provokateurin
5d4a358cc4
refactor(files_sharing): Make permissions prop checks less error prone 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-26 14:34:44 +02:00
provokateurin
adc38a7248
fix(files_sharing): Parse OCM share permissions from OCM and not OCS prop 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-26 09:38:41 +02:00
Côme Chilliet
8927510685
Merge pull request #48223 from nextcloud/feat/add-rector-config 
Add rector config
 2024-09-23 15:10:30 +02:00
Côme Chilliet
1a4978c4ea
chore: Apply rector configuration to apps folder 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-20 17:51:00 +02:00
Ferdinand Thiessen
4c067fcbae
chore(files): Remove legacy style files 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-20 13:46:46 +02:00
Ferdinand Thiessen
e243cb8b7d
chore: Remove deprecated Share_Helper::generateTarget $exclude parameter 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-20 00:51:00 +02:00
Julius Härtl
232c22fcd1 fix(federation): Do not overwrite certificate bundle 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-09-20 00:13:00 +02:00
provokateurin
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-19 14:21:20 +02:00
Robin Appelman
0bdd25eb0f fix: add sharding compatible version of share reminder job 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-09-19 11:59:46 +02:00
Robin Appelman
b45f2420fe fix: fix share reminder job for oracle 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-09-18 19:24:44 +02:00
Anna Larch
1ce46c1fca refactor: move to new activity exception 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2024-09-17 12:06:24 +02:00
provokateurin
d2d1e3284d
fix(Storage): Fix method docs inheritance 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-17 10:20:38 +02:00
provokateurin
8ca6fcace7
fix(Storage): Document getOwner() can return false 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-17 10:10:50 +02:00
Côme Chilliet
492e6997d8
chore: Fix psalm issues, put back private versions of getter in private Storage interface 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-16 18:11:38 +02:00
Côme Chilliet
22822d5e9b
fix: Fix other uses of removed Storage interface 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-16 18:11:36 +02:00
Christoph Wurst
c57e684e7b
fix: Handle null checks with the ?? operator 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2024-09-15 21:50:11 +02:00
Christoph Wurst
614f9ec0a2
refactor: Use the elvis operator 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2024-09-15 21:01:34 +02:00
John Molakvoæ
2b5dd11d97
Merge pull request #47339 from nextcloud/fix/leave-share-instead-of-delete 
fix: Display 'Leave share' instead of 'Delete'
 2024-09-11 13:42:15 +02:00
skjnldsv
bb37954abb fix(files_sharing): adjust permissions from custom edit and delete check methods 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-09-11 13:17:42 +02:00
provokateurin
f7246a9b7a
fix(INotification): Restrict rich object parameters type 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-10 16:37:42 +02:00
Jonas
0e4438fc04
Merge pull request #47841 from nextcloud/fix/files-sharing-openfile 
fix(files_sharing): Open single-file-share by default
 2024-09-09 16:44:15 +02:00
Ferdinand Thiessen
fccb132e2b fix(files_sharing): Open single-file-share by default 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-09 14:49:21 +02:00
Ferdinand Thiessen
1ea902a195
chore(files_sharing): Add migration attribute for share.reminder_sent column 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-06 14:46:33 +02:00
Marcel Klehr
c43353d6e6 fix: Display 'Leave share' instead of 'Delete' 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2024-09-06 13:50:52 +02:00
Ferdinand Thiessen
1d16bc47ff
fix(files_sharing): Handle download permission the same way for public and internal shares 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
e93ceea804
fix(files): Do not allow copy action on public shares without create permission 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-06 03:38:47 +02:00
Ferdinand Thiessen
96c8275586
feat(files_sharing): Migrate public share to use Vue files list 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-06 03:38:42 +02:00
Anna Larch
8af7ecb257 chore: adjust code to adhere to coding standard 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2024-09-05 21:23:38 +02:00
John Molakvoæ
f9fcc5b170
Merge pull request #47412 from Luka-sama/feat/shares-reminder 2024-09-03 17:24:02 +02:00
Stefan Cherniakov
2685501231 fix(files_sharing): Add check for null 
Signed-off-by: Stefan Cherniakov <luka-sama@pm.me>
 2024-09-03 17:23:31 +02:00