Commit graph

12210 commits

Author SHA1 Message Date
Vincent Petry
bea755f153
Merge pull request #32723 from MartinBrugnara/master
Expose umask override value as config parameter: localstorage.umask
2022-06-10 11:23:31 +02:00
Vincent Petry
56b1453945
Merge pull request #32768 from nextcloud/fs-setup-onetime-earlier
perform onetime setup earlier to ensure wrappers are registered on time
2022-06-10 11:21:54 +02:00
Robin Appelman
5c768f980e
fix mounts mounted at the users home
this fixes external storages with '/' as mountpoint

Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-06-09 19:21:56 +02:00
Julius Härtl
42f92153f5
Merge pull request #32767 from nextcloud/seeakble-http-stream-wrappers
handle stream wrappers in SeekableHttpStream
2022-06-09 09:49:55 +02:00
Pytal
e76d8bb901
Merge pull request #32697 from nextcloud/fix/get-avatar-authz 2022-06-08 16:27:31 -07:00
Robin Appelman
a937ab03dd
perform onetime setup earlier to ensure wrappers are registered on time
this fixes an issue with wrappers like encryption not always being applied to mountpoint that create the storage object directly (such as external storage)

Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-06-08 18:49:54 +02:00
Robin Appelman
499995b37a
handle stream wrappers in SeekableHttpStream
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-06-08 17:52:27 +02:00
Joas Schilling
9a8c9e5cf6
Merge pull request #32744 from nextcloud/bugfix/noid/easier-federation-debugging
Always log errors from sending federation api requests to ease debugging
2022-06-08 10:16:51 +02:00
Christopher Ng
7455cd9dd7 Fix get avatar authorization
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-06-07 23:57:21 +00:00
Joas Schilling
1cc2796613
Always log errors from sending federation api requests to ease debugging
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-06-07 22:01:32 +02:00
Julius Härtl
50ed84fe17
Simlify tests for integrity check on modified mimetype lists
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-06-07 21:54:27 +02:00
Luka Trovic
0858d3d514
feat: add docxf and form mimetypes
signed-off-by: Luka Trovic <luka@nextcloud.com>
2022-06-07 21:54:27 +02:00
Martin Brugnara
7409569994
Expose umask override value as config parameter: localstorage.umask
Commit 451c06d introduced override for umask value.
This is needed to avoid broken env configuration or dirty workers
to mess with the permissions when creating new files.

Most Nextcloud, that does not integrate with external software
would work fine with an hard-coded value (451c06d set it at 022).

Advanced install may require more flexibility, as such this commit
exposes the "umask override value" as configuration parameter:
`localstorage.umask`

It defaults to 0022 both in code and in config/config.sample.php .

Signed-off-by: Martin Brugnara <martin@0x6d62.eu>
2022-06-05 19:19:31 +02:00
Joas Schilling
6d5d91f6f9
Merge pull request #32556 from nextcloud/bugfix/noid/fix-comments-query-handling
Create query parameters on correct objects to make debugging easier
2022-06-03 15:31:40 +02:00
Julius Härtl
0f0e74a78c Cleanup temporary files after finishing the write to object storage
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-06-02 12:57:18 +00:00
blizzz
1d1b9d936b
Merge pull request #32690 from nextcloud/bugfix/noid/fix-mountpoint-matching-encryption
Trim mount point before matching in encryption code
2022-06-02 13:47:18 +02:00
Christopher Ng
57c66bf7cb Use Image class from public API
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-06-02 00:37:36 +00:00
Vincent Petry
a704bcf97f
Trim mount point before matching in encryption code
Often times the mount point has a leading slash.
This fix sanitizes it to make sure matching works.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-06-01 18:10:59 +02:00
Christoph Wurst
b17c4a6072 Check background job type
It is assumed that a job class loaded from the jobs table is an IJob,
but due to programming error the job might be of another type. Then the
setters will most likely fail.

This patch adds an interface type check so only correct jobs are used,
anything else is ignored.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-05-31 15:24:30 +00:00
blizzz
df89e7fd39
Merge pull request #32485 from nextcloud/debt/noid/psalm-streamer-fh
[Psalm] Fix docblock for addFileFromStream
2022-05-31 14:22:05 +02:00
Joas Schilling
279e06a80f
Merge pull request #32587 from nextcloud/bugfix/noid/improve-jsconfighelper
Improve JSConfigHelper code quality a bit
2022-05-31 10:29:30 +02:00
Côme Chilliet
7140201a32
Merge pull request #32634 from nextcloud/debt/noid/psalm-moveable-mount
[Psalm] Fix docblock for return type
2022-05-30 17:05:50 +02:00
Carl Schwan
1164c762eb
Merge pull request #31948 from nextcloud/core-cleanup-74
Update core to PHP 7.4 standard
2022-05-30 14:37:37 +02:00
Carl Schwan
e86bcc8953
Merge pull request #32655 from nextcloud/fix/handle-non-existing-settings
Handle non existing settings again
2022-05-30 12:53:36 +02:00
Joas Schilling
f9efc410fa
Restore old behaviour of sending flase for not found apps
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-30 12:41:35 +02:00
Joas Schilling
eb1a69d627
Improve JSConfigHelper code quality a bit
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-30 12:33:45 +02:00
Carl Schwan
63f589109b Handle non existing settings again
See https://github.com/nextcloud/server/pull/28189#issuecomment-1140874991

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-30 11:06:55 +02:00
Daniel Kesselberg
f399fd41ec
Fix docblock for return type
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-05-27 20:05:46 +02:00
Carl Schwan
e4378fd18c
Merge pull request #32349 from nextcloud/enh/projects-event
Add event to load additional scripts for projects
2022-05-27 18:36:40 +02:00
Julius Härtl
ac79137816
Merge pull request #32592 from nextcloud/fix/noid/allow-rememberme-token-apache-auth-backend
allow use of rememberme cookies for IApacheAuth backends
2022-05-27 17:21:08 +02:00
Git'Fellow
8d876358dd
Move Gd failed operations to debug level
Instead of error
2022-05-25 18:26:42 +02:00
Arthur Schiwon
a4a9e7601a
allow use of rememberme cookies for IApacheAuth backends
- e.g. enables it for SAML backend

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-05-25 13:09:06 +02:00
Daniel Kesselberg
95ec67ecd7
Fix docblock for addFileFromStream
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-05-24 22:05:59 +02:00
Joas Schilling
5b82ad0b30
Create query parameters on correct objects to make debugging easier
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-23 13:02:36 +02:00
Carl Schwan
8d599c3410
Merge pull request #32378 from nextcloud/fix/psalm-userbackend
Fix psalm issues related to the user backend
2022-05-23 11:41:21 +02:00
Carl Schwan
b70c6a128f Update core to PHP 7.4 standard
- Typed properties
- Port to LoggerInterface

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-20 22:18:06 +02:00
Carl Schwan
d90583ca28
Merge pull request #32486 from nextcloud/debt/noid/psalm-username
[Psalm] Rename $userName to $username  to align with child classes
2022-05-20 18:19:53 +02:00
Carl Schwan
9ec0cb0a90 Fix psalm issues related to the user backend
- Reflect the actual return value returned by the implementation in the
  the interface. E.g. IUser|bool -> IUser|false
- Remove $hasLoggedIn parameter from private countUser implementation.
  Replace the two call with the equivalent countSeenUser
- getBackend is nuallable, add this to the interface
- Use backend interface to make psalm happy about call to undefined
  methods. Also helps with getting rid at some point of the old
  implementActions

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-20 17:14:58 +02:00
John Molakvoæ
87ce03db1a
Merge pull request #32410 from nextcloud/bugfix/noid/imaginary-exception 2022-05-20 08:14:17 +02:00
Carl Schwan
a5a4e0df1c Fix crop condition
Make sure that when fetching the image from the cache we don't
accidentally fetch the cropped image just because it also start with
256-256

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-19 17:25:32 +02:00
Julius Härtl
3742b7392d Add explicit return if getSmallImagePreview fails
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-05-19 17:01:01 +02:00
Daniel Kesselberg
cf2bc22e0f
Fix return type for createSpecificUser
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-05-19 14:36:52 +02:00
Daniel Kesselberg
e163b1bb48
Rename userName to username to align with child classes
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-05-19 14:36:41 +02:00
Carl Schwan
1b60f304c2
Merge pull request #32451 from nextcloud/fix/cropped-image-when-not-asked
Fix cropped image generated when not asked
2022-05-18 16:08:58 +02:00
Simon L
18dd460720
Merge pull request #26813 from nextcloud/feature/files-search-tags
Files: Extend search to also cover tags
2022-05-18 10:58:02 +02:00
Marcel Klehr
f755ee0868 Files: Extend search to also cover tags
fixes #326

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2022-05-17 21:05:09 +02:00
Carl Schwan
05bf8b4445 Fix cropped image generated when not asked
The $crop parameter was not propagated to the imaginary pipeline and
instead it used the smartcrop algorithm always

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-17 10:19:54 +02:00
Thomas Citharel
4d26a9afa0
Allow to tweak default scopes for accounts
Close #6582

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-05-16 22:54:51 +02:00
Julius Härtl
778db45631
Merge pull request #32357 from nextcloud/user-delete-remove-wrappers
remove storage wrappers when deleting the user storage
2022-05-16 19:08:35 +02:00
Carl Schwan
03c46cf115
Merge pull request #32413 from nextcloud/fix/psalm-oc-legacy
Fix psalm errors from the end of the baseline file
2022-05-16 18:30:09 +02:00