upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-18 13:10:47 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 15
76078 commits 974 branches 1224 tags 8.6 GiB
Commit graph

1633 commits

Author SHA1 Message Date
Luka Trovic
8068ee8b85 fix(files_sharing): skip expiration notify for invalid share record 
Signed-off-by: Luka Trovic <luka@nextcloud.com>
 2025-03-27 11:23:30 +01:00
Ferdinand Thiessen
92c48d0394
fix(lookup-server): disable lookup server for non-global scale setups 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-03-11 21:58:09 +01:00
Ferdinand Thiessen
e674631f9b
fix(lookup-server): do not query data by default 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-03-11 21:56:45 +01:00
Ferdinand Thiessen
de99a257f2
fix(files_sharing): Also list deleted team shares 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-03-03 14:20:19 +01:00
Git'Fellow
35377d7e97 fix(SharedStorage): Check if storage ID is set on cache 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2025-02-14 17:57:15 +01:00
nfebe
d84be6b946 refactor: Remove some deprecated containers and exceptions 
Signed-off-by: nfebe <fenn25.fn@gmail.com>
 2025-02-11 10:51:13 -08:00
Ferdinand Thiessen
b94da13f6c
fix(sharing): Ensure download restrictions are not dropped 
When a user receives a share with share-permissions but also with
download restrictions (hide download or the modern download permission attribute),
then re-shares of that share must always also include those restrictions.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-04 18:20:38 +01:00
Ferdinand Thiessen
ea37f03f7d
fix(files_sharing): Respect permissions passed when creating link shares 
Given:
User creates a link or email share with permissions=4 (create only = file drop).

Problem:
Currently the permissions are automatically extended to permissions = 5
(READ + CREATE). Work around was to create the share and directly update
it.

Solution:
Respect what the user is requesting, create a file drop share.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-31 18:46:07 +01:00
Robin Appelman
11a3593243 perf: improve performance of SharedStorage::getWatcher 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-01-09 07:45:22 +01:00
Robin Appelman
926b9d37c5 perf: improve performance of SharedStorage::getWatcher 
Signed-off-by: Robin Appelman <robin@icewind.nl>

[skip ci]
 2025-01-09 07:45:22 +01:00
Kate
7290a93e09
Merge pull request #49836 from nextcloud/backport/49822/stable29 
[stable29] fix(files_sharing): Fix error messages from password policy
 2024-12-16 16:36:17 +01:00
Luka Trovic
d09482e116 fix(sharing): add command to fix broken shares after ownership transferring 
Signed-off-by: Luka Trovic <luka@nextcloud.com>
 2024-12-12 21:35:49 +01:00
Côme Chilliet
8ce499246f fix(files_sharing): Fix error messages from password policy 
Exceptions thrown from password_policy may bubble up in share creation
 or update when a password is used. Their message is meant to be shown
 to the user. This always the case for HintException so we catch that
 instead of the subclass GenericShareException.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-12-12 20:15:35 +00:00
Benjamin Gaussorgues
e39137de2d chore: stricter access to testremote endpoint 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-11-28 10:48:18 +00:00
provokateurin
c8dbb119c7
fix(BackgroundJobs): Adjust intervals and time sensitivities 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-11-25 08:40:57 +01:00
provokateurin
e4603a7e27
fix(files_sharing): Cleanup error messages 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-28 13:11:47 +01:00
Joas Schilling
a994cee15b fix(activity): Fix download activity parameters 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-10-20 06:03:53 +00:00
provokateurin
dfd0b9ddf7 fix(files_sharing): Check if propfind response is valid before accessing share permission props 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-26 14:22:37 +00:00
provokateurin
6416dba1ce refactor(files_sharing): Make permissions prop checks less error prone 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-26 14:22:37 +00:00
provokateurin
18968a6f52 fix(files_sharing): Parse OCM share permissions from OCM and not OCS prop 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-26 14:22:37 +00:00
skjnldsv
b9ef97260d fix(files_sharing): adjust permissions from custom edit and delete check methods 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-09-11 13:55:06 +02:00
Marcel Klehr
c80dd9dfec fix: Display 'Leave share' instead of 'Delete' 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2024-09-11 11:54:35 +00:00
Robin Appelman
20a7ab4be7 fix: try to find non-recursive share source 
instead of always picking the first one, try to find one that won't blow up

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-08-16 14:33:16 +00:00
Git'Fellow
cdf29e6e87 fix(share): Rename Circle to Team 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2024-08-06 21:27:19 +00:00
Maxence Lange
4370f9f4e9 fix(inherited-shares): ignore top root folder 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-08-06 12:13:51 +00:00
Robin Appelman
95361516de fix: fix recursive share check 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-07-30 07:04:01 +00:00
F. E Noel Nfebe
b94bcef5c8
Merge pull request #46228 from nextcloud/backport/45608/stable29 
[stable29] docs(ShareApiController): Correct note about expiry date timezone
 2024-07-02 11:02:41 +01:00
Louis Chemineau
1fb0cc25d2
fix(files_sharing): Store the expiration date relative to the server's timezone 
This is needed as we want to store the difference between the server's and the user's timezones.

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-07-01 22:23:26 +02:00
fenn-cs
78f4fb67ac docs(ShareApiController): Correct note about expiry date timezone 
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-07-01 17:24:48 +00:00
fenn-cs
5dbb96fc8a fix(shareManager): Respect empty expireDate in server 
If `expireDate` is an empty string and not `null` then the server should not set a default.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-05-29 12:58:37 +01:00
Joas Schilling
84b0818ed3 fix(sharing): Don't change the type of the controller argument 
[EA] New value type (\DateTime) is not matching the resolved parameter type and might introduce types-related false-positives.

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-04-18 12:36:48 +00:00
fenn-cs
9202a21516 fix(shareApiController): avoid duplicated expiryDate operations 
`expireDate` can be set once and used anywhere needed, the current implementation,
duplicates this behavior which leads to `parseDate` receiving an a date object it
parsed and returend earlier in the createShare method.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-04-18 01:27:47 +00:00
fenn-cs
e1fc954cc9 refactor(shareApiController): use contrusctor property promotion & DI logger 
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-04-18 01:27:46 +00:00
Côme Chilliet
0b332ceac2 fix: Apply new coding standard to all files 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-04 11:45:22 +02:00
Robin Appelman
85b5dd0a43
fix: add extra check to ensure wrapped shared storage is set 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-03-20 14:48:55 +01:00
Joas Schilling
6a82042d73
fix(sharing): Align wording for declining a share 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-03-19 11:15:18 +01:00
Ferdinand Thiessen
2be421785f
fix(files_sharing): ShareesAPI - Return empty response when user is not allowed to share 
Resolves: https://github.com/nextcloud/server/issues/20950

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-03-15 15:51:15 +01:00
Robin Appelman
f46209a34e
chore: improve typing for SharedStorage::$storage 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-03-14 11:22:17 +01:00
Robin Appelman
0ace9a4efa
fix: don't return null for SharedStorage::getWrapperStorage with share recursion 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-03-14 11:21:05 +01:00
Robin Appelman
ea8a774a0a fix: add some recrusive detection/prevention 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-03-08 14:20:14 +01:00
Robin Appelman
a598de627c chore: remove long depricated share code 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-03-06 15:24:48 +01:00
Christoph Wurst
5c20f5b9a2
fix(sharing): Avoid (dead)locking during orphan deletion 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2024-03-05 20:19:30 +01:00
Robin Appelman
e7a7b4a401 perf: switch places that always use the first getById result to getFirstNodeById 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-03-04 13:57:31 +01:00
Benjamin Gaussorgues
3f269782aa
Merge pull request #43428 from nextcloud/feat/share-expiration-with-time 2024-02-26 10:07:41 +01:00
John Molakvoæ
0eba9570eb
Merge branch 'master' into share-external-watcher 
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
 2024-02-23 21:51:44 +01:00
John Molakvoæ
d541a7d178
Merge pull request #43605 from nextcloud/orphan-share-daily 2024-02-23 19:43:07 +01:00
Aragon Gouveia
311d1d2306 fix truncated circleId returned from Share API 2024-02-23 14:43:31 +01:00
Benjamin Gaussorgues
01983d50d4
feat(share): save date and time for expiration 
Because of timezones, not saving time can lead to unexpected behaviour
when sharing an item sooner than timezone offset
Example: sharing a file before 9am when in UTC+9

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-02-22 11:26:01 +01:00
Robin Appelman
0b8f0d0a0b
fix: only cleanup orphaned shared daly 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-02-15 17:53:31 +01:00
F. E Noel Nfebe
3fb1674251
Merge pull request #43461 from nextcloud/fix/get-rid-of-getlogger 
chore: Migrate away from OC::$server->getLogger
 2024-02-14 10:47:22 +01:00