upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-15 22:11:17 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 25
56426 commits 882 branches 1195 tags 7.2 GiB
Commit graph

18602 commits

Author SHA1 Message Date
Roeland Jago Douma
04c037ebfd
[3rdparty] Migrate to Opis/Closure 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-12-02 20:16:57 +01:00
Roeland Jago Douma
6f4d3edb5e
Merge pull request #24113 from nextcloud/extend-cache-events 
extend cache events
 2020-12-02 19:48:20 +01:00
Christoph Wurst
4deff37a3c
Merge pull request #23278 from nextcloud/enh/noid/user-limits 
Allow subscription to indicate that a userlimit is reached
 2020-12-02 18:22:13 +01:00
Morris Jobke
e580f91143
Merge pull request #23257 from aler9/patch-32bit-filesize-master 
Fix file size computation on 32bit platforms
 2020-12-02 16:22:24 +01:00
Morris Jobke
32f6bdf067
Merge pull request #24396 from nextcloud/dont-use-system-composer 
dont use system composer for autoload checker
 2020-12-02 16:15:55 +01:00
Roeland Jago Douma
d69407963c
Merge pull request #24500 from nextcloud/bugfix/noid/log_query_no_crash 
Prevent log_query to mess up regular execution flow
 2020-12-02 16:15:26 +01:00
Robin Appelman
aef1cdba03
code style and dispatchTyped 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-12-02 16:15:02 +01:00
Morris Jobke
c0a05c0412
Add notification for user limit 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-12-02 15:20:03 +01:00
Morris Jobke
d87705a894
Allow subscription to indicate that a userlimit is reached 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-12-02 15:20:03 +01:00
Vincent Petry
a50bcdabcc
Prevent log_query to mess up regular execution flow 
When the "log_query" debug config parameter is set, SQL queries are
logged. However, if an error occurs when converting the values to
string, it will abort the request.

This fix catches the error and continues instead.

Also added handler for DateTime value which is already known to cause
aborts here.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2020-12-02 14:10:35 +01:00
aler9
ac0c7a8fe0 Fix file size computation on 32bit platforms 
Signed-off-by: aler9 <46489434+aler9@users.noreply.github.com>
 2020-12-02 12:05:14 +01:00
Nextcloud bot
7ceb98f63b
[tx-robot] updated from transifex 2020-12-01 02:19:46 +00:00
Christoph Wurst
9a3cc099db
Merge pull request #24414 from nextcloud/techdebt/remove-update-php 
Remove the deprecated update.php
 2020-11-30 12:11:03 +01:00
Morris Jobke
83a75c670b
Replace static call to Share::unshare with ShareManager->deleteShare in tests 
And then cleanup all the code that is dead then...

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-11-30 09:51:18 +01:00
Morris Jobke
6564a95160
Remove now unused methods in Share.php due to the reduced code complexity in Share::getItems 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-11-29 23:28:16 +01:00
Morris Jobke
10e5ae5e18
Remove unused method Share Helper::generateTarget 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-11-29 22:52:52 +01:00
Morris Jobke
a125d8aaa1
Reduce code complexity in Share::getItems by tracing all remaining callers 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-11-29 22:30:09 +01:00
Morris Jobke
596df8fc6f
Remove unused Share::getItemSharedWithBySource() 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-11-29 22:24:12 +01:00
Christoph Wurst
fd649afb1f
Remove the deprecated update.php 
* It was documented as deprecated.
* The app code checker warned about it
* It's been three years

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-11-27 13:02:59 +01:00
Robin Appelman
7956cef622
rebuild autoloader scripts with 2.0.7 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-11-26 15:49:03 +01:00
Robin Appelman
88f35d52d2
rename cache event to follow new naming standards 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-11-26 15:39:46 +01:00
Robin Appelman
23fb497ff5
extend cache events 
- adds cache remove event
- expose storage id in event
- emit events during cache move

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-11-26 15:22:03 +01:00
Christoph Wurst
7dd39a91ee
Remove dead method \OC\Updater::checkAppUpgrade 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-11-26 14:48:41 +01:00
Christoph Wurst
54e3beba16
Merge pull request #24319 from nextcloud/techdebt/noid/streamline-user-creation-and-deletion-events 
Streamline user creation and deletion events
 2020-11-26 14:09:54 +01:00
Roeland Jago Douma
2172432420
Merge pull request #23912 from nextcloud/objectstore-copy 
use in objectstore copy
 2020-11-25 16:09:26 +01:00
Arthur Schiwon
9cfa8a6c44
send expected format of cloud id 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-11-24 23:14:43 +01:00
blizzz
5d03b5c5dd
Merge pull request #24162 from nextcloud/fix/noid/fedshares-displaynamez 
set the display name of federated sharees from addressbook
 2020-11-24 17:23:37 +01:00
blizzz
6156a49f6e
Merge pull request #24341 from nextcloud/fix/sharing-enforce-expire-checkbox 
Fix the config key on the sharing expire checkbox
 2020-11-24 15:49:49 +01:00
Robin Appelman
9d4848e863
use in objectstore copy 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-11-24 15:16:58 +01:00
Christoph Wurst
2526c5e042
Fix the config key on the sharing expire checkbox 
We don't use `shareapi_internal_enforce_expire_date` anywhere.
`shareapi_enforce_internal_expire_date` is the one we want.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-11-24 14:17:41 +01:00
Roeland Jago Douma
d4fd61b7c6
Merge pull request #24324 from nextcloud/td/psalm/backgroundjob_job 
Fix the OCP\BackgroundJob\Job to make it compatible with  its interface
 2020-11-24 13:16:12 +01:00
Arthur Schiwon
16a78f535a
set the display name of federated sharees from addressbook 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-11-24 11:30:11 +01:00
Roeland Jago Douma
c2c539a754
Merge pull request #24323 from nextcloud/fix/comments-tab-missing 
Fix reverse registration and missing comments tab
 2020-11-24 09:34:50 +01:00
Roeland Jago Douma
82d3f50b78
Fix the OCP\BackgroundJob\Job to make it compatible with its interface 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-11-24 09:33:49 +01:00
Roeland Jago Douma
8ac9767881
Merge pull request #24312 from nextcloud/bugfix/noid/fix-router-alias 
Add proper alias for internal router class
 2020-11-24 08:43:29 +01:00
Christoph Wurst
decc5c844b
Fix reverse registration and missing comments tab 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-11-24 08:28:19 +01:00
Julius Härtl
d9708ebece
Add proper alias for internal router class 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-11-24 08:01:39 +01:00
Morris Jobke
f4c1512bb7
Fix typo in @deprecated PHPDoc tag 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-11-24 00:13:09 +01:00
Morris Jobke
9bf76d2bad
Streamline user creation and deletion events 
CreateUserEvent was the only one that didn't matched the naming scheme of BeforePASTTENSEEvent and PASTTENSEEvent. The event wasn't used at all so this just removes it again as there is BeforeUserCreatedEvent that is also available since 18.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-11-23 23:59:52 +01:00
Lukas Reschke
a5d4d3d4cc
Add IRequest taint sources 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2020-11-22 23:04:43 +01:00
Morris Jobke
9a0428835f
Merge pull request #24267 from nextcloud/techdebt/noid/auto-wire-encryption-app-view-dependent 
Auto-wire remaining encryption app services that depend on View
 2020-11-22 22:33:53 +01:00
Roeland Jago Douma
032de4f333
Merge pull request #24269 from nextcloud/taint-specialize 
Mark getAppPath as specialized taint
 2020-11-22 13:39:46 +01:00
Lukas Reschke
d25ca1976b Mark getAppPath as specialized taint 
Should remove some false positives.

https://psalm.dev/docs/security_analysis/avoiding_false_positives/

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2020-11-21 01:15:15 +00:00
Lukas Reschke
98ddfdd1e8 Mark cleanAppId as sanitizer for include 
Should remove a bunch of false positive code scanning results.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2020-11-21 00:57:25 +00:00
Morris Jobke
e606c0eef4
Allow View to be used via DI 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-11-21 00:18:59 +01:00
Morris Jobke
db3a3bee37
Merge pull request #24064 from nextcloud/techdebt/noid/auto-wire-encryption-app 
Auto-wire as much as possible in the encryption app
 2020-11-21 00:04:54 +01:00
Morris Jobke
6811274cfd
Merge pull request #24246 from LukasReschke/add-taint-flow-analysis 
Add Psalm Security Analysis
 2020-11-21 00:04:37 +01:00
Morris Jobke
5be18215fb
Auto-wire as much as possible in the encryption app 
Also cleans up only non-classname services in the server container

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-11-20 23:13:22 +01:00
Lukas Reschke
47ac8e0028
Add Psalm Taint Flow Analysis 
This adds the Psalm Security Analysis, as described at
https://psalm.dev/docs/security_analysis/

It also adds a plugin for adding input into AppFramework.

The results can be viewed in the GitHub Security tab at
https://github.com/nextcloud/server/security/code-scanning

**Q&A:**

Q: Why do you not use the shipped Psalm version?
A: I do a lot of changes to the Psalm Taint behaviour. Using released
versions is not gonna get us the results we want.

Q: How do I improve false positives?
A: https://psalm.dev/docs/security_analysis/avoiding_false_positives/

Q: How do I add custom sources?
A: https://psalm.dev/docs/security_analysis/custom_taint_sources/

Q: We should run this on apps!
A: Yes.

Q: What will change in Psalm?
A: Quite some of the PHP core functions are not yet marked to propagate
the taint. This leads to results where the taint flow is lost. That's
something that I am currently working on.

Q: Why is the plugin MIT licensed?
A: Because its the first of its kind (based on GitHub Code Search) and
I want other people to copy it if they want to. Security is for all :)

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2020-11-20 23:12:00 +01:00
Carlos Ferreira
a42eb05a35
Simple typo in comments 2020-11-20 20:01:28 +01:00