upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-03-09 09:51:03 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 7
78637 commits 736 branches 1186 tags 6.5 GiB
Commit graph

439 commits

Author SHA1 Message Date
Ferdinand Thiessen
832f79ac93
chore: apply code style 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-04-30 19:04:59 +02:00
John Molakvoæ
2fdb5096dd fix(files_sharing): adjust rate limit share creation to 20 over 10 minutes 
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
 2025-04-15 11:54:03 +02:00
skjnldsv
94d1435a6a fix(files_sharing): rate limit share creation 10 times per 10 minutes 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2025-04-15 08:58:02 +00:00
skjnldsv
71dfb43f8f fix(files_sharing): fix share creation error handling 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

[skip ci]
 2025-04-09 15:22:18 +00:00
Ferdinand Thiessen
c0003fbd9c
fix(lookup-server): disable lookup server for non-global scale setups 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-03-11 21:52:07 +01:00
Ferdinand Thiessen
7d3047f5cb
fix(lookup-server): do not query data by default 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-03-11 21:46:55 +01:00
Ferdinand Thiessen
7f8f8aa9d2 fix(files_sharing): Also list deleted team shares 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-20 15:00:43 +00:00
nfebe
08426e0a8f refactor: Remove some deprecated containers and exceptions 
Signed-off-by: nfebe <fenn25.fn@gmail.com>
 2025-02-06 22:14:12 +01:00
John Molakvoæ
5839a58737
Merge pull request #50217 from nextcloud/backport/49898/stable30 2025-02-06 10:34:54 +01:00
Ferdinand Thiessen
f9bd0ed462
fix(sharing): Ensure download restrictions are not dropped 
When a user receives a share with share-permissions but also with
download restrictions (hide download or the modern download permission attribute),
then re-shares of that share must always also include those restrictions.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-04 16:22:11 +01:00
Ferdinand Thiessen
ee5f5bc159
fix(files_sharing): Respect permissions passed when creating link shares 
Given:
User creates a link or email share with permissions=4 (create only = file drop).

Problem:
Currently the permissions are automatically extended to permissions = 5
(READ + CREATE). Work around was to create the share and directly update
it.

Solution:
Respect what the user is requesting, create a file drop share.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-31 18:21:26 +01:00
Ferdinand Thiessen
9658c051de fix: Ensure label is always a string 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-26 19:59:25 +00:00
Anna Larch
6af3bec748 fix(sharing): send share emails for internal users too 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2025-01-16 17:51:52 +00:00
Côme Chilliet
2fa67bfd52
fix(files_sharing): Fix error messages from password policy 
Exceptions thrown from password_policy may bubble up in share creation
 or update when a password is used. Their message is meant to be shown
 to the user. This always the case for HintException so we catch that
 instead of the subclass GenericShareException.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-12-12 15:38:16 +01:00
Benjamin Gaussorgues
7699598b94 chore: stricter access to testremote endpoint 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-11-28 10:49:27 +00:00
provokateurin
2ba4f6b2a0
fix(files_sharing): Cleanup error messages 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-28 13:07:38 +01:00
fenn-cs
26678174cc refactor(ShareApiController): Check for null and empty strings with empty() 
Proactive measure to avoid warnings in higher php versions as well possible type errors

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-10-25 10:26:16 +00:00
fenn-cs
0f2013d24f fix(ShareAPI): Send mails for mail shares by default 
It looks like, the frontend it needs to provide the `sendMail` param
for the backend to decide wether mails would be sent.

Our UI does not have that at the moment so it should default to sending
emails always for mail shares.

Not exactly sure how this was handled earlier but this is a good starting point.

Resolves : https://github.com/nextcloud/server/issues/48012

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-10-24 16:29:20 +00:00
skjnldsv
338e045141 fix(files_sharing): adjust permissions from custom edit and delete check methods 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-09-11 11:48:25 +00:00
Marcel Klehr
1e08f91408 fix: Display 'Leave share' instead of 'Delete' 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2024-09-11 11:48:25 +00:00
Andy Scherzinger
f0b658014a
Merge pull request #47070 from nextcloud/circToTeam 
fix(share): Rename Circle to Team
 2024-08-06 23:25:47 +02:00
skjnldsv
db28aa8cd1 fix(files_sharing): show proper share not found error message 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-08-06 16:25:10 +02:00
Git'Fellow
6002566d92
fix(share): Rename Circle to Team 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2024-08-06 14:48:07 +02:00
Maxence Lange
b6e3009e12
Merge pull request #47043 from nextcloud/fix/noid/ignore-root-on-inherited-shares 
fix(inherited-shares): ignore top root folder
 2024-08-06 11:08:17 -01:00
skjnldsv
712965daa1 fix(files_sharing): filter out invalid shareWith in sharee API 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-08-05 20:36:45 +02:00
Maxence Lange
6c4b0dba77 fix(inherited-shares): ignore top root folder 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-08-05 13:40:53 -01:00
provokateurin
9128a23af1
refactor(files_sharing): Replace security annotations with respective attributes 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-07-27 22:42:51 +02:00
skjnldsv
43ca07809d fix(files_sharing): file request creation permissions and link copy display 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-18 19:47:11 +02:00
skjnldsv
bb730a1ee3 fix(files_sharing): remove undesirable translations from ShareAPIController 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-16 08:33:53 +02:00
skjnldsv
df42a10e56 chore(files_sharing): lint & refactor fixes 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
9b84831c8d fix(files_sharing): adjust IAttributes API and files_versions 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
967b3848e0 fix(files_sharing): phpunit & openapi fixes 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
bc5839e5b5 chore(files_sharing): cleanup NewFileRequestDialog vue 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
30f9ef414e fix: psalm, cs, autoloader and lint 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
5ce4bb368f chore(files_sharing): refactor share password mail 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
75ca4944c9 feat(files_sharing): allow mixed values in share attributes and allow storing email arrays 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
c253112cf7 chore(files_sharing): refactor mail handling 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
d388370c3b feat(files_sharing): implement IShareProviderWithNotification and refactor sendMailNotification 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
skjnldsv
443c48aefb feat(files_sharing): add new file request option 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-07-12 20:14:30 +02:00
fenn-cs
6136112be1 docs(ShareApiController): Correct note about expiry date timezone 
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-07-01 13:53:18 +01:00
Louis Chemineau
f5fd6c8f08
fix(files_sharing): Store the expiration date relative to the server's timezone 
This is needed as we want to store the difference between the server's and the user's timezones.

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-06-26 12:49:42 +02:00
Andy Scherzinger
1e04619675
chore: Add SPDX header 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2024-06-06 22:53:41 +02:00
fenn-cs
c8a90f04b7 fix(ShareApiClients): Maintain meaning of '' and null for share api clients 
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-05-29 12:36:26 +01:00
fenn-cs
59a5b4e0bd fix(shareManager): Respect empty expireDate in server 
If `expireDate` is an empty string and not `null` then the server should not set a default.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-05-23 14:11:33 +01:00
Joas Schilling
490f545006
fix(sharing): Don't change the type of the controller argument 
[EA] New value type (\DateTime) is not matching the resolved parameter type and might introduce types-related false-positives.

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-04-18 14:31:45 +02:00
fenn-cs
ec8a0a6267 fix(shareApiController): avoid duplicated expiryDate operations 
`expireDate` can be set once and used anywhere needed, the current implementation,
duplicates this behavior which leads to `parseDate` receiving an a date object it
parsed and returend earlier in the createShare method.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-04-18 02:01:13 +01:00
fenn-cs
9a0913afdc refactor(shareApiController): use contrusctor property promotion & DI logger 
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
 2024-04-18 02:01:08 +01:00
Côme Chilliet
ec5133b739 fix: Apply new coding standard to all files 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-02 14:16:21 +02:00
Ferdinand Thiessen
2be421785f
fix(files_sharing): ShareesAPI - Return empty response when user is not allowed to share 
Resolves: https://github.com/nextcloud/server/issues/20950

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-03-15 15:51:15 +01:00
Robin Appelman
e7a7b4a401 perf: switch places that always use the first getById result to getFirstNodeById 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-03-04 13:57:31 +01:00