Commit graph

1711 commits

Author SHA1 Message Date
Arthur Schiwon
b61757a9e7
Merge pull request #53897 from nextcloud/fix/noid/krb-fallback
fix(Krb): switch away from deprecated and broken KerberosApacheAuth()
2025-07-11 09:58:47 +02:00
John Molakvoæ
1bc1902476
Merge pull request #53887 from nextcloud/fix/lower-email-case 2025-07-11 09:03:05 +02:00
Arthur Schiwon
fd799afc17
fix(Krb): switch away from deprecated and broken KerberosApacheAuth()
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2025-07-10 23:21:16 +02:00
Daniel Calviño Sánchez
d4e9a8ac33
Merge pull request #53501 from nextcloud/fix-theming-for-disabled-accounts
fix: Fix theming for disabled accounts
2025-07-10 20:47:48 +02:00
Daniel Calviño Sánchez
01766b18f8 fix: Fix theming for disabled accounts
The Theming app injects the stylesheets for the different themes in the
"<header>" element of the page, and those stylesheets are then loaded by
the browser from a "Controller" (a plain "Controller", not an
"OCSController"). The stylesheets, in turn, may also get some images
(like the background) also from the "Controller".

When handling a request to "index.php" it is checked whether the user is
logged in and, if not, a login is tried. A disabled user is explicitly
seen as not logged in, so a login is always tried in that case, but
disabled users are also explicitly prevented to log in, so the login
also fails. Due to that trying to get any of the themed stylesheets or
images with a disabled account (to be able to show the "Account
disabled" error page) fails with an HTTP status 401.

To solve that, and to avoid touching this basic logic as much as
possible, the login exception is now ignored (if the user is disabled)
for some specific requests to the Theming app.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2025-07-10 15:19:01 +02:00
Côme Chilliet
da20bbb44d
chore: update psalm baseline
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-10 11:40:27 +02:00
skjnldsv
027471b146 fix: force lowercase emails
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-07-10 09:10:01 +02:00
Kate
3da74810b5
Merge pull request #53537 from nextcloud/fix/cleanup-dependencyanalyser 2025-07-09 13:16:55 +02:00
Joas Schilling
d717dd9850
feat(OCP): Consumable vs. Implementable public API
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-07-09 10:24:10 +02:00
Côme Chilliet
adb6f00051
chore: update psalm baseline
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-09 10:15:00 +02:00
Côme Chilliet
7bdfd94246
chore: update psalm baseline
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-08 13:32:15 +02:00
Robin Appelman
1620a0c051
chore: add rector DataProviderAnnotationToAttributeRector
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-07-01 22:45:06 +02:00
Robin Appelman
259f1fe9bd
chore: add phpunit StaticDataProviderClassMethodRector rector rule
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-07-01 22:45:01 +02:00
Ferdinand Thiessen
5981b7eb51
chore: apply new CSFixer rules
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

# Conflicts:
#	apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
John Molakvoæ
bd00b75b29
Merge pull request #53671 from nextcloud/fix/read-only-share-download 2025-07-01 15:11:06 +02:00
provokateurin
2e5ccc7123
fix(files): Always transfer incoming shares when doing ownership transfer to prevent broken reshares
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-07-01 08:23:53 +02:00
Joas Schilling
60b8384e48
Merge branch 'master' into remove-x-xss-protection 2025-06-30 21:32:22 +02:00
Daniel Kesselberg
de54bdb06b
fix: handle ambiguous IResponse.getBody return types
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-06-30 11:50:11 +02:00
Daniel Kesselberg
3d0fb7e603
docs(http): Update return type for getBody
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-06-30 11:50:10 +02:00
skjnldsv
9806a9830c feat(files_sharing): allow viewing files with download disabled
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-06-26 11:47:53 +02:00
Daniel Kesselberg
53fb05e2d0
fix(nullcache): make get compliant with the interface
The interface defines ICacheEntry|false, thus we should not return null.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-06-26 09:54:48 +02:00
Richard Steinmetz
b6af06d2e0
fix: revive always storing lowercased email addresses
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-06-24 13:53:08 +02:00
Richard Steinmetz
960b3ec0eb refactor(dav): move shared logic to a dedicated example contact service
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-06-19 23:46:00 +02:00
Côme Chilliet
f314d930be
Merge pull request #52916 from nextcloud/fix/cache-ldap-configuration-prefixes
fix(user_ldap): Store the list of used configuration prefixed in appconfig
2025-06-19 11:57:15 +02:00
Ferdinand Thiessen
35a27b5fd5
fix(FilenameValidator): use _ as default replacement for invalid chars
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-06-18 09:44:57 +02:00
Daniel Kesselberg
6254354f27
test(dav): add integration test for principal property search
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-06-17 11:19:24 +02:00
invario
2b58f74cc8
Fix: Remove X-XSS-Protection use, check and recommendation
Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: invario <67800603+invario@users.noreply.github.com>
2025-06-13 16:12:27 -04:00
Robin Appelman
3cc34ac29d
chore: add UseSpecificWillMethodRector to rector configuration
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-06-12 18:33:43 +02:00
Robin Appelman
de74745ab6
chore: add tests to rector configuration
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-06-12 18:31:40 +02:00
Côme Chilliet
b9949b2381
chore: update psalm baseline
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-06-10 16:08:52 +02:00
Daniel Kesselberg
55bca1e5db fix: use logical operator instead of bitwise
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-06-10 13:55:53 +02:00
Côme Chilliet
231916d403
Merge pull request #52538 from nextcloud/feat/use-php84-lazy-objects
Use PHP 8.4 lazy ghosts for Dependency injection
2025-06-10 10:45:12 +02:00
Stephan Orbaugh
04118afdab
Merge pull request #53287 from nextcloud/feat/test-app-routes
feat(tests): Test application enabling/disabling and routes
2025-06-06 13:00:02 +02:00
Côme Chilliet
a42ef7d633
fix: Fix psalm issue and update baseline
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-06-05 20:51:18 +02:00
Côme Chilliet
ba53147e10
chore: update psalm baseline
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-06-05 18:20:05 +02:00
Côme Chilliet
580911dc89
chore: Disable appstore from integration tests
This avoids spamming the appstore server and getting banned from CI runs

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-06-05 16:23:07 +02:00
Côme Chilliet
a15c473ae2
feat(tests): Test application enabling/disabling and routes
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-06-05 15:12:28 +02:00
skjnldsv
e41e8de0e2 fix(dav): file drop nickname
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-06-05 09:09:17 +02:00
Ferdinand Thiessen
0a982374ec
refactor(core): migrate core application to IBootstrap
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-06-02 15:58:25 +02:00
Robin Appelman
7599162c7b feat: move primary object store configuration to a single place
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-05-28 15:32:31 +02:00
nextcloud-command
3f36d868ac fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2025-05-21 02:37:29 +00:00
Joas Schilling
9637fe6474
Revert "fix(files_sharing): Filter own shares that are reshares" 2025-05-19 17:16:39 +02:00
Kate
13f23061e8
Merge pull request #52891 from nextcloud/chore/nix-flake 2025-05-19 11:51:22 +02:00
provokateurin
7c6602cd8d
fix(files_sharing): Filter own shares that are reshares
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-19 08:18:16 +02:00
Kate
249e33fcd6
Merge pull request #52901 from nextcloud/chore/remove-dead-code-files 2025-05-19 07:02:41 +02:00
Kate
6b4f5c567c
Merge pull request #52848 from nextcloud/fix/cleanup-servercontainer 2025-05-19 07:02:11 +02:00
provokateurin
0c2cc0e9e1
chore: Add nix flake with development shell
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-18 13:59:32 +02:00
Ferdinand Thiessen
e2a331f53d
Merge pull request #52890 from nextcloud/chore/move-stream-copy-implementation
chore: move streamCopy implementation from `OC_Helper` to `OCP\Files`
2025-05-17 12:01:44 +02:00
Ferdinand Thiessen
bd91db8e20
chore: deprecate OC_Helper::copyr
Inline it into Installer as needed.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-16 17:32:45 +02:00
Ferdinand Thiessen
e693a5d4a5
fix(dav): correctly handle uploading folders with same name as a file
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-16 14:38:41 +02:00